Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release microsoft.maintenance 2023 04 01 #24793

Conversation

KalpeshChavan12
Copy link
Contributor

ARM (Control Plane) API Specification Update Pull Request

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

ARM API changes review

  • If you want for the ARM team to review this PR, you must add the ARMReview label.
  • The automation may automatically add the ARMReview label, if appropriate.
    If this happens, proceed according to guidance given in GitHub comments also added by the automation.

Breaking change review

If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.

Getting help

@openapi-workflow-bot
Copy link

Hi, @KalpeshChavan12! Thank you for your pull request. To help get your PR merged:

  • Ensure you reviewed the checklists in the PR description.
  • Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.
  • For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
  • @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 12, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 8 Errors, 12 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    Maintenance.json 2023-04-01(84effd5) 2021-05-01(main)
    Maintenance.json 2023-04-01(84effd5) 2022-11-01-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    1011 - AddingResponseCode The new version adds a response code '201'.
    New: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L344:11
    1011 - AddingResponseCode The new version adds a response code '201'.
    New: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L419:11
    1011 - AddingResponseCode The new version adds a response code '201'.
    New: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L616:11
    1011 - AddingResponseCode The new version adds a response code '201'.
    New: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L876:11
    1011 - AddingResponseCode The new version adds a response code '201'.
    New: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1240:11
    1042 - ChangedParameterOrder The order of parameter 'providerName' was changed.
    New: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L121:9
    Old: Microsoft.Maintenance/stable/2021-05-01/Maintenance.json#L121:9
    1042 - ChangedParameterOrder The order of parameter 'resourceParentType' was changed.
    New: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L121:9
    Old: Microsoft.Maintenance/stable/2021-05-01/Maintenance.json#L121:9
    1042 - ChangedParameterOrder The order of parameter 'resourceParentName' was changed.
    New: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L121:9
    Old: Microsoft.Maintenance/stable/2021-05-01/Maintenance.json#L121:9


    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'MaintenanceConfigurationOverrides' removed or renamed?
    New: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L2274:3
    Old: Microsoft.Maintenance/preview/2022-11-01-preview/Maintenance.json#L1777:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'softwareUpdateConfigurationTasks' removed or renamed?
    New: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L2274:3
    Old: Microsoft.Maintenance/preview/2022-11-01-preview/Maintenance.json#L1777:3
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '201'.
    New: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L344:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '201'.
    New: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L419:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '201'.
    New: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L616:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '201'.
    New: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L876:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '201'.
    New: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1240:11
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'overrides' renamed or removed?
    New: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L2536:7
    Old: Microsoft.Maintenance/preview/2022-11-01-preview/Maintenance.json#L2006:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'tasks' renamed or removed?
    New: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L2630:7
    Old: Microsoft.Maintenance/preview/2022-11-01-preview/Maintenance.json#L2105:7
    ⚠️ 1042 - ChangedParameterOrder The order of parameter 'providerName' was changed.
    New: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L121:9
    Old: Microsoft.Maintenance/preview/2022-11-01-preview/Maintenance.json#L121:9
    ⚠️ 1042 - ChangedParameterOrder The order of parameter 'resourceParentType' was changed.
    New: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L121:9
    Old: Microsoft.Maintenance/preview/2022-11-01-preview/Maintenance.json#L121:9
    ⚠️ 1042 - ChangedParameterOrder The order of parameter 'resourceParentName' was changed.
    New: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L121:9
    Old: Microsoft.Maintenance/preview/2022-11-01-preview/Maintenance.json#L121:9
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 23 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.3) new version base version
    package-2023-04 package-2023-04(84effd5) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1621
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1621
    ⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ConfigurationAssignments_GetParent
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1650
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1669
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1669
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1732
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1732
    ⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ConfigurationAssignmentsForSubscriptions_CreateOrUpdate
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1770
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1787
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1787
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1840
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1840
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1840
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1896
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1896
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1896
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1966
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1966
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1966
    ⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ConfigurationAssignmentsForResourceGroup_CreateOrUpdate
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L2011
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L2028
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L2028
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L2028


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L41
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1038
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1110
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1400
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1450
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1493
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1543
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1586
    OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L2095
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L2180
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L2252
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L30
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L30
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L73
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L73
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L121
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L121
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L121
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L211
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L211
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L211
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L287
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L287
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L287
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L376
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L376
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L376
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L453
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L453
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L453
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 12, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking



    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from cf04a5a68ffd5bd6674e0f0c7d9b37b9e96fbd91. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.8.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-maintenance [View full logs]  [Preview SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation ConfigurationAssignmentsOperations.get
      info	[Changelog]   - Added operation ConfigurationAssignmentsOperations.get_parent
      info	[Changelog]   - Added operation group ConfigurationAssignmentsForResourceGroupOperations
      info	[Changelog]   - Added operation group ConfigurationAssignmentsForSubscriptionsOperations
      info	[Changelog]   - Added operation group ConfigurationAssignmentsWithinSubscriptionOperations
      info	[Changelog]   - Model ConfigurationAssignment has a new parameter filter
      info	[Changelog]   - Model MaintenanceConfiguration has a new parameter install_patches
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from cf04a5a68ffd5bd6674e0f0c7d9b37b9e96fbd91. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/maintenance/armmaintenance [View full logs]  [Preview SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New value `MaintenanceScopeResource` added to enum type `MaintenanceScope`
      info	[Changelog] - New enum type `RebootOptions` with values `RebootOptionsAlways`, `RebootOptionsIfRequired`, `RebootOptionsNever`
      info	[Changelog] - New enum type `TagOperators` with values `TagOperatorsAll`, `TagOperatorsAny`
      info	[Changelog] - New function `*ClientFactory.NewConfigurationAssignmentsForResourceGroupClient() *ConfigurationAssignmentsForResourceGroupClient`
      info	[Changelog] - New function `*ClientFactory.NewConfigurationAssignmentsForSubscriptionsClient() *ConfigurationAssignmentsForSubscriptionsClient`
      info	[Changelog] - New function `*ClientFactory.NewConfigurationAssignmentsWithinSubscriptionClient() *ConfigurationAssignmentsWithinSubscriptionClient`
      info	[Changelog] - New function `*ConfigurationAssignmentsClient.Get(context.Context, string, string, string, string, string, *ConfigurationAssignmentsClientGetOptions) (ConfigurationAssignmentsClientGetResponse, error)`
      info	[Changelog] - New function `*ConfigurationAssignmentsClient.GetParent(context.Context, string, string, string, string, string, string, string, *ConfigurationAssignmentsClientGetParentOptions) (ConfigurationAssignmentsClientGetParentResponse, error)`
      info	[Changelog] - New function `NewConfigurationAssignmentsForResourceGroupClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ConfigurationAssignmentsForResourceGroupClient, error)`
      info	[Changelog] - New function `*ConfigurationAssignmentsForResourceGroupClient.CreateOrUpdate(context.Context, string, string, ConfigurationAssignment, *ConfigurationAssignmentsForResourceGroupClientCreateOrUpdateOptions) (ConfigurationAssignmentsForResourceGroupClientCreateOrUpdateResponse, error)`
      info	[Changelog] - New function `*ConfigurationAssignmentsForResourceGroupClient.Delete(context.Context, string, string, *ConfigurationAssignmentsForResourceGroupClientDeleteOptions) (ConfigurationAssignmentsForResourceGroupClientDeleteResponse, error)`
      info	[Changelog] - New function `*ConfigurationAssignmentsForResourceGroupClient.Get(context.Context, string, string, *ConfigurationAssignmentsForResourceGroupClientGetOptions) (ConfigurationAssignmentsForResourceGroupClientGetResponse, error)`
      info	[Changelog] - New function `*ConfigurationAssignmentsForResourceGroupClient.Update(context.Context, string, string, ConfigurationAssignment, *ConfigurationAssignmentsForResourceGroupClientUpdateOptions) (ConfigurationAssignmentsForResourceGroupClientUpdateResponse, error)`
      info	[Changelog] - New function `NewConfigurationAssignmentsForSubscriptionsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ConfigurationAssignmentsForSubscriptionsClient, error)`
      info	[Changelog] - New function `*ConfigurationAssignmentsForSubscriptionsClient.CreateOrUpdate(context.Context, string, ConfigurationAssignment, *ConfigurationAssignmentsForSubscriptionsClientCreateOrUpdateOptions) (ConfigurationAssignmentsForSubscriptionsClientCreateOrUpdateResponse, error)`
      info	[Changelog] - New function `*ConfigurationAssignmentsForSubscriptionsClient.Delete(context.Context, string, *ConfigurationAssignmentsForSubscriptionsClientDeleteOptions) (ConfigurationAssignmentsForSubscriptionsClientDeleteResponse, error)`
      info	[Changelog] - New function `*ConfigurationAssignmentsForSubscriptionsClient.Get(context.Context, string, *ConfigurationAssignmentsForSubscriptionsClientGetOptions) (ConfigurationAssignmentsForSubscriptionsClientGetResponse, error)`
      info	[Changelog] - New function `*ConfigurationAssignmentsForSubscriptionsClient.Update(context.Context, string, ConfigurationAssignment, *ConfigurationAssignmentsForSubscriptionsClientUpdateOptions) (ConfigurationAssignmentsForSubscriptionsClientUpdateResponse, error)`
      info	[Changelog] - New function `NewConfigurationAssignmentsWithinSubscriptionClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ConfigurationAssignmentsWithinSubscriptionClient, error)`
      info	[Changelog] - New function `*ConfigurationAssignmentsWithinSubscriptionClient.NewListPager(*ConfigurationAssignmentsWithinSubscriptionClientListOptions) *runtime.Pager[ConfigurationAssignmentsWithinSubscriptionClientListResponse]`
      info	[Changelog] - New struct `ConfigurationAssignmentFilterProperties`
      info	[Changelog] - New struct `InputLinuxParameters`
      info	[Changelog] - New struct `InputPatchConfiguration`
      info	[Changelog] - New struct `InputWindowsParameters`
      info	[Changelog] - New struct `TagSettingsProperties`
      info	[Changelog] - New field `Filter` in struct `ConfigurationAssignmentProperties`
      info	[Changelog] - New field `InstallPatches` in struct `ConfigurationProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 37 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from cf04a5a68ffd5bd6674e0f0c7d9b37b9e96fbd91. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️maintenance [View full logs]  [Preview Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs] Generate from cf04a5a68ffd5bd6674e0f0c7d9b37b9e96fbd91. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • ️✔️Az.maintenance.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.maintenance.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 12, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/maintenance/armmaintenance https://apiview.dev/Assemblies/Review/95ee014df8ce4064aca016680ab1908d

    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-FixRequiredOnFailure CI-MissingBaseCommit new-api-version resource-manager SuppressionReviewRequired labels Jul 12, 2023
    @openapi-workflow-bot
    Copy link

    Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    This will notify the reviewer to have another look.
    If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
    Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

    @openapi-workflow-bot
    Copy link

    Hi @KalpeshChavan12! The automation detected breaking changes in this pull request. As a result, it added the BreakingChangeReviewRequired label.

    You cannot proceed with merging this PR until you complete one of the following action items:

    ACTION ITEM ALTERNATIVE A: Fix the breaking change.
    Please consult the documentation provided in the relevant validation failures.

    ACTION ITEM ALTERNATIVE B: Request approval.
    Alternatively, if you cannot fix the breaking changes, then you can request an approval for them. Please follow the process described in the High-level Breaking Change Process doc.

    ACTION ITEM ALTERNATIVE C: Report false positive.
    If you think there are no breaking changes, i.e. the validation should pass yet it fails, then proceed as explained in ACTION ITEM ALTERNATIVE B.
    This applies even if the breaking change tool fails with internal runtime error. In such case a manual breaking change review is necessary.

    @openapi-workflow-bot
    Copy link

    Hi @KalpeshChavan12! Your PR has some issues. Please fix the CI issues, if present, in following order: Avocado, SemanticValidation, ModelValidation, Breaking Change, LintDiff.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic ValidationFix-SemanticValidation-ErrorHigh
    Model ValidationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffHigh

    If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel.

    @openapi-workflow-bot
    Copy link

    Hi @KalpeshChavan12! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
    For more details refer to the wiki.

    @openapi-workflow-bot
    Copy link

    Hi @KalpeshChavan12, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval.

    @AzureRestAPISpecReview AzureRestAPISpecReview added ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test and removed CI-FixRequiredOnFailure labels Jul 12, 2023
    @KalpeshChavan12
    Copy link
    Contributor Author

    Original PR with Breaking change approval:
    #23832

    Reference PR ( not able to update PR branch created new one with below as baseline)
    #24048

    @KalpeshChavan12
    Copy link
    Contributor Author

    @rkmanda

    As discussed offline can you review and provide signoff.

    @microsoft-github-policy-service
    Copy link
    Contributor

    Hi, @KalpeshChavan12. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Contributor

    Hi, @KalpeshChavan12. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Contributor

    Hi, @KalpeshChavan12. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-MissingBaseCommit new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager SuppressionReviewRequired
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants