-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release microsoft.maintenance 2023 04 01 #24793
Release microsoft.maintenance 2023 04 01 #24793
Conversation
…ce-Microsoft.Maintenance-2023-04-01' (Azure#23832)" (Azure#23923)" This reverts commit e6c0e18.
Hi, @KalpeshChavan12! Thank you for your pull request. To help get your PR merged: Generated ApiView comment added to this PR. You can use ApiView to show API versions diff. |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
Maintenance.json | 2023-04-01(84effd5) | 2021-05-01(main) |
Maintenance.json | 2023-04-01(84effd5) | 2022-11-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
The following breaking changes are detected by comparison with the latest preview version:
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 23 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.3) | new version | base version |
---|---|---|
package-2023-04 | package-2023-04(84effd5) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1621 |
||
Not using the common-types defined parameter 'api-version'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1621 |
||
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ConfigurationAssignments_GetParent Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1650 |
||
Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1669 |
||
Not using the common-types defined parameter 'api-version'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1669 |
||
Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1732 |
||
Not using the common-types defined parameter 'api-version'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1732 |
||
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ConfigurationAssignmentsForSubscriptions_CreateOrUpdate Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1770 |
||
Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1787 |
||
Not using the common-types defined parameter 'api-version'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1787 |
||
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1840 |
||
Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1840 |
||
Not using the common-types defined parameter 'api-version'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1840 |
||
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1896 |
||
Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1896 |
||
Not using the common-types defined parameter 'api-version'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1896 |
||
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1966 |
||
Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1966 |
||
Not using the common-types defined parameter 'api-version'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1966 |
||
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ConfigurationAssignmentsForResourceGroup_CreateOrUpdate Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L2011 |
||
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L2028 |
||
Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L2028 |
||
Not using the common-types defined parameter 'api-version'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L2028 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L41 |
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1038 |
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1110 |
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1400 |
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1450 |
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1493 |
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1543 |
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L1586 |
OperationsApiSchemaUsesCommonTypes |
Operations API path must follow the schema provided in the common types. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L2095 |
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L2180 |
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L2252 |
Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L30 |
|
Not using the common-types defined parameter 'api-version'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L30 |
|
Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L73 |
|
Not using the common-types defined parameter 'api-version'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L73 |
|
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L121 |
|
Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L121 |
|
Not using the common-types defined parameter 'api-version'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L121 |
|
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L211 |
|
Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L211 |
|
Not using the common-types defined parameter 'api-version'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L211 |
|
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L287 |
|
Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L287 |
|
Not using the common-types defined parameter 'api-version'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L287 |
|
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L376 |
|
Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L376 |
|
Not using the common-types defined parameter 'api-version'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L376 |
|
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L453 |
|
Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L453 |
|
Not using the common-types defined parameter 'api-version'. Location: Microsoft.Maintenance/stable/2023-04-01/Maintenance.json#L453 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️
~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
CadlAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
Please address or respond to feedback from the ARM API reviewer. |
Hi @KalpeshChavan12! The automation detected breaking changes in this pull request. As a result, it added the |
Hi @KalpeshChavan12! Your PR has some issues. Please fix the CI issues, if present, in following order:
If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel. |
Hi @KalpeshChavan12! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
Hi @KalpeshChavan12, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval. |
As discussed offline can you review and provide signoff. |
Hi, @KalpeshChavan12. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @KalpeshChavan12. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @KalpeshChavan12. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee. |
ARM (Control Plane) API Specification Update Pull Request
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.
ARM API changes review
ARMReview
label.ARMReview
label, if appropriate.If this happens, proceed according to guidance given in GitHub comments also added by the automation.
Breaking change review
If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.
Getting help
and https://aka.ms/ci-fix.