Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redis.json #24729

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Update redis.json #24729

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d8b167
Update redis.json
TimLovellSmith Jul 7, 2023
14f6480
Update specification/redis/resource-manager/Microsoft.Cache/stable/20…
TimLovellSmith Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion specification/redis/resource-manager/Microsoft.Cache/stable/2023-04-01/redis.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2018,7 +2018,7 @@
}
},
"publicNetworkAccess": {
"description": "Whether or not public endpoint access is allowed for this cache. Value is optional but if passed in, must be 'Enabled' or 'Disabled'. If 'Disabled', private endpoints are the exclusive access method. Default value is 'Enabled'",
"description": "Whether or not public endpoint access is allowed for this cache. Value is optional but if passed in, must be 'Enabled' or 'Disabled'. If 'Disabled', private endpoints are the exclusive access method. Default value is 'Enabled'. Note: this setting is important for caches with private endpoints; but has *no effect* on caches that are joined to, or injected into, a virtual network subnet.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to ensure if semi-colon was intentional.
Note: this setting is important for caches with private endpoints;
Note: this setting is important for caches with private endpoints,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I'll run it by an editor!

Copy link
Member Author

@TimLovellSmith TimLovellSmith Jul 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flang-msft any suggestions on semicolons or otherwise improving the docs here? They eventually turn into this page here:
https://learn.microsoft.com/en-us/rest/api/redis/redis/create?tabs=HTTP

TimLovellSmith marked this conversation as resolved.
Show resolved Hide resolved
"enum": [
"Enabled",
"Disabled"
Expand Down