Revert "Revert "[Hub Generated] Publish private branch 'azure-kusto/devCM'"" #24551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @michaelshikh07 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| kusto.json | 2023-05-02(c57cabf) | 2022-12-29(main) |
| kusto.json | 2023-05-02(c57cabf) | 2018-09-07-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 25 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with the latest preview version:
Only 25 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Kusto/clusters/{clusterName}/databases/{databaseName}/eventhubconnections' removed or restructured? Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L984:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Kusto/clusters/{clusterName}/databases/{databaseName}/eventhubConnectionValidation' removed or restructured? Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L1032:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Kusto/clusters/{clusterName}/databases/{databaseName}/eventhubconnections/{eventHubConnectionName}' removed or restructured? Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L1080:5 |
|
| The new version is missing a definition that was found in the old version. Was 'DatabaseProperties' removed or renamed? New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L4030:3 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L1345:3 |
|
| The new version is missing a definition that was found in the old version. Was 'EventHubConnectionValidation' removed or renamed? New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L4030:3 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L1345:3 |
|
| The new version is missing a definition that was found in the old version. Was 'DatabaseUpdate' removed or renamed? New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L4030:3 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L1345:3 |
|
| The new version is missing a definition that was found in the old version. Was 'EventHubConnectionUpdate' removed or renamed? New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L4030:3 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L1345:3 |
|
| The new version is missing a definition that was found in the old version. Was 'EventHubConnection' removed or renamed? New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L4030:3 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L1345:3 |
|
| The new version is missing a definition that was found in the old version. Was 'DatabaseCheckNameRequest' removed or renamed? New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L4030:3 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L1345:3 |
|
| The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupParameter' removed or renamed? New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L6940:3 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L2065:3 |
|
| The new version is missing a client parameter that was found in the old version. Was 'EventHubConnectionNameParameter' removed or renamed? New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L6940:3 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L2065:3 |
|
| The required parameter 'databaseName' was removed in the new version. Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L496:11 |
|
| The required parameter 'resourceName' was added in the new version. New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1087:11 |
|
| The new version adds a response code '202'. New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L199:11 |
|
| The '$ref' property points to different models in the old and new versions. New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L4055:9 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L1367:9 |
|
| The '$ref' property points to different models in the old and new versions. New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L53:13 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L53:13 |
|
| The '$ref' property points to different models in the old and new versions. New: common-types/resource-management/v3/types.json#L305:9 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L1885:9 |
|
| The '$ref' property points to different models in the old and new versions. New: common-types/resource-management/v3/types.json#L280:11 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L1999:11 |
|
| The '$ref' property points to different models in the old and new versions. New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L128:13 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L109:13 |
|
| The '$ref' property points to different models in the old and new versions. New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L213:13 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L165:13 |
|
| The '$ref' property points to different models in the old and new versions. New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L266:13 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L209:13 |
|
| The '$ref' property points to different models in the old and new versions. New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L318:13 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L252:13 |
|
| The '$ref' property points to different models in the old and new versions. New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L370:13 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L295:13 |
|
| The '$ref' property points to different models in the old and new versions. New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L890:13 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L334:13 |
|
| The '$ref' property points to different models in the old and new versions. New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L929:13 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L373:13 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 23 Errors, 1 Warnings failed [Detail]
| compared tags (via openapi-validator v2.1.3) | new version | base version |
|---|---|---|
| package-2023-05 | package-2023-05(c57cabf) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L254 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L309 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L361 |
RPC-Async-V1-07 |
|
200 response for a LRO POST operation must have a response schema specified. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L378 |
RPC-Post-V1-03 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L422 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L633 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L787 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L842 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1430 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1566 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1850 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L2176 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L2303 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L2470 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L2591 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L2794 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L3096 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L3149 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L3328 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L3569 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L3714 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L3863 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L3924 |
RPC-Async-V1-07 |
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'DatabaseModel'. Consider using the plural form of 'Database' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1594 |
The following errors/warnings exist before current PR submission:
Only 25 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Mark the top-level property 'location', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. These properties are not patchable. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L156 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L201 |
|
200 response for a LRO POST operation must have a response schema specified. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L274 |
|
200 response for a LRO POST operation must have a response schema specified. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L326 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L681 |
|
200 response for a LRO POST operation must have a response schema specified. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L743 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L884 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L923 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L959 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1046 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1244 |
|
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1369 |
|
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1369 |
|
A tracked resource MUST always have tags as a top level optional property. Tracked resource does not have tags in the request schema. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1369 |
|
Mark the top-level property 'location', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. These properties are not patchable. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1470 |
|
Properties of a PATCH request body must not be required, property:kind. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1474 |
|
200 response schema in long running PATCH operation is missing ProvisioningState property. A LRO PATCH operations 200 response schema must have ProvisioningState specified. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1490 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1510 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1901 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L2051 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L2244 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L2351 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L2535 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L2639 |
|
Description of 200 response code of a PUT operation MUST include term 'update'. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L2735 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
ARMChangesRequested
|
Please address or respond to feedback from the ARM API reviewer. When you are ready to continue the ARM API review, please remove the |
|
Hi @michaelshikh07! Your PR has some issues. Please fix the CI issues, if present, in following order:
If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel. |
|
Hi @michaelshikh07! The automation detected breaking changes in this pull request. As a result, it added the |
This was referenced Jun 22, 2023
tadelesh
approved these changes
Jun 24, 2023
tadelesh
deleted the
revert-24355-revert-24160-published/Azure/azure-rest-api-specs-pr/azure-kusto/devCM
branch
This was referenced Jun 24, 2023
This was referenced Jun 24, 2023
harryli0108
pushed a commit
to harryli0108/azure-rest-api-specs
that referenced
this pull request
Jul 28, 2023
…evCM' (Azure#24160)" (Azure#24355)" (Azure#24551) This reverts commit 6c157d4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #24355
Kusto service is now ready to publish the version
Please merge this pr