Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sqlvm.json #24248

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Fix sqlvm.json #24248

merged 1 commit into from
Jun 2, 2023

Conversation

msyyc
Copy link
Member

@msyyc msyyc commented Jun 1, 2023

@msyyc msyyc self-assigned this Jun 1, 2023
@openapi-workflow-bot
Copy link

Hi, @msyyc Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 1, 2023

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    sqlvm.json 2023-01-01-preview(21db649) 2023-01-01-preview(main)
    Rule Message
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L2169:9
    Old: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L2169:9
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.2) new version base version
    package-preview-2023-01 package-preview-2023-01(21db649) package-preview-2023-01(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ResourceNameRestriction The resource name parameter 'sqlVirtualMachineGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L19
    ResourceNameRestriction The resource name parameter 'availabilityGroupListenerName' should be defined with a 'pattern' restriction.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L19
    ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L26
    PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'AvailabilityGroupListeners_CreateOrUpdate' Request Model: 'parameters[3].schema' Response Model: 'responses[200].schema'
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L78
    ResourceNameRestriction The resource name parameter 'sqlVirtualMachineGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L215
    OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.SqlVirtualMachine/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L279
    OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L280
    ResourceNameRestriction The resource name parameter 'sqlVirtualMachineGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L300
    PatchResponseCode LRO PATCH must have 200 and 202 return codes.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L464
    LroPatch202 The async patch operation should return 202.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L497
    ResourceNameRestriction The resource name parameter 'sqlVirtualMachineGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L603
    LroPostReturn 200 response for a LRO POST operation must have a response schema specified.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L692
    LroPostReturn 200 response for a LRO POST operation must have a response schema specified.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L743
    ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L800
    PatchResponseCode LRO PATCH must have 200 and 202 return codes.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L967
    PatchIdentityProperty The patch operation body parameter schema should contains property 'identity'.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L980
    LroPatch202 The async patch operation should return 202.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L996
    XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L1382
    GuidUsage Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L1741
    GuidUsage Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L1759
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L26
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L26
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L26
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L84
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L84
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L84
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L157
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L157
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L157
    ⚠️ ProvisioningStateSpecifiedForLRODelete 200 response schema in long running DELETE operation is missing ProvisioningState property. A LRO DELETE operations 200 response schema must have ProvisioningState specified.
    Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L183
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 1, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/sqlvirtualmachine/armsqlvirtualmachine - 0.10.0
    +	`CommitASYNCHRONOUSCOMMIT`, `CommitSYNCHRONOUSCOMMIT` from enum `Commit` has been removed
    +	`FailoverAUTOMATIC`, `FailoverMANUAL` from enum `Failover` has been removed
    +	`ReadableSecondaryALL`, `ReadableSecondaryNO`, `ReadableSecondaryREADONLY` from enum `ReadableSecondary` has been removed
    +	`RolePRIMARY`, `RoleSECONDARY` from enum `Role` has been removed

    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 5b3850b. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.7
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.7>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-sqlvirtualmachine [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model SQLStorageSettings has a new parameter use_storage_pool
      info	[Changelog]   - Model SQLTempDbSettings has a new parameter use_storage_pool
      info	[Changelog]   - Model StorageConfigurationSettings has a new parameter enable_storage_config_blade
      info	[Changelog]   - Model WsfcDomainProfile has a new parameter is_sql_service_account_gmsa
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 5b3850b. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/sqlvirtualmachine/armsqlvirtualmachine [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - `CommitASYNCHRONOUSCOMMIT`, `CommitSYNCHRONOUSCOMMIT` from enum `Commit` has been removed
      info	[Changelog] - `FailoverAUTOMATIC`, `FailoverMANUAL` from enum `Failover` has been removed
      info	[Changelog] - `ReadableSecondaryALL`, `ReadableSecondaryNO`, `ReadableSecondaryREADONLY` from enum `ReadableSecondary` has been removed
      info	[Changelog] - `RolePRIMARY`, `RoleSECONDARY` from enum `Role` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New value `CommitAsynchronousCommit`, `CommitSynchronousCommit` added to enum type `Commit`
      info	[Changelog] - New value `FailoverAutomatic`, `FailoverManual` added to enum type `Failover`
      info	[Changelog] - New value `ReadableSecondaryAll`, `ReadableSecondaryNo`, `ReadableSecondaryReadOnly` added to enum type `ReadableSecondary`
      info	[Changelog] - New value `RolePrimary`, `RoleSecondary` added to enum type `Role`
      info	[Changelog] - New field `UseStoragePool` in struct `SQLStorageSettings`
      info	[Changelog] - New field `UseStoragePool` in struct `SQLTempDbSettings`
      info	[Changelog] - New field `EnableStorageConfigBlade` in struct `StorageConfigurationSettings`
      info	[Changelog] - New field `IsSQLServiceAccountGmsa` in struct `WsfcDomainProfile`
      info	[Changelog]
      info	[Changelog] Total 9 breaking change(s), 13 additive change(s).
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 5b3850b. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️sqlvirtualmachine [View full logs
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 5b3850b. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • Az.sqlvirtualmachine.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.sqlvirtualmachine.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 1, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/sqlvirtualmachine/armsqlvirtualmachine https://apiview.dev/Assemblies/Review/ed48d3803b3349c4b38bac46fc33ad40
    Java azure-resourcemanager-sqlvirtualmachine https://apiview.dev/Assemblies/Review/8f0442733e484fefbb97dc67440a77af
    .Net Azure.ResourceManager.SqlVirtualMachine https://apiview.dev/Assemblies/Review/e21dfdc4358f4f35bc80c0c47397fd77

    @openapi-workflow-bot
    Copy link

    Hi @msyyc, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants