Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appgw: Remove 499 status code from custom error page #24095

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Appgw: Remove 499 status code from custom error page #24095

merged 1 commit into from
Jun 1, 2023

Conversation

prateek2211
Copy link
Contributor

@prateek2211 prateek2211 commented May 22, 2023 •
edited
Loading

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @prateek2211 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 22, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 1 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    applicationGateway.json 2023-02-01(0c93bb5) 2022-11-01(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    ❌ 1019 - RemovedEnumValue The new version is removing enum value(s) 'HttpStatus499' from the old version.
    New: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L3747:9
    Old: Microsoft.Network/stable/2022-11-01/applicationGateway.json#L3747:9
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.2) new version base version
    package-2023-02 package-2023-02(0c93bb5) package-2023-02(release-network-Microsoft.Network-official-2023-02-01)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L37
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L72
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L84
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L194
    ❌ PatchIdentityProperty The patch operation body parameter schema should contains property 'identity'.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L234
    ❌ ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L351
    ❌ LroPostReturn 200 response for a LRO POST operation must have a response schema specified.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L352
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L389
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L395
    ❌ ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L405
    ❌ LroPostReturn 200 response for a LRO POST operation must have a response schema specified.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L406
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L443
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L449
    ❌ ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L459
    ❌ ParametersInPost $expand is a query parameter. Post operation must not contain any query parameter other than api-version.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L471
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L507
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L513
    ❌ ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L523
    ❌ ParametersInPost $expand is a query parameter. Post operation must not contain any query parameter other than api-version.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L535
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L580
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L586
    ❌ ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L596
    ❌ ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L649
    ❌ ResourceNameRestriction The resource name parameter 'connectionName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L649
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L691
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L703
    ❌ ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L712
    ❌ PutResponseSchemaDescription Any Put MUST contain 200 and 201 return codes.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L756
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L763
    ❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L769
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand] 
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 22, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️⚠️SDK Breaking Change Tracking warning [Detail]

    Breaking Changes Tracking

    ⚠️azure-sdk-for-go - sdk/resourcemanager/network/armnetwork - Approved - 3.0.0
    +	Field `PeerRouteList` of struct `VirtualHubBgpConnectionsClientListAdvertisedRoutesResponse` has been removed
+	Field `PeerRouteList` of struct `VirtualHubBgpConnectionsClientListLearnedRoutesResponse` has been removed
+	Struct `PeerRouteList` has been removed
+	Type of `EffectiveRouteMapRoute.Prefix` has been changed from `[]*string` to `*string`
+	`ApplicationGatewayCustomErrorStatusCodeHTTPStatus499` from enum `ApplicationGatewayCustomErrorStatusCode` has been removed
+	`LoadBalancerBackendAddressAdminStateDrain` from enum `LoadBalancerBackendAddressAdminState` has been removed
    ⚠️azure-sdk-for-js - @azure/arm-network - 31.0.0
    +	Enum KnownApplicationGatewayCustomErrorStatusCode no longer has value HttpStatus499
+	Enum KnownLoadBalancerBackendAddressAdminState no longer has value Drain
+	Interface Subnet no longer has parameter applicationGatewayIpConfigurations
+	Type of parameter prefix of interface EffectiveRouteMapRoute is changed from string[] to string
    ⚠️azure-sdk-for-python-track2 - track2_azure-mgmt-network - Approved - 23.1.0
    +	Model ApplicationRule no longer has parameter http_headers_to_insert
+	Model BastionHost no longer has parameter enable_kerberos
+	Model NetworkInterface no longer has parameter auxiliary_sku
+	Model NetworkVirtualAppliance no longer has parameter additional_nics
+	Model NetworkVirtualAppliance no longer has parameter virtual_appliance_connections
+	Model PolicySettings no longer has parameter file_upload_enforcement
+	Model PolicySettings no longer has parameter log_scrubbing
+	Model PolicySettings no longer has parameter request_body_enforcement
+	Model PolicySettings no longer has parameter request_body_inspect_limit_in_kb
+	Model PrivateEndpointConnection no longer has parameter private_endpoint_location
+	Model PublicIPAddressDnsSettings no longer has parameter domain_name_label_scope
+	Model VirtualApplianceNicProperties no longer has parameter instance_name
+	Model WebApplicationFirewallCustomRule no longer has parameter group_by_user_session
+	Model WebApplicationFirewallCustomRule no longer has parameter rate_limit_duration
+	Model WebApplicationFirewallCustomRule no longer has parameter rate_limit_threshold
+	Removed operation AzureFirewallsOperations.begin_packet_capture
+	Removed operation group NetworkVirtualApplianceConnectionsOperations
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • ❌Failed [Logs] Generate from 9198955adef6d35bc892bb5fcda286b18f295ca7. SDK Automation 14.0.0 
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • ❌Azure.ResourceManager.Network [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.ArmOperation<Azure.ResourceManager.Network.Models.PeerRouteList> Azure.ResourceManager.Network.BgpConnectionResource.GetLearnedRoutesVirtualHubBgpConnection(Azure.WaitUntil, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Threading.Tasks.Task<Azure.ResourceManager.ArmOperation<Azure.ResourceManager.Network.Models.PeerRouteList>> Azure.ResourceManager.Network.BgpConnectionResource.GetLearnedRoutesVirtualHubBgpConnectionAsync(Azure.WaitUntil, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.ArmOperation Azure.ResourceManager.Network.VirtualHubResource.GetEffectiveVirtualHubRoutes(Azure.WaitUntil, Azure.ResourceManager.Network.Models.EffectiveRoutesContent, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Threading.Tasks.Task<Azure.ResourceManager.ArmOperation> Azure.ResourceManager.Network.VirtualHubResource.GetEffectiveVirtualHubRoutesAsync(Azure.WaitUntil, Azure.ResourceManager.Network.Models.EffectiveRoutesContent, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.ArmOperation Azure.ResourceManager.Network.VirtualHubResource.GetInboundRoutes(Azure.WaitUntil, Azure.ResourceManager.Network.Models.VirtualHubInboundRoutesContent, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Threading.Tasks.Task<Azure.ResourceManager.ArmOperation> Azure.ResourceManager.Network.VirtualHubResource.GetInboundRoutesAsync(Azure.WaitUntil, Azure.ResourceManager.Network.Models.VirtualHubInboundRoutesContent, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.ArmOperation Azure.ResourceManager.Network.VirtualHubResource.GetOutboundRoutes(Azure.WaitUntil, Azure.ResourceManager.Network.Models.VirtualHubOutboundRoutesContent, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Threading.Tasks.Task<Azure.ResourceManager.ArmOperation> Azure.ResourceManager.Network.VirtualHubResource.GetOutboundRoutesAsync(Azure.WaitUntil, Azure.ResourceManager.Network.Models.VirtualHubOutboundRoutesContent, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.Models.ApplicationGatewayCustomErrorStatusCode Azure.ResourceManager.Network.Models.ApplicationGatewayCustomErrorStatusCode.HttpStatus499.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.Models.LoadBalancerBackendAddressAdminState Azure.ResourceManager.Network.Models.LoadBalancerBackendAddressAdminState.Drain.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.Network.Models.PeerRouteList' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.Network/Debug/netstandard2.0/Azure.ResourceManager.Network.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 9198955adef6d35bc892bb5fcda286b18f295ca7. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.7
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.7>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-network [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model ApplicationRule no longer has parameter http_headers_to_insert
info	[Changelog]   - Model BastionHost no longer has parameter enable_kerberos
info	[Changelog]   - Model NetworkInterface no longer has parameter auxiliary_sku
info	[Changelog]   - Model NetworkVirtualAppliance no longer has parameter additional_nics
info	[Changelog]   - Model NetworkVirtualAppliance no longer has parameter virtual_appliance_connections
info	[Changelog]   - Model PolicySettings no longer has parameter file_upload_enforcement
info	[Changelog]   - Model PolicySettings no longer has parameter log_scrubbing
info	[Changelog]   - Model PolicySettings no longer has parameter request_body_enforcement
info	[Changelog]   - Model PolicySettings no longer has parameter request_body_inspect_limit_in_kb
info	[Changelog]   - Model PrivateEndpointConnection no longer has parameter private_endpoint_location
info	[Changelog]   - Model PublicIPAddressDnsSettings no longer has parameter domain_name_label_scope
info	[Changelog]   - Model VirtualApplianceNicProperties no longer has parameter instance_name
info	[Changelog]   - Model WebApplicationFirewallCustomRule no longer has parameter group_by_user_session
info	[Changelog]   - Model WebApplicationFirewallCustomRule no longer has parameter rate_limit_duration
info	[Changelog]   - Model WebApplicationFirewallCustomRule no longer has parameter rate_limit_threshold
info	[Changelog]   - Removed operation AzureFirewallsOperations.begin_packet_capture
info	[Changelog]   - Removed operation group NetworkVirtualApplianceConnectionsOperations
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from 9198955adef6d35bc892bb5fcda286b18f295ca7. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-network-generated [View full logs]  [Preview SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 9198955adef6d35bc892bb5fcda286b18f295ca7. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/network/armnetwork [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `EffectiveRouteMapRoute.Prefix` has been changed from `[]*string` to `*string`
info	[Changelog] - `ApplicationGatewayCustomErrorStatusCodeHTTPStatus499` from enum `ApplicationGatewayCustomErrorStatusCode` has been removed
info	[Changelog] - `LoadBalancerBackendAddressAdminStateDrain` from enum `LoadBalancerBackendAddressAdminState` has been removed
info	[Changelog] - Struct `PeerRouteList` has been removed
info	[Changelog] - Field `PeerRouteList` of struct `VirtualHubBgpConnectionsClientListAdvertisedRoutesResponse` has been removed
info	[Changelog] - Field `PeerRouteList` of struct `VirtualHubBgpConnectionsClientListLearnedRoutesResponse` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `NetworkInterfaceAuxiliaryModeAcceleratedConnections` added to enum type `NetworkInterfaceAuxiliaryMode`
info	[Changelog] - New value `WebApplicationFirewallRuleTypeRateLimitRule` added to enum type `WebApplicationFirewallRuleType`
info	[Changelog] - New enum type `ApplicationGatewayFirewallRateLimitDuration` with values `ApplicationGatewayFirewallRateLimitDurationFiveMins`, `ApplicationGatewayFirewallRateLimitDurationOneMin`
info	[Changelog] - New enum type `ApplicationGatewayFirewallUserSessionVariable` with values `ApplicationGatewayFirewallUserSessionVariableClientAddr`, `ApplicationGatewayFirewallUserSessionVariableGeoLocation`, `ApplicationGatewayFirewallUserSessionVariableNone`
info	[Changelog] - New enum type `AzureFirewallPacketCaptureFlagsType` with values `AzureFirewallPacketCaptureFlagsTypeAck`, `AzureFirewallPacketCaptureFlagsTypeFin`, `AzureFirewallPacketCaptureFlagsTypePush`, `AzureFirewallPacketCaptureFlagsTypeRst`, `AzureFirewallPacketCaptureFlagsTypeSyn`, `AzureFirewallPacketCaptureFlagsTypeUrg`
info	[Changelog] - New enum type `NetworkInterfaceAuxiliarySKU` with values `NetworkInterfaceAuxiliarySKUA1`, `NetworkInterfaceAuxiliarySKUA2`, `NetworkInterfaceAuxiliarySKUA4`, `NetworkInterfaceAuxiliarySKUA8`, `NetworkInterfaceAuxiliarySKUNone`
info	[Changelog] - New enum type `PublicIPAddressDNSSettingsDomainNameLabelScope` with values `PublicIPAddressDNSSettingsDomainNameLabelScopeNoReuse`, `PublicIPAddressDNSSettingsDomainNameLabelScopeResourceGroupReuse`, `PublicIPAddressDNSSettingsDomainNameLabelScopeSubscriptionReuse`, `PublicIPAddressDNSSettingsDomainNameLabelScopeTenantReuse`
info	[Changelog] - New enum type `ScrubbingRuleEntryMatchOperator` with values `ScrubbingRuleEntryMatchOperatorEquals`, `ScrubbingRuleEntryMatchOperatorEqualsAny`
info	[Changelog] - New enum type `ScrubbingRuleEntryMatchVariable` with values `ScrubbingRuleEntryMatchVariableRequestArgNames`, `ScrubbingRuleEntryMatchVariableRequestCookieNames`, `ScrubbingRuleEntryMatchVariableRequestHeaderNames`, `ScrubbingRuleEntryMatchVariableRequestIPAddress`, `ScrubbingRuleEntryMatchVariableRequestJSONArgNames`, `ScrubbingRuleEntryMatchVariableRequestPostArgNames`
info	[Changelog] - New enum type `ScrubbingRuleEntryState` with values `ScrubbingRuleEntryStateDisabled`, `ScrubbingRuleEntryStateEnabled`
info	[Changelog] - New enum type `WebApplicationFirewallScrubbingState` with values `WebApplicationFirewallScrubbingStateDisabled`, `WebApplicationFirewallScrubbingStateEnabled`
info	[Changelog] - New function `*AzureFirewallsClient.BeginPacketCapture(context.Context, string, string, FirewallPacketCaptureParameters, *AzureFirewallsClientBeginPacketCaptureOptions) (*runtime.Poller[AzureFirewallsClientPacketCaptureResponse], error)`
info	[Changelog] - New function `*ClientFactory.NewVirtualApplianceConnectionsClient() *VirtualApplianceConnectionsClient`
info	[Changelog] - New function `NewVirtualApplianceConnectionsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*VirtualApplianceConnectionsClient, error)`
info	[Changelog] - New function `*VirtualApplianceConnectionsClient.BeginCreateOrUpdate(context.Context, string, string, string, VirtualApplianceConnection, *VirtualApplianceConnectionsClientBeginCreateOrUpdateOptions) (*runtime.Poller[VirtualApplianceConnectionsClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `*VirtualApplianceConnectionsClient.BeginDelete(context.Context, string, string, string, *VirtualApplianceConnectionsClientBeginDeleteOptions) (*runtime.Poller[VirtualApplianceConnectionsClientDeleteResponse], error)`
info	[Changelog] - New function `*VirtualApplianceConnectionsClient.Get(context.Context, string, string, string, *VirtualApplianceConnectionsClientGetOptions) (VirtualApplianceConnectionsClientGetResponse, error)`
info	[Changelog] - New function `*VirtualApplianceConnectionsClient.NewListPager(string, string, *VirtualApplianceConnectionsClientListOptions) *runtime.Pager[VirtualApplianceConnectionsClientListResponse]`
info	[Changelog] - New struct `AzureFirewallPacketCaptureFlags`
info	[Changelog] - New struct `AzureFirewallPacketCaptureRule`
info	[Changelog] - New struct `EffectiveRouteMapRouteList`
info	[Changelog] - New struct `FirewallPacketCaptureParameters`
info	[Changelog] - New struct `FirewallPacketCaptureParametersFormat`
info	[Changelog] - New struct `FirewallPolicyHTTPHeaderToInsert`
info	[Changelog] - New struct `GroupByUserSession`
info	[Changelog] - New struct `GroupByVariable`
info	[Changelog] - New struct `PolicySettingsLogScrubbing`
info	[Changelog] - New struct `PropagatedRouteTableNfv`
info	[Changelog] - New struct `RoutingConfigurationNfv`
info	[Changelog] - New struct `RoutingConfigurationNfvSubResource`
info	[Changelog] - New struct `VirtualApplianceAdditionalNicProperties`
info	[Changelog] - New struct `VirtualApplianceConnection`
info	[Changelog] - New struct `VirtualApplianceConnectionList`
info	[Changelog] - New struct `VirtualApplianceConnectionProperties`
info	[Changelog] - New struct `WebApplicationFirewallScrubbingRules`
info	[Changelog] - New field `HTTPHeadersToInsert` in struct `ApplicationRule`
info	[Changelog] - New field `EnableKerberos` in struct `BastionHostPropertiesFormat`
info	[Changelog] - New field `AuxiliarySKU` in struct `InterfacePropertiesFormat`
info	[Changelog] - New field `FileUploadEnforcement`, `LogScrubbing`, `RequestBodyEnforcement`, `RequestBodyInspectLimitInKB` in struct `PolicySettings`
info	[Changelog] - New field `PrivateEndpointLocation` in struct `PrivateEndpointConnectionProperties`
info	[Changelog] - New field `DomainNameLabelScope` in struct `PublicIPAddressDNSSettings`
info	[Changelog] - New field `InstanceName` in struct `VirtualApplianceNicProperties`
info	[Changelog] - New field `AdditionalNics`, `VirtualApplianceConnections` in struct `VirtualAppliancePropertiesFormat`
info	[Changelog] - New field `Value` in struct `VirtualHubBgpConnectionsClientListAdvertisedRoutesResponse`
info	[Changelog] - New field `Value` in struct `VirtualHubBgpConnectionsClientListLearnedRoutesResponse`
info	[Changelog] - New anonymous field `VirtualHubEffectiveRouteList` in struct `VirtualHubsClientGetEffectiveVirtualHubRoutesResponse`
info	[Changelog] - New anonymous field `EffectiveRouteMapRouteList` in struct `VirtualHubsClientGetInboundRoutesResponse`
info	[Changelog] - New anonymous field `EffectiveRouteMapRouteList` in struct `VirtualHubsClientGetOutboundRoutesResponse`
info	[Changelog] - New field `GroupByUserSession`, `RateLimitDuration`, `RateLimitThreshold` in struct `WebApplicationFirewallCustomRule`
info	[Changelog]
info	[Changelog] Total 7 breaking change(s), 98 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 9198955adef6d35bc892bb5fcda286b18f295ca7. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-network [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group NetworkVirtualApplianceConnections
info	[Changelog]   - Added operation AzureFirewalls.beginPacketCapture
info	[Changelog]   - Added operation AzureFirewalls.beginPacketCaptureAndWait
info	[Changelog]   - Added Interface AzureFirewallPacketCaptureFlags
info	[Changelog]   - Added Interface AzureFirewallPacketCaptureRule
info	[Changelog]   - Added Interface AzureFirewallsPacketCaptureHeaders
info	[Changelog]   - Added Interface AzureFirewallsPacketCaptureOptionalParams
info	[Changelog]   - Added Interface EffectiveRouteMapRouteList
info	[Changelog]   - Added Interface FirewallPacketCaptureParameters
info	[Changelog]   - Added Interface FirewallPolicyHttpHeaderToInsert
info	[Changelog]   - Added Interface GroupByUserSession
info	[Changelog]   - Added Interface GroupByVariable
info	[Changelog]   - Added Interface NetworkVirtualApplianceConnection
info	[Changelog]   - Added Interface NetworkVirtualApplianceConnectionList
info	[Changelog]   - Added Interface NetworkVirtualApplianceConnectionsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface NetworkVirtualApplianceConnectionsDeleteHeaders
info	[Changelog]   - Added Interface NetworkVirtualApplianceConnectionsDeleteOptionalParams
info	[Changelog]   - Added Interface NetworkVirtualApplianceConnectionsGetOptionalParams
info	[Changelog]   - Added Interface NetworkVirtualApplianceConnectionsListNextOptionalParams
info	[Changelog]   - Added Interface NetworkVirtualApplianceConnectionsListOptionalParams
info	[Changelog]   - Added Interface NetworkVirtualAppliancesCreateOrUpdateHeaders
info	[Changelog]   - Added Interface NetworkVirtualAppliancesDeleteHeaders
info	[Changelog]   - Added Interface PolicySettingsLogScrubbing
info	[Changelog]   - Added Interface PropagatedRouteTableNfv
info	[Changelog]   - Added Interface RoutingConfigurationNfv
info	[Changelog]   - Added Interface RoutingConfigurationNfvSubResource
info	[Changelog]   - Added Interface VirtualApplianceAdditionalNicProperties
info	[Changelog]   - Added Interface WebApplicationFirewallScrubbingRules
info	[Changelog]   - Added Type Alias ApplicationGatewayFirewallRateLimitDuration
info	[Changelog]   - Added Type Alias ApplicationGatewayFirewallUserSessionVariable
info	[Changelog]   - Added Type Alias AzureFirewallPacketCaptureFlagsType
info	[Changelog]   - Added Type Alias AzureFirewallsPacketCaptureResponse
info	[Changelog]   - Added Type Alias NetworkInterfaceAuxiliarySku
info	[Changelog]   - Added Type Alias NetworkVirtualApplianceConnectionsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias NetworkVirtualApplianceConnectionsGetResponse
info	[Changelog]   - Added Type Alias NetworkVirtualApplianceConnectionsListNextResponse
info	[Changelog]   - Added Type Alias NetworkVirtualApplianceConnectionsListResponse
info	[Changelog]   - Added Type Alias PublicIpAddressDnsSettingsDomainNameLabelScope
info	[Changelog]   - Added Type Alias ScrubbingRuleEntryMatchOperator
info	[Changelog]   - Added Type Alias ScrubbingRuleEntryMatchVariable
info	[Changelog]   - Added Type Alias ScrubbingRuleEntryState
info	[Changelog]   - Added Type Alias VirtualHubsGetEffectiveVirtualHubRoutesResponse
info	[Changelog]   - Added Type Alias VirtualHubsGetInboundRoutesResponse
info	[Changelog]   - Added Type Alias VirtualHubsGetOutboundRoutesResponse
info	[Changelog]   - Added Type Alias WebApplicationFirewallScrubbingState
info	[Changelog]   - Interface ApplicationRule has a new optional parameter httpHeadersToInsert
info	[Changelog]   - Interface BastionHost has a new optional parameter enableKerberos
info	[Changelog]   - Interface NetworkInterface has a new optional parameter auxiliarySku
info	[Changelog]   - Interface NetworkVirtualAppliance has a new optional parameter additionalNics
info	[Changelog]   - Interface NetworkVirtualAppliance has a new optional parameter virtualApplianceConnections
info	[Changelog]   - Interface PolicySettings has a new optional parameter fileUploadEnforcement
info	[Changelog]   - Interface PolicySettings has a new optional parameter logScrubbing
info	[Changelog]   - Interface PolicySettings has a new optional parameter requestBodyEnforcement
info	[Changelog]   - Interface PolicySettings has a new optional parameter requestBodyInspectLimitInKB
info	[Changelog]   - Interface PrivateEndpointConnection has a new optional parameter privateEndpointLocation
info	[Changelog]   - Interface PublicIPAddressDnsSettings has a new optional parameter domainNameLabelScope
info	[Changelog]   - Interface Subnet has a new optional parameter applicationGatewayIPConfigurations
info	[Changelog]   - Interface VirtualApplianceNicProperties has a new optional parameter instanceName
info	[Changelog]   - Interface WebApplicationFirewallCustomRule has a new optional parameter groupByUserSession
info	[Changelog]   - Interface WebApplicationFirewallCustomRule has a new optional parameter rateLimitDuration
info	[Changelog]   - Interface WebApplicationFirewallCustomRule has a new optional parameter rateLimitThreshold
info	[Changelog]   - Added Enum KnownApplicationGatewayFirewallRateLimitDuration
info	[Changelog]   - Added Enum KnownApplicationGatewayFirewallUserSessionVariable
info	[Changelog]   - Added Enum KnownAzureFirewallPacketCaptureFlagsType
info	[Changelog]   - Added Enum KnownNetworkInterfaceAuxiliarySku
info	[Changelog]   - Added Enum KnownScrubbingRuleEntryMatchOperator
info	[Changelog]   - Added Enum KnownScrubbingRuleEntryMatchVariable
info	[Changelog]   - Added Enum KnownScrubbingRuleEntryState
info	[Changelog]   - Added Enum KnownWebApplicationFirewallScrubbingState
info	[Changelog]   - Enum KnownNetworkInterfaceAuxiliaryMode has a new value AcceleratedConnections
info	[Changelog]   - Enum KnownWebApplicationFirewallRuleType has a new value RateLimitRule
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface Subnet no longer has parameter applicationGatewayIpConfigurations
info	[Changelog]   - Type of parameter prefix of interface EffectiveRouteMapRoute is changed from string[] to string
info	[Changelog]   - Enum KnownApplicationGatewayCustomErrorStatusCode no longer has value HttpStatus499
info	[Changelog]   - Enum KnownLoadBalancerBackendAddressAdminState no longer has value Drain
    ️🔄 azure-resource-manager-schemas inProgress [Detail]
    ️❌ azure-powershell failed [Detail]
    • ❌Pipeline Framework Failed [Logs] Generate from 9198955adef6d35bc892bb5fcda286b18f295ca7. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe
    • ❌Az.network.DefaultTag [View full logs]  
      error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.network.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 22, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Swagger Microsoft.Network Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Go sdk/resourcemanager/network/armnetwork Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Java azure-resourcemanager-network-generated Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    .Net Azure.ResourceManager.Network Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-network Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label May 22, 2023
    @ghost
    Copy link

    ghost commented May 22, 2023

    Thank you for your contribution prateek2211! We will review the pull request and get back to you soon.

    @ghost ghost added the Network label May 22, 2023
    @azure-sdk azure-sdk mentioned this pull request May 22, 2023
    Closed
    @AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager labels May 22, 2023
    @openapi-workflow-bot
    Copy link

    Hi @prateek2211, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    This was referenced May 22, 2023
    Closed
    Closed
    This was referenced May 22, 2023
    Closed
    Closed
    Closed
    @JackTn
    Copy link
    Member

    JackTn commented May 25, 2023

    @JeffreyRichter help to approve this breaking change, Thanks

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 25, 2023
    @prateek2211
    Copy link
    Contributor Author

    @microsoft-github-policy-service agree company="Microsoft"

    @prateek2211
    Copy link
    Contributor Author

    @JackTn Can you please review this?

    @JackTn
    Copy link
    Member

    JackTn commented May 29, 2023

    @JackTn Can you please review this?

    All checks pass. Need merge now ? @prateek2211

    @JackTn JackTn added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label May 29, 2023
    @prateek2211
    Copy link
    Contributor Author

    prateek2211 commented May 30, 2023 •
    edited
    Loading

    @JackTn Can you please review this?

    All checks pass. Need merge now ? @prateek2211

    @JackTn Yes, please merge this now.

    @JackTn
    Copy link
    Member

    JackTn commented May 30, 2023

    @JackTn Can you please review this?

    All checks pass. Need merge now ? @prateek2211

    @JackTn Yes, please merge this now.

    @msyyc help to merge this , Thanks

    @msyyc
    Copy link
    Member

    msyyc commented May 31, 2023

    @tadelesh @qiaozha Could you help confirm SDK breaking?

    @tadelesh tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label May 31, 2023
    @prateek2211
    Copy link
    Contributor Author

    @msyyc Can we merge this now?

    @msyyc msyyc merged commit 9b1ecde into Azure:release-network-Microsoft.Network-official-2023-02-01 Jun 1, 2023
    @htippanaboya htippanaboya mentioned this pull request Jun 12, 2023
    Merged
    11 tasks
    msyyc pushed a commit that referenced this pull request Jun 13, 2023
    @htippanaboya @MikhailTryakhov
    @JainRah @sssharma24 @prateek2211 @nimaller @sindhualuguvelli1
    Release network microsoft.network official 2023 02 01 (#24277)
    7c20402 
    * Adds base for updating Microsoft.Network from version stable/2022-11-01 to version 2023-02-01

* Updates readme

* Updates API version in new specs and examples

* Fixed double header issue (#23896)

* Edited description for additional nics (#24071)

* swagger 20230201 adding resource guid (#24154)

* Appgw: Remove 499 status code from custom error page (#24095)

* Add AdminState Property to Virtual Network Gateway Resource Properties (#23978)

* add adminstate

* update description

* add headers to 202

* prettier fix

* AppGW: Add default predefined ssl policy field in resource (#24094)

* Fix examples (#24274)

---------

Co-authored-by: Mikhail <[email protected]>
Co-authored-by: JainRah <[email protected]>
Co-authored-by: sssharma24 <[email protected]>
Co-authored-by: Prateek Sachan <[email protected]>
Co-authored-by: nimaller <[email protected]>
Co-authored-by: Sindhu Aluguvelli <[email protected]>
    @Alancere Alancere mentioned this pull request Jul 17, 2023
    Merged
    @MaryGao MaryGao mentioned this pull request Jul 19, 2023
    Merged
    harryli0108 pushed a commit to harryli0108/azure-rest-api-specs that referenced this pull request Jul 28, 2023
    @htippanaboya @MikhailTryakhov
    @JainRah @sssharma24 @prateek2211 @nimaller @sindhualuguvelli1 @harryli0108
    Release network microsoft.network official 2023 02 01 (Azure#24277)
    a8f713c 
    * Adds base for updating Microsoft.Network from version stable/2022-11-01 to version 2023-02-01

* Updates readme

* Updates API version in new specs and examples

* Fixed double header issue (Azure#23896)

* Edited description for additional nics (Azure#24071)

* swagger 20230201 adding resource guid (Azure#24154)

* Appgw: Remove 499 status code from custom error page (Azure#24095)

* Add AdminState Property to Virtual Network Gateway Resource Properties (Azure#23978)

* add adminstate

* update description

* add headers to 202

* prettier fix

* AppGW: Add default predefined ssl policy field in resource (Azure#24094)

* Fix examples (Azure#24274)

---------

Co-authored-by: Mikhail <[email protected]>
Co-authored-by: JainRah <[email protected]>
Co-authored-by: sssharma24 <[email protected]>
Co-authored-by: Prateek Sachan <[email protected]>
Co-authored-by: nimaller <[email protected]>
Co-authored-by: Sindhu Aluguvelli <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @msyyc msyyc msyyc approved these changes

    @MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

    Assignees

    @JackTn JackTn

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-Python BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript customer-reported Issues that are reported by GitHub users external to the Azure organization. Network resource-manager
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @prateek2211 @JackTn @msyyc @tadelesh @JeffreyRichter @AzureRestAPISpecReview