Using commony type error response #23955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @MattEberhart-MSFTE Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| costmanagement.benefits.json | 2023-03-01(a57e921) | 2022-10-01(main) |
The following breaking changes are detected by comparison with the latest stable version:
| Rule | Message |
|---|---|
| The '$ref' property points to different models in the old and new versions. New: common-types/resource-management/v5/types.json#L307:9 Old: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L78:9 |
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.1) | new version | base version |
|---|---|---|
| package-2023-03 | package-2023-03(a57e921) | package-2023-03(dev-cost-management-Microsoft.CostManagement-2023-03-01-stable-3) |
The following errors/warnings exist before current PR submission:
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️⌛PR Summary pending [Detail]
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=362505&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 128 " |
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]
Breaking Changes Tracking
️✔️azure-sdk-for-go - sdk/resourcemanager/costmanagement/armcostmanagement - 2.0.0+ Enum `ForecastTimeframeType` has been removed + Enum `ReportConfigColumnType` has been removed + Field `ETag` of struct `ProxyResource` has been removed + Field `ETag`, `Location`, `SKU`, `Tags` of struct `Resource` has been removed + Field `ID` of struct `Operation` has been removed + Field `QueryResult` of struct `ForecastClientExternalCloudProviderUsageResponse` has been removed + Field `QueryResult` of struct `ForecastClientUsageResponse` has been removed + Operation `*GenerateDetailedCostReportOperationResultsClient.Get` has been changed to LRO, use `*GenerateDetailedCostReportOperationResultsClient.BeginGet` instead. + Struct `ExportExecutionProperties` has been removed + Struct `ExportExecution` has been removed + Type of `ExportExecutionListResult.Value` has been changed from `[]*ExportExecution` to `[]*ExportRun` + Type of `ForecastDataset.Aggregation` has been changed from `map[string]*QueryAggregation` to `map[string]*ForecastAggregation` + Type of `ForecastDataset.Configuration` has been changed from `*QueryDatasetConfiguration` to `*ForecastDatasetConfiguration` + Type of `ForecastDataset.Filter` has been changed from `*QueryFilter` to `*ForecastFilter` + Type of `ForecastDefinition.TimePeriod` has been changed from `*QueryTimePeriod` to `*ForecastTimePeriod` + Type of `ForecastDefinition.Timeframe` has been changed from `*ForecastTimeframeType` to `*ForecastTimeframe` + Type of `OperationListResult.Value` has been changed from `[]*Operation` to `[]*OperationForCostManagement` + Type of `ReportConfigGrouping.Type` has been changed from `*ReportConfigColumnType` to `*QueryColumnType` + `QueryColumnTypeTag` from enum `QueryColumnType` has been removed
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-costmanagement - 3.0.0+ Model Alert no longer has parameter tags + Model ProxyResource no longer has parameter e_tag + Model ReportConfigFilter no longer has parameter tag_key + Model ReportConfigFilter no longer has parameter tag_value + Model Resource no longer has parameter tags + Removed operation group SettingsOperations
️❌ azure-sdk-for-net-track2 failed [Detail]
❌Failed [Logs] Generate from cb621736f6f1ee664155f13df9ff68070e5f4c22. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712 cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m | �[31;1mFailed to generate sdk. exit code: False cmderr [Invoke-GenerateAndBuildV2.ps1] �[0m cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:800 cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m 800 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m | �[31;1mCannot find path cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1mit does not exist. cmderr [Invoke-GenerateAndBuildV2.ps1] �[0m cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712 cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m | �[31;1mFailed to generate sdk artifact cmderr [Invoke-GenerateAndBuildV2.ps1] �[0m
❌Azure.ResourceManager.Cost-Management [View full logs] [Preview SDK Changes]info [Changelog]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from cb621736f6f1ee664155f13df9ff68070e5f4c22. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
- Only show 120 items here, please refer to log for details.
️✔️sdk/resourcemanager/costmanagement/armcostmanagement [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] - New enum type `ScheduledActionKind` with values `ScheduledActionKindEmail`, `ScheduledActionKindInsightAlert` info [Changelog] - New enum type `ScheduledActionStatus` with values `ScheduledActionStatusDisabled`, `ScheduledActionStatusEnabled`, `ScheduledActionStatusExpired` info [Changelog] - New enum type `Scope` with values `ScopeShared`, `ScopeSingle` info [Changelog] - New enum type `Term` with values `TermP1Y`, `TermP3Y` info [Changelog] - New enum type `WeeksOfMonth` with values `WeeksOfMonthFirst`, `WeeksOfMonthFourth`, `WeeksOfMonthLast`, `WeeksOfMonthSecond`, `WeeksOfMonthThird` info [Changelog] - New function `*BenefitRecommendationProperties.GetBenefitRecommendationProperties() *BenefitRecommendationProperties` info [Changelog] - New function `NewBenefitRecommendationsClient(azcore.TokenCredential, *arm.ClientOptions) (*BenefitRecommendationsClient, error)` info [Changelog] - New function `*BenefitRecommendationsClient.NewListPager(string, *BenefitRecommendationsClientListOptions) *runtime.Pager[BenefitRecommendationsClientListResponse]` info [Changelog] - New function `NewBenefitUtilizationSummariesClient(azcore.TokenCredential, *arm.ClientOptions) (*BenefitUtilizationSummariesClient, error)` info [Changelog] - New function `*BenefitUtilizationSummariesClient.NewListByBillingAccountIDPager(string, *BenefitUtilizationSummariesClientListByBillingAccountIDOptions) *runtime.Pager[BenefitUtilizationSummariesClientListByBillingAccountIDResponse]` info [Changelog] - New function `*BenefitUtilizationSummariesClient.NewListByBillingProfileIDPager(string, string, *BenefitUtilizationSummariesClientListByBillingProfileIDOptions) *runtime.Pager[BenefitUtilizationSummariesClientListByBillingProfileIDResponse]` info [Changelog] - New function `*BenefitUtilizationSummariesClient.NewListBySavingsPlanIDPager(string, string, *BenefitUtilizationSummariesClientListBySavingsPlanIDOptions) *runtime.Pager[BenefitUtilizationSummariesClientListBySavingsPlanIDResponse]` info [Changelog] - New function `*BenefitUtilizationSummariesClient.NewListBySavingsPlanOrderPager(string, *BenefitUtilizationSummariesClientListBySavingsPlanOrderOptions) *runtime.Pager[BenefitUtilizationSummariesClientListBySavingsPlanOrderResponse]` info [Changelog] - New function `*BenefitUtilizationSummary.GetBenefitUtilizationSummary() *BenefitUtilizationSummary` info [Changelog] - New function `NewBillingAccountScopeClient(azcore.TokenCredential, *arm.ClientOptions) (*BillingAccountScopeClient, error)` info [Changelog] - New function `*BillingAccountScopeClient.BeginGenerateBenefitUtilizationSummariesReport(context.Context, string, BenefitUtilizationSummariesRequest, *BillingAccountScopeClientBeginGenerateBenefitUtilizationSummariesReportOptions) (*runtime.Poller[BillingAccountScopeClientGenerateBenefitUtilizationSummariesReportResponse], error)` info [Changelog] - New function `NewBillingProfileScopeClient(azcore.TokenCredential, *arm.ClientOptions) (*BillingProfileScopeClient, error)` info [Changelog] - New function `*BillingProfileScopeClient.BeginGenerateBenefitUtilizationSummariesReport(context.Context, string, string, BenefitUtilizationSummariesRequest, *BillingProfileScopeClientBeginGenerateBenefitUtilizationSummariesReportOptions) (*runtime.Poller[BillingProfileScopeClientGenerateBenefitUtilizationSummariesReportResponse], error)` info [Changelog] - New function `*ClientFactory.NewBenefitRecommendationsClient() *BenefitRecommendationsClient` info [Changelog] - New function `*ClientFactory.NewBenefitUtilizationSummariesClient() *BenefitUtilizationSummariesClient` info [Changelog] - New function `*ClientFactory.NewBillingAccountScopeClient() *BillingAccountScopeClient` info [Changelog] - New function `*ClientFactory.NewBillingProfileScopeClient() *BillingProfileScopeClient` info [Changelog] - New function `*ClientFactory.NewGenerateCostDetailsReportClient() *GenerateCostDetailsReportClient` info [Changelog] - New function `*ClientFactory.NewPriceSheetClient() *PriceSheetClient` info [Changelog] - New function `*ClientFactory.NewReservationOrderScopeClient() *ReservationOrderScopeClient` info [Changelog] - New function `*ClientFactory.NewReservationScopeClient() *ReservationScopeClient` info [Changelog] - New function `*ClientFactory.NewSavingsPlanOrderScopeClient() *SavingsPlanOrderScopeClient` info [Changelog] - New function `*ClientFactory.NewSavingsPlanScopeClient() *SavingsPlanScopeClient` info [Changelog] - New function `*ClientFactory.NewScheduledActionsClient() *ScheduledActionsClient` info [Changelog] - New function `NewGenerateCostDetailsReportClient(azcore.TokenCredential, *arm.ClientOptions) (*GenerateCostDetailsReportClient, error)` info [Changelog] - New function `*GenerateCostDetailsReportClient.BeginCreateOperation(context.Context, string, GenerateCostDetailsReportRequestDefinition, *GenerateCostDetailsReportClientBeginCreateOperationOptions) (*runtime.Poller[GenerateCostDetailsReportClientCreateOperationResponse], error)` info [Changelog] - New function `*GenerateCostDetailsReportClient.BeginGetOperationResults(context.Context, string, string, *GenerateCostDetailsReportClientBeginGetOperationResultsOptions) (*runtime.Poller[GenerateCostDetailsReportClientGetOperationResultsResponse], error)` info [Changelog] - New function `*IncludedQuantityUtilizationSummary.GetBenefitUtilizationSummary() *BenefitUtilizationSummary` info [Changelog] - New function `PossibleGrainValues() []Grain` info [Changelog] - New function `NewPriceSheetClient(azcore.TokenCredential, *arm.ClientOptions) (*PriceSheetClient, error)` info [Changelog] - New function `*PriceSheetClient.BeginDownload(context.Context, string, string, string, *PriceSheetClientBeginDownloadOptions) (*runtime.Poller[PriceSheetClientDownloadResponse], error)` info [Changelog] - New function `*PriceSheetClient.BeginDownloadByBillingProfile(context.Context, string, string, *PriceSheetClientBeginDownloadByBillingProfileOptions) (*runtime.Poller[PriceSheetClientDownloadByBillingProfileResponse], error)` info [Changelog] - New function `NewReservationOrderScopeClient(azcore.TokenCredential, *arm.ClientOptions) (*ReservationOrderScopeClient, error)` info [Changelog] - New function `*ReservationOrderScopeClient.BeginGenerateBenefitUtilizationSummariesReport(context.Context, string, BenefitUtilizationSummariesRequest, *ReservationOrderScopeClientBeginGenerateBenefitUtilizationSummariesReportOptions) (*runtime.Poller[ReservationOrderScopeClientGenerateBenefitUtilizationSummariesReportResponse], error)` info [Changelog] - New function `NewReservationScopeClient(azcore.TokenCredential, *arm.ClientOptions) (*ReservationScopeClient, error)` info [Changelog] - New function `*ReservationScopeClient.BeginGenerateBenefitUtilizationSummariesReport(context.Context, string, string, BenefitUtilizationSummariesRequest, *ReservationScopeClientBeginGenerateBenefitUtilizationSummariesReportOptions) (*runtime.Poller[ReservationScopeClientGenerateBenefitUtilizationSummariesReportResponse], error)` info [Changelog] - New function `NewSavingsPlanOrderScopeClient(azcore.TokenCredential, *arm.ClientOptions) (*SavingsPlanOrderScopeClient, error)` info [Changelog] - New function `*SavingsPlanOrderScopeClient.BeginGenerateBenefitUtilizationSummariesReport(context.Context, string, BenefitUtilizationSummariesRequest, *SavingsPlanOrderScopeClientBeginGenerateBenefitUtilizationSummariesReportOptions) (*runtime.Poller[SavingsPlanOrderScopeClientGenerateBenefitUtilizationSummariesReportResponse], error)` info [Changelog] - New function `NewSavingsPlanScopeClient(azcore.TokenCredential, *arm.ClientOptions) (*SavingsPlanScopeClient, error)` info [Changelog] - New function `*SavingsPlanScopeClient.BeginGenerateBenefitUtilizationSummariesReportAsync(context.Context, string, string, BenefitUtilizationSummariesRequest, *SavingsPlanScopeClientBeginGenerateBenefitUtilizationSummariesReportAsyncOptions) (*runtime.Poller[SavingsPlanScopeClientGenerateBenefitUtilizationSummariesReportAsyncResponse], error)` info [Changelog] - New function `*SavingsPlanUtilizationSummary.GetBenefitUtilizationSummary() *BenefitUtilizationSummary` info [Changelog] - New function `NewScheduledActionsClient(azcore.TokenCredential, *arm.ClientOptions) (*ScheduledActionsClient, error)` info [Changelog] - New function `*ScheduledActionsClient.CheckNameAvailability(context.Context, CheckNameAvailabilityRequest, *ScheduledActionsClientCheckNameAvailabilityOptions) (ScheduledActionsClientCheckNameAvailabilityResponse, error)` info [Changelog] - New function `*ScheduledActionsClient.CheckNameAvailabilityByScope(context.Context, string, CheckNameAvailabilityRequest, *ScheduledActionsClientCheckNameAvailabilityByScopeOptions) (ScheduledActionsClientCheckNameAvailabilityByScopeResponse, error)` info [Changelog] - New function `*ScheduledActionsClient.CreateOrUpdate(context.Context, string, ScheduledAction, *ScheduledActionsClientCreateOrUpdateOptions) (ScheduledActionsClientCreateOrUpdateResponse, error)` info [Changelog] - New function `*ScheduledActionsClient.CreateOrUpdateByScope(context.Context, string, string, ScheduledAction, *ScheduledActionsClientCreateOrUpdateByScopeOptions) (ScheduledActionsClientCreateOrUpdateByScopeResponse, error)` info [Changelog] - New function `*ScheduledActionsClient.Delete(context.Context, string, *ScheduledActionsClientDeleteOptions) (ScheduledActionsClientDeleteResponse, error)` info [Changelog] - New function `*ScheduledActionsClient.DeleteByScope(context.Context, string, string, *ScheduledActionsClientDeleteByScopeOptions) (ScheduledActionsClientDeleteByScopeResponse, error)` info [Changelog] - New function `*ScheduledActionsClient.Get(context.Context, string, *ScheduledActionsClientGetOptions) (ScheduledActionsClientGetResponse, error)` info [Changelog] - New function `*ScheduledActionsClient.GetByScope(context.Context, string, string, *ScheduledActionsClientGetByScopeOptions) (ScheduledActionsClientGetByScopeResponse, error)` info [Changelog] - New function `*ScheduledActionsClient.NewListByScopePager(string, *ScheduledActionsClientListByScopeOptions) *runtime.Pager[ScheduledActionsClientListByScopeResponse]` info [Changelog] - New function `*ScheduledActionsClient.NewListPager(*ScheduledActionsClientListOptions) *runtime.Pager[ScheduledActionsClientListResponse]` info [Changelog] - New function `*ScheduledActionsClient.Run(context.Context, string, *ScheduledActionsClientRunOptions) (ScheduledActionsClientRunResponse, error)` info [Changelog] - New function `*ScheduledActionsClient.RunByScope(context.Context, string, string, *ScheduledActionsClientRunByScopeOptions) (ScheduledActionsClientRunByScopeResponse, error)` info [Changelog] - New function `*SharedScopeBenefitRecommendationProperties.GetBenefitRecommendationProperties() *BenefitRecommendationProperties` info [Changelog] - New function `*SingleScopeBenefitRecommendationProperties.GetBenefitRecommendationProperties() *BenefitRecommendationProperties` info [Changelog] - New struct `AllSavingsBenefitDetails` info [Changelog] - New struct `AllSavingsList` info [Changelog] - New struct `AsyncOperationStatusProperties` info [Changelog] - New struct `BenefitRecommendationModel` info [Changelog] - New struct `BenefitRecommendationsListResult` info [Changelog] - New struct `BenefitResource` info [Changelog] - New struct `BenefitUtilizationSummariesListResult` info [Changelog] - New struct `BenefitUtilizationSummariesOperationStatus` info [Changelog] - New struct `BenefitUtilizationSummariesRequest` info [Changelog] - New struct `BenefitUtilizationSummaryProperties` info [Changelog] - New struct `BlobInfo` info [Changelog] - New struct `CheckNameAvailabilityRequest` info [Changelog] - New struct `CheckNameAvailabilityResponse` info [Changelog] - New struct `CostDetailsOperationResults` info [Changelog] - New struct `CostDetailsTimePeriod` info [Changelog] - New struct `ErrorAdditionalInfo` info [Changelog] - New struct `ErrorDetail` info [Changelog] - New struct `ErrorDetailsWithNestedDetails` info [Changelog] - New struct `ErrorResponseAutoGenerated` info [Changelog] - New struct `ErrorResponseWithNestedDetails` info [Changelog] - New struct `ExportRun` info [Changelog] - New struct `ExportRunProperties` info [Changelog] - New struct `FileDestination` info [Changelog] - New struct `ForecastAggregation` info [Changelog] - New struct `ForecastColumn` info [Changelog] - New struct `ForecastComparisonExpression` info [Changelog] - New struct `ForecastDatasetConfiguration` info [Changelog] - New struct `ForecastFilter` info [Changelog] - New struct `ForecastProperties` info [Changelog] - New struct `ForecastResult` info [Changelog] - New struct `ForecastTimePeriod` info [Changelog] - New struct `GenerateCostDetailsReportErrorResponse` info [Changelog] - New struct `GenerateCostDetailsReportRequestDefinition` info [Changelog] - New struct `IncludedQuantityUtilizationSummary` info [Changelog] - New struct `IncludedQuantityUtilizationSummaryProperties` info [Changelog] - New struct `NotificationProperties` info [Changelog] - New struct `OperationForCostManagement` info [Changelog] - New struct `ProxyResourceForCostManagement` info [Changelog] - New struct `RecommendationUsageDetails` info [Changelog] - New struct `ReportManifest` info [Changelog] - New struct `RequestContext` info [Changelog] - New struct `ResourceForCostManagement` info [Changelog] - New struct `SavingsPlanUtilizationSummary` info [Changelog] - New struct `SavingsPlanUtilizationSummaryProperties` info [Changelog] - New struct `ScheduleProperties` info [Changelog] - New struct `ScheduledAction` info [Changelog] - New struct `ScheduledActionListResult` info [Changelog] - New struct `ScheduledActionProperties` info [Changelog] - New struct `ScheduledActionProxyResource` info [Changelog] - New struct `SharedScopeBenefitRecommendationProperties` info [Changelog] - New struct `SingleScopeBenefitRecommendationProperties` info [Changelog] - New struct `SystemData` info [Changelog] - New field `ExpiryTime` in struct `DownloadURL` info [Changelog] - New anonymous field `ForecastResult` in struct `ForecastClientExternalCloudProviderUsageResponse` info [Changelog] - New anonymous field `ForecastResult` in struct `ForecastClientUsageResponse` info [Changelog] - New field `EndTime`, `StartTime` in struct `GenerateDetailedCostReportOperationStatuses` info [Changelog] - New field `ActionType`, `IsDataAction`, `Origin` in struct `Operation` info [Changelog] info [Changelog] Total 18 breaking change(s), 260 additive change(s).
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs] Generate from cb621736f6f1ee664155f13df9ff68070e5f4c22. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] npm notice cmderr [automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.6 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.6> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-costmanagement [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] ### Features Added info [Changelog] info [Changelog] - Added operation group BenefitRecommendationsOperations info [Changelog] - Added operation group BenefitUtilizationSummariesOperations info [Changelog] - Added operation group BillingAccountScopeOperations info [Changelog] - Added operation group BillingProfileScopeOperations info [Changelog] - Added operation group GenerateCostDetailsReportOperations info [Changelog] - Added operation group GenerateDetailedCostReportOperationResultsOperations info [Changelog] - Added operation group GenerateDetailedCostReportOperationStatusOperations info [Changelog] - Added operation group GenerateDetailedCostReportOperations info [Changelog] - Added operation group PriceSheetOperations info [Changelog] - Added operation group ReservationOrderScopeOperations info [Changelog] - Added operation group ReservationScopeOperations info [Changelog] - Added operation group SavingsPlanOrderScopeOperations info [Changelog] - Added operation group SavingsPlanScopeOperations info [Changelog] - Added operation group ScheduledActionsOperations info [Changelog] - Model Alert has a new parameter e_tag info [Changelog] - Model AlertPropertiesDetails has a new parameter company_name info [Changelog] - Model AlertPropertiesDetails has a new parameter department_name info [Changelog] - Model AlertPropertiesDetails has a new parameter enrollment_end_date info [Changelog] - Model AlertPropertiesDetails has a new parameter enrollment_number info [Changelog] - Model AlertPropertiesDetails has a new parameter enrollment_start_date info [Changelog] - Model AlertPropertiesDetails has a new parameter invoicing_threshold info [Changelog] - Model CommonExportProperties has a new parameter next_run_time_estimate info [Changelog] - Model CommonExportProperties has a new parameter partition_data info [Changelog] - Model CommonExportProperties has a new parameter run_history info [Changelog] - Model Dimension has a new parameter e_tag info [Changelog] - Model Dimension has a new parameter location info [Changelog] - Model Dimension has a new parameter sku info [Changelog] - Model Export has a new parameter next_run_time_estimate info [Changelog] - Model Export has a new parameter partition_data info [Changelog] - Model Export has a new parameter run_history info [Changelog] - Model ExportDeliveryDestination has a new parameter sas_token info [Changelog] - Model ExportDeliveryDestination has a new parameter storage_account info [Changelog] - Model ExportProperties has a new parameter next_run_time_estimate info [Changelog] - Model ExportProperties has a new parameter partition_data info [Changelog] - Model ExportProperties has a new parameter run_history info [Changelog] - Model Operation has a new parameter action_type info [Changelog] - Model Operation has a new parameter is_data_action info [Changelog] - Model Operation has a new parameter origin info [Changelog] - Model OperationDisplay has a new parameter description info [Changelog] - Operation ExportsOperations.get has a new optional parameter expand info [Changelog] - Operation ExportsOperations.list has a new optional parameter expand info [Changelog] info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Model Alert no longer has parameter tags info [Changelog] - Model ProxyResource no longer has parameter e_tag info [Changelog] - Model ReportConfigFilter no longer has parameter tag_key info [Changelog] - Model ReportConfigFilter no longer has parameter tag_value info [Changelog] - Model Resource no longer has parameter tags info [Changelog] - Removed operation group SettingsOperations
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs] Generate from cb621736f6f1ee664155f13df9ff68070e5f4c22. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️cost-management [View full logs] [Preview Schema Changes]
️❌ azure-powershell failed [Detail]
❌Pipeline Framework Failed [Logs] Generate from cb621736f6f1ee664155f13df9ff68070e5f4c22. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json SSL error: syscall failure: Broken pipe Error: SSL error: syscall failure: Broken pipe
❌Az.cost-management.DefaultTag [View full logs]error Fatal error: SSL error: syscall failure: Broken pipe error The following packages are still pending: error Az.cost-management.DefaultTag
Generated ApiView
|
Shailja24
approved these changes
May 12, 2023
MattEberhart-MSFTE
merged commit 93eab54
into
dev-cost-management-Microsoft.CostManagement-2023-03-01-stable-3
ArcturusZhang
pushed a commit
that referenced
this pull request
May 16, 2023
…rsion stable/2023-03-01 (#23892) * Adds base for updating Microsoft.CostManagement from version stable/2022-10-01 to version 2023-03-01 * Updates readme * Updates API version in new specs and examples * Matteberhart/merging main for readme (#23886) * Adds base for updating Microsoft.CostManagement from version stable/2022-10-01 to version 2023-03-01 * Updates readme * Updates API version in new specs and examples * Benefit Summaries Async (#22497) * Added benefit utilizaiton summaries APIs to costmanagement.benefits.json and appropriate examples. * Added report schema and secondary url * Prettier check and spelling error fix * Addressed BenefitKind / Kind in the csv schema and changed parameter name to benefitAsyncOperationIdParameter * Replacing included quantity * Alphabetized the parameters * Changing request body BenefitKind property to Kind * Adding 200 repsonse to generate api and fixing linter warnings * Adding examples to generate api * Making status optional for running scenario * Changing to completed to have all properties in generate examples and adding long running operation tag to error response * LRO Error response * LRO lint diff error still present. * Found all diffs in 2022-10-01 version added since branching (#23590) * Found all diffs in 2022-10-01 version added since branching * Fixing examples ruined by updating. Pulled straight from 2022-10-01 * Changed enum name (#23605) * Changing code of ErrorDetails object back to a string (#23734) * cost details report operation results example needs string error code (#23742) * Cherry picked commit causing conflict in readme (#23817) Co-authored-by: alprosms <[email protected]> --------- Co-authored-by: alprosms <[email protected]> * Adding x-ms-secret to the report urls (#23934) * Remove operation results (#23938) * Remove operation results * Removing examples * Using commony type error response (#23955) --------- Co-authored-by: alprosms <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.