-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Publish private branch 'nickdepinet-devcenter-Microsoft.DevCenter-2023-04-01' #23695
Conversation
The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/11737 |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
commonDefinitions.json | 2023-04-01(8c1c7c2) | 2023-01-01-preview(main) |
devcenter.json | 2023-04-01(8c1c7c2) | 2023-01-01-preview(main) |
vdi.json | 2023-04-01(8c1c7c2) | 2023-01-01-preview(main) |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.0.0) | new version | base version |
---|---|---|
package-2023-04 | package-2023-04(8c1c7c2) | default(main) |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
Operations with a 202 response should specify x-ms-long-running-operation: true .Location: Microsoft.DevCenter/stable/2023-04-01/devcenter.json#L2592 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DevCenter/stable/2023-04-01/devcenter.json#L3185 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.DevCenter/stable/2023-04-01/devcenter.json#L3705 |
|
Schema should have a description or title. Location: Microsoft.DevCenter/stable/2023-04-01/vdi.json#L1152 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️❌
~[Staging] ServiceAPIReadinessTest: 54 Errors, 0 Warnings failed [Detail]
Tag package-2023-04; Prod region: Deployed
Test run on region: westeurope; Operation coverage: total: 78, untested: 0, failed: 51, passed: 27
Service API Readiness Test failed. Check pipeline artifact for detail report.
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
CLIENT_ERROR |
statusCode: 400, errorCode: ValidationError, errorMessage: The request is not valid. Source: runtime OperationId: Projects_CreateOrUpdate |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: additionalInfo Source: response OperationId: Projects_CreateOrUpdate |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DevCenter/projects/projectn1db3ob' under resource group 'apiTest-OpewvM-23695' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Projects_Get |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DevCenter/projects/projectn1db3ob' under resource group 'apiTest-OpewvM-23695' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Projects_Update |
CLIENT_ERROR |
statusCode: 400, errorCode: MissingApiVersionParameter, errorMessage: The api-version query parameter (?api-version=) is required for all requests. Source: runtime OperationId: Pools_CreateOrUpdate |
CLIENT_ERROR |
statusCode: 400, errorCode: MissingApiVersionParameter, errorMessage: The api-version query parameter (?api-version=) is required for all requests. Source: runtime OperationId: Pools_ListByProject |
CLIENT_ERROR |
statusCode: 400, errorCode: MissingApiVersionParameter, errorMessage: The api-version query parameter (?api-version=) is required for all requests. Source: runtime OperationId: Pools_Get |
CLIENT_ERROR |
statusCode: 400, errorCode: MissingApiVersionParameter, errorMessage: The api-version query parameter (?api-version=) is required for all requests. Source: runtime OperationId: Pools_Update |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DevCenter/projects/projectn1db3ob/pools/poolnameyuupus' under resource group 'apiTest-OpewvM-23695' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Pools_RunHealthChecks |
CLIENT_ERROR |
statusCode: 400, errorCode: MissingApiVersionParameter, errorMessage: The api-version query parameter (?api-version=) is required for all requests. Source: runtime OperationId: NetworkConnections_CreateOrUpdate |
CLIENT_ERROR |
statusCode: 400, errorCode: MissingApiVersionParameter, errorMessage: The api-version query parameter (?api-version=) is required for all requests. Source: runtime OperationId: NetworkConnections_ListBySubscription |
CLIENT_ERROR |
statusCode: 400, errorCode: MissingApiVersionParameter, errorMessage: The api-version query parameter (?api-version=) is required for all requests. Source: runtime OperationId: NetworkConnections_ListHealthDetails |
CLIENT_ERROR |
statusCode: 400, errorCode: MissingApiVersionParameter, errorMessage: The api-version query parameter (?api-version=) is required for all requests. Source: runtime OperationId: NetworkConnections_ListOutboundNetworkDependenciesEndpoints |
CLIENT_ERROR |
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'networkczcvglg' not found. Source: runtime OperationId: NetworkConnections_GetHealthDetails |
CLIENT_ERROR |
statusCode: 400, errorCode: MissingApiVersionParameter, errorMessage: The api-version query parameter (?api-version=) is required for all requests. Source: runtime OperationId: NetworkConnections_ListByResourceGroup |
CLIENT_ERROR |
statusCode: 400, errorCode: MissingApiVersionParameter, errorMessage: The api-version query parameter (?api-version=) is required for all requests. Source: runtime OperationId: NetworkConnections_Get |
CLIENT_ERROR |
statusCode: 400, errorCode: MissingApiVersionParameter, errorMessage: The api-version query parameter (?api-version=) is required for all requests. Source: runtime OperationId: NetworkConnections_Update |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DevCenter/networkconnections/networkczcvglg' under resource group 'apiTest-OpewvM-23695' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: NetworkConnections_RunHealthChecks |
CLIENT_ERROR |
statusCode: 400, errorCode: ValidationError, errorMessage: The request is not valid. Source: runtime OperationId: Galleries_CreateOrUpdate |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: additionalInfo Source: response OperationId: Galleries_CreateOrUpdate |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The resource 'Microsoft.DevCenter/devcenters/devcenteafh2fw/galleries/galleryn0rnwfr' could not be found. Source: runtime OperationId: Galleries_Get |
CLIENT_ERROR |
statusCode: 403, errorCode: LinkedAuthorizationFailed, errorMessage: The client has permission to perform action 'Microsoft.Authorization/roleAssignments/write' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-OpewvM-23695/providers/Microsoft.DevCenter/projects/projectn1db3ob/environmentTypes/environm40e1uy', however the linked subscription '00000000-0000-0000-0000-000000000000' was not found. Source: runtime OperationId: ProjectEnvironmentTypes_CreateOrUpdate |
CLIENT_ERROR |
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'projectn1db3ob' not found. Source: runtime OperationId: ProjectEnvironmentTypes_List |
CLIENT_ERROR |
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'projectn1db3ob' not found. Source: runtime OperationId: ProjectEnvironmentTypes_Get |
CLIENT_ERROR |
statusCode: 403, errorCode: LinkedAuthorizationFailed, errorMessage: The client has permission to perform action 'Microsoft.Authorization/roleAssignments/write' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-OpewvM-23695/providers/Microsoft.DevCenter/projects/projectn1db3ob/environmentTypes/environm40e1uy', however the linked subscription '00000000-0000-0000-0000-000000000000' was not found. Source: runtime OperationId: ProjectEnvironmentTypes_Update |
CLIENT_ERROR |
statusCode: 400, errorCode: MissingApiVersionParameter, errorMessage: The api-version query parameter (?api-version=) is required for all requests. Source: runtime OperationId: DevBoxDefinitions_CreateOrUpdate |
CLIENT_ERROR |
statusCode: 400, errorCode: MissingApiVersionParameter, errorMessage: The api-version query parameter (?api-version=) is required for all requests. Source: runtime OperationId: DevBoxDefinitions_ListByDevCenter |
CLIENT_ERROR |
statusCode: 400, errorCode: MissingApiVersionParameter, errorMessage: The api-version query parameter (?api-version=) is required for all requests. Source: runtime OperationId: DevBoxDefinitions_ListByProject |
CLIENT_ERROR |
statusCode: 400, errorCode: MissingApiVersionParameter, errorMessage: The api-version query parameter (?api-version=) is required for all requests. Source: runtime OperationId: DevBoxDefinitions_GetByProject |
CLIENT_ERROR |
statusCode: 400, errorCode: MissingApiVersionParameter, errorMessage: The api-version query parameter (?api-version=) is required for all requests. Source: runtime OperationId: DevBoxDefinitions_Get |
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
CadlAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Hi, @nickdepinet Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Generation Artifacts
|
Generated ApiView
|
This is a publish-only pr of previously approved and merged api version from private repo: https://github.com/Azure/azure-rest-api-specs-pr/pull/11737 |
@nickdepinet Please fill in the correct checkboxes in the first comment so we can get a quick overview of what's going on with this PR and make sure you've understood the relevant linked docs. |
@v-jiaodi - completed the checklist. This api version is already deployed to public, we're only merging from private repo to public repo. |
/azp run |
Commenter does not have sufficient privileges for PR 23695 in repo Azure/azure-rest-api-specs |
@msyyc Could you help to take a look at the SDK BreakingChange in this PR? Thanks |
approved for python SDK breaking |
@@ -97,7 +108,6 @@ swagger-to-sdk: | |||
- repo: azure-sdk-for-python | |||
- repo: azure-sdk-for-java | |||
- repo: azure-sdk-for-js | |||
- repo: azure-sdk-for-go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason that we removed this job here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArcturusZhang - I think this happened on the preview version of this API too (2023-01-01-preview) - I think there is some difference between the public/private branches that is causing this - do you want me to manually re-add?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please add this back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArcturusZhang - re-added
re-add azure-sdk-for-go
@raych1 Could you help to take a look at the SDK BreakingChange in this PR? Thanks |
Approved for Go SDK breaking changes as it is first stable version of devcenter. |
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Publish approved + merged api spec from private branch to public
Already deployed to public regions
ASAP
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.