Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Publish private branch 'datafactory/binluwang/synctrack2' #23684

Merged
merged 6 commits into from
Apr 25, 2023
Merged

[Hub Generated] Publish private branch 'datafactory/binluwang/synctrack2' #23684

merged 6 commits into from
Apr 25, 2023

Conversation

Frey-Wang
Copy link
Member

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@Frey-Wang
Copy link
Member Author

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/12168

@openapi-workflow-bot
Copy link

Hi, @Frey-Wang Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @ghost ghost added the Data Factory label Apr 24, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 24, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 250 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    datafactory.json 2018-06-01(b6c546a) 2018-06-01(main)
    Dataset.json 2018-06-01(b6c546a) 2018-06-01(main)
    LinkedService.json 2018-06-01(b6c546a) 2018-06-01(main)
    Pipeline.json 2018-06-01(b6c546a) 2018-06-01(main)
    Trigger.json 2018-06-01(b6c546a) 2018-06-01(main)

    Only 27 items are listed, please refer to log for more details.

    Rule Message
    ❌ 1021 - AddedAdditionalProperties The new version adds an 'additionalProperties' element.
    New: stable/2018-06-01/entityTypes/Dataset.json#L2424:9
    Old: stable/2018-06-01/entityTypes/Dataset.json#L2291:9
    ❌ 1021 - AddedAdditionalProperties The new version adds an 'additionalProperties' element.
    New: stable/2018-06-01/entityTypes/Dataset.json#L2431:9
    Old: stable/2018-06-01/entityTypes/Dataset.json#L2295:9
    ❌ 1021 - AddedAdditionalProperties The new version adds an 'additionalProperties' element.
    New: stable/2018-06-01/entityTypes/Pipeline.json#L5702:9
    Old: stable/2018-06-01/entityTypes/Pipeline.json#L5257:9
    ❌ 1021 - AddedAdditionalProperties The new version adds an 'additionalProperties' element.
    New: stable/2018-06-01/entityTypes/Dataset.json#L2424:9
    Old: stable/2018-06-01/entityTypes/Dataset.json#L2291:9
    ❌ 1021 - AddedAdditionalProperties The new version adds an 'additionalProperties' element.
    New: stable/2018-06-01/entityTypes/Dataset.json#L2431:9
    Old: stable/2018-06-01/entityTypes/Dataset.json#L2295:9
    ❌ 1021 - AddedAdditionalProperties The new version adds an 'additionalProperties' element.
    New: stable/2018-06-01/entityTypes/Pipeline.json#L5702:9
    Old: stable/2018-06-01/entityTypes/Pipeline.json#L5257:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: stable/2018-06-01/entityTypes/Pipeline.json#L8367:9
    Old: stable/2018-06-01/entityTypes/Pipeline.json#L7808:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: stable/2018-06-01/entityTypes/Pipeline.json#L8367:9
    Old: stable/2018-06-01/entityTypes/Pipeline.json#L7808:9
    ❌ 1026 - TypeChanged The new version has a different type 'string' than the previous one 'object'.
    New: stable/2018-06-01/entityTypes/LinkedService.json#L7402:9
    Old: stable/2018-06-01/entityTypes/LinkedService.json#L6931:9
    ❌ 1026 - TypeChanged The new version has a different type 'string' than the previous one 'object'.
    New: stable/2018-06-01/entityTypes/LinkedService.json#L7350:9
    Old: stable/2018-06-01/entityTypes/LinkedService.json#L6882:9
    ❌ 1026 - TypeChanged The new version has a different type 'string' than the previous one 'object'.
    New: stable/2018-06-01/entityTypes/LinkedService.json#L7296:9
    Old: stable/2018-06-01/entityTypes/LinkedService.json#L6829:9
    ❌ 1026 - TypeChanged The new version has a different type 'string' than the previous one 'object'.
    New: stable/2018-06-01/entityTypes/LinkedService.json#L7200:9
    Old: stable/2018-06-01/entityTypes/LinkedService.json#L6737:9
    ❌ 1026 - TypeChanged The new version has a different type 'string' than the previous one 'object'.
    New: stable/2018-06-01/entityTypes/LinkedService.json#L7096:9
    Old: stable/2018-06-01/entityTypes/LinkedService.json#L6647:9
    ❌ 1026 - TypeChanged The new version has a different type 'string' than the previous one 'object'.
    New: stable/2018-06-01/entityTypes/LinkedService.json#L7003:9
    Old: stable/2018-06-01/entityTypes/LinkedService.json#L6560:9
    ❌ 1026 - TypeChanged The new version has a different type 'string' than the previous one 'object'.
    New: stable/2018-06-01/entityTypes/LinkedService.json#L6939:9
    Old: stable/2018-06-01/entityTypes/LinkedService.json#L6499:9
    ❌ 1026 - TypeChanged The new version has a different type 'string' than the previous one 'object'.
    New: stable/2018-06-01/entityTypes/LinkedService.json#L6881:9
    Old: stable/2018-06-01/entityTypes/LinkedService.json#L6445:9
    ❌ 1026 - TypeChanged The new version has a different type 'string' than the previous one 'object'.
    New: stable/2018-06-01/entityTypes/LinkedService.json#L6810:9
    Old: stable/2018-06-01/entityTypes/LinkedService.json#L6380:9
    ❌ 1026 - TypeChanged The new version has a different type 'string' than the previous one 'object'.
    New: stable/2018-06-01/entityTypes/LinkedService.json#L6754:9
    Old: stable/2018-06-01/entityTypes/LinkedService.json#L6327:9
    ❌ 1026 - TypeChanged The new version has a different type 'string' than the previous one 'object'.
    New: stable/2018-06-01/entityTypes/LinkedService.json#L6628:9
    Old: stable/2018-06-01/entityTypes/LinkedService.json#L6217:9
    ❌ 1026 - TypeChanged The new version has a different type 'string' than the previous one 'object'.
    New: stable/2018-06-01/entityTypes/LinkedService.json#L6479:9
    Old: stable/2018-06-01/entityTypes/LinkedService.json#L6076:9
    ❌ 1026 - TypeChanged The new version has a different type 'string' than the previous one 'object'.
    New: stable/2018-06-01/entityTypes/LinkedService.json#L6327:9
    Old: stable/2018-06-01/entityTypes/LinkedService.json#L5936:9
    ❌ 1026 - TypeChanged The new version has a different type 'string' than the previous one 'object'.
    New: stable/2018-06-01/entityTypes/LinkedService.json#L6268:9
    Old: stable/2018-06-01/entityTypes/LinkedService.json#L5882:9
    ❌ 1026 - TypeChanged The new version has a different type 'string' than the previous one 'object'.
    New: stable/2018-06-01/entityTypes/LinkedService.json#L6229:9
    Old: stable/2018-06-01/entityTypes/LinkedService.json#L5844:9
    ❌ 1026 - TypeChanged The new version has a different type 'string' than the previous one 'object'.
    New: stable/2018-06-01/entityTypes/LinkedService.json#L6190:9
    Old: stable/2018-06-01/entityTypes/LinkedService.json#L5806:9
    ❌ 1026 - TypeChanged The new version has a different type 'string' than the previous one 'object'.
    New: stable/2018-06-01/entityTypes/LinkedService.json#L6132:9
    Old: stable/2018-06-01/entityTypes/LinkedService.json#L5752:9
    ❌ 1026 - TypeChanged The new version has a different type 'string' than the previous one 'object'.
    New: stable/2018-06-01/entityTypes/LinkedService.json#L6070:9
    Old: stable/2018-06-01/entityTypes/LinkedService.json#L5694:9
    ❌ 1026 - TypeChanged The new version has a different type 'string' than the previous one 'object'.
    New: stable/2018-06-01/entityTypes/LinkedService.json#L5997:9
    Old: stable/2018-06-01/entityTypes/LinkedService.json#L5627:9
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2018-06 package-2018-06(b6c546a) package-2018-06(main)

    The following errors/warnings exist before current PR submission:

    Only 27 items are listed, please refer to log for more details.

    Rule Message
    ❌ OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.DataFactory/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L56
    ❌ TrackedResourcePatchOperation Tracked resource 'Factory' must have patch operation that at least supports the update of tags.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L111
    ❌ ConsistentPatchProperties The property 'autoUpdate' in the request body either not apppear in the resource model or has the wrong level.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L840
    ❌ ConsistentPatchProperties The property 'updateDelayOffset' in the request body either not apppear in the resource model or has the wrong level.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L840
    ❌ PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1139
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1175
    ❌ PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1188
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1221
    ❌ OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'IntegrationRuntimes' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1418
    ❌ PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1468
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1504
    ❌ PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2924
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2960
    ❌ PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3018
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3054
    ❌ PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3067
    ❌ PostOperationAsyncResponseValidation An async POST operation must return 202.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3096
    ❌ PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3110
    ❌ PostOperationAsyncResponseValidation An async POST operation must return 202.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3139
    ❌ PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3496
    ❌ PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3701
    ❌ ResourceNameRestriction The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4375
    ❌ MissingTypeObject The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4760
    ❌ MissingTypeObject The schema 'SubResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4801
    ❌ MissingTypeObject The schema 'SubResourceDebugResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4827
    ❌ XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4840
    ❌ MissingTypeObject The schema 'IntegrationRuntimeReference' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4960
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️❌ModelValidation: 47 Errors, 0 Warnings failed [Detail]

    Only 27 items are listed, please refer to log for more details.

    Rule Message
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1168:22
    ExampleUrl: stable/2018-06-01/examples/IntegrationRuntimes_Start.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1217:22
    ExampleUrl: stable/2018-06-01/examples/IntegrationRuntimes_Stop.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1497:22
    ExampleUrl: stable/2018-06-01/examples/IntegrationRuntimeObjectMetadata_Refresh.json
    ❌ INVALID_TYPE Expected type object but found type array
    Url: stable/2018-06-01/entityTypes/Pipeline.json#L138:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_ListByFactory.json#L46:35
    ❌ INVALID_TYPE Expected type object but found type array
    Url: stable/2018-06-01/entityTypes/Pipeline.json#L138:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_ListByFactory.json#L56:36
    ❌ INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5398:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_ListByFactory.json#L50:47
    ❌ INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5398:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_ListByFactory.json#L51:45
    ❌ INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5398:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_ListByFactory.json#L60:47
    ❌ INVALID_TYPE Expected type object but found type array
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L138:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L8:17
    ❌ INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5398:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L8:17
    ❌ INVALID_TYPE Expected type object but found type array
    Url: stable/2018-06-01/entityTypes/Pipeline.json#L138:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L124:31
    ❌ INVALID_TYPE Expected type object but found type array
    Url: stable/2018-06-01/entityTypes/Pipeline.json#L138:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L134:32
    ❌ INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5398:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L128:43
    ❌ INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5398:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L129:41
    ❌ INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5398:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Create.json#L138:43
    ❌ INVALID_TYPE Expected type object but found type array
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L138:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L8:17
    ❌ INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5398:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L8:17
    ❌ INVALID_TYPE Expected type object but found type array
    Url: stable/2018-06-01/entityTypes/Pipeline.json#L138:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L112:31
    ❌ INVALID_TYPE Expected type object but found type array
    Url: stable/2018-06-01/entityTypes/Pipeline.json#L138:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L122:32
    ❌ INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5398:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L116:43
    ❌ INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5398:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L117:41
    ❌ INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5398:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Update.json#L126:43
    ❌ INVALID_TYPE Expected type object but found type array
    Url: stable/2018-06-01/entityTypes/Pipeline.json#L138:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Get.json#L47:31
    ❌ INVALID_TYPE Expected type object but found type array
    Url: stable/2018-06-01/entityTypes/Pipeline.json#L138:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Get.json#L57:32
    ❌ INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5398:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Get.json#L51:43
    ❌ INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5398:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Get.json#L52:41
    ❌ INVALID_TYPE Expected type object but found type string
    Url: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5398:31
    ExampleUrl: stable/2018-06-01/examples/Pipelines_Get.json#L61:43
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand] 
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 24, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌SDK Breaking Change Tracking failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net-track2 failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-java warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-resource-manager-schemas warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-powershell failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 24, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/datafactory/armdatafactory https://apiview.dev/Assemblies/Review/008956fb97bb462c85f14142e19a2ba0
    Java azure-resourcemanager-datafactory Create ApiView failed. Please ask PR assignee for help
    JavaScript @azure/arm-datafactory https://apiview.dev/Assemblies/Review/42309b1e0dc34fe4839b0820cdb930fa

    @azure-sdk azure-sdk mentioned this pull request Apr 24, 2023
    Closed
    @azure-sdk azure-sdk mentioned this pull request Apr 24, 2023
    Closed
    @AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-FixRequiredOnFailure resource-manager labels Apr 24, 2023
    @openapi-workflow-bot
    Copy link

    Hi @Frey-Wang, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @openapi-workflow-bot
    Copy link

    Hi @Frey-Wang, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    This was referenced Apr 24, 2023
    Closed
    Closed
    This was referenced Apr 24, 2023
    Closed
    Closed
    @ArcturusZhang ArcturusZhang added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Apr 24, 2023
    @ArcturusZhang
    Copy link
    Member

    Sync the labels from the private repo PR: https://github.com/Azure/azure-rest-api-specs-pr/pull/12168

    @tadelesh tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Apr 24, 2023
    @raych1 raych1 requested a review from v-xuto April 25, 2023 01:05
    @ArcturusZhang ArcturusZhang merged commit 5dd4058 into main Apr 25, 2023
    @ArcturusZhang ArcturusZhang deleted the published/Azure/azure-rest-api-specs-pr/datafactory/binluwang/synctrack2 branch April 25, 2023 06:38
    This was referenced Apr 25, 2023
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023
    @Frey-Wang @AzureRestAPISpecReview @JoshLove-msft
    [Hub Generated] Publish private branch 'datafactory/binluwang/synctra…
    700ed98 
    …ck2' (Azure#23684)

* [AutoSync] de5700363c [Track2] Sync with master swagger

* [AutoSync] d6fca01386 Update encryptedCredential types

* [AutoSync] 550f408fc4 review v1

* [AutoSync] 98b1f20909 prettify

* [AutoSync] aa7bfef8e8 prettier

* [AutoSync] 92e227b820 prettify

---------

Co-authored-by: swagger-automation <[email protected]>
    @Alancere Alancere mentioned this pull request Nov 23, 2023
    Merged
    @tombuildsstuff tombuildsstuff mentioned this pull request Mar 21, 2024
    Open
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

    @zhangyd2015 zhangyd2015 Awaiting requested review from zhangyd2015 zhangyd2015 is a code owner

    @davidzhaoyue davidzhaoyue Awaiting requested review from davidzhaoyue davidzhaoyue is a code owner

    @v-xuto v-xuto Awaiting requested review from v-xuto

    Assignees

    @weidongxu-microsoft weidongxu-microsoft

    @v-xuto v-xuto

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-ModelValidation Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript Approved-SdkBreakingChange-Python BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript CI-FixRequiredOnFailure Data Factory resource-manager
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    8 participants
    @Frey-Wang @ArcturusZhang @tadelesh @weidongxu-microsoft @AzureRestAPISpecReview @qiaozha @v-xuto @msyyc