Release of microsoft.network api version: 2022 11 01 #23652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…01 to version 2022-11-01
…3144) * remove loadDistributionPolicy from appgw PUT request body example * remove loadDistributionPolicy from appgw PUT request body example2 * remove loadDistributionPolicy from appgw PUT request body example * remove duplicates * add private link configuration to see if it will fix validation error * remove privateLinkConfig related * revert changes to see if still get validation error * update back to original changes * add response resource id to fix modelValidation error * add connection resource
…oes not need a Selector (#23184)
* Application Gateway WAF Rate Limit feature swagger changes * Fixing lint errors * Updated rate limit feature examples
…rity parameter as required for NSG (#23210) * Fix for applicationGatewayIpConfigurations property This swagger definition is defining property applicationGatewayIpConfigurations, ``` "applicationGatewayIpConfigurations": { "type": "array", "items": { "$ref": "./applicationGateway.json#/definitions/ApplicationGatewayIPConfiguration" }, "description": "Application gateway IP configurations of virtual network resource." } ``` but actual rest api returned applicationGatewayIPConfigurations, the P is upper case while in swagger it is lower case. ``` { "name": "subnet-agw", "id": "/subscriptions/<sub-id>/resourceGroups/<rg-name>/providers/Microsoft.Network/virtualNetworks/<vnet-name>/subnets/subnet-agw", "properties": { "applicationGatewayIPConfigurations": [ { "id": "/subscriptions/<sub-id>/resourceGroups/<rg-name>/providers/Microsoft.Network/applicationGateways/<agw-name>/gatewayIPConfigurations/appGatewayIpConfig" } ] }, "type": "Microsoft.Network/virtualNetworks/subnets" } ``` * Making priority property required [This is the API invoked](https://learn.microsoft.com/en-us/rest/api/virtualnetwork/network-security-groups/create-or-update?tabs=HTTP#code-try-0). For the NSG security rules without priorities, seems like the priority parameter is required. Azure portal works as expected. I don't think that's allowed but according to the schema it is because the priority property is not marked as required. I tried to create a NSG security rule without the priorities and it failed with below. Request Body: ``` { "properties": { "securityRules": [ { "name": "rule1", "properties": { "protocol": "*", "sourceAddressPrefix": "*", "destinationAddressPrefix": "*", "access": "Allow", "destinationPortRange": "80", "sourcePortRange": "*", "direction": "Inbound" } } ] }, "location": "eastus" } ``` Response received: ``` { "error": { "code": "SecurityRuleInvalidPriority", "message": "Security rule has invalid Priority. Value provided: 0 Allowed range 100-4096.", "details": [] } } ``` This PR will make the priority parameter as required. * Update NetworkSecurityGroupDelete.json * Update NetworkSecurityGroupRuleDelete.json * Update NetworkSecurityGroupDelete.json
* new app rule property - http header to insert * prettier * add to 22-11-01 * removed changes from 22-09-01 * fixed example * delete RCG example * fix delete examples * added a Location header * prettier fix
* Log scrubbing API changes * Update examples * Addressing comments * Fix
…reated for 2022-11-01 (#23114) * moving packet-capture api to 2022-11-01 release from 2022-09-01 * fixing the LRO response header error for model validation
* Changes for Additional nic and corrections * Fixes for tool reported issues * Fix for SpellCheck, ModelValidation * Defining Location in NetworkVirtualApplianceDelete for async * Minor fix * Minor fix * Minor fix * PrettierCheck fixed * Fixing VirtualApplianceAdditionalNicProperties * ModelValidation fixed * Correcting the location header string * Correcting location header * Prettied Check Fix * Fix * Fix
* fix response type * fix format * fix example, add x-ms-identifiers
* Adding auxiliary sku property on nic * Adding AcceleratedConnections to AuxMode * modifying the auxSku values * Removing accidental change --------- Co-authored-by: Prachi Pravin Bhavsar <[email protected]>
* Changes for NVA connection * Changes to address validation failures * Fix some ModelValidation errors * Fix some ModelValidation errors * Fix some ModelValidation errors * Fix some ModelValidation errors * Fix some ModelValidation errors * Addressing some review comments * Addressing some review comments * Addressing some review comments * Addressing some review comments * Addressing some review comments * Fix camel case for property name * Fixing resourceUri to Camel case in example files * Fix SDK duplication error * Fix one LintDiff error * try fix lintdiff errors * fix lro erro in lintdiff * fix model validation error
|
Hi, @MikhailTryakhov Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
ghost
added
the
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| applicationGateway.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| applicationGatewayWafDynamicManifests.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| applicationSecurityGroup.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| availableDelegations.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| availableServiceAliases.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| azureFirewall.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| azureFirewallFqdnTag.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| azureWebCategory.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| bastionHost.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| checkDnsAvailability.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| cloudServiceNetworkInterface.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| cloudServicePublicIpAddress.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| cloudServiceSwap.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| customIpPrefix.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| ddosCustomPolicy.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| ddosProtectionPlan.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| dscpConfiguration.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| endpointService.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| expressRouteCircuit.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| expressRouteCrossConnection.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| expressRoutePort.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| expressRouteProviderPort.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| firewallPolicy.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| ipAllocation.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| ipGroups.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| loadBalancer.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| natGateway.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| network.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| network.json | 2022-11-01(af3e299) | 2022-06-01-preview(main) |
| networkInterface.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| networkManager.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| networkManager.json | 2022-11-01(af3e299) | 2022-04-01-preview(main) |
| networkManagerActiveConfiguration.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| networkManagerActiveConfiguration.json | 2022-11-01(af3e299) | 2022-04-01-preview(main) |
| networkManagerConnection.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| networkManagerConnection.json | 2022-11-01(af3e299) | 2022-04-01-preview(main) |
| networkManagerConnectivityConfiguration.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| networkManagerConnectivityConfiguration.json | 2022-11-01(af3e299) | 2022-04-01-preview(main) |
| networkManagerEffectiveConfiguration.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| networkManagerEffectiveConfiguration.json | 2022-11-01(af3e299) | 2022-04-01-preview(main) |
| networkManagerGroup.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| networkManagerGroup.json | 2022-11-01(af3e299) | 2022-04-01-preview(main) |
| networkManagerScopeConnection.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| networkManagerScopeConnection.json | 2022-11-01(af3e299) | 2022-04-01-preview(main) |
| networkManagerSecurityAdminConfiguration.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| networkManagerSecurityAdminConfiguration.json | 2022-11-01(af3e299) | 2022-04-01-preview(main) |
| networkProfile.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| networkSecurityGroup.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| networkVirtualAppliance.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| networkWatcher.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| operation.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| privateEndpoint.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| privateLinkService.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| publicIpAddress.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| publicIpPrefix.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| routeFilter.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| routeTable.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| securityPartnerProvider.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| serviceCommunity.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| serviceEndpointPolicy.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| serviceTags.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| usage.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| virtualNetwork.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| virtualNetworkGateway.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| virtualNetworkTap.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| virtualRouter.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| virtualWan.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| vmssNetworkInterface.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| vmssPublicIpAddress.json | 2022-11-01(af3e299) | 2022-09-01(main) |
| webapplicationfirewall.json | 2022-11-01(af3e299) | 2022-09-01(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 10 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with the latest preview version:
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/listEffectiveVirtualNetworks' removed or restructured? Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L418:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/listActiveSecurityUserRules' removed or restructured? Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L143:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/networkGroups/{networkGroupName}/listEffectiveVirtualNetworks' removed or restructured? Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerGroup.json#L240:5 |
|
| The new version is missing a definition that was found in the old version. Was 'EffectiveVirtualNetworksParameter' removed or renamed? New: Microsoft.Network/stable/2022-11-01/networkManager.json#L422:3 Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L476:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ActiveSecurityUserRule' removed or renamed? New: Microsoft.Network/stable/2022-11-01/networkManagerActiveConfiguration.json#L150:3 Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L197:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ActiveDefaultSecurityUserRule' removed or renamed? New: Microsoft.Network/stable/2022-11-01/networkManagerActiveConfiguration.json#L150:3 Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L197:3 |
|
| The new version is missing a definition that was found in the old version. Was 'DefaultUserRulePropertiesFormat' removed or renamed? New: Microsoft.Network/stable/2022-11-01/networkManagerActiveConfiguration.json#L150:3 Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L197:3 |
|
| The new version is missing a definition that was found in the old version. Was 'UserRulePropertiesFormat' removed or renamed? New: Microsoft.Network/stable/2022-11-01/networkManagerActiveConfiguration.json#L150:3 Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L197:3 |
|
| The new version is removing enum value(s) 'SecurityUser' from the old version. New: Microsoft.Network/stable/2022-11-01/networkManager.json#L504:11 Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L558:11 |
|
| The new version is removing enum value(s) 'SecurityUser' from the old version. New: Microsoft.Network/stable/2022-11-01/networkManager.json#L571:9 Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L625:9 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️🔄LintDiff inProgress [Detail]
️❌Avocado: 2 Errors, 6 Warnings failed [Detail]
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 490 Errors, 0 Warnings failed [Detail]
Only 10 items are listed, please refer to log for more details.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=358623&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-go - sdk/resourcemanager/network/armnetwork - 3.0.0+ Field `PeerRouteList` of struct `VirtualHubBgpConnectionsClientListAdvertisedRoutesResponse` has been removed + Field `PeerRouteList` of struct `VirtualHubBgpConnectionsClientListLearnedRoutesResponse` has been removed + Struct `PeerRouteList` has been removed + `LoadBalancerBackendAddressAdminStateDrain` from enum `LoadBalancerBackendAddressAdminState` has been removed
❌azure-sdk-for-js - @azure/arm-network - 31.0.0+ Enum KnownLoadBalancerBackendAddressAdminState no longer has value Drain + Interface Subnet no longer has parameter applicationGatewayIpConfigurations
️🔄 azure-sdk-for-net inProgress [Detail]
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️Azure.ResourceManager.Network [View full logs] [Release SDK Changes]info [Changelog]
️🔄 azure-sdk-for-python-track2 inProgress [Detail]
️⚠️ azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-network-generated [View full logs] [Release SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/network/armnetwork [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - `LoadBalancerBackendAddressAdminStateDrain` from enum `LoadBalancerBackendAddressAdminState` has been removed info [Changelog] - Struct `PeerRouteList` has been removed info [Changelog] - Field `PeerRouteList` of struct `VirtualHubBgpConnectionsClientListAdvertisedRoutesResponse` has been removed info [Changelog] - Field `PeerRouteList` of struct `VirtualHubBgpConnectionsClientListLearnedRoutesResponse` has been removed info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New value `NetworkInterfaceAuxiliaryModeAcceleratedConnections` added to enum type `NetworkInterfaceAuxiliaryMode` info [Changelog] - New value `WebApplicationFirewallRuleTypeRateLimitRule` added to enum type `WebApplicationFirewallRuleType` info [Changelog] - New enum type `ApplicationGatewayFirewallRateLimitDuration` with values `ApplicationGatewayFirewallRateLimitDurationFiveMins`, `ApplicationGatewayFirewallRateLimitDurationOneMin` info [Changelog] - New enum type `ApplicationGatewayFirewallUserSessionVariable` with values `ApplicationGatewayFirewallUserSessionVariableClientAddr`, `ApplicationGatewayFirewallUserSessionVariableGeoLocation`, `ApplicationGatewayFirewallUserSessionVariableNone` info [Changelog] - New enum type `AzureFirewallPacketCaptureFlagsType` with values `AzureFirewallPacketCaptureFlagsTypeAck`, `AzureFirewallPacketCaptureFlagsTypeFin`, `AzureFirewallPacketCaptureFlagsTypePush`, `AzureFirewallPacketCaptureFlagsTypeRst`, `AzureFirewallPacketCaptureFlagsTypeSyn`, `AzureFirewallPacketCaptureFlagsTypeUrg` info [Changelog] - New enum type `NetworkInterfaceAuxiliarySKU` with values `NetworkInterfaceAuxiliarySKUA1`, `NetworkInterfaceAuxiliarySKUA2`, `NetworkInterfaceAuxiliarySKUA4`, `NetworkInterfaceAuxiliarySKUA8`, `NetworkInterfaceAuxiliarySKUNone` info [Changelog] - New enum type `ScrubbingRuleEntryMatchOperator` with values `ScrubbingRuleEntryMatchOperatorEquals`, `ScrubbingRuleEntryMatchOperatorEqualsAny` info [Changelog] - New enum type `ScrubbingRuleEntryMatchVariable` with values `ScrubbingRuleEntryMatchVariableRequestArgNames`, `ScrubbingRuleEntryMatchVariableRequestCookieNames`, `ScrubbingRuleEntryMatchVariableRequestHeaderNames`, `ScrubbingRuleEntryMatchVariableRequestIPAddress`, `ScrubbingRuleEntryMatchVariableRequestJSONArgNames`, `ScrubbingRuleEntryMatchVariableRequestPostArgNames` info [Changelog] - New enum type `ScrubbingRuleEntryState` with values `ScrubbingRuleEntryStateDisabled`, `ScrubbingRuleEntryStateEnabled` info [Changelog] - New enum type `WebApplicationFirewallScrubbingState` with values `WebApplicationFirewallScrubbingStateDisabled`, `WebApplicationFirewallScrubbingStateEnabled` info [Changelog] - New function `*AzureFirewallsClient.BeginPacketCapture(context.Context, string, string, FirewallPacketCaptureParameters, *AzureFirewallsClientBeginPacketCaptureOptions) (*runtime.Poller[AzureFirewallsClientPacketCaptureResponse], error)` info [Changelog] - New function `*ClientFactory.NewVirtualApplianceConnectionsClient() *VirtualApplianceConnectionsClient` info [Changelog] - New function `NewVirtualApplianceConnectionsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*VirtualApplianceConnectionsClient, error)` info [Changelog] - New function `*VirtualApplianceConnectionsClient.BeginCreateOrUpdate(context.Context, string, string, string, VirtualApplianceConnection, *VirtualApplianceConnectionsClientBeginCreateOrUpdateOptions) (*runtime.Poller[VirtualApplianceConnectionsClientCreateOrUpdateResponse], error)` info [Changelog] - New function `*VirtualApplianceConnectionsClient.BeginDelete(context.Context, string, string, string, *VirtualApplianceConnectionsClientBeginDeleteOptions) (*runtime.Poller[VirtualApplianceConnectionsClientDeleteResponse], error)` info [Changelog] - New function `*VirtualApplianceConnectionsClient.Get(context.Context, string, string, string, *VirtualApplianceConnectionsClientGetOptions) (VirtualApplianceConnectionsClientGetResponse, error)` info [Changelog] - New function `*VirtualApplianceConnectionsClient.NewListPager(string, string, *VirtualApplianceConnectionsClientListOptions) *runtime.Pager[VirtualApplianceConnectionsClientListResponse]` info [Changelog] - New struct `AzureFirewallPacketCaptureFlags` info [Changelog] - New struct `AzureFirewallPacketCaptureRule` info [Changelog] - New struct `FirewallPacketCaptureParameters` info [Changelog] - New struct `FirewallPacketCaptureParametersFormat` info [Changelog] - New struct `FirewallPolicyHTTPHeaderToInsert` info [Changelog] - New struct `GroupByUserSession` info [Changelog] - New struct `GroupByVariable` info [Changelog] - New struct `PolicySettingsLogScrubbing` info [Changelog] - New struct `PropagatedRouteTableNfv` info [Changelog] - New struct `RoutingConfigurationNfv` info [Changelog] - New struct `RoutingConfigurationNfvSubResource` info [Changelog] - New struct `VirtualApplianceAdditionalNicProperties` info [Changelog] - New struct `VirtualApplianceConnection` info [Changelog] - New struct `VirtualApplianceConnectionList` info [Changelog] - New struct `VirtualApplianceConnectionProperties` info [Changelog] - New struct `WebApplicationFirewallScrubbingRules` info [Changelog] - New field `HTTPHeadersToInsert` in struct `ApplicationRule` info [Changelog] - New field `EnableKerberos` in struct `BastionHostPropertiesFormat` info [Changelog] - New field `AuxiliarySKU` in struct `InterfacePropertiesFormat` info [Changelog] - New field `FileUploadEnforcement`, `LogScrubbing`, `RequestBodyEnforcement`, `RequestBodyInspectLimitInKB` in struct `PolicySettings` info [Changelog] - New field `PrivateEndpointLocation` in struct `PrivateEndpointConnectionProperties` info [Changelog] - New field `InstanceName` in struct `VirtualApplianceNicProperties` info [Changelog] - New field `AdditionalNics`, `VirtualApplianceConnections` in struct `VirtualAppliancePropertiesFormat` info [Changelog] - New field `Value` in struct `VirtualHubBgpConnectionsClientListAdvertisedRoutesResponse` info [Changelog] - New field `Value` in struct `VirtualHubBgpConnectionsClientListLearnedRoutesResponse` info [Changelog] - New field `GroupByUserSession`, `RateLimitDuration`, `RateLimitThreshold` in struct `WebApplicationFirewallCustomRule` info [Changelog] info [Changelog] Total 5 breaking change(s), 87 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-network [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Added operation group NetworkVirtualApplianceConnections info [Changelog] - Added operation AzureFirewalls.beginPacketCapture info [Changelog] - Added operation AzureFirewalls.beginPacketCaptureAndWait info [Changelog] - Added Interface AzureFirewallPacketCaptureFlags info [Changelog] - Added Interface AzureFirewallPacketCaptureRule info [Changelog] - Added Interface AzureFirewallsPacketCaptureHeaders info [Changelog] - Added Interface AzureFirewallsPacketCaptureOptionalParams info [Changelog] - Added Interface FirewallPacketCaptureParameters info [Changelog] - Added Interface FirewallPolicyHttpHeaderToInsert info [Changelog] - Added Interface GroupByUserSession info [Changelog] - Added Interface GroupByVariable info [Changelog] - Added Interface NetworkVirtualApplianceConnection info [Changelog] - Added Interface NetworkVirtualApplianceConnectionList info [Changelog] - Added Interface NetworkVirtualApplianceConnectionsCreateOrUpdateOptionalParams info [Changelog] - Added Interface NetworkVirtualApplianceConnectionsDeleteHeaders info [Changelog] - Added Interface NetworkVirtualApplianceConnectionsDeleteOptionalParams info [Changelog] - Added Interface NetworkVirtualApplianceConnectionsGetOptionalParams info [Changelog] - Added Interface NetworkVirtualApplianceConnectionsListNextOptionalParams info [Changelog] - Added Interface NetworkVirtualApplianceConnectionsListOptionalParams info [Changelog] - Added Interface NetworkVirtualAppliancesCreateOrUpdateHeaders info [Changelog] - Added Interface NetworkVirtualAppliancesDeleteHeaders info [Changelog] - Added Interface PolicySettingsLogScrubbing info [Changelog] - Added Interface PropagatedRouteTableNfv info [Changelog] - Added Interface RoutingConfigurationNfv info [Changelog] - Added Interface RoutingConfigurationNfvSubResource info [Changelog] - Added Interface VirtualApplianceAdditionalNicProperties info [Changelog] - Added Interface WebApplicationFirewallScrubbingRules info [Changelog] - Added Type Alias ApplicationGatewayFirewallRateLimitDuration info [Changelog] - Added Type Alias ApplicationGatewayFirewallUserSessionVariable info [Changelog] - Added Type Alias AzureFirewallPacketCaptureFlagsType info [Changelog] - Added Type Alias AzureFirewallsPacketCaptureResponse info [Changelog] - Added Type Alias NetworkInterfaceAuxiliarySku info [Changelog] - Added Type Alias NetworkVirtualApplianceConnectionsCreateOrUpdateResponse info [Changelog] - Added Type Alias NetworkVirtualApplianceConnectionsGetResponse info [Changelog] - Added Type Alias NetworkVirtualApplianceConnectionsListNextResponse info [Changelog] - Added Type Alias NetworkVirtualApplianceConnectionsListResponse info [Changelog] - Added Type Alias ScrubbingRuleEntryMatchOperator info [Changelog] - Added Type Alias ScrubbingRuleEntryMatchVariable info [Changelog] - Added Type Alias ScrubbingRuleEntryState info [Changelog] - Added Type Alias WebApplicationFirewallScrubbingState info [Changelog] - Interface ApplicationRule has a new optional parameter httpHeadersToInsert info [Changelog] - Interface BastionHost has a new optional parameter enableKerberos info [Changelog] - Interface NetworkInterface has a new optional parameter auxiliarySku info [Changelog] - Interface NetworkVirtualAppliance has a new optional parameter additionalNics info [Changelog] - Interface NetworkVirtualAppliance has a new optional parameter virtualApplianceConnections info [Changelog] - Interface PolicySettings has a new optional parameter fileUploadEnforcement info [Changelog] - Interface PolicySettings has a new optional parameter logScrubbing info [Changelog] - Interface PolicySettings has a new optional parameter requestBodyEnforcement info [Changelog] - Interface PolicySettings has a new optional parameter requestBodyInspectLimitInKB info [Changelog] - Interface PrivateEndpointConnection has a new optional parameter privateEndpointLocation info [Changelog] - Interface Subnet has a new optional parameter applicationGatewayIPConfigurations info [Changelog] - Interface VirtualApplianceNicProperties has a new optional parameter instanceName info [Changelog] - Interface WebApplicationFirewallCustomRule has a new optional parameter groupByUserSession info [Changelog] - Interface WebApplicationFirewallCustomRule has a new optional parameter rateLimitDuration info [Changelog] - Interface WebApplicationFirewallCustomRule has a new optional parameter rateLimitThreshold info [Changelog] - Added Enum KnownApplicationGatewayFirewallRateLimitDuration info [Changelog] - Added Enum KnownApplicationGatewayFirewallUserSessionVariable info [Changelog] - Added Enum KnownAzureFirewallPacketCaptureFlagsType info [Changelog] - Added Enum KnownNetworkInterfaceAuxiliarySku info [Changelog] - Added Enum KnownScrubbingRuleEntryMatchOperator info [Changelog] - Added Enum KnownScrubbingRuleEntryMatchVariable info [Changelog] - Added Enum KnownScrubbingRuleEntryState info [Changelog] - Added Enum KnownWebApplicationFirewallScrubbingState info [Changelog] - Enum KnownNetworkInterfaceAuxiliaryMode has a new value AcceleratedConnections info [Changelog] - Enum KnownWebApplicationFirewallRuleType has a new value RateLimitRule info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Interface Subnet no longer has parameter applicationGatewayIpConfigurations info [Changelog] - Enum KnownLoadBalancerBackendAddressAdminState no longer has value Drain
️🔄 azure-resource-manager-schemas inProgress [Detail]
️❌ azure-powershell failed [Detail]
command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json SSL error: syscall failure: Broken pipe Error: SSL error: syscall failure: Broken pipe
❌Az.network.DefaultTag [View full logs]error Fatal error: SSL error: syscall failure: Broken pipe error The following packages are still pending: error Az.network.DefaultTag
Generated ApiView
|
This was referenced Apr 21, 2023
…tInKB (#23663) * Remove minimum value for optional field requestBodyInspectLimitInKB * Remove exlcusiveMinimum
|
hi~ @mikhailshilkov First of all, about the first comment (#23652 (comment)), please read carefully and fill in them correctly. “Changelog” section: at least one of the options should be selected in. |
|
On the other hand, pls fix valiation report error including Avocado, ModelValidation. Thanks. |
|
@JackTn the avocado failure is regular from such releases and we're skipping that each time. I've asked many times for swagger team to update this check, but not done by swagger team. as well as model validation. So please help to bypass them and release swagger |
|
@raych1 can't you please help to understand, why did swagger model validation finished without any failures for all the PRs for monthly branch (example: last PR for monthly branch https://github.com/Azure/azure-rest-api-specs/pull/23663/checks?check_run_id=12915229991). But in the same time we've received tens of failures contributing to main... Can't we do something with that to prevent such confusions? I don't have resources to work on 50+ failures, code owners should work on them |
@MikhailTryakhov , @JackTn , all the changes are supposed to be reviewed by ARM team in previous PR targeting release branch, so this PR normally we ignore ARM review. we could approve MV, avocado for this PR. For cross version breaking change, I confirmed that the change was approved in previous PR #23082. |
raych1
added
Approved-BreakingChange
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
raych1
removed
WaitForARMFeedback
raych1
approved these changes
Apr 25, 2023
This was referenced Apr 25, 2023
MikhailTryakhov
added
the
DoNotMerge
JoshLove-msft
pushed a commit
to JoshLove-msft/azure-rest-api-specs
that referenced
this pull request
Apr 25, 2023
* Adds base for updating Microsoft.Network from version stable/2022-09-01 to version 2022-11-01 * Updates readme * Updates API version in new specs and examples * remove loadDistributionPolicy from appgw PUT request body example (Azure#23144) * remove loadDistributionPolicy from appgw PUT request body example * remove loadDistributionPolicy from appgw PUT request body example2 * remove loadDistributionPolicy from appgw PUT request body example * remove duplicates * add private link configuration to see if it will fix validation error * remove privateLinkConfig related * revert changes to see if still get validation error * update back to original changes * add response resource id to fix modelValidation error * add connection resource * Selector in Exclusions should not be required as Operator EqualsAny does not need a Selector (Azure#23184) * Application Gateway WAF Rate Limit feature swagger changes (Azure#23021) * Application Gateway WAF Rate Limit feature swagger changes * Fixing lint errors * Updated rate limit feature examples * Fix for applicationGatewayIpConfigurations property and make the priority parameter as required for NSG (Azure#23210) * Fix for applicationGatewayIpConfigurations property This swagger definition is defining property applicationGatewayIpConfigurations, ``` "applicationGatewayIpConfigurations": { "type": "array", "items": { "$ref": "./applicationGateway.json#/definitions/ApplicationGatewayIPConfiguration" }, "description": "Application gateway IP configurations of virtual network resource." } ``` but actual rest api returned applicationGatewayIPConfigurations, the P is upper case while in swagger it is lower case. ``` { "name": "subnet-agw", "id": "/subscriptions/<sub-id>/resourceGroups/<rg-name>/providers/Microsoft.Network/virtualNetworks/<vnet-name>/subnets/subnet-agw", "properties": { "applicationGatewayIPConfigurations": [ { "id": "/subscriptions/<sub-id>/resourceGroups/<rg-name>/providers/Microsoft.Network/applicationGateways/<agw-name>/gatewayIPConfigurations/appGatewayIpConfig" } ] }, "type": "Microsoft.Network/virtualNetworks/subnets" } ``` * Making priority property required [This is the API invoked](https://learn.microsoft.com/en-us/rest/api/virtualnetwork/network-security-groups/create-or-update?tabs=HTTP#code-try-0). For the NSG security rules without priorities, seems like the priority parameter is required. Azure portal works as expected. I don't think that's allowed but according to the schema it is because the priority property is not marked as required. I tried to create a NSG security rule without the priorities and it failed with below. Request Body: ``` { "properties": { "securityRules": [ { "name": "rule1", "properties": { "protocol": "*", "sourceAddressPrefix": "*", "destinationAddressPrefix": "*", "access": "Allow", "destinationPortRange": "80", "sourcePortRange": "*", "direction": "Inbound" } } ] }, "location": "eastus" } ``` Response received: ``` { "error": { "code": "SecurityRuleInvalidPriority", "message": "Security rule has invalid Priority. Value provided: 0 Allowed range 100-4096.", "details": [] } } ``` This PR will make the priority parameter as required. * Update NetworkSecurityGroupDelete.json * Update NetworkSecurityGroupRuleDelete.json * Update NetworkSecurityGroupDelete.json * Undo previous change of making fields optional within Exclusion (Azure#23325) * Nivishenker/http headers to insert (Azure#23295) * new app rule property - http header to insert * prettier * add to 22-11-01 * removed changes from 22-09-01 * fixed example * delete RCG example * fix delete examples * added a Location header * prettier fix * Application Gateway WAF Log scrubbing swagger changes (Azure#23022) * Log scrubbing API changes * Update examples * Addressing comments * Fix * Update property in load balancer for Connection Draining Phase 1 (Azure#23082) * Update property in load balancer for Coneection Draining Phase 1 * Fix model validation * Azure Firewall Packet Capture API. Cancelled PR from 2022-09-01 and created for 2022-11-01 (Azure#23114) * moving packet-capture api to 2022-11-01 release from 2022-09-01 * fixing the LRO response header error for model validation * Changes for Additional nic and corrections (Azure#23522) * Changes for Additional nic and corrections * Fixes for tool reported issues * Fix for SpellCheck, ModelValidation * Defining Location in NetworkVirtualApplianceDelete for async * Minor fix * Minor fix * Minor fix * PrettierCheck fixed * Fixing VirtualApplianceAdditionalNicProperties * ModelValidation fixed * Correcting the location header string * Correcting location header * Prettied Check Fix * Fix * Fix * Add inspection limit changes (Azure#23536) * Fixed headers for examples (Azure#23554) * Fix response of API: List of advertised/learned BGP routes (Azure#23555) * fix response type * fix format * fix example, add x-ms-identifiers * AuxiliarySku on Nic (Azure#23552) * Adding auxiliary sku property on nic * Adding AcceleratedConnections to AuxMode * modifying the auxSku values * Removing accidental change --------- Co-authored-by: Prachi Pravin Bhavsar <[email protected]> * migrated latest pr from incorrect branch (Azure#23589) * Changes for NVA connection (Azure#23173) * Changes for NVA connection * Changes to address validation failures * Fix some ModelValidation errors * Fix some ModelValidation errors * Fix some ModelValidation errors * Fix some ModelValidation errors * Fix some ModelValidation errors * Addressing some review comments * Addressing some review comments * Addressing some review comments * Addressing some review comments * Addressing some review comments * Fix camel case for property name * Fixing resourceUri to Camel case in example files * Fix SDK duplication error * Fix one LintDiff error * try fix lintdiff errors * fix lro erro in lintdiff * fix model validation error * Bastion S360 for 2022-11 version (Azure#23595) * Release microsoft.network 2022 11 01 (Azure#23564) * Application Gateway WAF Rate Limit feature swagger changes * Fixing lint errors * Updated rate limit feature examples * rateLimitDuration and rateLimitThreshold are not mandatory. There are only mandatory if ruleType is RateLimitRule. This validation will be done in NRP. * Fix attempt 2. Removed minimum constraint from rateLimitThreshold. Validation will be done in NRP * Remove the minimum number for the option field requestBodyInspectLimitInKB (Azure#23663) * Remove minimum value for optional field requestBodyInspectLimitInKB * Remove exlcusiveMinimum --------- Co-authored-by: htippanaboya <[email protected]> Co-authored-by: tracyMicro <[email protected]> Co-authored-by: tejasshah7 <[email protected]> Co-authored-by: sraghavan-msft <[email protected]> Co-authored-by: navba-MSFT <[email protected]> Co-authored-by: NiviShenker <[email protected]> Co-authored-by: Sindhu Aluguvelli <[email protected]> Co-authored-by: phrazfipho <[email protected]> Co-authored-by: nikhilpadhye1 <[email protected]> Co-authored-by: JainRah <[email protected]> Co-authored-by: karanbazaz <[email protected]> Co-authored-by: yeliMSFT <[email protected]> Co-authored-by: pracsb <[email protected]> Co-authored-by: Prachi Pravin Bhavsar <[email protected]> Co-authored-by: nanditaashok-ms <[email protected]> Co-authored-by: anvrao1 <[email protected]> Co-authored-by: baoqihuang0326 <[email protected]>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.