Fixing live validation correctness error for BackupProtectableItems_List #23600

iwrinshow · 2023-04-18T12:28:35Z

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2023-04-18T12:28:39Z

Hi, @iwrinshow Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2023-04-18T12:28:40Z

Swagger Validation Report

️❌BreakingChange: 12 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
bms.json	2023-01-01(1dfa2a6)	2023-01-01(main)
bms.json	2023-02-01(1dfa2a6)	2023-02-01(main)

Rule	Message
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'AzureVmWorkloadSAPHanaHSR' removed or renamed? New: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L4587:3 Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L4587:3
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'AzureVmWorkloadSAPHanaHSR' removed or renamed? New: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L4587:3 Old: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L4587:3
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'actionRequired' renamed or removed? New: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L4760:7 Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L4743:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'actionRequired' renamed or removed? New: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L4760:7 Old: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L4743:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'actionsRequired' in response that was not found in the old version. New: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L4760:7 Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L4743:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'groupIds' in response that was not found in the old version. New: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L4701:7 Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L4701:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'actionsRequired' in response that was not found in the old version. New: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L4760:7 Old: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L4743:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'groupIds' in response that was not found in the old version. New: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L4701:7 Old: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L4701:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'groupIds' that was not found in the old version. New: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L4701:7 Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L4701:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'actionsRequired' that was not found in the old version. New: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L4760:7 Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L4743:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'groupIds' that was not found in the old version. New: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L4701:7 Old: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L4701:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'actionsRequired' that was not found in the old version. New: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L4760:7 Old: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L4743:7

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️🔄LintDiff inProgress [Detail]

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-18T12:28:41Z

Swagger Generation Artifacts

️🔄ApiDocPreview inProgress [Detail]

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup - 3.0.0

+	Field `ActionRequired` of struct `PrivateLinkServiceConnectionState` has been removed
+	Function `*AzureVMWorkloadSAPHanaHSR.GetAzureVMWorkloadProtectableItem` has been removed
+	Function `*AzureVMWorkloadSAPHanaHSR.GetWorkloadProtectableItem` has been removed
+	Struct `AzureVMWorkloadSAPHanaHSR` has been removed

❌azure-sdk-for-go - sdk/resourcemanager/security/armsecurity - 0.10.0

+	Function `*ConnectorGovernanceRuleClient.NewListPager` has been removed
+	Function `*ConnectorGovernanceRulesClient.CreateOrUpdate` has been removed
+	Function `*ConnectorGovernanceRulesClient.Delete` has been removed
+	Function `*ConnectorGovernanceRulesClient.Get` has been removed
+	Function `*ConnectorGovernanceRulesExecuteStatusClient.BeginGet` has been removed
+	Function `*GovernanceRuleClient.NewListPager` has been removed
+	Function `*GovernanceRulesClient.BeginRuleIDExecuteSingleSecurityConnector` has been removed
+	Function `*GovernanceRulesClient.BeginRuleIDExecuteSingleSubscription` has been removed
+	Function `*GovernanceRulesClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, GovernanceRule, *GovernanceRulesClientCreateOrUpdateOptions)` to `(context.Context, string, string, GovernanceRule, *GovernanceRulesClientCreateOrUpdateOptions)`
+	Function `*GovernanceRulesClient.Get` parameter(s) have been changed from `(context.Context, string, *GovernanceRulesClientGetOptions)` to `(context.Context, string, string, *GovernanceRulesClientGetOptions)`
+	Function `*SubscriptionGovernanceRulesExecuteStatusClient.BeginGet` has been removed
+	Function `NewConnectorGovernanceRuleClient` has been removed
+	Function `NewConnectorGovernanceRulesClient` has been removed
+	Function `NewConnectorGovernanceRulesExecuteStatusClient` has been removed
+	Function `NewGovernanceRuleClient` has been removed
+	Function `NewGovernanceRulesClient` parameter(s) have been changed from `(string, azcore.TokenCredential, *arm.ClientOptions)` to `(azcore.TokenCredential, *arm.ClientOptions)`
+	Function `NewSubscriptionGovernanceRulesExecuteStatusClient` has been removed
+	Operation `*GovernanceRulesClient.Delete` has been changed to LRO, use `*GovernanceRulesClient.BeginDelete` instead.
+	Struct `ConnectorGovernanceRuleClient` has been removed
+	Struct `ConnectorGovernanceRulesClient` has been removed
+	Struct `ConnectorGovernanceRulesExecuteStatusClient` has been removed
+	Struct `ExecuteRuleStatus` has been removed
+	Struct `GovernanceRuleClient` has been removed
+	Struct `SubscriptionGovernanceRulesExecuteStatusClient` has been removed

❌azure-sdk-for-js - @azure/arm-recoveryservicesbackup - 11.0.0

+	Interface PrivateLinkServiceConnectionState no longer has parameter actionRequired
+	Type of parameter protectableItemType of interface AzureVmWorkloadProtectableItem is changed from "AzureVmWorkloadProtectableItem" | "SAPAseSystem" | "SAPHanaDatabase" | "SAPHanaSystem" | "SAPHanaDBInstance" | "SAPHanaHSR" | "SQLAvailabilityGroupContainer" | "SQLDataBase" | "SQLInstance" to "AzureVmWorkloadProtectableItem" | "SAPAseSystem" | "SAPHanaDatabase" | "SAPHanaSystem" | "SAPHanaDBInstance" | "HanaHSRContainer" | "SQLAvailabilityGroupContainer" | "SQLDataBase" | "SQLInstance"
+	Type of parameter protectableItemType of interface WorkloadProtectableItem is changed from "AzureFileShare" | "IaaSVMProtectableItem" | "Microsoft.ClassicCompute/virtualMachines" | "Microsoft.Compute/virtualMachines" | "AzureVmWorkloadProtectableItem" | "SAPAseSystem" | "SAPHanaDatabase" | "SAPHanaSystem" | "SAPHanaDBInstance" | "SAPHanaHSR" | "SQLAvailabilityGroupContainer" | "SQLDataBase" | "SQLInstance" to "AzureFileShare" | "IaaSVMProtectableItem" | "Microsoft.ClassicCompute/virtualMachines" | "Microsoft.Compute/virtualMachines" | "AzureVmWorkloadProtectableItem" | "SAPAseSystem" | "SAPHanaDatabase" | "SAPHanaSystem" | "SAPHanaDBInstance" | "HanaHSRContainer" | "SQLAvailabilityGroupContainer" | "SQLDataBase" | "SQLInstance"

❌azure-sdk-for-js - @azure/arm-security - 6.0.0-beta.4

+	Interface AlertsSuppressionRulesListNextOptionalParams no longer has parameter alertType
+	Interface DefenderForServersAwsOfferingArcAutoProvisioning no longer has parameter servicePrincipalSecretMetadata
+	Interface IotSecuritySolutionListByResourceGroupNextOptionalParams no longer has parameter filter
+	Interface IotSecuritySolutionListBySubscriptionNextOptionalParams no longer has parameter filter
+	Interface IotSecuritySolutionsAnalyticsAggregatedAlertListNextOptionalParams no longer has parameter top
+	Interface IotSecuritySolutionsAnalyticsRecommendationListNextOptionalParams no longer has parameter top
+	Interface RegulatoryComplianceAssessmentsListNextOptionalParams no longer has parameter filter
+	Interface RegulatoryComplianceControlsListNextOptionalParams no longer has parameter filter
+	Interface RegulatoryComplianceStandardsListNextOptionalParams no longer has parameter filter
+	Interface SecureScoreControlsListBySecureScoreNextOptionalParams no longer has parameter expand
+	Interface SecureScoreControlsListNextOptionalParams no longer has parameter expand
+	Interface TasksListByHomeRegionNextOptionalParams no longer has parameter filter
+	Interface TasksListByResourceGroupNextOptionalParams no longer has parameter filter
+	Interface TasksListNextOptionalParams no longer has parameter filter
+	Operation AllowedConnections.get has a new signature
+	Removed Enum KnownAlertNotifications
+	Removed Enum KnownAlertsToAdmins
+	Removed operation Alerts.simulate
+	Removed operation SecurityContacts.update
+	Type of parameter value of interface ExternalSecuritySolutionList is changed from ExternalSecuritySolutionUnion[] to ExternalSecuritySolution[]

❌azure-sdk-for-python-track2 - track2_azure-mgmt-recoveryservicesbackup - 5.2.0

+	Model PrivateLinkServiceConnectionState no longer has parameter action_required

❌azure-sdk-for-python-track2 - track2_azure-mgmt-security - 4.0.0

+	Model DefenderForDatabasesGcpOfferingArcAutoProvisioningConfiguration no longer has parameter agent_onboarding_service_account_numeric_id
+	Model DefenderForDatabasesGcpOfferingArcAutoProvisioningConfiguration no longer has parameter client_id
+	Model DefenderForServersGcpOfferingArcAutoProvisioningConfiguration no longer has parameter agent_onboarding_service_account_numeric_id
+	Model DefenderForServersGcpOfferingArcAutoProvisioningConfiguration no longer has parameter client_id

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from c8c2fed. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:671
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 671 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.RecoveryServicesBackup [View full logs] [Release SDK Changes] Breaking Change Detected

Azure.ResourceManager.RecoveryServicesBackup.1.1.0-alpha.20230420.1.nupkg

info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.RecoveryServicesBackup.Models.VmWorkloadSapHanaHsr' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/recoveryservices-backup/Azure.ResourceManager.RecoveryServicesBackup/src/Azure.ResourceManager.RecoveryServicesBackup.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.RecoveryServicesBackup/Debug/netstandard2.0/Azure.ResourceManager.RecoveryServicesBackup.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/recoveryservices-backup/Azure.ResourceManager.RecoveryServicesBackup/src/Azure.ResourceManager.RecoveryServicesBackup.csproj::TargetFramework=netstandard2.0]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from c8c2fed. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.5
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.5>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-recoveryservicesbackup [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model PrivateEndpointConnection has a new parameter group_ids
info	[Changelog]   - Model PrivateLinkServiceConnectionState has a new parameter actions_required
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model PrivateLinkServiceConnectionState no longer has parameter action_required

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from c8c2fed. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-recoveryservicesbackup [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from c8c2fed. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*AzureVMWorkloadSAPHanaHSR.GetAzureVMWorkloadProtectableItem` has been removed
info	[Changelog] - Function `*AzureVMWorkloadSAPHanaHSR.GetWorkloadProtectableItem` has been removed
info	[Changelog] - Struct `AzureVMWorkloadSAPHanaHSR` has been removed
info	[Changelog] - Field `ActionRequired` of struct `PrivateLinkServiceConnectionState` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `VaultSubResourceType` with values `VaultSubResourceTypeAzureBackup`, `VaultSubResourceTypeAzureBackupSecondary`, `VaultSubResourceTypeAzureSiteRecovery`
info	[Changelog] - New function `*AzureVMWorkloadSAPHanaHSRProtectableItem.GetAzureVMWorkloadProtectableItem() *AzureVMWorkloadProtectableItem`
info	[Changelog] - New function `*AzureVMWorkloadSAPHanaHSRProtectableItem.GetWorkloadProtectableItem() *WorkloadProtectableItem`
info	[Changelog] - New struct `AzureVMWorkloadSAPHanaHSRProtectableItem`
info	[Changelog] - New field `GroupIDs` in struct `PrivateEndpointConnection`
info	[Changelog] - New field `ActionsRequired` in struct `PrivateLinkServiceConnectionState`
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 10 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from c8c2fed. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-recoveryservicesbackup [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-recoveryservicesbackup-11.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface AzureVmWorkloadSAPHanaHSRProtectableItem
info	[Changelog]   - Added Type Alias VaultSubResourceType
info	[Changelog]   - Interface PrivateEndpointConnection has a new optional parameter groupIds
info	[Changelog]   - Interface PrivateLinkServiceConnectionState has a new optional parameter actionsRequired
info	[Changelog]   - Added Enum KnownVaultSubResourceType
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface PrivateLinkServiceConnectionState no longer has parameter actionRequired
info	[Changelog]   - Type of parameter protectableItemType of interface AzureVmWorkloadProtectableItem is changed from "AzureVmWorkloadProtectableItem" | "SAPAseSystem" | "SAPHanaDatabase" | "SAPHanaSystem" | "SAPHanaDBInstance" | "SAPHanaHSR" | "SQLAvailabilityGroupContainer" | "SQLDataBase" | "SQLInstance" to "AzureVmWorkloadProtectableItem" | "SAPAseSystem" | "SAPHanaDatabase" | "SAPHanaSystem" | "SAPHanaDBInstance" | "HanaHSRContainer" | "SQLAvailabilityGroupContainer" | "SQLDataBase" | "SQLInstance"
info	[Changelog]   - Type of parameter protectableItemType of interface WorkloadProtectableItem is changed from "AzureFileShare" | "IaaSVMProtectableItem" | "Microsoft.ClassicCompute/virtualMachines" | "Microsoft.Compute/virtualMachines" | "AzureVmWorkloadProtectableItem" | "SAPAseSystem" | "SAPHanaDatabase" | "SAPHanaSystem" | "SAPHanaDBInstance" | "SAPHanaHSR" | "SQLAvailabilityGroupContainer" | "SQLDataBase" | "SQLInstance" to "AzureFileShare" | "IaaSVMProtectableItem" | "Microsoft.ClassicCompute/virtualMachines" | "Microsoft.Compute/virtualMachines" | "AzureVmWorkloadProtectableItem" | "SAPAseSystem" | "SAPHanaDatabase" | "SAPHanaSystem" | "SAPHanaDBInstance" | "HanaHSRContainer" | "SQLAvailabilityGroupContainer" | "SQLDataBase" | "SQLInstance"

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from c8c2fed. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️recoveryservicesbackup [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Failed [Logs]Release - Generate from c8c2fed. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

❌Az.recoveryservicesbackup.DefaultTag [View full logs] [Release SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-18T12:28:42Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup	https://apiview.dev/Assemblies/Review/34d96f58bde0461e9dc71d1a301b5c95
Java	azure-resourcemanager-recoveryservicesbackup	https://apiview.dev/Assemblies/Review/d4be85e195bf44a1a8454fbe7bf49dab
.Net	Azure.ResourceManager.RecoveryServicesBackup	https://apiview.dev/Assemblies/Review/bfdc40c05e3042e39cb5d0a5160e7635
JavaScript	@azure/arm-recoveryservicesbackup	https://apiview.dev/Assemblies/Review/214b39cd6df94d09b7dfb32a45ce4761

openapi-workflow-bot · 2023-04-18T12:37:22Z

Hi @iwrinshow, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

…esbackup-Microsoft.RecoveryServices-2023-02-01'

…ist (#23600) * Fixing live validation correctness error for BackupProtectableItems_List * Fixing bms.json for PrivateEndpointConnection addition of groupIds * Making changes in the version 2023-01-01 --------- Co-authored-by: Shashwat Trivedi <[email protected]>

…ist (Azure#23600) * Fixing live validation correctness error for BackupProtectableItems_List * Fixing bms.json for PrivateEndpointConnection addition of groupIds * Making changes in the version 2023-01-01 --------- Co-authored-by: Shashwat Trivedi <[email protected]>

openapi-assignment-bot bot assigned chunyu3 Apr 18, 2023

azure-sdk mentioned this pull request Apr 18, 2023

[AutoPR sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup] Fixing live validation correctness error for BackupProtectableItems_List azure-sdk/azure-sdk-for-go#5375

Closed

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager labels Apr 18, 2023

azure-sdk mentioned this pull request Apr 18, 2023

[AutoPR sdk/resourcemanager/security/armsecurity] Fixing live validation correctness for BackupProtectableItems_List azure-sdk/azure-sdk-for-go#5376

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Apr 18, 2023

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Apr 18, 2023

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Apr 18, 2023

Fixing live validation correctness error for BackupProtectableItems_List

5b9d40f

iwrinshow force-pushed the master branch from a8cfb13 to 5b9d40f Compare April 19, 2023 05:19

iwrinshow changed the title ~~Fixing live validation correctness for BackupProtectableItems_List~~ Fixing live validation correctness error for BackupProtectableItems_List Apr 19, 2023

Shashwat Trivedi and others added 3 commits April 19, 2023 13:20

Fixing bms.json for PrivateEndpointConnection addition of groupIds

d83ce39

Making changes in the version 2023-01-01

c125822

Merge remote-tracking branch 'upstream/shashwattrivedi-recoveryservic…

1dfa2a6

…esbackup-Microsoft.RecoveryServices-2023-02-01'

azure-sdk mentioned this pull request Apr 19, 2023

[AutoPR recoveryservicesbackup] Fixing live validation correctness error for BackupProtectableItems_List azure-sdk/azure-resource-manager-schemas#2440

Closed

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Apr 19, 2023

chunyu3 approved these changes Apr 20, 2023

View reviewed changes

chunyu3 merged commit c8c2fed into Azure:main Apr 20, 2023

tadelesh mentioned this pull request Jun 13, 2023

Adding changes for Distributed Node info list along with new API version 2023 04 01 for RecoveryServicesBackup #24210

Merged

11 tasks

kazrael2119 mentioned this pull request Sep 1, 2023

[mgmt] recoveryservicesbackup release Azure/azure-sdk-for-js#27004

Merged

tadelesh mentioned this pull request Sep 13, 2023

[Release] sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup/3.0.0 Azure/azure-sdk-for-go#21486

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing live validation correctness error for BackupProtectableItems_List #23600

Fixing live validation correctness error for BackupProtectableItems_List #23600

iwrinshow commented Apr 18, 2023 •

edited by openapi-workflow-bot bot

Loading

openapi-workflow-bot bot commented Apr 18, 2023

openapi-pipeline-app bot commented Apr 18, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 18, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Apr 18, 2023 •

edited

Loading

openapi-workflow-bot bot commented Apr 18, 2023

Fixing live validation correctness error for BackupProtectableItems_List #23600

Fixing live validation correctness error for BackupProtectableItems_List #23600

Conversation

iwrinshow commented Apr 18, 2023 • edited by openapi-workflow-bot bot Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Apr 18, 2023

openapi-pipeline-app bot commented Apr 18, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Apr 18, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Apr 18, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Apr 18, 2023

iwrinshow commented Apr 18, 2023 •

edited by openapi-workflow-bot bot

Loading

openapi-pipeline-app bot commented Apr 18, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 18, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 18, 2023 •

edited

Loading