Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2023-03-01 #23514

Conversation

MattEberhart-MSFTE
Copy link
Contributor

@MattEberhart-MSFTE MattEberhart-MSFTE commented Apr 11, 2023

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

* Added benefit utilizaiton summaries APIs to costmanagement.benefits.json and appropriate examples.

* Added report schema and secondary url

* Prettier check and spelling error fix

* Addressed BenefitKind / Kind in the csv schema and changed parameter name to benefitAsyncOperationIdParameter

* Replacing included quantity

* Alphabetized the parameters

* Changing request body BenefitKind property to Kind

* Adding 200 repsonse to generate api and fixing linter warnings

* Adding examples to generate api

* Making status optional for running scenario

* Changing to completed to have all properties in generate examples and adding long running operation tag to error response

* LRO Error response

* LRO lint diff error still present.
@openapi-workflow-bot
Copy link

Hi, @MattEberhart-MSFTE Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 11, 2023

    Swagger pipeline can not start as the pull request has merge conflicts.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 11, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️❌ azure-sdk-for-net failed [Detail]
    • Code Generator Failed [Logs] Generate from 2b1e2725f45df27813ddedcacf1197d9fedcc8b3. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/cost-management/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] FATAL: System.InvalidOperationException: Swagger document contains two or more x-ms-enum extensions with the same name 'OperationStatusType' and different values: Running,Complete,Failed vs. Running,Completed,Failed
      cmderr	[Autorest]    at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/ObjectBuilder.cs:line 150
      cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 217
      cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 48
      cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 133
      cmderr	[Autorest]    at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in /opt/vsts/work/1/s/src/SwaggerModeler.cs:line 348
      cmderr	[Autorest]    at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in /opt/vsts/work/1/s/src/SwaggerModeler.cs:line 66
      cmderr	[Autorest]    at AutoRest.Modeler.Program.<ProcessInternal>d2.MoveNext() in /opt/vsts/work/1/s/src/Program.cs:line 60
      cmderr	[Autorest] --- End of stack trace from previous location where exception was thrown ---
      cmderr	[Autorest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      cmderr	[Autorest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      cmderr	[Autorest]    at NewPlugin.<Process>d15.MoveNext()
      cmderr	[Autorest] FATAL: csharp/imodeler1 - FAILED
      cmderr	[Autorest] FATAL: Error: Plugin imodeler1 reported failure.
      cmderr	[Autorest]   Error: Plugin imodeler1 reported failure.
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
      warn	Skip package processing as generation is failed
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 2b1e2725f45df27813ddedcacf1197d9fedcc8b3. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/costmanagement/armcostmanagement [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog] - New enum type `WeeksOfMonth` with values `WeeksOfMonthFirst`, `WeeksOfMonthFourth`, `WeeksOfMonthLast`, `WeeksOfMonthSecond`, `WeeksOfMonthThird`
      info	[Changelog] - New function `*BenefitRecommendationProperties.GetBenefitRecommendationProperties() *BenefitRecommendationProperties`
      info	[Changelog] - New function `NewBenefitRecommendationsClient(azcore.TokenCredential, *arm.ClientOptions) (*BenefitRecommendationsClient, error)`
      info	[Changelog] - New function `*BenefitRecommendationsClient.NewListPager(string, *BenefitRecommendationsClientListOptions) *runtime.Pager[BenefitRecommendationsClientListResponse]`
      info	[Changelog] - New function `NewBenefitUtilizationSummariesAsyncClient(azcore.TokenCredential, *arm.ClientOptions) (*BenefitUtilizationSummariesAsyncClient, error)`
      info	[Changelog] - New function `*BenefitUtilizationSummariesAsyncClient.GetOperationStatusBillingAccountScope(context.Context, string, string, *BenefitUtilizationSummariesAsyncClientGetOperationStatusBillingAccountScopeOptions) (BenefitUtilizationSummariesAsyncClientGetOperationStatusBillingAccountScopeResponse, error)`
      info	[Changelog] - New function `*BenefitUtilizationSummariesAsyncClient.GetOperationStatusBillingProfileScope(context.Context, string, string, string, *BenefitUtilizationSummariesAsyncClientGetOperationStatusBillingProfileScopeOptions) (BenefitUtilizationSummariesAsyncClientGetOperationStatusBillingProfileScopeResponse, error)`
      info	[Changelog] - New function `*BenefitUtilizationSummariesAsyncClient.GetOperationStatusReservationOrderScope(context.Context, string, string, *BenefitUtilizationSummariesAsyncClientGetOperationStatusReservationOrderScopeOptions) (BenefitUtilizationSummariesAsyncClientGetOperationStatusReservationOrderScopeResponse, error)`
      info	[Changelog] - New function `*BenefitUtilizationSummariesAsyncClient.GetOperationStatusReservationScope(context.Context, string, string, string, *BenefitUtilizationSummariesAsyncClientGetOperationStatusReservationScopeOptions) (BenefitUtilizationSummariesAsyncClientGetOperationStatusReservationScopeResponse, error)`
      info	[Changelog] - New function `*BenefitUtilizationSummariesAsyncClient.GetOperationStatusSavingsPlanOrderScope(context.Context, string, string, *BenefitUtilizationSummariesAsyncClientGetOperationStatusSavingsPlanOrderScopeOptions) (BenefitUtilizationSummariesAsyncClientGetOperationStatusSavingsPlanOrderScopeResponse, error)`
      info	[Changelog] - New function `*BenefitUtilizationSummariesAsyncClient.GetOperationStatusSavingsPlanScope(context.Context, string, string, string, *BenefitUtilizationSummariesAsyncClientGetOperationStatusSavingsPlanScopeOptions) (BenefitUtilizationSummariesAsyncClientGetOperationStatusSavingsPlanScopeResponse, error)`
      info	[Changelog] - New function `NewBenefitUtilizationSummariesClient(azcore.TokenCredential, *arm.ClientOptions) (*BenefitUtilizationSummariesClient, error)`
      info	[Changelog] - New function `*BenefitUtilizationSummariesClient.NewListByBillingAccountIDPager(string, *BenefitUtilizationSummariesClientListByBillingAccountIDOptions) *runtime.Pager[BenefitUtilizationSummariesClientListByBillingAccountIDResponse]`
      info	[Changelog] - New function `*BenefitUtilizationSummariesClient.NewListByBillingProfileIDPager(string, string, *BenefitUtilizationSummariesClientListByBillingProfileIDOptions) *runtime.Pager[BenefitUtilizationSummariesClientListByBillingProfileIDResponse]`
      info	[Changelog] - New function `*BenefitUtilizationSummariesClient.NewListBySavingsPlanIDPager(string, string, *BenefitUtilizationSummariesClientListBySavingsPlanIDOptions) *runtime.Pager[BenefitUtilizationSummariesClientListBySavingsPlanIDResponse]`
      info	[Changelog] - New function `*BenefitUtilizationSummariesClient.NewListBySavingsPlanOrderPager(string, *BenefitUtilizationSummariesClientListBySavingsPlanOrderOptions) *runtime.Pager[BenefitUtilizationSummariesClientListBySavingsPlanOrderResponse]`
      info	[Changelog] - New function `*BenefitUtilizationSummary.GetBenefitUtilizationSummary() *BenefitUtilizationSummary`
      info	[Changelog] - New function `NewBillingAccountScopeClient(azcore.TokenCredential, *arm.ClientOptions) (*BillingAccountScopeClient, error)`
      info	[Changelog] - New function `*BillingAccountScopeClient.BeginGenerateBenefitUtilizationSummariesReport(context.Context, string, BenefitUtilizationSummariesRequest, *BillingAccountScopeClientBeginGenerateBenefitUtilizationSummariesReportOptions) (*runtime.Poller[BillingAccountScopeClientGenerateBenefitUtilizationSummariesReportResponse], error)`
      info	[Changelog] - New function `NewBillingProfileScopeClient(azcore.TokenCredential, *arm.ClientOptions) (*BillingProfileScopeClient, error)`
      info	[Changelog] - New function `*BillingProfileScopeClient.BeginGenerateBenefitUtilizationSummariesReport(context.Context, string, string, BenefitUtilizationSummariesRequest, *BillingProfileScopeClientBeginGenerateBenefitUtilizationSummariesReportOptions) (*runtime.Poller[BillingProfileScopeClientGenerateBenefitUtilizationSummariesReportResponse], error)`
      info	[Changelog] - New function `*ClientFactory.NewBenefitRecommendationsClient() *BenefitRecommendationsClient`
      info	[Changelog] - New function `*ClientFactory.NewBenefitUtilizationSummariesAsyncClient() *BenefitUtilizationSummariesAsyncClient`
      info	[Changelog] - New function `*ClientFactory.NewBenefitUtilizationSummariesClient() *BenefitUtilizationSummariesClient`
      info	[Changelog] - New function `*ClientFactory.NewBillingAccountScopeClient() *BillingAccountScopeClient`
      info	[Changelog] - New function `*ClientFactory.NewBillingProfileScopeClient() *BillingProfileScopeClient`
      info	[Changelog] - New function `*ClientFactory.NewGenerateCostDetailsReportClient() *GenerateCostDetailsReportClient`
      info	[Changelog] - New function `*ClientFactory.NewPriceSheetClient() *PriceSheetClient`
      info	[Changelog] - New function `*ClientFactory.NewReservationOrderScopeClient() *ReservationOrderScopeClient`
      info	[Changelog] - New function `*ClientFactory.NewReservationScopeClient() *ReservationScopeClient`
      info	[Changelog] - New function `*ClientFactory.NewSavingsPlanOrderScopeClient() *SavingsPlanOrderScopeClient`
      info	[Changelog] - New function `*ClientFactory.NewSavingsPlanScopeClient() *SavingsPlanScopeClient`
      info	[Changelog] - New function `*ClientFactory.NewScheduledActionsClient() *ScheduledActionsClient`
      info	[Changelog] - New function `NewGenerateCostDetailsReportClient(azcore.TokenCredential, *arm.ClientOptions) (*GenerateCostDetailsReportClient, error)`
      info	[Changelog] - New function `*GenerateCostDetailsReportClient.BeginCreateOperation(context.Context, string, GenerateCostDetailsReportRequestDefinition, *GenerateCostDetailsReportClientBeginCreateOperationOptions) (*runtime.Poller[GenerateCostDetailsReportClientCreateOperationResponse], error)`
      info	[Changelog] - New function `*GenerateCostDetailsReportClient.BeginGetOperationResults(context.Context, string, string, *GenerateCostDetailsReportClientBeginGetOperationResultsOptions) (*runtime.Poller[GenerateCostDetailsReportClientGetOperationResultsResponse], error)`
      info	[Changelog] - New function `*IncludedQuantityUtilizationSummary.GetBenefitUtilizationSummary() *BenefitUtilizationSummary`
      info	[Changelog] - New function `NewPriceSheetClient(azcore.TokenCredential, *arm.ClientOptions) (*PriceSheetClient, error)`
      info	[Changelog] - New function `*PriceSheetClient.BeginDownload(context.Context, string, string, string, *PriceSheetClientBeginDownloadOptions) (*runtime.Poller[PriceSheetClientDownloadResponse], error)`
      info	[Changelog] - New function `*PriceSheetClient.BeginDownloadByBillingProfile(context.Context, string, string, *PriceSheetClientBeginDownloadByBillingProfileOptions) (*runtime.Poller[PriceSheetClientDownloadByBillingProfileResponse], error)`
      info	[Changelog] - New function `NewReservationOrderScopeClient(azcore.TokenCredential, *arm.ClientOptions) (*ReservationOrderScopeClient, error)`
      info	[Changelog] - New function `*ReservationOrderScopeClient.BeginGenerateBenefitUtilizationSummariesReport(context.Context, string, BenefitUtilizationSummariesRequest, *ReservationOrderScopeClientBeginGenerateBenefitUtilizationSummariesReportOptions) (*runtime.Poller[ReservationOrderScopeClientGenerateBenefitUtilizationSummariesReportResponse], error)`
      info	[Changelog] - New function `NewReservationScopeClient(azcore.TokenCredential, *arm.ClientOptions) (*ReservationScopeClient, error)`
      info	[Changelog] - New function `*ReservationScopeClient.BeginGenerateBenefitUtilizationSummariesReport(context.Context, string, string, BenefitUtilizationSummariesRequest, *ReservationScopeClientBeginGenerateBenefitUtilizationSummariesReportOptions) (*runtime.Poller[ReservationScopeClientGenerateBenefitUtilizationSummariesReportResponse], error)`
      info	[Changelog] - New function `NewSavingsPlanOrderScopeClient(azcore.TokenCredential, *arm.ClientOptions) (*SavingsPlanOrderScopeClient, error)`
      info	[Changelog] - New function `*SavingsPlanOrderScopeClient.BeginGenerateBenefitUtilizationSummariesReport(context.Context, string, BenefitUtilizationSummariesRequest, *SavingsPlanOrderScopeClientBeginGenerateBenefitUtilizationSummariesReportOptions) (*runtime.Poller[SavingsPlanOrderScopeClientGenerateBenefitUtilizationSummariesReportResponse], error)`
      info	[Changelog] - New function `NewSavingsPlanScopeClient(azcore.TokenCredential, *arm.ClientOptions) (*SavingsPlanScopeClient, error)`
      info	[Changelog] - New function `*SavingsPlanScopeClient.BeginGenerateBenefitUtilizationSummariesReportAsync(context.Context, string, string, BenefitUtilizationSummariesRequest, *SavingsPlanScopeClientBeginGenerateBenefitUtilizationSummariesReportAsyncOptions) (*runtime.Poller[SavingsPlanScopeClientGenerateBenefitUtilizationSummariesReportAsyncResponse], error)`
      info	[Changelog] - New function `*SavingsPlanUtilizationSummary.GetBenefitUtilizationSummary() *BenefitUtilizationSummary`
      info	[Changelog] - New function `NewScheduledActionsClient(azcore.TokenCredential, *arm.ClientOptions) (*ScheduledActionsClient, error)`
      info	[Changelog] - New function `*ScheduledActionsClient.CheckNameAvailability(context.Context, CheckNameAvailabilityRequest, *ScheduledActionsClientCheckNameAvailabilityOptions) (ScheduledActionsClientCheckNameAvailabilityResponse, error)`
      info	[Changelog] - New function `*ScheduledActionsClient.CheckNameAvailabilityByScope(context.Context, string, CheckNameAvailabilityRequest, *ScheduledActionsClientCheckNameAvailabilityByScopeOptions) (ScheduledActionsClientCheckNameAvailabilityByScopeResponse, error)`
      info	[Changelog] - New function `*ScheduledActionsClient.CreateOrUpdate(context.Context, string, ScheduledAction, *ScheduledActionsClientCreateOrUpdateOptions) (ScheduledActionsClientCreateOrUpdateResponse, error)`
      info	[Changelog] - New function `*ScheduledActionsClient.CreateOrUpdateByScope(context.Context, string, string, ScheduledAction, *ScheduledActionsClientCreateOrUpdateByScopeOptions) (ScheduledActionsClientCreateOrUpdateByScopeResponse, error)`
      info	[Changelog] - New function `*ScheduledActionsClient.Delete(context.Context, string, *ScheduledActionsClientDeleteOptions) (ScheduledActionsClientDeleteResponse, error)`
      info	[Changelog] - New function `*ScheduledActionsClient.DeleteByScope(context.Context, string, string, *ScheduledActionsClientDeleteByScopeOptions) (ScheduledActionsClientDeleteByScopeResponse, error)`
      info	[Changelog] - New function `*ScheduledActionsClient.Get(context.Context, string, *ScheduledActionsClientGetOptions) (ScheduledActionsClientGetResponse, error)`
      info	[Changelog] - New function `*ScheduledActionsClient.GetByScope(context.Context, string, string, *ScheduledActionsClientGetByScopeOptions) (ScheduledActionsClientGetByScopeResponse, error)`
      info	[Changelog] - New function `*ScheduledActionsClient.NewListByScopePager(string, *ScheduledActionsClientListByScopeOptions) *runtime.Pager[ScheduledActionsClientListByScopeResponse]`
      info	[Changelog] - New function `*ScheduledActionsClient.NewListPager(*ScheduledActionsClientListOptions) *runtime.Pager[ScheduledActionsClientListResponse]`
      info	[Changelog] - New function `*ScheduledActionsClient.Run(context.Context, string, *ScheduledActionsClientRunOptions) (ScheduledActionsClientRunResponse, error)`
      info	[Changelog] - New function `*ScheduledActionsClient.RunByScope(context.Context, string, string, *ScheduledActionsClientRunByScopeOptions) (ScheduledActionsClientRunByScopeResponse, error)`
      info	[Changelog] - New function `*SharedScopeBenefitRecommendationProperties.GetBenefitRecommendationProperties() *BenefitRecommendationProperties`
      info	[Changelog] - New function `*SingleScopeBenefitRecommendationProperties.GetBenefitRecommendationProperties() *BenefitRecommendationProperties`
      info	[Changelog] - New struct `AllSavingsBenefitDetails`
      info	[Changelog] - New struct `AllSavingsList`
      info	[Changelog] - New struct `AsyncOperationStatusProperties`
      info	[Changelog] - New struct `BenefitRecommendationModel`
      info	[Changelog] - New struct `BenefitRecommendationsListResult`
      info	[Changelog] - New struct `BenefitResource`
      info	[Changelog] - New struct `BenefitUtilizationSummariesListResult`
      info	[Changelog] - New struct `BenefitUtilizationSummariesOperationStatus`
      info	[Changelog] - New struct `BenefitUtilizationSummariesRequest`
      info	[Changelog] - New struct `BenefitUtilizationSummaryProperties`
      info	[Changelog] - New struct `BlobInfo`
      info	[Changelog] - New struct `CheckNameAvailabilityRequest`
      info	[Changelog] - New struct `CheckNameAvailabilityResponse`
      info	[Changelog] - New struct `CostDetailsOperationResults`
      info	[Changelog] - New struct `CostDetailsTimePeriod`
      info	[Changelog] - New struct `ErrorDetailsWithNestedDetails`
      info	[Changelog] - New struct `ErrorResponseWithNestedDetails`
      info	[Changelog] - New struct `ExportRun`
      info	[Changelog] - New struct `ExportRunProperties`
      info	[Changelog] - New struct `FileDestination`
      info	[Changelog] - New struct `ForecastAggregation`
      info	[Changelog] - New struct `ForecastColumn`
      info	[Changelog] - New struct `ForecastComparisonExpression`
      info	[Changelog] - New struct `ForecastDatasetConfiguration`
      info	[Changelog] - New struct `ForecastFilter`
      info	[Changelog] - New struct `ForecastProperties`
      info	[Changelog] - New struct `ForecastResult`
      info	[Changelog] - New struct `ForecastTimePeriod`
      info	[Changelog] - New struct `GenerateCostDetailsReportErrorResponse`
      info	[Changelog] - New struct `GenerateCostDetailsReportRequestDefinition`
      info	[Changelog] - New struct `IncludedQuantityUtilizationSummary`
      info	[Changelog] - New struct `IncludedQuantityUtilizationSummaryProperties`
      info	[Changelog] - New struct `NotificationProperties`
      info	[Changelog] - New struct `OperationForCostManagement`
      info	[Changelog] - New struct `ProxyResourceForCostManagement`
      info	[Changelog] - New struct `RecommendationUsageDetails`
      info	[Changelog] - New struct `ReportManifest`
      info	[Changelog] - New struct `RequestContext`
      info	[Changelog] - New struct `ResourceForCostManagement`
      info	[Changelog] - New struct `SavingsPlanUtilizationSummary`
      info	[Changelog] - New struct `SavingsPlanUtilizationSummaryProperties`
      info	[Changelog] - New struct `ScheduleProperties`
      info	[Changelog] - New struct `ScheduledAction`
      info	[Changelog] - New struct `ScheduledActionListResult`
      info	[Changelog] - New struct `ScheduledActionProperties`
      info	[Changelog] - New struct `ScheduledActionProxyResource`
      info	[Changelog] - New struct `SharedScopeBenefitRecommendationProperties`
      info	[Changelog] - New struct `SingleScopeBenefitRecommendationProperties`
      info	[Changelog] - New struct `SystemData`
      info	[Changelog] - New field `ExpiryTime` in struct `DownloadURL`
      info	[Changelog] - New anonymous field `ForecastResult` in struct `ForecastClientExternalCloudProviderUsageResponse`
      info	[Changelog] - New anonymous field `ForecastResult` in struct `ForecastClientUsageResponse`
      info	[Changelog] - New field `EndTime`, `StartTime` in struct `GenerateDetailedCostReportOperationStatuses`
      info	[Changelog] - New field `ActionType`, `IsDataAction`, `Origin` in struct `Operation`
      info	[Changelog]
      info	[Changelog] Total 18 breaking change(s), 261 additive change(s).
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 2b1e2725f45df27813ddedcacf1197d9fedcc8b3. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.5
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.5>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-costmanagement [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation group BenefitRecommendationsOperations
      info	[Changelog]   - Added operation group BenefitUtilizationSummariesAsyncOperations
      info	[Changelog]   - Added operation group BenefitUtilizationSummariesOperations
      info	[Changelog]   - Added operation group BillingAccountScopeOperations
      info	[Changelog]   - Added operation group BillingProfileScopeOperations
      info	[Changelog]   - Added operation group GenerateCostDetailsReportOperations
      info	[Changelog]   - Added operation group GenerateDetailedCostReportOperationResultsOperations
      info	[Changelog]   - Added operation group GenerateDetailedCostReportOperationStatusOperations
      info	[Changelog]   - Added operation group GenerateDetailedCostReportOperations
      info	[Changelog]   - Added operation group PriceSheetOperations
      info	[Changelog]   - Added operation group ReservationOrderScopeOperations
      info	[Changelog]   - Added operation group ReservationScopeOperations
      info	[Changelog]   - Added operation group SavingsPlanOrderScopeOperations
      info	[Changelog]   - Added operation group SavingsPlanScopeOperations
      info	[Changelog]   - Added operation group ScheduledActionsOperations
      info	[Changelog]   - Model Alert has a new parameter e_tag
      info	[Changelog]   - Model AlertPropertiesDetails has a new parameter company_name
      info	[Changelog]   - Model AlertPropertiesDetails has a new parameter department_name
      info	[Changelog]   - Model AlertPropertiesDetails has a new parameter enrollment_end_date
      info	[Changelog]   - Model AlertPropertiesDetails has a new parameter enrollment_number
      info	[Changelog]   - Model AlertPropertiesDetails has a new parameter enrollment_start_date
      info	[Changelog]   - Model AlertPropertiesDetails has a new parameter invoicing_threshold
      info	[Changelog]   - Model CommonExportProperties has a new parameter next_run_time_estimate
      info	[Changelog]   - Model CommonExportProperties has a new parameter partition_data
      info	[Changelog]   - Model CommonExportProperties has a new parameter run_history
      info	[Changelog]   - Model Dimension has a new parameter e_tag
      info	[Changelog]   - Model Dimension has a new parameter location
      info	[Changelog]   - Model Dimension has a new parameter sku
      info	[Changelog]   - Model Export has a new parameter next_run_time_estimate
      info	[Changelog]   - Model Export has a new parameter partition_data
      info	[Changelog]   - Model Export has a new parameter run_history
      info	[Changelog]   - Model ExportDeliveryDestination has a new parameter sas_token
      info	[Changelog]   - Model ExportDeliveryDestination has a new parameter storage_account
      info	[Changelog]   - Model ExportProperties has a new parameter next_run_time_estimate
      info	[Changelog]   - Model ExportProperties has a new parameter partition_data
      info	[Changelog]   - Model ExportProperties has a new parameter run_history
      info	[Changelog]   - Model Operation has a new parameter action_type
      info	[Changelog]   - Model Operation has a new parameter is_data_action
      info	[Changelog]   - Model Operation has a new parameter origin
      info	[Changelog]   - Model OperationDisplay has a new parameter description
      info	[Changelog]   - Operation ExportsOperations.get has a new optional parameter expand
      info	[Changelog]   - Operation ExportsOperations.list has a new optional parameter expand
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model Alert no longer has parameter tags
      info	[Changelog]   - Model ProxyResource no longer has parameter e_tag
      info	[Changelog]   - Model ReportConfigFilter no longer has parameter tag_key
      info	[Changelog]   - Model ReportConfigFilter no longer has parameter tag_value
      info	[Changelog]   - Model Resource no longer has parameter tags
      info	[Changelog]   - Removed operation group SettingsOperations
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 2b1e2725f45df27813ddedcacf1197d9fedcc8b3. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️cost-management [View full logs]  [Preview Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs] Generate from 2b1e2725f45df27813ddedcacf1197d9fedcc8b3. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • Az.cost-management.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.cost-management.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 11, 2023

    Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

    @MattEberhart-MSFTE
    Copy link
    Contributor Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @MattEberhart-MSFTE MattEberhart-MSFTE marked this pull request as ready for review April 11, 2023 21:30
    @MattEberhart-MSFTE MattEberhart-MSFTE added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Apr 11, 2023
    @openapi-workflow-bot
    Copy link

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    @haolingdong-msft
    Copy link
    Member

    @tadelesh , @raych1 , please help review go breaking change.

    @haolingdong-msft
    Copy link
    Member

    @msyyc, please help review python breaking changes.

    @msyyc
    Copy link
    Member

    msyyc commented Apr 14, 2023

    approved for python breaking

    @MattEberhart-MSFTE MattEberhart-MSFTE added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Apr 24, 2023
    @pilor pilor added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Apr 24, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 24, 2023
    @MattEberhart-MSFTE MattEberhart-MSFTE added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 24, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Apr 24, 2023
    @pilor pilor added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Apr 25, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 25, 2023
    @MattEberhart-MSFTE MattEberhart-MSFTE added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 25, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Apr 25, 2023
    @AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-FixRequiredOnFailure labels Apr 26, 2023
    @openapi-workflow-bot
    Copy link

    Hi @MattEberhart-MSFTE, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi @MattEberhart-MSFTE, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @pilor pilor added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Apr 26, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 26, 2023
    @MattEberhart-MSFTE
    Copy link
    Contributor Author

    Hi @MattEberhart-MSFTE, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    This is not a breaking change. The breaking change was done in 2022-10-01 version and is being reverted. The 'code' property of the ErrorDetails object in common-types has been and should be a string. I've created a task https://msazure.visualstudio.com/One/_workitems/edit/19954184

    @mikekistler mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 1, 2023
    @v-xuto
    Copy link
    Member

    v-xuto commented May 4, 2023

    @MattEberhart-MSFTE Please resolve conflicting files.
    image

    @ArcturusZhang ArcturusZhang self-requested a review as a code owner May 5, 2023 14:51
    @MattEberhart-MSFTE
    Copy link
    Contributor Author

    This is the commit for which I have a merge conflict c2103f6#diff-376a5aea4b6207ec857b1c0d688b8a450cd0c392e28ff591e54909c21c76c685. I cherry picked this commit and resolved the conflicts, but I still see this branch has conflicts. The checks are not run and I do not have permissions to 'Resolve Conflicts' here
    image

    Please help @haolingdong-msft

    @ghost
    Copy link

    ghost commented May 21, 2023

    Hi, @MattEberhart-MSFTE. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    9 participants