Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacks/2022 08 01 preview #23482

Merged
merged 18 commits into from
Apr 28, 2023
Merged

Stacks/2022 08 01 preview #23482

Changes from 8 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
0bbb664
Added 2022-08 API Version files
Mar 16, 2023
b7d54b8
Added request changes
Mar 23, 2023
56cd96b
Missed some file
Mar 23, 2023
db7180e
changed to v3 types
Mar 29, 2023
c5ee0a4
Removed all snapshot references
Mar 29, 2023
ff32d7a
denySettings should be required
Apr 7, 2023
ada7fe4
Merge with main
Apr 7, 2023
6b6a145
Reverted ErrorResponse to v1 from V3
Apr 12, 2023
c724e82
Added denySettings to examples
Apr 20, 2023
38091ce
Fixed model errors
Apr 20, 2023
ea3d4e3
Fixed array model diff issue
Apr 20, 2023
7c96e4f
retrigger checks
Apr 20, 2023
a381fb6
Turned string into boolean for model validation + prettier fix
Apr 20, 2023
88ba813
Fixed prettier
Apr 20, 2023
b85d903
More prettier fixes
Apr 21, 2023
b204f95
retrigger checks
Apr 21, 2023
116f64d
reverted errorresponse back to V3
Apr 25, 2023
cd49c89
fix prettier
XiaofeiCao Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...ces/resource-manager/Microsoft.Resources/preview/2022-08-01-preview/deploymentStacks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,7 +772,8 @@
"DeploymentStackProperties": {
"type": "object",
"required": [
"actionOnUnmanage"
"actionOnUnmanage",
"denySettings"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has also been required for a while in our service. Given we are still in private preview, this change is something we have notified a limited set of customers about.

],
"description": "Deployment stack properties.",
"allOf": [
Expand Down Expand Up @@ -1129,7 +1130,7 @@
"type": "object",
"properties": {
"error": {
"$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorResponse"
"$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/ErrorResponse"
Copy link

@dantedallag dantedallag Apr 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The justification for this reversion is that both v2 and v3 versions generate an ErrorResponse object with a modified structure. Since ErrorResponse is shared, all swagger files in Microsoft.Resources need to be updated at the same time to v3.

This was found while building Microsoft.Azure.Management.Resources locally after the PR had been merged as Track1 generation is bypassed on the PR. We would like to delay upgrading this until we can upgrade all ErrorResponse objects in Microsoft.Resources to v3.

}
},
"description": "Deployment Stacks error response."
Expand Down