-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Databricks to add version stable/2023-05-01 #23470
[Hub Generated] Review request for Microsoft.Databricks to add version stable/2023-05-01 #23470
Conversation
…-10-01-preview to version 2023-05-01
Hi, @mvvsubbu Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/databricks/resource-manager/readme.md tag: specification/databricks/resource-manager/readme.md#tag-package-2023-05-01 |
️⌛
ApiReadinessCheck pending [Detail]
️⌛
~[Staging] ServiceAPIReadinessTest pending [Detail]
️🔄
SwaggerAPIView inProgress [Detail]
️⌛
CadlAPIView pending [Detail]
️⌛
TypeSpecAPIView pending [Detail]
️⌛
ModelValidation pending [Detail]
️⌛
SemanticValidation pending [Detail]
️⌛
PoliCheck pending [Detail]
️⌛
PrettierCheck pending [Detail]
️⌛
SpellCheck pending [Detail]
️⌛
Lint(RPaaS) pending [Detail]
️⌛
CadlValidation pending [Detail]
️⌛
TypeSpec Validation pending [Detail]
️⌛
PR Summary pending [Detail]
Swagger Generation Artifacts
|
Generated ApiView
|
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
Hi, @mvvsubbu your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
Hi @mvvsubbu, Your PR has some issues. Please fix the CI sequentially by following the order of
|
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@msyyc Please help to confirm the Python SDK breaking change. |
@live1206 service deployment is expected to be completed by end of month. don't merge it. |
@mvvsubbu |
@live1206 got it thanks for sharing this information. Yes our service changes are not deployed yet. I will rerun the validations once the deployment of service is done. |
Hi, @mvvsubbu. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@live1206 can you merge this PR, all the changes were deployed to production. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.