[Hub Generated] Review request for Microsoft.SqlVirtualMachine to add version preview/2023-01-01-preview #23469

lingxiao-microsoft · 2023-04-06T23:40:15Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

…ew/2022-08-01-preview to version 2023-01-01-preview

openapi-workflow-bot · 2023-04-06T23:40:18Z

Hi, @lingxiao-microsoft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2023-04-06T23:40:21Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌Breaking Change(Cross-Version): 7 Errors, 4 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
sqlvm.json	2023-01-01-preview(bf542d6)	2022-02-01(main)
sqlvm.json	2023-01-01-preview(bf542d6)	2022-08-01-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule	Message
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L800:9 Old: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L638:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L847:9 Old: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L686:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L921:9 Old: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L758:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L973:9 Old: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L803:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L749:9 Old: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L895:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L698:9 Old: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L939:11
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L2637:5 Old: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L2314:5

The following breaking changes are detected by comparison with the latest preview version:

Rule	Message
⚠️ 1019 - RemovedEnumValue	The new version is removing enum value(s) 'PRIMARY, SECONDARY' from the old version. New: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L1278:9 Old: Microsoft.SqlVirtualMachine/preview/2022-08-01-preview/sqlvm.json#L1278:9
⚠️ 1019 - RemovedEnumValue	The new version is removing enum value(s) 'SYNCHRONOUS_COMMIT, ASYNCHRONOUS_COMMIT' from the old version. New: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L1290:9 Old: Microsoft.SqlVirtualMachine/preview/2022-08-01-preview/sqlvm.json#L1290:9
⚠️ 1019 - RemovedEnumValue	The new version is removing enum value(s) 'AUTOMATIC, MANUAL' from the old version. New: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L1302:9 Old: Microsoft.SqlVirtualMachine/preview/2022-08-01-preview/sqlvm.json#L1302:9
⚠️ 1019 - RemovedEnumValue	The new version is removing enum value(s) 'NO, ALL, READ_ONLY' from the old version. New: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L1314:9 Old: Microsoft.SqlVirtualMachine/preview/2022-08-01-preview/sqlvm.json#L1314:9

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 4 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-preview-2023-01	package-preview-2023-01(bf542d6)	default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L1584
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L2169
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L2408
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L2463

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'sqlVirtualMachineGroupName' should be defined with a 'pattern' restriction. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L19
`❌` ResourceNameRestriction	The resource name parameter 'availabilityGroupListenerName' should be defined with a 'pattern' restriction. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L19
`❌` ResourceNameRestriction	The resource name parameter 'sqlVirtualMachineGroupName' should be defined with a 'pattern' restriction. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L215
`❌` OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.SqlVirtualMachine/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L279
`❌` ResourceNameRestriction	The resource name parameter 'sqlVirtualMachineGroupName' should be defined with a 'pattern' restriction. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L300
`❌` LroPatch202	The async patch operation should return 202. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L497
`❌` ResourceNameRestriction	The resource name parameter 'sqlVirtualMachineGroupName' should be defined with a 'pattern' restriction. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L603
`❌` PatchIdentityProperty	The patch operation body parameter schema should contains property 'identity'. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L980
`❌` LroPatch202	The async patch operation should return 202. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L996
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L1382
`❌` GuidUsage	Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L1741
`❌` GuidUsage	Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L1759
⚠️ PutRequestResponseScheme	A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'AvailabilityGroupListeners_CreateOrUpdate' Request Model: 'parameters[3].schema' Response Model: 'responses[200].schema' Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L78
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L1157
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L1431
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L1890
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L1919
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L1957
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L1961
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L1994
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L2063
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L2135
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L2220
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L2231
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L2235
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L2339
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L2358
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L2372
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L2376
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json#L2443

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️❌~[Staging] ServiceAPIReadinessTest: 9 Errors, 0 Warnings failed [Detail]

Tag package-preview-2023-01; Prod region: Deployed

Test run on region: westcentralus; Operation coverage: total: 21, untested: 0, failed: 9, passed: 12

Service API Readiness Test failed. Check pipeline artifact for detail report.

Rule	Message
`❌` CLIENT_ERROR	statusCode: 404, errorCode: ResourceDoesNotExist, errorMessage: Resource '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-qdZeJM-23469/providers/Microsoft.Compute/virtualMachines/sqlvirtuxbr1pl' does not exist. Source: runtime OperationId: SqlVirtualMachines_CreateOrUpdate
`❌` CLIENT_ERROR	statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.SqlVirtualMachine/SqlVirtualMachines/sqlvirtuxbr1pl' under resource group 'apiTest-qdZeJM-23469' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: SqlVirtualMachines_Get
`❌` CLIENT_ERROR	statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.SqlVirtualMachine/SqlVirtualMachines/sqlvirtuxbr1pl' under resource group 'apiTest-qdZeJM-23469' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: SqlVirtualMachines_Update
`❌` CLIENT_ERROR	statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.SqlVirtualMachine/SqlVirtualMachines/sqlvirtuxbr1pl' under resource group 'apiTest-qdZeJM-23469' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: SqlVirtualMachines_Redeploy
`❌` CLIENT_ERROR	statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.SqlVirtualMachine/SqlVirtualMachines/sqlvirtuxbr1pl' under resource group 'apiTest-qdZeJM-23469' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: SqlVirtualMachines_StartAssessment
`❌` CLIENT_ERROR	statusCode: 400, errorCode: SqlVmNotInGroup, errorMessage: SqlVirtualMachine '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-qdZeJM-23469/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm2' is not part of the SQL virtual machine group 'sqlvirtu6zuy5f'. Source: runtime OperationId: AvailabilityGroupListeners_CreateOrUpdate
`❌` CLIENT_ERROR	statusCode: 404, errorCode: ResourceNotFound, errorMessage: The requested resource of type 'Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/availabilityGroupListeners' with name 'availabi3jywr9' was not found. Source: runtime OperationId: AvailabilityGroupListeners_Get
`❌` CLIENT_ERROR	statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.SqlVirtualMachine/SqlVirtualMachines/sqlvirtuxbr1pl' under resource group 'apiTest-qdZeJM-23469' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: SqlVirtualMachineTroubleshoot_Troubleshoot
`❌` CLIENT_ERROR	statusCode: 400, errorCode: SqlVmGroupDoesNotHaveAGListener, errorMessage: SQL virtual machine group 'subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-qdZeJM-23469/providers/Microsoft.SqlVirtualMachine/SqlVirtualMachineGroups/sqlvirtu6zuy5f' does not have availability group listener 'availabi3jywr9'. Source: runtime OperationId: AvailabilityGroupListeners_Delete

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-06T23:40:21Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/sqlvirtualmachine/armsqlvirtualmachine - Approved - 0.9.0

+	`CommitASYNCHRONOUSCOMMIT`, `CommitSYNCHRONOUSCOMMIT` from enum `Commit` has been removed
+	`FailoverAUTOMATIC`, `FailoverMANUAL` from enum `Failover` has been removed
+	`ReadableSecondaryALL`, `ReadableSecondaryNO`, `ReadableSecondaryREADONLY` from enum `ReadableSecondary` has been removed
+	`RolePRIMARY`, `RoleSECONDARY` from enum `Role` has been removed

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from b73e2d3. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.SqlVirtualMachine [View full logs] [Release SDK Changes]
- Azure.ResourceManager.SqlVirtualMachine.1.1.0-alpha.20230426.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from b73e2d3. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.5
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.5>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-sqlvirtualmachine [View full logs] [Release SDK Changes]
- azure-mgmt-sqlvirtualmachine-1.0.0b1.zip
- azure_mgmt_sqlvirtualmachine-1.0.0b1-py3-none-any.whl
```
info	[Changelog] change log generation failed!!!
```

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from b73e2d3. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/sqlvirtualmachine/armsqlvirtualmachine [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - `CommitASYNCHRONOUSCOMMIT`, `CommitSYNCHRONOUSCOMMIT` from enum `Commit` has been removed
info	[Changelog] - `FailoverAUTOMATIC`, `FailoverMANUAL` from enum `Failover` has been removed
info	[Changelog] - `ReadableSecondaryALL`, `ReadableSecondaryNO`, `ReadableSecondaryREADONLY` from enum `ReadableSecondary` has been removed
info	[Changelog] - `RolePRIMARY`, `RoleSECONDARY` from enum `Role` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `CommitAsynchronousCommit`, `CommitSynchronousCommit` added to enum type `Commit`
info	[Changelog] - New value `FailoverAutomatic`, `FailoverManual` added to enum type `Failover`
info	[Changelog] - New value `LeastPrivilegeModeNotSet` added to enum type `LeastPrivilegeMode`
info	[Changelog] - New value `ReadableSecondaryAll`, `ReadableSecondaryNo`, `ReadableSecondaryReadOnly` added to enum type `ReadableSecondary`
info	[Changelog] - New value `RolePrimary`, `RoleSecondary` added to enum type `Role`
info	[Changelog] - New enum type `TroubleshootingScenario` with values `TroubleshootingScenarioUnhealthyReplica`
info	[Changelog] - New function `*ClientFactory.NewTroubleshootClient() *TroubleshootClient`
info	[Changelog] - New function `NewTroubleshootClient(string, azcore.TokenCredential, *arm.ClientOptions) (*TroubleshootClient, error)`
info	[Changelog] - New function `*TroubleshootClient.BeginTroubleshoot(context.Context, string, string, SQLVMTroubleshooting, *TroubleshootClientBeginTroubleshootOptions) (*runtime.Poller[TroubleshootClientTroubleshootResponse], error)`
info	[Changelog] - New struct `AADAuthenticationSettings`
info	[Changelog] - New struct `SQLVMTroubleshooting`
info	[Changelog] - New struct `TroubleshootingAdditionalProperties`
info	[Changelog] - New struct `TroubleshootingStatus`
info	[Changelog] - New struct `UnhealthyReplicaInfo`
info	[Changelog] - New field `TroubleshootingStatus` in struct `Properties`
info	[Changelog] - New field `UseStoragePool` in struct `SQLStorageSettings`
info	[Changelog] - New field `UseStoragePool` in struct `SQLTempDbSettings`
info	[Changelog] - New field `AzureAdAuthenticationSettings` in struct `ServerConfigurationsManagementSettings`
info	[Changelog] - New field `EnableStorageConfigBlade` in struct `StorageConfigurationSettings`
info	[Changelog] - New field `IsSQLServiceAccountGmsa` in struct `WsfcDomainProfile`
info	[Changelog]
info	[Changelog] Total 9 breaking change(s), 31 additive change(s).

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from b73e2d3. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-sqlvirtualmachine [View full logs] [Release SDK Changes]

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from b73e2d3. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️sqlvirtualmachine [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from b73e2d3. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

❌Az.sqlvirtualmachine.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.sqlvirtualmachine.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-06T23:40:22Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/sqlvirtualmachine/armsqlvirtualmachine	https://apiview.dev/Assemblies/Review/4632d501fb5f45908f142e2e9a6c03f8
Java	azure-resourcemanager-sqlvirtualmachine	https://apiview.dev/Assemblies/Review/96217f2889a64adab10947246fc9f790
.Net	Azure.ResourceManager.SqlVirtualMachine	https://apiview.dev/Assemblies/Review/0314ad07540f4be19f93424b2ae7f11b

openapi-workflow-bot · 2023-04-07T18:38:55Z

Hi @lingxiao-microsoft, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

lingxiao-microsoft · 2023-04-10T20:31:49Z

/azp run unifiedPipeline

lingxiao-microsoft · 2023-04-11T18:25:42Z

Hello team,

please kindly let me know if there is anything needs to be taken care of for this PR.

Submitted for review as passed validation

lingxiao-microsoft · 2023-04-17T16:57:21Z

Hello @chunyu3, could you please take a look and let me know what else is needed from my side? Thank you

Please see above for all passed validations

chunyu3 · 2023-04-21T05:44:17Z

/azp run

azure-pipelines · 2023-04-21T05:44:27Z

Azure Pipelines successfully started running 1 pipeline(s).

chunyu3 · 2023-04-24T02:06:45Z

Breaking change 1036-constraintChange has been approved in #21422. So approve for this PR.

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json

openapi-workflow-bot · 2023-04-24T04:58:38Z

Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

lingxiao-microsoft and others added 4 commits April 4, 2023 13:36

Adds base for updating Microsoft.SqlVirtualMachine from version previ…

9932b7f

…ew/2022-08-01-preview to version 2023-01-01-preview

Updates readme

df4281a

Updates API version in new specs and examples

dbc2fba

initial commit for submitting generated swagger for new API version

9e8967c

openapi-pipeline-app bot added the CI-BreakingChange-Go label Apr 6, 2023

AzureRestAPISpecReview added new-api-version resource-manager labels Apr 6, 2023

lingxiao-microsoft added 4 commits April 6, 2023 17:03

changed the API version to match latest

78c3363

fixed headers missing in 202 response

580ccef

added x-ms-identifiers

12beb3b

fixed casing issue for azureAaAuthenticationSettings

7d5174f

AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Apr 7, 2023

lingxiao-microsoft added 6 commits April 7, 2023 11:46

fixed typo

0c29f80

added missing systemData

e31cc2a

fixed IdentityType

eb904c9

fixed Swagger PrettierCheck

d05d705

added schema to error response

30c65ac

format fixed

a88c529

lingxiao-microsoft marked this pull request as ready for review April 11, 2023 18:23

openapi-assignment-bot bot assigned chunyu3 Apr 11, 2023

fixing spell check

622ad02

AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test labels Apr 20, 2023

changed the case issue

bf542d6

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 24, 2023

pilor reviewed Apr 24, 2023

View reviewed changes

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2023-01-01-preview/sqlvm.json Show resolved Hide resolved

pilor added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Apr 24, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 24, 2023

pilor added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Apr 24, 2023

openapi-workflow-bot bot removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Apr 24, 2023

tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Apr 26, 2023

chunyu3 approved these changes Apr 26, 2023

View reviewed changes

chunyu3 merged commit b73e2d3 into main Apr 26, 2023

chunyu3 deleted the lingxiao-microsoft-sqlvirtualmachine-Microsoft.SqlVirtualMachine-2023-01-01-preview branch April 26, 2023 02:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.SqlVirtualMachine to add version preview/2023-01-01-preview #23469

[Hub Generated] Review request for Microsoft.SqlVirtualMachine to add version preview/2023-01-01-preview #23469

lingxiao-microsoft commented Apr 6, 2023 •

edited

Loading

openapi-workflow-bot bot commented Apr 6, 2023

openapi-pipeline-app bot commented Apr 6, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 6, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Apr 6, 2023 •

edited

Loading

openapi-workflow-bot bot commented Apr 7, 2023

lingxiao-microsoft commented Apr 10, 2023

lingxiao-microsoft commented Apr 11, 2023

lingxiao-microsoft commented Apr 17, 2023

chunyu3 commented Apr 21, 2023

azure-pipelines bot commented Apr 21, 2023

chunyu3 commented Apr 24, 2023

openapi-workflow-bot bot commented Apr 24, 2023

[Hub Generated] Review request for Microsoft.SqlVirtualMachine to add version preview/2023-01-01-preview #23469

[Hub Generated] Review request for Microsoft.SqlVirtualMachine to add version preview/2023-01-01-preview #23469

Conversation

lingxiao-microsoft commented Apr 6, 2023 • edited Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Apr 6, 2023

openapi-pipeline-app bot commented Apr 6, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Apr 6, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Apr 6, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Apr 7, 2023

lingxiao-microsoft commented Apr 10, 2023

lingxiao-microsoft commented Apr 11, 2023

lingxiao-microsoft commented Apr 17, 2023

chunyu3 commented Apr 21, 2023

azure-pipelines bot commented Apr 21, 2023

chunyu3 commented Apr 24, 2023

openapi-workflow-bot bot commented Apr 24, 2023

lingxiao-microsoft commented Apr 6, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 6, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 6, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 6, 2023 •

edited

Loading