Add 202 status code for PrivateEndpointConnections_Delete #23404

priyankarking · 2023-04-03T10:42:36Z

…and update response examples

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[x] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2023-04-03T10:42:40Z

Hi, @priyankarking Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2023-04-03T10:42:42Z

Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
redisenterprise.json	2022-01-01(4fbe6a3)	2022-01-01(main)

Rule	Message
`❌` 1011 - AddingResponseCode	The new version adds a response code '202'. New: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L1073:11
`❌` 1044 - XmsLongRunningOperationChanged	The new version has a different 'x-ms-longrunning-operation' value than the previous one. New: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L1037:7 Old: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L1037:7

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-2022-01	package-2022-01(4fbe6a3)	package-2022-01(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L115
`❌` CreateOperationAsyncResponseValidation	An async PUT operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'azure-async-operation' on 'x-ms-long-running-operation-options' Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L116
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L220
`❌` DeleteOperationAsyncResponseValidation	An async DELETE operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options' Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L231
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L264
`❌` ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L400
`❌` ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L446
`❌` ResourceNameRestriction	The resource name parameter 'databaseName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L446
`❌` CreateOperationAsyncResponseValidation	An async PUT operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'azure-async-operation' on 'x-ms-long-running-operation-options' Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L447
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L562
`❌` DeleteOperationAsyncResponseValidation	An async DELETE operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options' Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L617
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L654
`❌` ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L669
`❌` ResourceNameRestriction	The resource name parameter 'databaseName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L669
`❌` ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L715
`❌` ResourceNameRestriction	The resource name parameter 'databaseName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L715
`❌` PostOperationAsyncResponseValidation	An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options' Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L716
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L765
`❌` ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L777
`❌` ResourceNameRestriction	The resource name parameter 'databaseName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L777
`❌` PostOperationAsyncResponseValidation	An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options' Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L778
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L824
`❌` ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L836
`❌` ResourceNameRestriction	The resource name parameter 'databaseName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L836
`❌` PostOperationAsyncResponseValidation	An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options' Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L837
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L883
`❌` GetCollectionResponseSchema	The response in the GET collection operation 'PrivateEndpointConnections_List' does not match the response definition in the individual GET operation 'PrivateEndpointConnections_Get' . Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L895
`❌` ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L895
`❌` ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L940
`❌` ResourceNameRestriction	The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction. Location: Microsoft.Cache/stable/2022-01-01/redisenterprise.json#L940

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-03T10:42:43Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/redisenterprise/armredisenterprise - Approved - 1.1.0-beta.2

-	Operation `*PrivateEndpointConnectionsClient.Delete` has been changed to LRO, use `*PrivateEndpointConnectionsClient.BeginDelete` instead.

❌azure-sdk-for-python-track2 - track2_azure-mgmt-redisenterprise - Approved - 2.1.0b1

-	Renamed operation PrivateEndpointConnectionsOperations.delete to PrivateEndpointConnectionsOperations.begin_delete

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 1198b4b. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.RedisEnterprise [View full logs] [Release SDK Changes]
- Azure.ResourceManager.RedisEnterprise.1.1.0-alpha.20230411.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 1198b4b. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]  notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.4
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.4>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-redisenterprise [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation DatabasesOperations.begin_flush
info	[Changelog]   - Added operation group SkusOperations
info	[Changelog]   - Model Cluster has a new parameter encryption
info	[Changelog]   - Model Cluster has a new parameter identity
info	[Changelog]   - Model Cluster has a new parameter system_data
info	[Changelog]   - Model ClusterUpdate has a new parameter encryption
info	[Changelog]   - Model ClusterUpdate has a new parameter identity
info	[Changelog]   - Model Database has a new parameter system_data
info	[Changelog]   - Model PrivateEndpointConnection has a new parameter system_data
info	[Changelog]   - Model PrivateLinkResource has a new parameter system_data
info	[Changelog]   - Model ProxyResource has a new parameter system_data
info	[Changelog]   - Model Resource has a new parameter system_data
info	[Changelog]   - Model TrackedResource has a new parameter system_data
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Renamed operation PrivateEndpointConnectionsOperations.delete to PrivateEndpointConnectionsOperations.begin_delete

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 1198b4b. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-redisenterprise [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 1198b4b. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/redisenterprise/armredisenterprise [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Operation `*PrivateEndpointConnectionsClient.Delete` has been changed to LRO, use `*PrivateEndpointConnectionsClient.BeginDelete` instead.
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `CmkIdentityType` with values `CmkIdentityTypeSystemAssignedIdentity`, `CmkIdentityTypeUserAssignedIdentity`
info	[Changelog] - New enum type `CreatedByType` with values `CreatedByTypeApplication`, `CreatedByTypeKey`, `CreatedByTypeManagedIdentity`, `CreatedByTypeUser`
info	[Changelog] - New enum type `ManagedServiceIdentityType` with values `ManagedServiceIdentityTypeNone`, `ManagedServiceIdentityTypeSystemAssigned`, `ManagedServiceIdentityTypeSystemAssignedUserAssigned`, `ManagedServiceIdentityTypeUserAssigned`
info	[Changelog] - New function `*ClientFactory.NewSKUsClient() *SKUsClient`
info	[Changelog] - New function `*DatabasesClient.BeginFlush(context.Context, string, string, string, FlushParameters, *DatabasesClientBeginFlushOptions) (*runtime.Poller[DatabasesClientFlushResponse], error)`
info	[Changelog] - New function `NewSKUsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*SKUsClient, error)`
info	[Changelog] - New function `*SKUsClient.NewListPager(string, *SKUsClientListOptions) *runtime.Pager[SKUsClientListResponse]`
info	[Changelog] - New function `timeRFC3339.MarshalText() ([]byte, error)`
info	[Changelog] - New function `*timeRFC3339.Parse(string) error`
info	[Changelog] - New function `*timeRFC3339.UnmarshalText([]byte) error`
info	[Changelog] - New struct `Capability`
info	[Changelog] - New struct `ClusterPropertiesEncryption`
info	[Changelog] - New struct `ClusterPropertiesEncryptionCustomerManagedKeyEncryption`
info	[Changelog] - New struct `ClusterPropertiesEncryptionCustomerManagedKeyEncryptionKeyIdentity`
info	[Changelog] - New struct `FlushParameters`
info	[Changelog] - New struct `LocationInfo`
info	[Changelog] - New struct `ManagedServiceIdentity`
info	[Changelog] - New struct `RegionSKUDetail`
info	[Changelog] - New struct `RegionSKUDetails`
info	[Changelog] - New struct `SKUDetail`
info	[Changelog] - New struct `SystemData`
info	[Changelog] - New struct `UserAssignedIdentity`
info	[Changelog] - New field `Identity` in struct `Cluster`
info	[Changelog] - New field `SystemData` in struct `Cluster`
info	[Changelog] - New field `Encryption` in struct `ClusterProperties`
info	[Changelog] - New field `Identity` in struct `ClusterUpdate`
info	[Changelog] - New field `SystemData` in struct `Database`
info	[Changelog] - New field `SystemData` in struct `PrivateEndpointConnection`
info	[Changelog] - New field `SystemData` in struct `PrivateLinkResource`
info	[Changelog] - New field `SystemData` in struct `ProxyResource`
info	[Changelog] - New field `SystemData` in struct `Resource`
info	[Changelog] - New field `SystemData` in struct `TrackedResource`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 53 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 1198b4b. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-redisenterprisecache [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-redisenterprisecache-3.0.0-beta.1.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group Skus
info	[Changelog]   - Added operation Databases.beginFlush
info	[Changelog]   - Added operation Databases.beginFlushAndWait
info	[Changelog]   - Added operation PrivateEndpointConnections.beginDelete
info	[Changelog]   - Added operation PrivateEndpointConnections.beginDeleteAndWait
info	[Changelog]   - Added Interface Capability
info	[Changelog]   - Added Interface ClusterPropertiesEncryption
info	[Changelog]   - Added Interface ClusterPropertiesEncryptionCustomerManagedKeyEncryption
info	[Changelog]   - Added Interface ClusterPropertiesEncryptionCustomerManagedKeyEncryptionKeyIdentity
info	[Changelog]   - Added Interface DatabasesFlushHeaders
info	[Changelog]   - Added Interface DatabasesFlushOptionalParams
info	[Changelog]   - Added Interface FlushParameters
info	[Changelog]   - Added Interface LocationInfo
info	[Changelog]   - Added Interface ManagedServiceIdentity
info	[Changelog]   - Added Interface PrivateEndpointConnectionsDeleteHeaders
info	[Changelog]   - Added Interface RegionSkuDetail
info	[Changelog]   - Added Interface RegionSkuDetails
info	[Changelog]   - Added Interface SkuDetail
info	[Changelog]   - Added Interface SkusListOptionalParams
info	[Changelog]   - Added Interface SystemData
info	[Changelog]   - Added Interface UserAssignedIdentity
info	[Changelog]   - Added Type Alias CmkIdentityType
info	[Changelog]   - Added Type Alias CreatedByType
info	[Changelog]   - Added Type Alias ManagedServiceIdentityType
info	[Changelog]   - Added Type Alias SkusListResponse
info	[Changelog]   - Interface Cluster has a new optional parameter encryption
info	[Changelog]   - Interface Cluster has a new optional parameter identity
info	[Changelog]   - Interface ClusterUpdate has a new optional parameter encryption
info	[Changelog]   - Interface ClusterUpdate has a new optional parameter identity
info	[Changelog]   - Interface PrivateEndpointConnectionsDeleteOptionalParams has a new optional parameter resumeFrom
info	[Changelog]   - Interface PrivateEndpointConnectionsDeleteOptionalParams has a new optional parameter updateIntervalInMs
info	[Changelog]   - Interface Resource has a new optional parameter systemData
info	[Changelog]   - Added Enum KnownCmkIdentityType
info	[Changelog]   - Added Enum KnownCreatedByType
info	[Changelog]   - Added Enum KnownManagedServiceIdentityType
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Removed operation PrivateEndpointConnections.delete

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 1198b4b. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️redisenterprise [View full logs]

️❌ azure-powershell failed [Detail]

❌Failed [Logs]Release - Generate from 1198b4b. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

❌Az.redisenterprise.DefaultTag [View full logs] [Release SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-03T10:42:44Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/redisenterprise/armredisenterprise	https://apiview.dev/Assemblies/Review/5cb3d6e96f9c48ca9312e5a7fba23071
Java	azure-resourcemanager-redisenterprise	https://apiview.dev/Assemblies/Review/00053a34362e4f56aa2e2fcced5a1f8f
.Net	Azure.ResourceManager.RedisEnterprise	There is no API change compared with the previous version
JavaScript	@azure/arm-redisenterprisecache	https://apiview.dev/Assemblies/Review/7ddce152f45b415383bac66fd428450c

openapi-workflow-bot · 2023-04-03T10:49:41Z

Hi @priyankarking, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

...ache/preview/2023-03-01-preview/examples/RedisEnterpriseDeletePrivateEndpointConnection.json

msyyc · 2023-04-10T06:57:12Z

@MaryGao @tadelesh please help confirm sdk breaking

MaryGao · 2023-04-10T07:21:26Z

@msyyc I don't think we have JS braking...

Co-authored-by: Priyankar Gupta <[email protected]>

openapi-assignment-bot bot assigned msyyc Apr 3, 2023

openapi-workflow-bot bot added the FixS360 label Apr 3, 2023

priyankarking requested a review from revanthballa1188 April 3, 2023 10:42

priyankarking requested a review from TimLovellSmith April 3, 2023 10:43

azure-sdk mentioned this pull request Apr 3, 2023

[AutoPR sdk/resourcemanager/redisenterprise/armredisenterprise] Add 202 status code for PrivateEndpointConnections_Delete azure-sdk/azure-sdk-for-go#5179

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Apr 3, 2023

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager labels Apr 3, 2023

azure-sdk mentioned this pull request Apr 3, 2023

[AutoPR track2_azure-mgmt-redisenterprise] Add 202 status code for PrivateEndpointConnections_Delete azure-sdk/azure-sdk-for-python#3201

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Apr 3, 2023

azure-sdk mentioned this pull request Apr 3, 2023

[AutoPR @azure/arm-redisenterprisecache] Add 202 status code for PrivateEndpointConnections_Delete azure-sdk/azure-sdk-for-js#4652

Closed

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Apr 3, 2023

TimLovellSmith reviewed Apr 4, 2023

View reviewed changes

...ache/preview/2023-03-01-preview/examples/RedisEnterpriseDeletePrivateEndpointConnection.json Outdated Show resolved Hide resolved

priyankarking force-pushed the priyankarking-redisenterprise-Microsoft.Cache-2022-01-01 branch from 18a963a to ae59724 Compare April 5, 2023 10:42

mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Apr 5, 2023

TimLovellSmith added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Apr 5, 2023

TimLovellSmith approved these changes Apr 5, 2023

View reviewed changes

Add 202 status code for PrivateEndpointConnections_Delete

4fbe6a3

priyankarking force-pushed the priyankarking-redisenterprise-Microsoft.Cache-2022-01-01 branch from ae59724 to 4fbe6a3 Compare April 10, 2023 05:58

msyyc added the Approved-SdkBreakingChange-Python label Apr 10, 2023

tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Apr 10, 2023

msyyc merged commit 1198b4b into main Apr 11, 2023

msyyc deleted the priyankarking-redisenterprise-Microsoft.Cache-2022-01-01 branch April 11, 2023 01:55

JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023

Add 202 status code for PrivateEndpointConnections_Delete (Azure#23404)

0f6aabc

Co-authored-by: Priyankar Gupta <[email protected]>

Alancere mentioned this pull request Feb 21, 2024

[Release] sdk/resourcemanager/redisenterprise/armredisenterprise/2.0.0 Azure/azure-sdk-for-go#22423

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 202 status code for PrivateEndpointConnections_Delete #23404

Add 202 status code for PrivateEndpointConnections_Delete #23404

priyankarking commented Apr 3, 2023

openapi-workflow-bot bot commented Apr 3, 2023

openapi-pipeline-app bot commented Apr 3, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 3, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Apr 3, 2023 •

edited

Loading

openapi-workflow-bot bot commented Apr 3, 2023

msyyc commented Apr 10, 2023

MaryGao commented Apr 10, 2023

Add 202 status code for PrivateEndpointConnections_Delete #23404

Add 202 status code for PrivateEndpointConnections_Delete #23404

Conversation

priyankarking commented Apr 3, 2023

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Apr 3, 2023

openapi-pipeline-app bot commented Apr 3, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Apr 3, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Apr 3, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Apr 3, 2023

msyyc commented Apr 10, 2023

MaryGao commented Apr 10, 2023

openapi-pipeline-app bot commented Apr 3, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 3, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 3, 2023 •

edited

Loading