Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 202 status code for PrivateEndpointConnections_Delete #23403

Conversation

priyankarking
Copy link
Contributor

…and update response examples

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[x] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @priyankarking Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 3, 2023

    Swagger Validation Report

    ️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    redisenterprise.json 2022-11-01-preview(d02057c) 2022-11-01-preview(main)
    Rule Message
    1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L1073:11
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L1037:7
    Old: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L1037:7
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-preview-2022-11 package-preview-2022-11(d02057c) package-preview-2022-11(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L115
    CreateOperationAsyncResponseValidation An async PUT operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'azure-async-operation' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L116
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L220
    DeleteOperationAsyncResponseValidation An async DELETE operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L231
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L264
    ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L400
    ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L446
    ResourceNameRestriction The resource name parameter 'databaseName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L446
    CreateOperationAsyncResponseValidation An async PUT operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'azure-async-operation' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L447
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L562
    DeleteOperationAsyncResponseValidation An async DELETE operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L617
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L654
    ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L669
    ResourceNameRestriction The resource name parameter 'databaseName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L669
    ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L715
    ResourceNameRestriction The resource name parameter 'databaseName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L715
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L765
    ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L777
    ResourceNameRestriction The resource name parameter 'databaseName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L777
    PostOperationAsyncResponseValidation An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L778
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L824
    ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L836
    ResourceNameRestriction The resource name parameter 'databaseName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L836
    PostOperationAsyncResponseValidation An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L837
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L883
    GetCollectionResponseSchema The response in the GET collection operation 'PrivateEndpointConnections_List' does not match the response definition in the individual GET operation 'PrivateEndpointConnections_Get' .
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L895
    ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L895
    ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L940
    ResourceNameRestriction The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L940
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2022-11-01-preview/redisenterprise.json#L984
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 3, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking




    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a1ecc18. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.4
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.4>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-redisenterprise [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation DatabasesOperations.begin_flush
      info	[Changelog]   - Added operation group SkusOperations
      info	[Changelog]   - Model Cluster has a new parameter encryption
      info	[Changelog]   - Model Cluster has a new parameter identity
      info	[Changelog]   - Model Cluster has a new parameter system_data
      info	[Changelog]   - Model ClusterUpdate has a new parameter encryption
      info	[Changelog]   - Model ClusterUpdate has a new parameter identity
      info	[Changelog]   - Model Database has a new parameter system_data
      info	[Changelog]   - Model PrivateEndpointConnection has a new parameter system_data
      info	[Changelog]   - Model PrivateLinkResource has a new parameter system_data
      info	[Changelog]   - Model ProxyResource has a new parameter system_data
      info	[Changelog]   - Model Resource has a new parameter system_data
      info	[Changelog]   - Model TrackedResource has a new parameter system_data
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from a1ecc18. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/redisenterprise/armredisenterprise [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New enum type `CmkIdentityType` with values `CmkIdentityTypeSystemAssignedIdentity`, `CmkIdentityTypeUserAssignedIdentity`
      info	[Changelog] - New enum type `CreatedByType` with values `CreatedByTypeApplication`, `CreatedByTypeKey`, `CreatedByTypeManagedIdentity`, `CreatedByTypeUser`
      info	[Changelog] - New enum type `ManagedServiceIdentityType` with values `ManagedServiceIdentityTypeNone`, `ManagedServiceIdentityTypeSystemAssigned`, `ManagedServiceIdentityTypeSystemAssignedUserAssigned`, `ManagedServiceIdentityTypeUserAssigned`
      info	[Changelog] - New function `*ClientFactory.NewSKUsClient() *SKUsClient`
      info	[Changelog] - New function `*DatabasesClient.BeginFlush(context.Context, string, string, string, FlushParameters, *DatabasesClientBeginFlushOptions) (*runtime.Poller[DatabasesClientFlushResponse], error)`
      info	[Changelog] - New function `NewSKUsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*SKUsClient, error)`
      info	[Changelog] - New function `*SKUsClient.NewListPager(string, *SKUsClientListOptions) *runtime.Pager[SKUsClientListResponse]`
      info	[Changelog] - New function `timeRFC3339.MarshalText() ([]byte, error)`
      info	[Changelog] - New function `*timeRFC3339.Parse(string) error`
      info	[Changelog] - New function `*timeRFC3339.UnmarshalText([]byte) error`
      info	[Changelog] - New struct `Capability`
      info	[Changelog] - New struct `ClusterPropertiesEncryption`
      info	[Changelog] - New struct `ClusterPropertiesEncryptionCustomerManagedKeyEncryption`
      info	[Changelog] - New struct `ClusterPropertiesEncryptionCustomerManagedKeyEncryptionKeyIdentity`
      info	[Changelog] - New struct `FlushParameters`
      info	[Changelog] - New struct `LocationInfo`
      info	[Changelog] - New struct `ManagedServiceIdentity`
      info	[Changelog] - New struct `RegionSKUDetail`
      info	[Changelog] - New struct `RegionSKUDetails`
      info	[Changelog] - New struct `SKUDetail`
      info	[Changelog] - New struct `SystemData`
      info	[Changelog] - New struct `UserAssignedIdentity`
      info	[Changelog] - New field `Identity` in struct `Cluster`
      info	[Changelog] - New field `SystemData` in struct `Cluster`
      info	[Changelog] - New field `Encryption` in struct `ClusterProperties`
      info	[Changelog] - New field `Identity` in struct `ClusterUpdate`
      info	[Changelog] - New field `SystemData` in struct `Database`
      info	[Changelog] - New field `SystemData` in struct `PrivateEndpointConnection`
      info	[Changelog] - New field `SystemData` in struct `PrivateLinkResource`
      info	[Changelog] - New field `SystemData` in struct `ProxyResource`
      info	[Changelog] - New field `SystemData` in struct `Resource`
      info	[Changelog] - New field `SystemData` in struct `TrackedResource`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 53 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from a1ecc18. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-redisenterprisecache [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group Skus
      info	[Changelog]   - Added operation Databases.beginFlush
      info	[Changelog]   - Added operation Databases.beginFlushAndWait
      info	[Changelog]   - Added Interface Capability
      info	[Changelog]   - Added Interface ClusterPropertiesEncryption
      info	[Changelog]   - Added Interface ClusterPropertiesEncryptionCustomerManagedKeyEncryption
      info	[Changelog]   - Added Interface ClusterPropertiesEncryptionCustomerManagedKeyEncryptionKeyIdentity
      info	[Changelog]   - Added Interface DatabasesFlushHeaders
      info	[Changelog]   - Added Interface DatabasesFlushOptionalParams
      info	[Changelog]   - Added Interface FlushParameters
      info	[Changelog]   - Added Interface LocationInfo
      info	[Changelog]   - Added Interface ManagedServiceIdentity
      info	[Changelog]   - Added Interface RegionSkuDetail
      info	[Changelog]   - Added Interface RegionSkuDetails
      info	[Changelog]   - Added Interface SkuDetail
      info	[Changelog]   - Added Interface SkusListOptionalParams
      info	[Changelog]   - Added Interface SystemData
      info	[Changelog]   - Added Interface UserAssignedIdentity
      info	[Changelog]   - Added Type Alias CmkIdentityType
      info	[Changelog]   - Added Type Alias CreatedByType
      info	[Changelog]   - Added Type Alias ManagedServiceIdentityType
      info	[Changelog]   - Added Type Alias SkusListResponse
      info	[Changelog]   - Interface Cluster has a new optional parameter encryption
      info	[Changelog]   - Interface Cluster has a new optional parameter identity
      info	[Changelog]   - Interface ClusterUpdate has a new optional parameter encryption
      info	[Changelog]   - Interface ClusterUpdate has a new optional parameter identity
      info	[Changelog]   - Interface Resource has a new optional parameter systemData
      info	[Changelog]   - Added Enum KnownCmkIdentityType
      info	[Changelog]   - Added Enum KnownCreatedByType
      info	[Changelog]   - Added Enum KnownManagedServiceIdentityType
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a1ecc18. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️redisenterprise [View full logs
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from a1ecc18. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.redisenterprise.DefaultTag [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 3, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/redisenterprise/armredisenterprise https://apiview.dev/Assemblies/Review/3e9fb7ccc8d3482ca4529619b5c2cc90
    Java azure-resourcemanager-redisenterprise https://apiview.dev/Assemblies/Review/349db73cc5c1417fab430dc603eb0c8d
    .Net Azure.ResourceManager.RedisEnterprise There is no API change compared with the previous version
    JavaScript @azure/arm-redisenterprisecache https://apiview.dev/Assemblies/Review/45d97bedc2d14ce3a2418418278cf49d

    @openapi-workflow-bot
    Copy link

    Hi @priyankarking, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @priyankarking priyankarking force-pushed the priyankarking-redisenterprise-Microsoft.Cache-2022-11-01-preview branch from 0e070c3 to c9407cc Compare April 5, 2023 10:37
    @mikekistler mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Apr 5, 2023
    @TimLovellSmith TimLovellSmith added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Apr 5, 2023
    @live1206
    Copy link
    Member

    live1206 commented Apr 7, 2023

    @priyankarking Please fix the PrettierCheck faillure, details can be found via #23403 (comment)

    @priyankarking priyankarking force-pushed the priyankarking-redisenterprise-Microsoft.Cache-2022-11-01-preview branch from c9407cc to d02057c Compare April 10, 2023 06:03
    @live1206 live1206 merged commit a1ecc18 into main Apr 10, 2023
    @live1206 live1206 deleted the priyankarking-redisenterprise-Microsoft.Cache-2022-11-01-preview branch April 10, 2023 06:17
    JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript FixS360 resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants