Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation banner to GetMapTile and GetMapTileset #23307

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

ismael-ms
Copy link
Contributor

@ismael-ms ismael-ms commented Mar 27, 2023

Data Plane API - Pull Request

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your engagement record.

Elevation services
Elevation - REST API (Azure Maps) | Microsoft Learn
Elevation - Get Data For Bounding Box - REST API (Azure Maps) | Microsoft Learn
Elevation - Get Data For Points - REST API (Azure Maps) | Microsoft Learn
Elevation - Get Data For Polyline - REST API (Azure Maps) | Microsoft Learn
Elevation - Post Data For Points - REST API (Azure Maps) | Microsoft Learn
Elevation - Post Data For Polyline - REST API (Azure Maps) | Microsoft Learn

Render V2 DEM Tiles
Render V2 - Get Map Tile - REST API (Azure Maps) | Microsoft Learn
Render V2 - Get Map Tileset - REST API (Azure Maps) | Microsoft Learn

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous Open API document (swagger) if applicable, and the root paths that have been updated.

  • Design Document: N/A
  • Previous Open API Doc: N/A
  • Updated paths: specification/maps/data-plane/Render/stable/2022-08-01/render.json

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

@openapi-workflow-bot
Copy link

Hi, @ismael-ms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 27, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.10.4)] new version base version
    render.json 2022-08-01(a821505) 2022-08-01(main)
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    2022-08-01 2022-08-01(a821505) 2022-08-01(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ValidFormats 'file' is not a known format.
    Location: Render/stable/2022-08-01/render.json#L342
    ValidFormats 'file' is not a known format.
    Location: Render/stable/2022-08-01/render.json#L494
    ValidFormats 'file' is not a known format.
    Location: Render/stable/2022-08-01/render.json#L704
    IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Render/stable/2022-08-01/render.json#L963
    IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Render/stable/2022-08-01/render.json#L970
    ⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
    Location: Render/stable/2022-08-01/render.json#L352
    ⚠️ ErrorResponse The error property in the error response schema should be required.
    Location: Render/stable/2022-08-01/render.json#L352
    ⚠️ ErrorResponse Error schema should define code and message properties as required.
    Location: Render/stable/2022-08-01/render.json#L352
    ⚠️ SchemaTypeAndFormat Schema with type: integer should specify format
    Location: Render/stable/2022-08-01/render.json#L385
    ⚠️ SchemaTypeAndFormat Schema with type: integer should specify format
    Location: Render/stable/2022-08-01/render.json#L385
    ⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
    Location: Render/stable/2022-08-01/render.json#L389
    ⚠️ ErrorResponse The error property in the error response schema should be required.
    Location: Render/stable/2022-08-01/render.json#L389
    ⚠️ ErrorResponse Error schema should define code and message properties as required.
    Location: Render/stable/2022-08-01/render.json#L389
    ⚠️ PageableOperation Based on the response model schema, operation 'Render_GetMapAttribution' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Render/stable/2022-08-01/render.json#L396
    ⚠️ PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
    Location: Render/stable/2022-08-01/render.json#L396
    ⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
    Location: Render/stable/2022-08-01/render.json#L446
    ⚠️ ErrorResponse The error property in the error response schema should be required.
    Location: Render/stable/2022-08-01/render.json#L446
    ⚠️ ErrorResponse Error schema should define code and message properties as required.
    Location: Render/stable/2022-08-01/render.json#L446
    ⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
    Location: Render/stable/2022-08-01/render.json#L504
    ⚠️ ErrorResponse The error property in the error response schema should be required.
    Location: Render/stable/2022-08-01/render.json#L504
    ⚠️ ErrorResponse Error schema should define code and message properties as required.
    Location: Render/stable/2022-08-01/render.json#L504
    ⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
    Location: Render/stable/2022-08-01/render.json#L526
    ⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
    Location: Render/stable/2022-08-01/render.json#L537
    ⚠️ ErrorResponse The error property in the error response schema should be required.
    Location: Render/stable/2022-08-01/render.json#L537
    ⚠️ ErrorResponse Error schema should define code and message properties as required.
    Location: Render/stable/2022-08-01/render.json#L537
    ⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
    Location: Render/stable/2022-08-01/render.json#L559
    ⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
    Location: Render/stable/2022-08-01/render.json#L714
    ⚠️ ErrorResponse The error property in the error response schema should be required.
    Location: Render/stable/2022-08-01/render.json#L714
    ⚠️ ErrorResponse Error schema should define code and message properties as required.
    Location: Render/stable/2022-08-01/render.json#L714
    ⚠️ PageableOperation Based on the response model schema, operation 'Render_GetCopyrightFromBoundingBox' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Render/stable/2022-08-01/render.json#L721
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the Maps label Mar 27, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 27, 2023

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 27, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Swagger maps-data-plane-Render https://apiview.dev/Assemblies/Review/20f7f44978b441d5be1c1a6b1375d3b9

    @ismael-ms ismael-ms marked this pull request as ready for review March 27, 2023 19:59
    @ismael-ms ismael-ms requested a review from a team as a code owner March 27, 2023 19:59
    @ismael-ms ismael-ms requested review from stewartadam and scgbear and removed request for a team March 27, 2023 19:59
    @ismael-ms ismael-ms assigned markweitzel and unassigned markweitzel Mar 27, 2023
    @heaths heaths merged commit f98ba05 into main Mar 27, 2023
    @heaths heaths deleted the ismael-ms-maps-Render-2022-08-01 branch March 27, 2023 20:54
    JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants