Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readonly flag to providerName incident property. #23259

Conversation

anat-gilenson
Copy link
Contributor

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @anat-gilenson Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 23, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️Breaking Change(Cross-Version): 4 Warnings warning [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    Incidents.json 2023-04-01-preview(d3faeef) 2023-02-01(main)
    Incidents.json 2023-04-01-preview(d3faeef) 2023-03-01-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.SecurityInsights/preview/2023-04-01-preview/Incidents.json#L1315:9
    Old: Microsoft.SecurityInsights/stable/2023-02-01/Incidents.json#L1102:9
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.SecurityInsights/preview/2023-04-01-preview/Incidents.json#L1319:9
    Old: Microsoft.SecurityInsights/stable/2023-02-01/Incidents.json#L1138:9
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.SecurityInsights/preview/2023-04-01-preview/Incidents.json#L1312:9
    Old: Microsoft.SecurityInsights/stable/2023-02-01/Incidents.json#L1245:9


    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.SecurityInsights/preview/2023-04-01-preview/Incidents.json#L1387:9
    Old: Microsoft.SecurityInsights/preview/2023-03-01-preview/Incidents.json#L1387:9
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-preview-2023-04 package-preview-2023-04(d3faeef) package-preview-2023-04(release-Sentinel-2023-04-01-preview)

    The following errors/warnings exist before current PR submission:

    Rule Message
    GetCollectionResponseSchema The response in the GET collection operation 'IncidentRelations_List' does not match the response definition in the individual GET operation 'IncidentRelations_Get' .
    Location: Microsoft.SecurityInsights/preview/2023-04-01-preview/Incidents.json#L634
    ResourceNameRestriction The resource name parameter 'relationName' should be defined with a 'pattern' restriction.
    Location: Microsoft.SecurityInsights/preview/2023-04-01-preview/Incidents.json#L698
    XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.SecurityInsights/preview/2023-04-01-preview/Incidents.json#L1245
    XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.SecurityInsights/preview/2023-04-01-preview/Incidents.json#L1332
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.SecurityInsights/preview/2023-04-01-preview/Incidents.json#L1067
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.SecurityInsights/preview/2023-04-01-preview/Incidents.json#L1185
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.SecurityInsights/preview/2023-04-01-preview/Incidents.json#L1293
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.SecurityInsights/preview/2023-04-01-preview/Incidents.json#L1404
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.SecurityInsights/preview/2023-04-01-preview/Incidents.json#L1422
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.SecurityInsights/preview/2023-04-01-preview/Incidents.json#L1436
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.SecurityInsights/preview/2023-04-01-preview/Incidents.json#L1476
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 23, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from f0e1f1ce2353b91205ce685c899d1c47e32fcfde. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.SecurityInsights [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from f0e1f1ce2353b91205ce685c899d1c47e32fcfde. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-securityinsight [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation EntitiesOperations.run_playbook
      info	[Changelog]   - Added operation group AlertRuleOperations
      info	[Changelog]   - Added operation group GetTriggeredAnalyticsRuleRunsOperations
      info	[Changelog]   - Added operation group TriggeredAnalyticsRuleRunOperations
      info	[Changelog]   - Added operation group WorkspaceManagerAssignmentJobsOperations
      info	[Changelog]   - Added operation group WorkspaceManagerAssignmentsOperations
      info	[Changelog]   - Added operation group WorkspaceManagerConfigurationsOperations
      info	[Changelog]   - Added operation group WorkspaceManagerGroupsOperations
      info	[Changelog]   - Added operation group WorkspaceManagerMembersOperations
      info	[Changelog]   - Model MTPDataConnector has a new parameter filtered_providers
      info	[Changelog]   - Model MTPDataConnectorDataTypes has a new parameter alerts
      info	[Changelog]   - Model MTPDataConnectorProperties has a new parameter filtered_providers
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model MSTIDataConnectorDataTypes no longer has parameter bing_safety_phishing_url
      info	[Changelog]   - Parameter logic_app_resource_id of model PlaybookActionProperties is now required
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from f0e1f1ce2353b91205ce685c899d1c47e32fcfde. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-securityinsight [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface DnsEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter kind of interface Entity is changed from EntityKind to EntityKindEnum
      info	[Changelog]   - Type of parameter additionalData of interface EntityCommonProperties is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface EntityEdges is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter entityKind of interface ExpansionResultAggregation is changed from EntityKind to EntityKindEnum
      info	[Changelog]   - Type of parameter additionalData of interface FileEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface FileHashEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface HostEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface HuntingBookmark is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter entityKind of interface IncidentEntitiesResultsMetadata is changed from EntityKind to EntityKindEnum
      info	[Changelog]   - Type of parameter additionalData of interface IoTDeviceEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface IpEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface MailboxEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface MailClusterEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface MailMessageEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface MalwareEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter kind of interface MetadataDependencies is changed from Kind to string
      info	[Changelog]   - Type of parameter kind of interface MetadataModel is changed from Kind to string
      info	[Changelog]   - Type of parameter kind of interface MetadataPatch is changed from Kind to string
      info	[Changelog]   - Type of parameter additionalData of interface NicEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface ProcessEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface RegistryKeyEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface RegistryValueEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface SecurityAlert is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface SecurityGroupEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface SubmissionMailEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface ThreatIntelligenceIndicatorModel is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter additionalData of interface UrlEntity is changed from {
      info	[Changelog]         [propertyName: string]: Record<string, unknown>;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Removed Enum KnownEntityKind
      info	[Changelog]   - Removed Enum KnownKind
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Failed [Logs] Generate from f0e1f1ce2353b91205ce685c899d1c47e32fcfde. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • securityinsights/resource-manager [View full logs
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs] Generate from f0e1f1ce2353b91205ce685c899d1c47e32fcfde. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.securityinsights.DefaultTag [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 23, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Java azure-resourcemanager-securityinsights https://apiview.dev/Assemblies/Review/f360e5de8823496b9d6ed20ce9b73e85
    .Net Azure.ResourceManager.SecurityInsights There is no API change compared with the previous version
    JavaScript @azure/arm-securityinsight https://apiview.dev/Assemblies/Review/3467a70adda04026a87799fa7f45ebe0

    @weidongxu-microsoft weidongxu-microsoft merged commit 5752267 into Azure:release-Sentinel-2023-04-01-preview Mar 31, 2023
    tadelesh pushed a commit that referenced this pull request Apr 14, 2023
    * Adds base for updating Microsoft.SecurityInsights from version preview/2023-03-01-preview to version 2023-04-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Workspace Manager Members (#23134)
    
    * Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Workspace Manager Members
    
    * udpate pattern
    
    * Workspace manager configurations (#23133)
    
    * Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * adding april configurations swagger
    
    * update pattern
    
    * prettier update
    
    * update readme
    
    * Workspace manager assignments (#23130)
    
    * Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Workspace Manager Assignments/Jobs
    
    * update readme
    
    * updated from comments
    
    * update from lint diff errors
    
    * updated descriptions
    
    * Workspace manager groups (#23135)
    
    * Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * april swagger for groups
    
    * update path name & pattern
    
    * [Hunts] Add hunts to Sentinel 2023-04-01-preview version (#23139)
    
    * Add hunts files
    
    * Include update in 200 description and add defaults
    
    * Add back 201
    
    * Update relation properties
    
    * Update example
    
    ---------
    
    Co-authored-by: Derrick Lee <[email protected]>
    
    * Add readonly flag to providerName property (#23259)
    
    * sentinel content hub package and template API (#23151)
    
    * commit for content template and content package API
    
    * fix issues reported by swagger lint
    
    * add 201 for put requests in template service
    
    * resolve the comments
    
    * resolve comments in packageId
    
    * resolve comments
    
    * update descriptions due to lint error (#23392)
    
    * Fix policheck issue by updating the description. (#23415)
    
    * Fix polich issue by updating the description.
    
    * update the description to fix a typo.
    
    * Release sentinel 2023 04 01 preview (#23420)
    
    * Fix polich issue by updating the description.
    
    * update the description to fix a typo.
    
    * fix policheck by updating description
    
    * rename enum name to stable version to fix cross-version breaking change failure.
    
    * fix typo (#23463)
    
    ---------
    
    Co-authored-by: rheabansal <[email protected]>
    Co-authored-by: Derrick Lee <[email protected]>
    Co-authored-by: Derrick Lee <[email protected]>
    Co-authored-by: Anat Gilenson <[email protected]>
    Co-authored-by: xuhumsft <[email protected]>
    Co-authored-by: Nan Zang <[email protected]>
    JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023
    * Adds base for updating Microsoft.SecurityInsights from version preview/2023-03-01-preview to version 2023-04-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Workspace Manager Members (Azure#23134)
    
    * Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Workspace Manager Members
    
    * udpate pattern
    
    * Workspace manager configurations (Azure#23133)
    
    * Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * adding april configurations swagger
    
    * update pattern
    
    * prettier update
    
    * update readme
    
    * Workspace manager assignments (Azure#23130)
    
    * Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Workspace Manager Assignments/Jobs
    
    * update readme
    
    * updated from comments
    
    * update from lint diff errors
    
    * updated descriptions
    
    * Workspace manager groups (Azure#23135)
    
    * Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * april swagger for groups
    
    * update path name & pattern
    
    * [Hunts] Add hunts to Sentinel 2023-04-01-preview version (Azure#23139)
    
    * Add hunts files
    
    * Include update in 200 description and add defaults
    
    * Add back 201
    
    * Update relation properties
    
    * Update example
    
    ---------
    
    Co-authored-by: Derrick Lee <[email protected]>
    
    * Add readonly flag to providerName property (Azure#23259)
    
    * sentinel content hub package and template API (Azure#23151)
    
    * commit for content template and content package API
    
    * fix issues reported by swagger lint
    
    * add 201 for put requests in template service
    
    * resolve the comments
    
    * resolve comments in packageId
    
    * resolve comments
    
    * update descriptions due to lint error (Azure#23392)
    
    * Fix policheck issue by updating the description. (Azure#23415)
    
    * Fix polich issue by updating the description.
    
    * update the description to fix a typo.
    
    * Release sentinel 2023 04 01 preview (Azure#23420)
    
    * Fix polich issue by updating the description.
    
    * update the description to fix a typo.
    
    * fix policheck by updating description
    
    * rename enum name to stable version to fix cross-version breaking change failure.
    
    * fix typo (Azure#23463)
    
    ---------
    
    Co-authored-by: rheabansal <[email protected]>
    Co-authored-by: Derrick Lee <[email protected]>
    Co-authored-by: Derrick Lee <[email protected]>
    Co-authored-by: Anat Gilenson <[email protected]>
    Co-authored-by: xuhumsft <[email protected]>
    Co-authored-by: Nan Zang <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants