[Hub Generated] Review request for Microsoft.AzureStackHCI to add version preview/2022-12-15-preview #23230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…021-09-01-preview to version 2022-12-15-preview
|
Hi, @pathuang-sia Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| arcSettings.json | 2022-12-15-preview(7ba1ee3) | 2022-12-01(main) |
| arcSettings.json | 2022-12-15-preview(7ba1ee3) | 2021-09-01-preview(main) |
| clusters.json | 2022-12-15-preview(7ba1ee3) | 2022-12-01(main) |
| clusters.json | 2022-12-15-preview(7ba1ee3) | 2021-09-01-preview(main) |
| common.json | 2022-12-15-preview(7ba1ee3) | 2021-09-01-preview(main) |
| extensions.json | 2022-12-15-preview(7ba1ee3) | 2022-12-01(main) |
| extensions.json | 2022-12-15-preview(7ba1ee3) | 2021-09-01-preview(main) |
| galleryImages.json | 2022-12-15-preview(7ba1ee3) | 2021-09-01-preview(main) |
| marketplaceGalleryImages.json | 2022-12-15-preview(7ba1ee3) | 2021-09-01-preview(main) |
| networkInterfaces.json | 2022-12-15-preview(7ba1ee3) | 2021-09-01-preview(main) |
| offers.json | 2022-12-15-preview(7ba1ee3) | 2022-12-01(main) |
| operations.json | 2022-12-15-preview(7ba1ee3) | 2022-12-01(main) |
| operations.json | 2022-12-15-preview(7ba1ee3) | 2021-09-01-preview(main) |
| publishers.json | 2022-12-15-preview(7ba1ee3) | 2022-12-01(main) |
| skus.json | 2022-12-15-preview(7ba1ee3) | 2022-12-01(main) |
| storageContainers.json | 2022-12-15-preview(7ba1ee3) | 2021-09-01-preview(main) |
| updateRuns.json | 2022-12-15-preview(7ba1ee3) | 2022-12-01(main) |
| updateSummaries.json | 2022-12-15-preview(7ba1ee3) | 2022-12-01(main) |
| updates.json | 2022-12-15-preview(7ba1ee3) | 2022-12-01(main) |
| virtualHardDisks.json | 2022-12-15-preview(7ba1ee3) | 2021-09-01-preview(main) |
| virtualMachines.json | 2022-12-15-preview(7ba1ee3) | 2021-09-01-preview(main) |
| virtualNetworks.json | 2022-12-15-preview(7ba1ee3) | 2021-09-01-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
Only 26 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureStackHCI/galleryimages/{galleryimagesName}' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L40:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureStackHCI/galleryimages' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L222:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.AzureStackHCI/galleryimages' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L261:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureStackHCI/marketplacegalleryimages/{marketplacegalleryimagesName}' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/marketplaceGalleryImages.json#L40:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureStackHCI/marketplacegalleryimages' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/marketplaceGalleryImages.json#L222:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.AzureStackHCI/marketplacegalleryimages' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/marketplaceGalleryImages.json#L261:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureStackHCI/networkinterfaces/{networkinterfacesName}' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L40:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureStackHCI/networkinterfaces' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L219:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.AzureStackHCI/networkinterfaces' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L257:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureStackHCI/storagecontainers/{storagecontainersName}' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/storageContainers.json#L40:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureStackHCI/storagecontainers' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/storageContainers.json#L219:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.AzureStackHCI/storagecontainers' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/storageContainers.json#L257:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureStackHCI/virtualharddisks/{virtualharddisksName}' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/virtualHardDisks.json#L40:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureStackHCI/virtualharddisks' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/virtualHardDisks.json#L219:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.AzureStackHCI/virtualharddisks' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/virtualHardDisks.json#L257:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureStackHCI/virtualmachines/{virtualmachinesName}' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/virtualMachines.json#L40:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureStackHCI/virtualmachines/{virtualmachinesName}/start' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/virtualMachines.json#L225:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureStackHCI/virtualmachines/{virtualmachinesName}/stop' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/virtualMachines.json#L267:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureStackHCI/virtualmachines/{virtualmachinesName}/restart' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/virtualMachines.json#L309:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureStackHCI/virtualmachines' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/virtualMachines.json#L351:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.AzureStackHCI/virtualmachines' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/virtualMachines.json#L389:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureStackHCI/virtualnetworks/{virtualnetworksName}' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/virtualNetworks.json#L40:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureStackHCI/virtualnetworks' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/virtualNetworks.json#L218:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.AzureStackHCI/virtualnetworks' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/virtualNetworks.json#L256:5 |
|
The new version is missing a definition that was found in the old version. Was 'galleryimagesProperties' removed or renamed? New: Microsoft.AzureStackHCI/preview/2022-12-15-preview/galleryImages.json#L299:3 Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L298:3 |
|
The new version is missing a definition that was found in the old version. Was 'galleryImageIdentifier' removed or renamed? New: Microsoft.AzureStackHCI/preview/2022-12-15-preview/galleryImages.json#L299:3 Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L298:3 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 113 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.2) | new version | base version |
|---|---|---|
| package-preview-2022-12-15 | package-preview-2022-12-15(7ba1ee3) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 26 items are listed, please refer to log for more details.
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImagesModel'. Consider using the plural form of 'GalleryImages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/galleryImages.json#L42 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImagesModel'. Consider using the plural form of 'GalleryImages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/galleryImages.json#L79 |
||
| Parameter should have a description. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/galleryImages.json#L103 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImagesModel'. Consider using the plural form of 'GalleryImages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/galleryImages.json#L134 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImagesModel'. Consider using the plural form of 'GalleryImages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/galleryImages.json#L171 |
||
| Parameter should have a description. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/galleryImages.json#L195 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImagesModel'. Consider using the plural form of 'GalleryImages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/galleryImages.json#L225 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'GalleryImagesModel'. Consider using the plural form of 'GalleryImages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/galleryImages.json#L264 |
||
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/galleryImages.json#L390 |
||
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/galleryImages.json#L411 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'MarketplaceGalleryImagesModel'. Consider using the plural form of 'MarketplaceGalleryImages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/marketplaceGalleryImages.json#L42 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'MarketplaceGalleryImagesModel'. Consider using the plural form of 'MarketplaceGalleryImages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/marketplaceGalleryImages.json#L79 |
||
| Parameter should have a description. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/marketplaceGalleryImages.json#L103 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'MarketplaceGalleryImagesModel'. Consider using the plural form of 'MarketplaceGalleryImages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/marketplaceGalleryImages.json#L134 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'MarketplaceGalleryImagesModel'. Consider using the plural form of 'MarketplaceGalleryImages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/marketplaceGalleryImages.json#L171 |
||
| Parameter should have a description. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/marketplaceGalleryImages.json#L195 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'MarketplaceGalleryImagesModel'. Consider using the plural form of 'MarketplaceGalleryImages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/marketplaceGalleryImages.json#L225 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'MarketplaceGalleryImagesModel'. Consider using the plural form of 'MarketplaceGalleryImages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/marketplaceGalleryImages.json#L264 |
||
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/marketplaceGalleryImages.json#L385 |
||
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/marketplaceGalleryImages.json#L406 |
||
| Schema should have a description or title. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/marketplaceGalleryImages.json#L530 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'NetworkInterfacesModel'. Consider using the plural form of 'NetworkInterfaces' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/networkInterfaces.json#L42 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'NetworkInterfacesModel'. Consider using the plural form of 'NetworkInterfaces' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/networkInterfaces.json#L79 |
||
| Parameter should have a description. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/networkInterfaces.json#L103 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'NetworkInterfacesModel'. Consider using the plural form of 'NetworkInterfaces' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/networkInterfaces.json#L134 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'NetworkInterfacesModel'. Consider using the plural form of 'NetworkInterfaces' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/networkInterfaces.json#L171 |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/arcSettings.json#L704 |
|
| Schema should have a description or title. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/arcSettings.json#L711 |
|
| Schema should have a description or title. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/arcSettings.json#L743 |
|
| Schema should have a description or title. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/clusters.json#L904 |
|
| Schema should have a description or title. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/clusters.json#L916 |
|
| Schema should have a description or title. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/clusters.json#L925 |
|
| Schema should have a description or title. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/clusters.json#L942 |
|
| Schema should have a description or title. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/clusters.json#L962 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/extensions.json#L559 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/extensions.json#L572 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/extensions.json#L594 |
|
| 'PUT' operation 'UpdateRuns_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/updateRuns.json#L140 |
|
| 'PUT' operation 'Updates_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/updates.json#L186 |
|
| Schema should have a description or title. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/updates.json#L532 |
|
| Schema should have a description or title. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/updates.json#L544 |
|
| Schema should have a description or title. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/updates.json#L559 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/updates.json#L565 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'UpdateSummariesModel'. Consider using the plural form of 'UpdateSummaries' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/updateSummaries.json#L39 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'UpdateSummariesModel'. Consider using the plural form of 'UpdateSummaries' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/updateSummaries.json#L81 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'UpdateSummariesModel'. Consider using the plural form of 'UpdateSummaries' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/updateSummaries.json#L131 |
|
| 'PUT' operation 'UpdateSummaries_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/updateSummaries.json#L131 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'UpdateSummariesModel'. Consider using the plural form of 'UpdateSummaries' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/updateSummaries.json#L177 |
|
| Schema should have a description or title. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/updateSummaries.json#L378 |
|
| Schema should have a description or title. Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/updateSummaries.json#L393 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AzureStackHCI/preview/2022-12-15-preview/updateSummaries.json#L399 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 0 Errors, 0 Warnings failed [Detail]
Tag package-preview-2022-12-15; Prod region: Not deployed; Canary region: Not deployed
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
ghost
added
the
Generated ApiView
|
|
Hi @pathuang-sia and @arcboard, one or more change(s) have been detected in your Arc enabled VM's or Arc enabled Server's RPs. Please review the changes and ensure that no gaps have been introduced with respect to the ARM API modeling consistency across Azure Arc and Azure Compute. For further details, see guidelines at Consistency in ARM Modeling. To approve the change(s), set the label to ArcSignedOff. If you have any questions, please mail to [email protected]. |
This was referenced Mar 22, 2023
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
|
Hi @pathuang-sia, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced Mar 22, 2023
|
Hi @pathuang-sia, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Backporting changes requested from ARM reviewers in this PR from: https://github.com/Azure/azure-rest-api-specs-pr/pull/12162 |
pathuang-sia
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
visingla-ms
reviewed
May 23, 2023
| "202": { | ||
| "description": "Accepted", | ||
| "schema": { | ||
| "$ref": "#/definitions/NetworkInterfaces" |
visingla-ms
reviewed
May 23, 2023
...i/resource-manager/Microsoft.AzureStackHCI/preview/2022-12-15-preview/storageContainers.json
Outdated
Show resolved
Hide resolved
visingla-ms
reviewed
May 23, 2023
...ci/resource-manager/Microsoft.AzureStackHCI/preview/2022-12-15-preview/virtualHardDisks.json
Outdated
Show resolved
Hide resolved
visingla-ms
reviewed
May 23, 2023
...ckhci/resource-manager/Microsoft.AzureStackHCI/preview/2022-12-15-preview/galleryImages.json
Outdated
Show resolved
Hide resolved
visingla-ms
reviewed
May 23, 2023
...rce-manager/Microsoft.AzureStackHCI/preview/2022-12-15-preview/marketplaceGalleryImages.json
Outdated
Show resolved
Hide resolved
visingla-ms
added
the
ARMChangesRequested
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
pathuang-sia
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
visingla-ms
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
SignedOff based the feedback by the previous ARM Reviewer. |
weidongxu-microsoft
approved these changes
May 24, 2023
Comment on lines
+408
to
+409
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureStackHCI/clusters/{clusterName}/arcSettings/{arcSettingName}/InitializeDisableProcess": { | ||
| "post": { |
There was a problem hiding this comment.
Why is this path Pascal case in last segment?
There was a problem hiding this comment.
The change was brought forth by this PR: https://github.com/Azure/azure-rest-api-specs-pr/pull/11428/files
@bniranjanbhat was there a reason?
weidongxu-microsoft
deleted the
pathuang-sia-azurestackhci-Microsoft.AzureStackHCI-2022-12-15-preview
branch
This was referenced May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.