[Hub Generated] Publish private branch 'nickdepinet-devcenter-Microsoft.DevCenter-2023-01-01-preview' #23124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/11086 |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| commonDefinitions.json | 2023-01-01-preview(0313b37) | 2022-11-11-preview(main) |
| devcenter.json | 2023-01-01-preview(0313b37) | 2022-11-11-preview(main) |
| vdi.json | 2023-01-01-preview(0313b37) | 2022-11-11-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-preview-2023-01 | package-preview-2023-01(0313b37) | default(main) |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
Operations with a 202 response should specify x-ms-long-running-operation: true.Location: Microsoft.DevCenter/preview/2023-01-01-preview/devcenter.json#L2592 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DevCenter/preview/2023-01-01-preview/devcenter.json#L3141 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.DevCenter/preview/2023-01-01-preview/devcenter.json#L3661 |
|
| Schema should have a description or title. Location: Microsoft.DevCenter/preview/2023-01-01-preview/vdi.json#L1152 |
️❌Avocado: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.DevCenter/locations/{}/usages is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/devcenter/resource-manager/readme.md json: Microsoft.DevCenter/preview/2022-11-11-preview/devcenter.json |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
|
Hi, @nickdepinet Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
CI-FixRequiredOnFailure
new-api-version
resource-manager
RPaaS
WaitForARMFeedback
|
Hi @nickdepinet, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
@Alancere - this is a publish-only pr of a previously approved + merged PR in the private repo here: https://github.com/Azure/azure-rest-api-specs-pr/pull/11086 |
|
Can you please update the checklist above with the correct options ? Assuming this is a new service ..
|
raosuhas
added
the
ARMChangesRequested
|
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
Hi @raosuhas - This is only copying an already approved + merged API version from private repo to public. You can see approved changes merged in private repo in this pr: https://github.com/Azure/azure-rest-api-specs-pr/pull/11086 |
ArcturusZhang
added
ARMSignedOff
openapi-workflow-bot
bot
removed
the
ARMChangesRequested
|
Adding the labels on private PR to this. |
re-adding azure-sdk-for-go
tadelesh
added
the
Approved-SdkBreakingChange-Go
ArcturusZhang
approved these changes
Mar 29, 2023
ArcturusZhang
deleted the
published/Azure/azure-rest-api-specs-pr/nickdepinet-devcenter-Microsoft.DevCenter-2023-01-01-preview
branch
This was referenced Mar 29, 2023
JoshLove-msft
pushed a commit
to JoshLove-msft/azure-rest-api-specs
that referenced
this pull request
Apr 25, 2023
…ft.DevCenter-2023-01-01-preview' (Azure#23124) * add or modify files * Update readme.md re-adding azure-sdk-for-go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.