Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Monitor to add version stable/2023-04-03 #23107

Merged
merged 43 commits into from
Apr 18, 2023
Merged

[Hub Generated] Review request for Microsoft.Monitor to add version stable/2023-04-03 #23107

Show file tree
Hide file tree
Changes from 41 commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
aea270e
Adds base for updating Microsoft.Monitor from version preview/2021-06…
jasondavis-MS Mar 15, 2023
896a3a3
Updates readme
jasondavis-MS Mar 15, 2023
3c6fffc
Updates API version in new specs and examples
jasondavis-MS Mar 15, 2023
2e2eaef
add publicNetworkAccess
jasondavis-MS Mar 17, 2023
4f7a009
add PrivateEndpointConnections
jasondavis-MS Mar 17, 2023
4674d93
add PrivateEndpointConnections subclasses
jasondavis-MS Mar 17, 2023
ea9dd89
give PrivateEndpointConnectionProperties.ProvisioningState enum vals
jasondavis-MS Mar 17, 2023
baa9fbb
give publicNetworkAccess an enum
jasondavis-MS Mar 20, 2023
de7cab4
add privateEndpointConnections and publicNetworkAccess to Create example
jasondavis-MS Mar 20, 2023
76906f8
add PrivateEndpointConnection and PublicNetworkAccess to other examples
jasondavis-MS Mar 20, 2023
b62df79
attempt to fix XmsIdentifierValidation linter error
jasondavis-MS Mar 20, 2023
3cf06e5
attempt to fix ArrayMustHaveType linter error
jasondavis-MS Mar 20, 2023
b773ed0
attempt to fix XmsEnumValidation and retry XmsIdentifierValidation er…
jasondavis-MS Mar 20, 2023
c89f963
attempt to fix MISSING_APIS_IN_DEFAULT_TAG
jasondavis-MS Mar 20, 2023
9d548d0
use common-type for PrivateEndpointConnection ref, remove nested fields
jasondavis-MS Mar 21, 2023
c0b1031
update Create and Delete responses for async operations
jasondavis-MS Mar 24, 2023
c9c17da
further async update
jasondavis-MS Mar 24, 2023
671a594
Revert "further async update"
jasondavis-MS Mar 28, 2023
4720e43
Revert "update Create and Delete responses for async operations"
jasondavis-MS Mar 28, 2023
2043102
remove 201 from Create, 200 and 204 from Delete, add 202 to Delete
jasondavis-MS Mar 28, 2023
7ea8171
readd 204 to Delete
jasondavis-MS Mar 28, 2023
3b77b5b
make corresponding response updates to API
jasondavis-MS Mar 28, 2023
f539c36
add x-ms-long-running-operation: true to Delete
jasondavis-MS Mar 28, 2023
63f568b
add x-ms-long-running-operation-options for Delete
jasondavis-MS Mar 28, 2023
6bd3979
try to fix Lro errors
jasondavis-MS Mar 28, 2023
42562f8
try to fix errors
jasondavis-MS Mar 28, 2023
39e3b10
try to fix errors
jasondavis-MS Mar 28, 2023
9c725fa
attempt fix again
jasondavis-MS Mar 28, 2023
5011d28
try again
jasondavis-MS Mar 28, 2023
9c4c655
continue
jasondavis-MS Mar 28, 2023
899d6b1
continue
jasondavis-MS Mar 28, 2023
1622644
once more
jasondavis-MS Mar 28, 2023
d08031d
another try
jasondavis-MS Mar 29, 2023
649bc7e
last one for real
jasondavis-MS Mar 29, 2023
72950f5
last one v2
jasondavis-MS Mar 29, 2023
f7edcdc
just one more
jasondavis-MS Mar 29, 2023
4f28a31
last or second to last one, guaranteed
jasondavis-MS Mar 29, 2023
0fc498f
attempt cleanup
jasondavis-MS Mar 29, 2023
4bf85ca
Revert "attempt cleanup"
jasondavis-MS Mar 29, 2023
31944e2
reintroduce 201 response for PUT
jasondavis-MS Apr 6, 2023
09319ca
remove double readme entry
jamlai Apr 14, 2023
efd1402
resolve Go SDK duplication schema issue
tadelesh Apr 17, 2023
58daca2
revert change
tadelesh Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 123 additions & 0 deletions ...ce-manager/Microsoft.Monitor/stable/2023-04-03/examples/AzureMonitorWorkspacesCreate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,123 @@
{
"parameters": {
"subscriptionId": "703362b3-f278-4e4b-9179-c76eaf41ffc2",
"resourceGroupName": "myResourceGroup",
"azureMonitorWorkspaceName": "myAzureMonitorWorkspace",
"api-version": "2023-04-03",
"azureMonitorWorkspaceProperties": {
"location": "eastus"
}
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Monitor/accounts/myAzureMonitorWorkspace",
"name": "myAzureMonitorWorkspace",
"type": "Microsoft.Monitor/accounts",
"location": "eastus",
"tags": {
"tag1": "A",
"tag2": "B"
},
"properties": {
"accountId": "2df515bf-c3ce-4920-84d4-1d9d16542d9f",
"metrics": {
"prometheusQueryEndpoint": "https://myAzureMonitorWorkspace-v8hx.eastus.prometheus.monitor.azure.com",
"internalId": "mac_2df515bf-c3ce-4920-84d4-1d9d16542d9f"
},
"provisioningState": "Succeeded",
"defaultIngestionSettings": {
"dataCollectionRuleResourceId": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/MA_myAzureMonitorWorkspace_eastus_managed/providers/Microsoft.Insights/dataCollectionRules/myAzureMonitorWorkspace",
"dataCollectionEndpointResourceId": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/MA_myAzureMonitorWorkspace_eastus_managed/providers/Microsoft.Insights/dataCollectionEndpoints/myAzureMonitorWorkspace"
},
"privateEndpointConnections": [
{
"id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Monitor/accounts/myAzureMonitorWorkspace/privateEndpointConnections/myPrivateEndpointConnection",
"name": "myPrivateEndpointConnection",
"type": "Microsoft.Monitor/accounts/privateEndpointConnections",
"properties": {
"provisioningState": "Updating",
"privateEndpoint": {
"id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Network/privateEndpoints/myPrivateEndpointConnection"
},
"groupIds": [
"prometheusMetrics"
],
"privateLinkServiceConnectionState": {
"status": "Approved",
"description": "Auto-approved",
"actionsRequired": "None"
}
}
}
],
"publicNetworkAccess": "Enabled"
},
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2021-04-01T12:34:56.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2021-04-02T12:34:56.1234567Z"
},
"etag": "070057da-0000-0000-0000-5ba70d6c0000"
}
},
"201": {
jasondavis-MS marked this conversation as resolved.
Show resolved Hide resolved
"body": {
"id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Monitor/accounts/myAzureMonitorWorkspace",
"name": "myAzureMonitorWorkspace",
"type": "Microsoft.Monitor/accounts",
"location": "eastus",
"tags": {
"tag1": "A",
"tag2": "B"
},
"properties": {
"accountId": "2df515bf-c3ce-4920-84d4-1d9d16542d9f",
"metrics": {
"prometheusQueryEndpoint": "https://myAzureMonitorWorkspace-v8hx.eastus.prometheus.monitor.azure.com",
"internalId": "mac_2df515bf-c3ce-4920-84d4-1d9d16542d9f"
},
"provisioningState": "Creating",
"defaultIngestionSettings": {
"dataCollectionRuleResourceId": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/MA_myAzureMonitorWorkspace_eastus_managed/providers/Microsoft.Insights/dataCollectionRules/myAzureMonitorWorkspace",
"dataCollectionEndpointResourceId": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/MA_myAzureMonitorWorkspace_eastus_managed/providers/Microsoft.Insights/dataCollectionEndpoints/myAzureMonitorWorkspace"
},
"privateEndpointConnections": [
{
"id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Monitor/accounts/myAzureMonitorWorkspace/privateEndpointConnections/myPrivateEndpointConnection",
"name": "myPrivateEndpointConnection",
"type": "Microsoft.Monitor/accounts/privateEndpointConnections",
"properties": {
"provisioningState": "Succeeded",
"privateEndpoint": {
"id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Network/privateEndpoints/myPrivateEndpointConnection"
},
"groupIds": [
"prometheusMetrics"
],
"privateLinkServiceConnectionState": {
"status": "Approved",
"description": "Auto-approved",
"actionsRequired": "None"
}
}
}
],
"publicNetworkAccess": "Enabled"
},
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2021-04-01T12:34:56.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2021-04-02T12:34:56.1234567Z"
},
"etag": "070057da-0000-0000-0000-5ba70d6c0000"
}
}
}
}
17 changes: 17 additions & 0 deletions ...ce-manager/Microsoft.Monitor/stable/2023-04-03/examples/AzureMonitorWorkspacesDelete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"parameters": {
"subscriptionId": "703362b3-f278-4e4b-9179-c76eaf41ffc2",
"resourceGroupName": "myResourceGroup",
"azureMonitorWorkspaceName": "myAzureMonitorWorkspace",
"api-version": "2023-04-03"
},
"responses": {
"202": {
"headers": {
"Azure-AsyncOperation": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.Monitor/locations/eastus/operationResults/00000000-0000-0000-0000-000000000000/AzureMonitorWorkspace/default?api-version=2023-04-03",
"Location": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.Monitor/locations/eastus/operationStatus/default/operationId/00000000-0000-0000-0000-000000000000?api-version=2023-04-03"
}
},
"204": {}
}
}
65 changes: 65 additions & 0 deletions ...ource-manager/Microsoft.Monitor/stable/2023-04-03/examples/AzureMonitorWorkspacesGet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
{
"parameters": {
"subscriptionId": "703362b3-f278-4e4b-9179-c76eaf41ffc2",
"resourceGroupName": "myResourceGroup",
"azureMonitorWorkspaceName": "myAzureMonitorWorkspace",
"api-version": "2023-04-03"
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Monitor/accounts/myAzureMonitorWorkspace",
"name": "myAzureMonitorWorkspace",
"type": "Microsoft.Monitor/accounts",
"location": "eastus",
"tags": {
"tag1": "A",
"tag2": "B"
},
"properties": {
"accountId": "2df515bf-c3ce-4920-84d4-1d9d16542d9f",
"metrics": {
"prometheusQueryEndpoint": "https://myAzureMonitorWorkspace-v8hx.eastus.prometheus.monitor.azure.com",
"internalId": "mac_2df515bf-c3ce-4920-84d4-1d9d16542d9f"
},
"provisioningState": "Succeeded",
"defaultIngestionSettings": {
"dataCollectionRuleResourceId": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/MA_myAzureMonitorWorkspace_eastus_managed/providers/Microsoft.Insights/dataCollectionRules/myAzureMonitorWorkspace",
"dataCollectionEndpointResourceId": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/MA_myAzureMonitorWorkspace_eastus_managed/providers/Microsoft.Insights/dataCollectionEndpoints/myAzureMonitorWorkspace"
},
"privateEndpointConnections": [
{
"id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Monitor/accounts/myAzureMonitorWorkspace/privateEndpointConnections/myPrivateEndpointConnection",
"name": "myPrivateEndpointConnection",
"type": "Microsoft.Monitor/accounts/privateEndpointConnections",
"properties": {
"provisioningState": "Succeeded",
"privateEndpoint": {
"id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Network/privateEndpoints/myPrivateEndpointConnection"
},
"groupIds": [
"prometheusMetrics"
],
"privateLinkServiceConnectionState": {
"status": "Approved",
"description": "Auto-approved",
"actionsRequired": "None"
}
}
}
],
"publicNetworkAccess": "Enabled"
},
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2021-04-01T12:34:56.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2021-04-02T12:34:56.1234567Z"
},
"etag": "070057da-0000-0000-0000-5ba70d6c0000"
}
}
}
}
122 changes: 122 additions & 0 deletions ...crosoft.Monitor/stable/2023-04-03/examples/AzureMonitorWorkspacesListByResourceGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,122 @@
{
"parameters": {
"subscriptionId": "703362b3-f278-4e4b-9179-c76eaf41ffc2",
"resourceGroupName": "myResourceGroup",
"api-version": "2023-04-03"
},
"responses": {
"200": {
"body": {
"value": [
{
"id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Monitor/accounts/myAzureMonitorWorkspace",
"name": "myAzureMonitorWorkspace",
"type": "Microsoft.Monitor/accounts",
"location": "eastus",
"tags": {
"tag1": "A",
"tag2": "B"
},
"properties": {
"accountId": "2df515bf-c3ce-4920-84d4-1d9d16542d9f",
"metrics": {
"prometheusQueryEndpoint": "https://myAzureMonitorWorkspace-abcd.eastus.prometheus.monitor.azure.com",
"internalId": "mac_2df515bf-c3ce-4920-84d4-1d9d16542d9f"
},
"provisioningState": "Succeeded",
"defaultIngestionSettings": {
"dataCollectionRuleResourceId": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/MA_myAzureMonitorWorkspace_eastus_managed/providers/Microsoft.Insights/dataCollectionRules/myAzureMonitorWorkspace",
"dataCollectionEndpointResourceId": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/MA_myAzureMonitorWorkspace_eastus_managed/providers/Microsoft.Insights/dataCollectionEndpoints/myAzureMonitorWorkspace"
},
"privateEndpointConnections": [
{
"id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Monitor/accounts/myAzureMonitorWorkspace/privateEndpointConnections/myPrivateEndpointConnection",
"name": "myPrivateEndpointConnection",
"type": "Microsoft.Monitor/accounts/privateEndpointConnections",
"properties": {
"provisioningState": "Succeeded",
"privateEndpoint": {
"id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Network/privateEndpoints/myPrivateEndpointConnection"
},
"groupIds": [
"prometheusMetrics"
],
"privateLinkServiceConnectionState": {
"status": "Approved",
"description": "Auto-approved",
"actionsRequired": "None"
}
}
}
],
"publicNetworkAccess": "Enabled"
},
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2021-04-01T12:34:56.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2021-04-02T12:34:56.1234567Z"
},
"etag": "070057da-0000-0000-0000-5ba70d6c0000"
},
{
"id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Monitor/accounts/herAzureMonitorWorkspace",
"name": "herAzureMonitorWorkspace",
"type": "Microsoft.Monitor/accounts",
"location": "westus",
"tags": {
"tag1": "A",
"tag2": "B"
},
"properties": {
"accountId": "823220c6-0415-44d8-bfb2-d5c1c9ea1172",
"metrics": {
"prometheusQueryEndpoint": "https://herAzureMonitorWorkspace-xywz.eastus.prometheus.monitor.azure.com",
"internalId": "mac_823220c6-0415-44d8-bfb2-d5c1c9ea1172"
},
"provisioningState": "Succeeded",
"defaultIngestionSettings": {
"dataCollectionRuleResourceId": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/MA_herAzureMonitorWorkspace_eastus_managed/providers/Microsoft.Insights/dataCollectionRules/herAzureMonitorWorkspace",
"dataCollectionEndpointResourceId": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/MA_herAzureMonitorWorkspace_eastus_managed/providers/Microsoft.Insights/dataCollectionEndpoints/herAzureMonitorWorkspace"
},
"privateEndpointConnections": [
{
"id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Monitor/accounts/myAzureMonitorWorkspace/privateEndpointConnections/myPrivateEndpointConnection",
"name": "myPrivateEndpointConnection",
"type": "Microsoft.Monitor/accounts/privateEndpointConnections",
"properties": {
"provisioningState": "Succeeded",
"privateEndpoint": {
"id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Network/privateEndpoints/myPrivateEndpointConnection"
},
"groupIds": [
"prometheusMetrics"
],
"privateLinkServiceConnectionState": {
"status": "Approved",
"description": "Auto-approved",
"actionsRequired": "None"
}
}
}
],
"publicNetworkAccess": "Enabled"
},
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2021-04-01T12:34:56.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2021-04-02T12:34:56.1234567Z"
},
"etag": "070057da-0000-0000-0000-5ba70d6c0000"
}
],
"nextLink": null
}
}
}
}
Loading