-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Insights to add version preview/2023-03-15-preview #22993
[Hub Generated] Review request for Microsoft.Insights to add version preview/2023-03-15-preview #22993
Conversation
…8-01-preview to version 2023-03-15-preview
Hi, @meydand Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
scheduledQueryRule_API.json | 2023-03-15-preview(1293c9f) | 2022-06-15(main) |
scheduledQueryRule_API.json | 2023-03-15-preview(1293c9f) | 2022-08-01-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
Rule | Message |
---|---|
The new version is missing a property found in the old version. Was 'publicNetworkAccess' renamed or removed? New: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L358:7 Old: Microsoft.Insights/preview/2022-08-01-preview/scheduledQueryRule_API.json#L350:7 |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.0.0) | new version | base version |
---|---|---|
package-preview-2023-04 | package-preview-2023-04(1293c9f) | package-preview-2023-04(main) |
package-preview-2023-03 | package-preview-2023-03(1293c9f) | package-preview-2023-03(main) |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
ResourceNameRestriction |
The resource name parameter 'ruleName' should be defined with a 'pattern' restriction. Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L118 |
ResourceNameRestriction |
The resource name parameter 'ruleName' should be defined with a 'pattern' restriction. Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L118 |
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L345 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L345 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L364 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L364 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L393 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L393 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L440 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L440 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L445 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L445 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L449 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L449 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L453 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L453 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/monitor/resource-manager/readme.md tag: specification/monitor/resource-manager/readme.md#tag-package-preview-2023-04 |
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️❌
~[Staging] ServiceAPIReadinessTest: 131 Errors, 0 Warnings failed [Detail]
Tag package-preview-2023-04; Prod region: Deployed
Test run on region: westcentralus; Operation coverage: total: 114, untested: 0, failed: 76, passed: 38
Service API Readiness Test failed. Check pipeline artifact for detail report.
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
CLIENT_ERROR |
statusCode: 400, errorCode: LocationNotAvailableForResourceType, errorMessage: The provided location 'westcentralus' is not available for resource type 'microsoft.insights/privateLinkScopes'. List of available regions for the resource type is 'global'. Source: runtime OperationId: PrivateLinkScopes_CreateOrUpdate |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'microsoft.insights/privateLinkScopes/scopenamsf4ciw' under resource group 'apiTest-BOcLFG-22993' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: PrivateLinkScopes_Get |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'microsoft.insights/privateLinkScopes/scopenamsf4ciw' under resource group 'apiTest-BOcLFG-22993' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: PrivateLinkScopes_UpdateTags |
CLIENT_ERROR |
statusCode: 400, errorCode: LocationNotAvailableForResourceType, errorMessage: The provided location 'westcentralus' is not available for resource type 'microsoft.insights/actiongroups'. List of available regions for the resource type is 'global,swedencentral,germanywestcentral,northcentralus,southcentralus,eastus2euap,centraluseuap'. Source: runtime OperationId: ActionGroups_CreateOrUpdate |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: error Source: response OperationId: ActionGroups_CreateOrUpdate |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Insights/actiongroups/actiongrkmlkof' under resource group 'apiTest-BOcLFG-22993' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ActionGroups_GetTestNotificationsAtActionGroupResourceLevel |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: error Source: response OperationId: ActionGroups_GetTestNotificationsAtActionGroupResourceLevel |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Insights/actiongroups/actiongrkmlkof' under resource group 'apiTest-BOcLFG-22993' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ActionGroups_Get |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: error Source: response OperationId: ActionGroups_Get |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Insights/actiongroups/actiongrkmlkof' under resource group 'apiTest-BOcLFG-22993' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ActionGroups_Update |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: error Source: response OperationId: ActionGroups_Update |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Insights/actiongroups/actiongrkmlkof' under resource group 'apiTest-BOcLFG-22993' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ActionGroups_EnableReceiver |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: error Source: response OperationId: ActionGroups_EnableReceiver |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Insights/actiongroups/actiongrkmlkof' under resource group 'apiTest-BOcLFG-22993' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ActionGroups_CreateNotificationsAtActionGroupResourceLevel |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: error Source: response OperationId: ActionGroups_CreateNotificationsAtActionGroupResourceLevel |
CLIENT_ERROR |
statusCode: 400, errorCode: LocationNotAvailableForResourceType, errorMessage: The provided location 'westcentralus' is not available for resource type 'microsoft.insights/metricalerts'. List of available regions for the resource type is 'global,westeurope,northeurope,swedencentral,germanywestcentral,eastus2euap'. Source: runtime OperationId: MetricAlerts_CreateOrUpdate |
INVALID_FORMAT |
Object didn't pass validation for format duration: Pt1m Source: request OperationId: MetricAlerts_CreateOrUpdate |
INVALID_FORMAT |
Object didn't pass validation for format duration: Pt15m Source: request OperationId: MetricAlerts_CreateOrUpdate |
INVALID_TYPE |
Expected type object but found type array Source: request OperationId: MetricAlerts_CreateOrUpdate |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: error Source: response OperationId: MetricAlerts_CreateOrUpdate |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Insights/metricalerts/rulename2att2l' under resource group 'apiTest-BOcLFG-22993' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: MetricAlerts_Get |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: error Source: response OperationId: MetricAlerts_Get |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Insights/metricalerts/rulename2att2l' under resource group 'apiTest-BOcLFG-22993' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: MetricAlerts_Update |
INVALID_FORMAT |
Object didn't pass validation for format duration: Pt1m Source: request OperationId: MetricAlerts_Update |
INVALID_FORMAT |
Object didn't pass validation for format duration: Pt15m Source: request OperationId: MetricAlerts_Update |
INVALID_TYPE |
Expected type object but found type array Source: request OperationId: MetricAlerts_Update |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: error Source: response OperationId: MetricAlerts_Update |
CLIENT_ERROR |
statusCode: 404, errorCode: undefined, errorMessage: undefined Source: runtime OperationId: AlertRules_CreateOrUpdate |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Insights/alertrules/rulename2att2l' under resource group 'apiTest-BOcLFG-22993' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: AlertRules_Get |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: error Source: response OperationId: AlertRules_Get |
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
CadlAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
Hi, @meydand your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
...r/resource-manager/Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json
Show resolved
Hide resolved
Hi @meydand, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
Hi, @meydand. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
@ArcturusZhang - I fixed the autorest file. |
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.