-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert Standard_Basic sku type for Application Gateway #22702
Conversation
Hi, @amperugu Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
applicationGateway.json | 2022-07-01(d364752) | 2022-07-01(main) |
Rule | Message |
---|---|
1019 - RemovedEnumValue |
The new version is removing enum value(s) 'Standard_Basic' from the old version. New: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L1285:9 Old: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L1285:9 |
1019 - RemovedEnumValue |
The new version is removing enum value(s) 'Standard_Basic' from the old version. New: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L1302:9 Old: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L1303:9 |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.0.0) | new version | base version |
---|---|---|
package-2022-07 | package-2022-07(d364752) | package-2022-07(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
ResourceNameRestriction |
The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L37 |
LongRunningResponseStatusCode |
A 'delete' operation 'ApplicationGateways_Delete' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 204. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L38 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L72 |
PatchIdentityProperty |
The patch operation body parameter schema should contains property 'identity'. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L234 |
ResourceNameRestriction |
The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L351 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L389 |
ResourceNameRestriction |
The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L405 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L443 |
ResourceNameRestriction |
The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L459 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L507 |
ResourceNameRestriction |
The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L523 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L580 |
ResourceNameRestriction |
The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L596 |
ResourceNameRestriction |
The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L649 |
ResourceNameRestriction |
The resource name parameter 'connectionName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L649 |
LongRunningResponseStatusCode |
A 'delete' operation 'ApplicationGatewayPrivateEndpointConnections_Delete' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 204. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L650 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L691 |
CreateOperationAsyncResponseValidation |
An async PUT operation must return 201. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L756 |
CreateOperationAsyncResponseValidation |
Only 201 is the supported response code for PUT async response. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L763 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L763 |
ResourceNameRestriction |
The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L839 |
DefaultErrorResponseSchema |
the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L919 |
DefaultErrorResponseSchema |
the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L955 |
DefaultErrorResponseSchema |
the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L991 |
TrackedResourcePatchOperation |
Tracked resource 'ApplicationGatewayAvailableSslOptions' must have patch operation that at least supports the update of tags. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L1036 |
TrackedResourcesMustHavePut |
The tracked resource ApplicationGatewayAvailableSslOptions does not have a corresponding put operation. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L1036 |
ResourceNameRestriction |
The resource name parameter 'predefinedPolicyName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L1111 |
MissingTypeObject |
The schema 'ApplicationGatewayOnDemandProbe' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L1156 |
MissingTypeObject |
The schema 'ApplicationGatewayBackendHealthOnDemand' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L1194 |
MissingTypeObject |
The schema 'ApplicationGatewayBackendHealth' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L1207 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️
~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️❌
SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️
CadlAPIView succeeded [Detail] [Expand]
️❌
ModelValidation: 25 Errors, 0 Warnings failed [Detail]
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Rule | Message |
---|---|
RestBuild error |
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=347874&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Unable to load the service index for source https://apidrop.pkgs.visualstudio.com/_packaging/ReferenceAutomationTool/nuget/v3/index.json." |
️️✔️
azure-sdk-for-net succeeded [Detail] [Expand]
command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️
Microsoft.Azure.Management.Network [View full logs] [Release SDK Changes]
️️✔️
azure-sdk-for-net-track2 succeeded [Detail] [Expand]
command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️
Azure.ResourceManager.Network [View full logs] [Release SDK Changes]info [Changelog]
️🔄
azure-sdk-for-python-track2 inProgress [Detail]
️️✔️
azure-sdk-for-java succeeded [Detail] [Expand]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️
azure-resourcemanager-network-generated [View full logs] [Release SDK Changes]
️️✔️
azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️
sdk/resourcemanager/network/armnetwork [View full logs] [Release SDK Changes]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️️✔️
azure-sdk-for-js succeeded [Detail] [Expand]
command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️
@azure/arm-network [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Interface AdminRuleCollectionsListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface AdminRuleCollectionsListNextOptionalParams no longer has parameter top info [Changelog] - Interface AdminRulesListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface AdminRulesListNextOptionalParams no longer has parameter top info [Changelog] - Interface ConnectivityConfigurationsListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface ConnectivityConfigurationsListNextOptionalParams no longer has parameter top info [Changelog] - Interface ManagementGroupNetworkManagerConnectionsListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface ManagementGroupNetworkManagerConnectionsListNextOptionalParams no longer has parameter top info [Changelog] - Interface NetworkGroupsListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface NetworkGroupsListNextOptionalParams no longer has parameter top info [Changelog] - Interface NetworkInterfacesListVirtualMachineScaleSetIpConfigurationsNextOptionalParams no longer has parameter expand info [Changelog] - Interface NetworkManagersListBySubscriptionNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface NetworkManagersListBySubscriptionNextOptionalParams no longer has parameter top info [Changelog] - Interface NetworkManagersListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface NetworkManagersListNextOptionalParams no longer has parameter top info [Changelog] - Interface ScopeConnectionsListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface ScopeConnectionsListNextOptionalParams no longer has parameter top info [Changelog] - Interface SecurityAdminConfigurationsListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface SecurityAdminConfigurationsListNextOptionalParams no longer has parameter top info [Changelog] - Interface ServiceTagInformationListNextOptionalParams no longer has parameter noAddressPrefixes info [Changelog] - Interface ServiceTagInformationListNextOptionalParams no longer has parameter tagName info [Changelog] - Interface StaticMembersListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface StaticMembersListNextOptionalParams no longer has parameter top info [Changelog] - Interface SubscriptionNetworkManagerConnectionsListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface SubscriptionNetworkManagerConnectionsListNextOptionalParams no longer has parameter top info [Changelog] - Interface VirtualNetworksListDdosProtectionStatusNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface VirtualNetworksListDdosProtectionStatusNextOptionalParams no longer has parameter top
️🔄
azure-resource-manager-schemas inProgress [Detail]
️❌
azure-powershell failed [Detail]
command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
❌
Az.network [View full logs] [Release SDK Changes]
Generated ApiView
|
Thank you for your contribution amperugu! We will review the pull request and get back to you soon. |
Hi @amperugu, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Hi @amperugu, Your PR has some issues. Please fix the CI sequentially by following the order of
|
@MikhailTryakhov , can you approve the change? @amperugu , please follow breaking change review instructions to get the approval. |
This PR is to revert the changes in PR #21976 |
The enum needs to be removed for the following reasons:
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@akning-ms , can you force merge this PR since python sdk check always hit time out? |
* Add new tier and sku for standard_basic * spaces * Revert Standard_Basic sku type for Application Gateway
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.
The enum needs to be removed for the following reasons: