Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Azure Database Migration Service to Azure Database Migration Service to Azure Database Migration Service (classic) #22501

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

ash1625
Copy link
Contributor

@ash1625 ash1625 commented Feb 8, 2023

Rename Azure Database Migration Service to Azure Database Migration Service to Azure Database Migration Service (classic)

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify - Rename Azure Database Migration Service to Azure Database Migration Service to Azure Database Migration Service (classic)
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@ash1625 ash1625 requested a review from hitenjava as a code owner February 8, 2023 04:31
@openapi-workflow-bot
Copy link

Hi, @ash1625 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 8, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.10.4)] new version base version
    datamigration.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    Commands.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    Common.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    ConnectToSourceMySqlTask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    ConnectToSourcePostgreSqlSyncTask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    ConnectToSourceSqlServerTask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    ConnectToTargetAzureDbForMySqlTask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    ConnectToTargetAzureDbForPostgreSqlSyncTask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    ConnectToTargetSqlDbTask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    ConnectToTargetSqlMITask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    ConnectToTargetSqlMiSyncTask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    ConnectToTargetSqlSqlDbSyncTask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    Files.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    GetTdeCertificatesSqlTask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    GetUserTablesMySqlTask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    GetUserTablesSqlSyncTask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    GetUserTablesSqlTask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    MigrateMySqlAzureDbForMySqlOfflineTask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    MigrateMySqlAzureDbForMySqlSyncTask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    MigratePostgreSqlAzureDbForPostgreSqlSyncTask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    MigrateSchemaSqlServerSqlDbTask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    MigrateSqlServerSqlDbSyncTask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    MigrateSqlServerSqlDbTask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    MigrateSqlServerSqlMITask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    MigrateSqlServerSqlMiSyncTask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    MigrateSsisTask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    MigrationValidation.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    MongoDbTasks.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    OracleAzureDbPostgreSqlSyncTask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    Projects.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    ResourceSkus.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    ServiceFeatureOCITask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    ServiceTasks.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    Services.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    Tasks.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    TasksCommon.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    ValidateMigrationInputSqlServerSqlMITask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    ValidateMigrationInputSqlServerSqlMiSyncTask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    ValidateSyncMigrationInputSqlServerTask.json 2022-03-30-preview(428d4e1) 2022-03-30-preview(main)
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-preview-2022-03 package-preview-2022-03(428d4e1) package-preview-2022-03(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.DataMigration/preview/2022-03-30-preview/datamigration.json#L97
    CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.DataMigration/preview/2022-03-30-preview/datamigration.json#L130
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.DataMigration/preview/2022-03-30-preview/datamigration.json#L170
    PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.DataMigration/preview/2022-03-30-preview/datamigration.json#L293
    PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.DataMigration/preview/2022-03-30-preview/datamigration.json#L339
    GetCollectionResponseSchema The response in the GET collection operation 'Tasks_List' does not match the response definition in the individual GET operation 'Tasks_Get' .
    Location: Microsoft.DataMigration/preview/2022-03-30-preview/datamigration.json#L432
    GetCollectionResponseSchema The response in the GET collection operation 'ServiceTasks_List' does not match the response definition in the individual GET operation 'ServiceTasks_Get' .
    Location: Microsoft.DataMigration/preview/2022-03-30-preview/datamigration.json#L486
    GetCollectionResponseSchema The response in the GET collection operation 'Services_ListByResourceGroup' does not match the response definition in the individual GET operation 'Services_Get' .
    Location: Microsoft.DataMigration/preview/2022-03-30-preview/datamigration.json#L584
    GetCollectionResponseSchema The response in the GET collection operation 'Projects_List' does not match the response definition in the individual GET operation 'Projects_Get' .
    Location: Microsoft.DataMigration/preview/2022-03-30-preview/datamigration.json#L1157
    GetCollectionResponseSchema The response in the GET collection operation 'Files_List' does not match the response definition in the individual GET operation 'Files_Get' .
    Location: Microsoft.DataMigration/preview/2022-03-30-preview/datamigration.json#L1449
    XmsIdentifierValidation Missing identifier id in array item property
    Location: preview/2022-03-30-preview/definitions/Commands.json#L39
    XmsIdentifierValidation Missing identifier id in array item property
    Location: preview/2022-03-30-preview/definitions/Commands.json#L121
    XmsIdentifierValidation Missing identifier id in array item property
    Location: preview/2022-03-30-preview/definitions/Commands.json#L169
    XmsIdentifierValidation Missing identifier id in array item property
    Location: preview/2022-03-30-preview/definitions/Common.json#L87
    IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: preview/2022-03-30-preview/definitions/Common.json#L171
    MissingTypeObject The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: preview/2022-03-30-preview/definitions/Common.json#L181
    IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: preview/2022-03-30-preview/definitions/Common.json#L280
    IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: preview/2022-03-30-preview/definitions/Common.json#L315
    IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: preview/2022-03-30-preview/definitions/Common.json#L382
    IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: preview/2022-03-30-preview/definitions/Common.json#L427
    IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: preview/2022-03-30-preview/definitions/Common.json#L466
    XmsIdentifierValidation Missing identifier id in array item property
    Location: preview/2022-03-30-preview/definitions/Common.json#L595
    IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: preview/2022-03-30-preview/definitions/Common.json#L648
    XmsIdentifierValidation Missing identifier id in array item property
    Location: preview/2022-03-30-preview/definitions/ConnectToSourcePostgreSqlSyncTask.json#L60
    XmsIdentifierValidation Missing identifier id in array item property
    Location: preview/2022-03-30-preview/definitions/ConnectToSourceSqlServerTask.json#L132
    XmsIdentifierValidation Missing identifier id in array item property
    Location: preview/2022-03-30-preview/definitions/ConnectToSourceSqlServerTask.json#L256
    XmsIdentifierValidation Missing identifier id in array item property
    Location: preview/2022-03-30-preview/definitions/ConnectToTargetAzureDbForMySqlTask.json#L70
    XmsIdentifierValidation Missing identifier id in array item property
    Location: preview/2022-03-30-preview/definitions/ConnectToTargetAzureDbForPostgreSqlSyncTask.json#L65
    XmsIdentifierValidation Missing identifier id in array item property
    Location: preview/2022-03-30-preview/definitions/ConnectToTargetSqlMiSyncTask.json#L52
    XmsIdentifierValidation Missing identifier id in array item property
    Location: preview/2022-03-30-preview/definitions/ConnectToTargetSqlMITask.json#L83
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️❌ModelValidation: 12 Errors, 0 Warnings failed [Detail]
    Rule Message
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DataMigration/preview/2022-03-30-preview/datamigration.json#L190:22
    ExampleUrl: preview/2022-03-30-preview/examples/Services_Delete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DataMigration/preview/2022-03-30-preview/datamigration.json#L228:22
    ExampleUrl: preview/2022-03-30-preview/examples/Services_Update.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DataMigration/preview/2022-03-30-preview/datamigration.json#L322:22
    ExampleUrl: preview/2022-03-30-preview/examples/Services_Start.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.DataMigration/preview/2022-03-30-preview/datamigration.json#L368:22
    ExampleUrl: preview/2022-03-30-preview/examples/Services_Stop.json
    DISCRIMINATOR_VALUE_NOT_FOUND Discriminator value "Service.Check.OCI" not found
    Url: preview/2022-03-30-preview/definitions/Tasks.json#L20:30
    ExampleUrl: preview/2022-03-30-preview/examples/ServiceTasks_List.json#L17:27
    DISCRIMINATOR_VALUE_NOT_FOUND Discriminator value "Service.Check.OCI" not found
    Url: Microsoft.DataMigration/preview/2022-03-30-preview/datamigration.json#L20:30
    ExampleUrl: preview/2022-03-30-preview/examples/ServiceTasks_CreateOrUpdate.json#L8:19
    DISCRIMINATOR_VALUE_NOT_FOUND Discriminator value "Service.Check.OCI" not found
    Url: preview/2022-03-30-preview/definitions/Tasks.json#L20:30
    ExampleUrl: preview/2022-03-30-preview/examples/ServiceTasks_CreateOrUpdate.json#L24:23
    DISCRIMINATOR_VALUE_NOT_FOUND Discriminator value "Service.Check.OCI" not found
    Url: preview/2022-03-30-preview/definitions/Tasks.json#L20:30
    ExampleUrl: preview/2022-03-30-preview/examples/ServiceTasks_CreateOrUpdate.json#L39:23
    DISCRIMINATOR_VALUE_NOT_FOUND Discriminator value "Service.Check.OCI" not found
    Url: preview/2022-03-30-preview/definitions/Tasks.json#L20:30
    ExampleUrl: preview/2022-03-30-preview/examples/ServiceTasks_Get.json#L16:23
    DISCRIMINATOR_VALUE_NOT_FOUND Discriminator value "Service.Check.OCI" not found
    Url: Microsoft.DataMigration/preview/2022-03-30-preview/datamigration.json#L20:30
    ExampleUrl: preview/2022-03-30-preview/examples/ServiceTasks_Update.json#L8:19
    DISCRIMINATOR_VALUE_NOT_FOUND Discriminator value "Service.Check.OCI" not found
    Url: preview/2022-03-30-preview/definitions/Tasks.json#L20:30
    ExampleUrl: preview/2022-03-30-preview/examples/ServiceTasks_Update.json#L24:23
    DISCRIMINATOR_VALUE_NOT_FOUND Discriminator value "Service.Check.OCI" not found
    Url: preview/2022-03-30-preview/definitions/Tasks.json#L20:30
    ExampleUrl: preview/2022-03-30-preview/examples/ServiceTasks_Cancel.json#L16:23
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 8, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/datamigration/armdatamigration - 2.0.0-beta.1
    +	Field `ServiceOperationList` of struct `OperationsClientListResponse` has been removed
    +	Type of `CheckOCIDriverTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `CommandProperties.CommandType` has been changed from `*string` to `*CommandType`
    +	Type of `ConnectToMongoDbTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `ConnectToSourceMySQLTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `ConnectToSourceOracleSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `ConnectToSourcePostgreSQLSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `ConnectToSourceSQLServerSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `ConnectToSourceSQLServerTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `ConnectToTargetAzureDbForMySQLTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `ConnectToTargetAzureDbForPostgreSQLSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `ConnectToTargetOracleAzureDbForPostgreSQLSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `ConnectToTargetSQLDbSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `ConnectToTargetSQLDbTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `ConnectToTargetSQLMISyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `ConnectToTargetSQLMITaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `GetTdeCertificatesSQLTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `GetUserTablesMySQLTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `GetUserTablesOracleTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `GetUserTablesPostgreSQLTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `GetUserTablesSQLSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `GetUserTablesSQLTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `InstallOCIDriverTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `MigrateMISyncCompleteCommandProperties.CommandType` has been changed from `*string` to `*CommandType`
    +	Type of `MigrateMongoDbTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `MigrateMySQLAzureDbForMySQLOfflineTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `MigrateMySQLAzureDbForMySQLSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `MigrateOracleAzureDbForPostgreSQLSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `MigratePostgreSQLAzureDbForPostgreSQLSyncDatabaseInput.MigrationSetting` has been changed from `map[string]*string` to `map[string]any`
    +	Type of `MigratePostgreSQLAzureDbForPostgreSQLSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `MigrateSQLServerSQLDbSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `MigrateSQLServerSQLDbTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `MigrateSQLServerSQLMISyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `MigrateSQLServerSQLMITaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `MigrateSchemaSQLServerSQLDbTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `MigrateSsisTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `MigrateSyncCompleteCommandProperties.CommandType` has been changed from `*string` to `*CommandType`
    +	Type of `MongoDbCancelCommand.CommandType` has been changed from `*string` to `*CommandType`
    +	Type of `MongoDbFinishCommand.CommandType` has been changed from `*string` to `*CommandType`
    +	Type of `MongoDbRestartCommand.CommandType` has been changed from `*string` to `*CommandType`
    +	Type of `ProjectTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `UploadOCIDriverTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `ValidateMigrationInputSQLServerSQLDbSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `ValidateMigrationInputSQLServerSQLMISyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `ValidateMigrationInputSQLServerSQLMITaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `ValidateMongoDbTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
    +	Type of `ValidateOracleAzureDbForPostgreSQLSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`

    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 3443f1b. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.4.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.4.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-datamigration [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 3443f1b. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/datamigration/armdatamigration [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog] - New struct `DatabaseMigrationsSQLDbClient`
      info	[Changelog] - New struct `DatabaseMigrationsSQLDbClientCancelResponse`
      info	[Changelog] - New struct `DatabaseMigrationsSQLDbClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `DatabaseMigrationsSQLDbClientDeleteResponse`
      info	[Changelog] - New struct `DatabaseMigrationsSQLMiClient`
      info	[Changelog] - New struct `DatabaseMigrationsSQLMiClientCancelResponse`
      info	[Changelog] - New struct `DatabaseMigrationsSQLMiClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `DatabaseMigrationsSQLMiClientCutoverResponse`
      info	[Changelog] - New struct `DatabaseMigrationsSQLVMClient`
      info	[Changelog] - New struct `DatabaseMigrationsSQLVMClientCancelResponse`
      info	[Changelog] - New struct `DatabaseMigrationsSQLVMClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `DatabaseMigrationsSQLVMClientCutoverResponse`
      info	[Changelog] - New struct `DeleteNode`
      info	[Changelog] - New struct `ErrorInfo`
      info	[Changelog] - New struct `IntegrationRuntimeMonitoringData`
      info	[Changelog] - New struct `MigrationOperationInput`
      info	[Changelog] - New struct `MigrationStatusDetails`
      info	[Changelog] - New struct `NodeMonitoringData`
      info	[Changelog] - New struct `OfflineConfiguration`
      info	[Changelog] - New struct `OperationListResult`
      info	[Changelog] - New struct `OperationsDefinition`
      info	[Changelog] - New struct `OperationsDisplayDefinition`
      info	[Changelog] - New struct `ProxyResource`
      info	[Changelog] - New struct `RegenAuthKeys`
      info	[Changelog] - New struct `SQLBackupFileInfo`
      info	[Changelog] - New struct `SQLBackupSetInfo`
      info	[Changelog] - New struct `SQLConnectionInformation`
      info	[Changelog] - New struct `SQLDbMigrationStatusDetails`
      info	[Changelog] - New struct `SQLDbOfflineConfiguration`
      info	[Changelog] - New struct `SQLFileShare`
      info	[Changelog] - New struct `SQLMigrationListResult`
      info	[Changelog] - New struct `SQLMigrationService`
      info	[Changelog] - New struct `SQLMigrationServiceProperties`
      info	[Changelog] - New struct `SQLMigrationServiceUpdate`
      info	[Changelog] - New struct `SQLMigrationServicesClient`
      info	[Changelog] - New struct `SQLMigrationServicesClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `SQLMigrationServicesClientDeleteResponse`
      info	[Changelog] - New struct `SQLMigrationServicesClientListByResourceGroupResponse`
      info	[Changelog] - New struct `SQLMigrationServicesClientListBySubscriptionResponse`
      info	[Changelog] - New struct `SQLMigrationServicesClientListMigrationsResponse`
      info	[Changelog] - New struct `SQLMigrationServicesClientUpdateResponse`
      info	[Changelog] - New struct `SourceLocation`
      info	[Changelog] - New struct `TargetLocation`
      info	[Changelog] - New field `IgnoreAzurePermissions` in struct `AzureActiveDirectoryApp`
      info	[Changelog] - New field `EncryptedKeyForSecureFields` in struct `ConnectToSourceSQLServerTaskInput`
      info	[Changelog] - New field `TaskID` in struct `ConnectToSourceSQLServerTaskProperties`
      info	[Changelog] - New field `QueryObjectCounts` in struct `ConnectToTargetSQLDbTaskInput`
      info	[Changelog] - New field `CreatedOn` in struct `ConnectToTargetSQLDbTaskProperties`
      info	[Changelog] - New field `EncryptedKeyForSecureFields` in struct `GetUserTablesSQLTaskInput`
      info	[Changelog] - New field `TaskID` in struct `GetUserTablesSQLTaskProperties`
      info	[Changelog] - New field `EncryptedKeyForSecureFields` in struct `MigrateMySQLAzureDbForMySQLOfflineTaskInput`
      info	[Changelog] - New field `IsCloneable` in struct `MigrateMySQLAzureDbForMySQLOfflineTaskProperties`
      info	[Changelog] - New field `TaskID` in struct `MigrateMySQLAzureDbForMySQLOfflineTaskProperties`
      info	[Changelog] - New field `ID` in struct `MigratePostgreSQLAzureDbForPostgreSQLSyncDatabaseInput`
      info	[Changelog] - New field `EncryptedKeyForSecureFields` in struct `MigratePostgreSQLAzureDbForPostgreSQLSyncTaskInput`
      info	[Changelog] - New field `StartedOn` in struct `MigratePostgreSQLAzureDbForPostgreSQLSyncTaskInput`
      info	[Changelog] - New field `Events` in struct `MigratePostgreSQLAzureDbForPostgreSQLSyncTaskOutputError`
      info	[Changelog] - New field `DatabaseCount` in struct `MigratePostgreSQLAzureDbForPostgreSQLSyncTaskOutputMigrationLevel`
      info	[Changelog] - New field `CreatedOn` in struct `MigratePostgreSQLAzureDbForPostgreSQLSyncTaskProperties`
      info	[Changelog] - New field `IsCloneable` in struct `MigratePostgreSQLAzureDbForPostgreSQLSyncTaskProperties`
      info	[Changelog] - New field `TaskID` in struct `MigratePostgreSQLAzureDbForPostgreSQLSyncTaskProperties`
      info	[Changelog] - New field `ID` in struct `MigrateSQLServerSQLDbDatabaseInput`
      info	[Changelog] - New field `SchemaSetting` in struct `MigrateSQLServerSQLDbDatabaseInput`
      info	[Changelog] - New field `EncryptedKeyForSecureFields` in struct `MigrateSQLServerSQLDbTaskInput`
      info	[Changelog] - New field `StartedOn` in struct `MigrateSQLServerSQLDbTaskInput`
      info	[Changelog] - New field `CreatedOn` in struct `MigrateSQLServerSQLDbTaskProperties`
      info	[Changelog] - New field `IsCloneable` in struct `MigrateSQLServerSQLDbTaskProperties`
      info	[Changelog] - New field `TaskID` in struct `MigrateSQLServerSQLDbTaskProperties`
      info	[Changelog] - New field `ID` in struct `MigrateSQLServerSQLMIDatabaseInput`
      info	[Changelog] - New field `NumberOfParallelDatabaseMigrations` in struct `MigrateSQLServerSQLMISyncTaskInput`
      info	[Changelog] - New field `CreatedOn` in struct `MigrateSQLServerSQLMISyncTaskProperties`
      info	[Changelog] - New field `EncryptedKeyForSecureFields` in struct `MigrateSQLServerSQLMITaskInput`
      info	[Changelog] - New field `StartedOn` in struct `MigrateSQLServerSQLMITaskInput`
      info	[Changelog] - New field `CreatedOn` in struct `MigrateSQLServerSQLMITaskProperties`
      info	[Changelog] - New field `IsCloneable` in struct `MigrateSQLServerSQLMITaskProperties`
      info	[Changelog] - New field `ParentTaskID` in struct `MigrateSQLServerSQLMITaskProperties`
      info	[Changelog] - New field `TaskID` in struct `MigrateSQLServerSQLMITaskProperties`
      info	[Changelog] - New field `ID` in struct `MigrateSchemaSQLServerSQLDbDatabaseInput`
      info	[Changelog] - New field `EncryptedKeyForSecureFields` in struct `MigrateSchemaSQLServerSQLDbTaskInput`
      info	[Changelog] - New field `StartedOn` in struct `MigrateSchemaSQLServerSQLDbTaskInput`
      info	[Changelog] - New field `CreatedOn` in struct `MigrateSchemaSQLServerSQLDbTaskProperties`
      info	[Changelog] - New field `IsCloneable` in struct `MigrateSchemaSQLServerSQLDbTaskProperties`
      info	[Changelog] - New field `TaskID` in struct `MigrateSchemaSQLServerSQLDbTaskProperties`
      info	[Changelog] - New field `CommandID` in struct `MigrateSyncCompleteCommandProperties`
      info	[Changelog] - New field `AdditionalSettings` in struct `MongoDbConnectionInfo`
      info	[Changelog] - New field `Authentication` in struct `MongoDbConnectionInfo`
      info	[Changelog] - New field `DataSource` in struct `MongoDbConnectionInfo`
      info	[Changelog] - New field `EncryptConnection` in struct `MongoDbConnectionInfo`
      info	[Changelog] - New field `EnforceSSL` in struct `MongoDbConnectionInfo`
      info	[Changelog] - New field `Port` in struct `MongoDbConnectionInfo`
      info	[Changelog] - New field `ServerBrandVersion` in struct `MongoDbConnectionInfo`
      info	[Changelog] - New field `ServerName` in struct `MongoDbConnectionInfo`
      info	[Changelog] - New field `ServerVersion` in struct `MongoDbConnectionInfo`
      info	[Changelog] - New field `TrustServerCertificate` in struct `MongoDbConnectionInfo`
      info	[Changelog] - New field `AdditionalSettings` in struct `MySQLConnectionInfo`
      info	[Changelog] - New field `Authentication` in struct `MySQLConnectionInfo`
      info	[Changelog] - New field `DataSource` in struct `MySQLConnectionInfo`
      info	[Changelog] - New anonymous field `OperationListResult` in struct `OperationsClientListResponse`
      info	[Changelog] - New field `Authentication` in struct `OracleConnectionInfo`
      info	[Changelog] - New field `Port` in struct `OracleConnectionInfo`
      info	[Changelog] - New field `ServerName` in struct `OracleConnectionInfo`
      info	[Changelog] - New field `ServerVersion` in struct `OracleConnectionInfo`
      info	[Changelog] - New field `AdditionalSettings` in struct `PostgreSQLConnectionInfo`
      info	[Changelog] - New field `Authentication` in struct `PostgreSQLConnectionInfo`
      info	[Changelog] - New field `DataSource` in struct `PostgreSQLConnectionInfo`
      info	[Changelog] - New field `ServerBrandVersion` in struct `PostgreSQLConnectionInfo`
      info	[Changelog] - New field `ServerVersion` in struct `PostgreSQLConnectionInfo`
      info	[Changelog] - New field `Etag` in struct `Project`
      info	[Changelog] - New field `AzureAuthenticationInfo` in struct `ProjectProperties`
      info	[Changelog] - New field `Port` in struct `SQLConnectionInfo`
      info	[Changelog] - New field `ResourceID` in struct `SQLConnectionInfo`
      info	[Changelog] - New field `ServerBrandVersion` in struct `SQLConnectionInfo`
      info	[Changelog] - New field `ServerName` in struct `SQLConnectionInfo`
      info	[Changelog] - New field `ServerVersion` in struct `SQLConnectionInfo`
      info	[Changelog] - New field `FileName` in struct `SchemaMigrationSetting`
      info	[Changelog] - New field `AutoStopDelay` in struct `ServiceProperties`
      info	[Changelog] - New field `DeleteResourcesOnStop` in struct `ServiceProperties`
      info	[Changelog] - New field `AgentConfiguration` in struct `ServiceStatusResponse`
      info	[Changelog]
      info	[Changelog] Total 47 breaking change(s), 232 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 3443f1b. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-datamigration [View full logs]  [Release SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 3443f1b. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-datamigration [View full logs]  [Release SDK Changes]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 3443f1b. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️datamigration [View full logs]  [Release Schema Changes]
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 3443f1b. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.DataMigration [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 8, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/datamigration/armdatamigration https://apiview.dev/Assemblies/Review/6f3d58fe11b549249fcc12e189ded1e5
    Java azure-resourcemanager-datamigration https://apiview.dev/Assemblies/Review/37942d27b1d8435b90391c9df1f65b1d
    .Net Azure.ResourceManager.DataMigration https://apiview.dev/Assemblies/Review/419c4fa1d20a405d9aa27e15b0ac997b
    JavaScript @azure/arm-datamigration https://apiview.dev/Assemblies/Review/c702f8d06d294aa3902be17d0a099b35

    @openapi-workflow-bot
    Copy link

    Hi @ash1625, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @hitenjava hitenjava removed their request for review February 8, 2023 22:07
    @AzureRestAPISpecReview AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Feb 9, 2023
    @openapi-workflow-bot
    Copy link

    Hi @ash1625, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @AzureRestAPISpecReview AzureRestAPISpecReview removed the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Feb 9, 2023
    @xiaoxuqi-ms
    Copy link
    Member

    As discussed offline, model validation errors will be fixed in another pr. And since this pr only update the document, SDK breaking change will be ignored.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants