[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2023-01-15 #22431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| bms.json | 2023-01-15(47ae9c4) | 2023-01-01(main) |
| bms.json | 2023-01-15(47ae9c4) | 2022-09-30-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 23 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig' removed or restructured? Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L21:5 |
|
The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupPreValidateProtection' removed or restructured? Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L164:5 |
|
The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupStatus' removed or restructured? Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L209:5 |
|
The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupValidateFeatures' removed or restructured? Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L254:5 |
|
The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/backupProtectionIntent/{intentObjectName}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L299:5 |
|
The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupProtectionIntents' removed or restructured? Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L460:5 |
|
The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupUsageSummaries' removed or restructured? Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L517:5 |
|
The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.RecoveryServices/operations' removed or restructured? Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L577:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupconfig/vaultconfig' removed or restructured? Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L608:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupEncryptionConfigs/backupResourceEncryptionConfig' removed or restructured? Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L757:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections/{privateEndpointConnectionName}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L851:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections/{privateEndpointConnectionName}/operationsStatus/{operationId}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L1023:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig/operationStatus/{operationId}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L1082:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig/prepareDataMove' removed or restructured? Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L1133:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig/operationResults/{operationId}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L1188:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig/triggerDataMove' removed or restructured? Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L1242:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L1297:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}/operationResults/{operationId}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L1520:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}/recoveryPoints' removed or restructured? Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L1599:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}/recoveryPoints/{recoveryPointId}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L1676:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}/recoveryPoints/{recoveryPointId}/restore' removed or restructured? Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L1749:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupPolicies' removed or restructured? Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L1844:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupPolicies/{policyName}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2023-01-01/bms.json#L1906:5 |
The following breaking changes are detected by comparison with the latest preview version:
Only 23 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig' removed or restructured? Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L21:5 |
|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupPreValidateProtection' removed or restructured? Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L164:5 |
|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupStatus' removed or restructured? Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L209:5 |
|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupValidateFeatures' removed or restructured? Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L254:5 |
|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/backupProtectionIntent/{intentObjectName}' removed or restructured? Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L299:5 |
|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupProtectionIntents' removed or restructured? Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L460:5 |
|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupUsageSummaries' removed or restructured? Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L517:5 |
|
| The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.RecoveryServices/operations' removed or restructured? Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L577:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupconfig/vaultconfig' removed or restructured? Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L608:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupEncryptionConfigs/backupResourceEncryptionConfig' removed or restructured? Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L757:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections/{privateEndpointConnectionName}' removed or restructured? Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L851:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections/{privateEndpointConnectionName}/operationsStatus/{operationId}' removed or restructured? Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L1023:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig/operationStatus/{operationId}' removed or restructured? Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L1082:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig/prepareDataMove' removed or restructured? Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L1133:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig/operationResults/{operationId}' removed or restructured? Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L1188:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig/triggerDataMove' removed or restructured? Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L1242:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}' removed or restructured? Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L1297:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}/operationResults/{operationId}' removed or restructured? Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L1520:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}/recoveryPoints' removed or restructured? Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L1599:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}/recoveryPoints/{recoveryPointId}' removed or restructured? Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L1676:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}/recoveryPoints/{recoveryPointId}/restore' removed or restructured? Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L1749:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupPolicies' removed or restructured? Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L1844:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupPolicies/{policyName}' removed or restructured? Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/bms.json#L1906:5 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 56 Errors, 24 Warnings failed [Detail]
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-passivestamp-2023-01-15 | package-passivestamp-2023-01-15(47ae9c4) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 23 items are listed, please refer to log for more details.
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
|
Operations API must be implemented for 'Microsoft.RecoveryServices'. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L1 |
|
|
The resource name parameter 'vaultName' should be defined with a 'pattern' restriction. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L21 |
RPC-Uri-V1-05 |
|
The parameters:vaultName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L22 |
|
|
Tracked resource 'AADPropertiesResource' must have patch operation that at least supports the update of tags. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L87 |
RPC-Patch-V1-03 |
|
The tracked resource AADPropertiesResource does not have a corresponding put operation. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L87 |
RPC-Put-V1-22 |
|
An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options' Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L138 |
RPC-Async-V1-11 |
|
A 202 response should include an Location response header. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L171 |
RPC-Async-V1-07 |
|
The get operation should only return 200. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L345 |
RPC-Get-V1-01 |
|
A 202 response should include an Location response header. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L345 |
RPC-Async-V1-07 |
|
The resource name parameter 'vaultName' should be defined with a 'pattern' restriction. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L409 |
RPC-Uri-V1-05 |
|
The resource name parameter 'fabricName' should be defined with a 'pattern' restriction. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L409 |
RPC-Uri-V1-05 |
|
The resource name parameter 'containerName' should be defined with a 'pattern' restriction. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L409 |
RPC-Uri-V1-05 |
|
The resource name parameter 'protectedItemName' should be defined with a 'pattern' restriction. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L409 |
RPC-Uri-V1-05 |
|
The parameters:vaultName,resourceGroupName,fabricName,containerName,protectedItemName,recoveryPointId should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L410 |
|
|
The resource BackupResourceConfigResource does not have a corresponding delete operation. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L495 |
|
|
The path for nested resource doest not meet the valid resource pattern. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L495 |
RPC-Uri-V1-06,RPC-Put-V1-02 |
|
/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L495 |
RPC-Put-V1-12 |
|
The resource name parameter 'vaultName' should be defined with a 'pattern' restriction. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L495 |
RPC-Uri-V1-05 |
|
The parameters:vaultName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L496 |
|
|
The parameters:vaultName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L539 |
|
|
The parameters:vaultName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L591 |
|
|
The patch operation body parameter schema should not contains property name. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L610 |
RPC-Patch-V1-02 |
|
The patch operation body parameter schema should not contains property type. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L610 |
RPC-Patch-V1-02 |
The following errors/warnings exist before current PR submission:
Only 23 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The parameter 'SubscriptionId' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L4489 |
|
The parameter 'ApiVersion' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L4504 |
| The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L6 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L1507 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L2223 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L2227 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L2290 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L2294 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L2298 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L2351 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L2395 |
|
| Schema should have a description or title. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L2585 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L2596 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L2796 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L2800 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L2838 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L2860 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L3031 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L3040 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L3051 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L3059 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L3156 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.RecoveryServices/stable/2023-01-15/bms.json#L3160 |
️❌Avocado: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The readme file has more than one default tag. readme: specification/recoveryservicesbackup/resource-manager/readme.md |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
|
Hi, @profDisarray Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
ghost
added
the
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
|
Hi @profDisarray, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced Feb 2, 2023
Swagger Generation Artifacts
|
|
Hi @profDisarray, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
raych1
added
the
WaitForARMFeedback
NetRock
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
@profDisarray , can you follow above instructions to get breaking change reviewed? |
Hi @raych1, we are having the discussion with the respective team over a mail thread. There are some confusions. I will provide an update when everything is resolved and the breaking change is approved. |
raych1
added
the
Reviewed-ChangesRequested
sounds good. |
JeffreyRichter
added
the
Approved-BreakingChange
|
@profDisarray , can you resolve the conflicts and fix the CI check failures? |
…t.RecoveryServices-2023-01-15
|
For LintDiff failures: You can refer to this PR where similar thing was done #17044 |
raych1
approved these changes
Mar 28, 2023
raych1
deleted the
profDisarray-recoveryservicesbackup-Microsoft.RecoveryServices-2023-01-15
branch
This was referenced Mar 28, 2023
Closed
JoshLove-msft
pushed a commit
to JoshLove-msft/azure-rest-api-specs
that referenced
this pull request
Apr 25, 2023
…version stable/2023-01-15 (Azure#22431) * Adds base for updating Microsoft.RecoveryServices from version stable/2021-11-15 to version 2023-01-15 * Updates readme * Updates API version in new specs and examples * Adds RecoveryPointProperties for 2023-01-15 * Adds RecoveryPointProperties at missed places * Fixes API version in examples * Fixes model validation errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.