Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api freshness variable changed #22430

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Api freshness variable changed #22430

merged 1 commit into from
Feb 14, 2023

Conversation

manikprabhu1208
Copy link
Contributor

@manikprabhu1208 manikprabhu1208 commented Feb 2, 2023

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

We only changed “ApiFreshnessWindowInMinutes” to “ApiFreshnessTimeInMinutes” in the PR. We got feedback from the customers that the word “window” is causing confusion regarding the purpose of this variable. This is not a window but rather a time period for which we are going to refresh weather data in cache. 

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @manikprabhu1208 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 2, 2023

    Swagger Validation Report

    ️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    agfood.json 2021-09-01-preview(4a41c5f) 2021-09-01-preview(main)
    Rule Message
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'apiFreshnessWindowInMinutes' renamed or removed?
    New: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1622:7
    Old: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1622:7
    1041 - AddedPropertyInResponse The new version has a new property 'apiFreshnessTimeInMinutes' in response that was not found in the old version.
    New: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1622:7
    Old: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1622:7
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-preview-2021-09 package-preview-2021-09(4a41c5f) package-preview-2021-09(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ResourceNameRestriction The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L9
    ResourceNameRestriction The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L166
    ResourceNameRestriction The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L383
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property location.
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L513
    ResourceNameRestriction The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L721
    ResourceNameRestriction The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L867
    ResourceNameRestriction The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction.
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L867
    GetCollectionResponseSchema The response in the GET collection operation 'PrivateEndpointConnections_ListByResource' does not match the response definition in the individual GET operation 'PrivateEndpointConnections_Get' .
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1050
    ResourceNameRestriction The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1050
    GetCollectionResponseSchema The response in the GET collection operation 'PrivateLinkResources_ListByResource' does not match the response definition in the individual GET operation 'PrivateLinkResources_Get' .
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1098
    ResourceNameRestriction The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1098
    ResourceNameRestriction The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1146
    ResourceNameRestriction The resource name parameter 'subResourceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1146
    ResourceNameRestriction The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1205
    RepeatedPathInfo The 'solutionId' already appears in the path, please don't repeat it in the request body.
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1228
    ResourceNameRestriction The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1362
    TopLevelResourcesListBySubscription The top-level resource 'FarmBeatsExtension' does not have list by subscription operation, please add it.
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1867
    ProvisioningStateValidation ProvisioningState must have terminal states: Succeeded, Failed and Canceled.
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1909
    ProvisioningStateValidation ProvisioningState must have terminal states: Succeeded, Failed and Canceled.
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1952
    GuidUsage Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L2366
    GuidUsage Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L2372
    TopLevelResourcesListBySubscription The top-level resource 'FarmBeatsSolution' does not have list by subscription operation, please add it.
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L2402
    ⚠️ PreviewVersionOverOneYear The API version:2021-09-01-preview having been in a preview state over one year , please move it to GA or retire.
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L6
    ⚠️ PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Extensions_CreateOrUpdate' Request Model: 'parameters[5].schema' Response Model: 'responses[200].schema'
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L10
    ⚠️ PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Solutions_CreateOrUpdate' Request Model: 'parameters[5].schema' Response Model: 'responses[200].schema'
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1206
    ⚠️ LocationMustHaveXmsMutability Property location must have 'x-ms-mutability':['read', 'create'] extension defined.
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L2015
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L2022
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L2122
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L2139
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L2171
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 2, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/agrifood/armagrifood - Approved - 0.8.0
    +	Function `*ExtensionsClient.Create` has been removed
    +	Function `*ExtensionsClient.Update` has been removed
    azure-sdk-for-js - @azure/arm-agrifood - Approved - 1.0.0-beta.5
    +	Interface ExtensionsListByFarmBeatsNextOptionalParams no longer has parameter extensionCategories
    +	Interface ExtensionsListByFarmBeatsNextOptionalParams no longer has parameter extensionIds
    +	Interface ExtensionsListByFarmBeatsNextOptionalParams no longer has parameter maxPageSize
    +	Interface ExtensionsListByFarmBeatsNextOptionalParams no longer has parameter skipToken
    +	Interface FarmBeatsExtensionsListNextOptionalParams no longer has parameter extensionCategories
    +	Interface FarmBeatsExtensionsListNextOptionalParams no longer has parameter farmBeatsExtensionIds
    +	Interface FarmBeatsExtensionsListNextOptionalParams no longer has parameter farmBeatsExtensionNames
    +	Interface FarmBeatsExtensionsListNextOptionalParams no longer has parameter maxPageSize
    +	Interface FarmBeatsExtensionsListNextOptionalParams no longer has parameter publisherIds
    +	Interface FarmBeatsModelsListByResourceGroupNextOptionalParams no longer has parameter maxPageSize
    +	Interface FarmBeatsModelsListByResourceGroupNextOptionalParams no longer has parameter skipToken
    +	Interface FarmBeatsModelsListBySubscriptionNextOptionalParams no longer has parameter maxPageSize
    +	Interface FarmBeatsModelsListBySubscriptionNextOptionalParams no longer has parameter skipToken
    +	Removed operation Extensions.create
    +	Removed operation Extensions.update
    azure-sdk-for-python-track2 - track2_azure-mgmt-agrifood - Approved - 1.0.0b3
    +	Model ApiProperties no longer has parameter api_freshness_window_in_minutes
    +	Operation SolutionsOperations.create_or_update has a new required parameter solution_id
    +	Operation SolutionsOperations.delete has a new required parameter solution_id
    +	Operation SolutionsOperations.get has a new required parameter solution_id
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from e9f1cd4. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.4.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.4.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-agrifood [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model ApiProperties has a new parameter api_freshness_time_in_minutes
      info	[Changelog]   - Model FarmBeatsSolutionProperties has a new parameter action_ids
      info	[Changelog]   - Model FarmBeatsSolutionProperties has a new parameter saa_s_application_id
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model ApiProperties no longer has parameter api_freshness_window_in_minutes
      info	[Changelog]   - Operation SolutionsOperations.create_or_update has a new required parameter solution_id
      info	[Changelog]   - Operation SolutionsOperations.delete has a new required parameter solution_id
      info	[Changelog]   - Operation SolutionsOperations.get has a new required parameter solution_id
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e9f1cd4. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/agrifood/armagrifood [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `*ExtensionsClient.Create` has been removed
      info	[Changelog] - Function `*ExtensionsClient.Update` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New function `*ExtensionsClient.CreateOrUpdate(context.Context, string, string, string, *ExtensionsClientCreateOrUpdateOptions) (ExtensionsClientCreateOrUpdateResponse, error)`
      info	[Changelog] - New function `NewSolutionsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*SolutionsClient, error)`
      info	[Changelog] - New function `*SolutionsClient.CreateOrUpdate(context.Context, string, string, string, *SolutionsClientCreateOrUpdateOptions) (SolutionsClientCreateOrUpdateResponse, error)`
      info	[Changelog] - New function `*SolutionsClient.Delete(context.Context, string, string, string, *SolutionsClientDeleteOptions) (SolutionsClientDeleteResponse, error)`
      info	[Changelog] - New function `*SolutionsClient.Get(context.Context, string, string, string, *SolutionsClientGetOptions) (SolutionsClientGetResponse, error)`
      info	[Changelog] - New function `*SolutionsClient.NewListPager(string, string, *SolutionsClientListOptions) *runtime.Pager[SolutionsClientListResponse]`
      info	[Changelog] - New function `NewSolutionsDiscoverabilityClient(azcore.TokenCredential, *arm.ClientOptions) (*SolutionsDiscoverabilityClient, error)`
      info	[Changelog] - New function `*SolutionsDiscoverabilityClient.Get(context.Context, string, *SolutionsDiscoverabilityClientGetOptions) (SolutionsDiscoverabilityClientGetResponse, error)`
      info	[Changelog] - New function `*SolutionsDiscoverabilityClient.NewListPager(*SolutionsDiscoverabilityClientListOptions) *runtime.Pager[SolutionsDiscoverabilityClientListResponse]`
      info	[Changelog] - New struct `APIProperties`
      info	[Changelog] - New struct `ExtensionInstallationRequest`
      info	[Changelog] - New struct `FarmBeatsSolution`
      info	[Changelog] - New struct `FarmBeatsSolutionListResponse`
      info	[Changelog] - New struct `FarmBeatsSolutionProperties`
      info	[Changelog] - New struct `Insight`
      info	[Changelog] - New struct `InsightAttachment`
      info	[Changelog] - New struct `MarketplaceOfferDetails`
      info	[Changelog] - New struct `Measure`
      info	[Changelog] - New struct `ResourceParameter`
      info	[Changelog] - New struct `Solution`
      info	[Changelog] - New struct `SolutionEvaluatedOutput`
      info	[Changelog] - New struct `SolutionInstallationRequest`
      info	[Changelog] - New struct `SolutionListResponse`
      info	[Changelog] - New struct `SolutionProperties`
      info	[Changelog] - New struct `SolutionsClient`
      info	[Changelog] - New struct `SolutionsClientListResponse`
      info	[Changelog] - New struct `SolutionsDiscoverabilityClient`
      info	[Changelog] - New struct `SolutionsDiscoverabilityClientListResponse`
      info	[Changelog] - New field `AdditionalAPIProperties` in struct `ExtensionProperties`
      info	[Changelog] - New field `GroupIDs` in struct `PrivateEndpointConnectionProperties`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 49 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e9f1cd4. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-agrifood [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group Solutions
      info	[Changelog]   - Added operation group SolutionsDiscoverability
      info	[Changelog]   - Added operation Extensions.createOrUpdate
      info	[Changelog]   - Added Interface ApiProperties
      info	[Changelog]   - Added Interface ExtensionInstallationRequest
      info	[Changelog]   - Added Interface ExtensionsCreateOrUpdateOptionalParams
      info	[Changelog]   - Added Interface FarmBeatsSolution
      info	[Changelog]   - Added Interface FarmBeatsSolutionListResponse
      info	[Changelog]   - Added Interface FarmBeatsSolutionProperties
      info	[Changelog]   - Added Interface Insight
      info	[Changelog]   - Added Interface InsightAttachment
      info	[Changelog]   - Added Interface MarketplaceOfferDetails
      info	[Changelog]   - Added Interface Measure
      info	[Changelog]   - Added Interface ResourceParameter
      info	[Changelog]   - Added Interface Solution
      info	[Changelog]   - Added Interface SolutionEvaluatedOutput
      info	[Changelog]   - Added Interface SolutionInstallationRequest
      info	[Changelog]   - Added Interface SolutionListResponse
      info	[Changelog]   - Added Interface SolutionProperties
      info	[Changelog]   - Added Interface SolutionsCreateOrUpdateOptionalParams
      info	[Changelog]   - Added Interface SolutionsDeleteOptionalParams
      info	[Changelog]   - Added Interface SolutionsDiscoverabilityGetOptionalParams
      info	[Changelog]   - Added Interface SolutionsDiscoverabilityListNextOptionalParams
      info	[Changelog]   - Added Interface SolutionsDiscoverabilityListOptionalParams
      info	[Changelog]   - Added Interface SolutionsGetOptionalParams
      info	[Changelog]   - Added Interface SolutionsListNextOptionalParams
      info	[Changelog]   - Added Interface SolutionsListOptionalParams
      info	[Changelog]   - Added Type Alias ExtensionsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias SolutionsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias SolutionsDiscoverabilityGetResponse
      info	[Changelog]   - Added Type Alias SolutionsDiscoverabilityListNextResponse
      info	[Changelog]   - Added Type Alias SolutionsDiscoverabilityListResponse
      info	[Changelog]   - Added Type Alias SolutionsGetResponse
      info	[Changelog]   - Added Type Alias SolutionsListNextResponse
      info	[Changelog]   - Added Type Alias SolutionsListResponse
      info	[Changelog]   - Interface Extension has a new optional parameter additionalApiProperties
      info	[Changelog]   - Interface PrivateEndpointConnection has a new optional parameter groupIds
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation Extensions.create
      info	[Changelog]   - Removed operation Extensions.update
      info	[Changelog]   - Interface ExtensionsListByFarmBeatsNextOptionalParams no longer has parameter extensionCategories
      info	[Changelog]   - Interface ExtensionsListByFarmBeatsNextOptionalParams no longer has parameter extensionIds
      info	[Changelog]   - Interface ExtensionsListByFarmBeatsNextOptionalParams no longer has parameter maxPageSize
      info	[Changelog]   - Interface ExtensionsListByFarmBeatsNextOptionalParams no longer has parameter skipToken
      info	[Changelog]   - Interface FarmBeatsExtensionsListNextOptionalParams no longer has parameter extensionCategories
      info	[Changelog]   - Interface FarmBeatsExtensionsListNextOptionalParams no longer has parameter farmBeatsExtensionIds
      info	[Changelog]   - Interface FarmBeatsExtensionsListNextOptionalParams no longer has parameter farmBeatsExtensionNames
      info	[Changelog]   - Interface FarmBeatsExtensionsListNextOptionalParams no longer has parameter maxPageSize
      info	[Changelog]   - Interface FarmBeatsExtensionsListNextOptionalParams no longer has parameter publisherIds
      info	[Changelog]   - Interface FarmBeatsModelsListByResourceGroupNextOptionalParams no longer has parameter maxPageSize
      info	[Changelog]   - Interface FarmBeatsModelsListByResourceGroupNextOptionalParams no longer has parameter skipToken
      info	[Changelog]   - Interface FarmBeatsModelsListBySubscriptionNextOptionalParams no longer has parameter maxPageSize
      info	[Changelog]   - Interface FarmBeatsModelsListBySubscriptionNextOptionalParams no longer has parameter skipToken
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from e9f1cd4. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-agrifood [View full logs]  [Release SDK Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from e9f1cd4. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.agrifood [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 2, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/agrifood/armagrifood https://apiview.dev/Assemblies/Review/aefa5840710a493ea4b1785dfd511b93
    Java azure-resourcemanager-agrifood https://apiview.dev/Assemblies/Review/a5ff8b28f3464acf983a41b1687a85c0
    JavaScript @azure/arm-agrifood https://apiview.dev/Assemblies/Review/99d45e17ac074bbe93b43a7573a24a7d

    @openapi-workflow-bot
    Copy link

    Hi @manikprabhu1208, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @leniatgh
    Copy link
    Contributor

    leniatgh commented Feb 7, 2023

    @qiaozha @tadelesh @msyyc please help review the sdk breaking changes

    @tadelesh tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Feb 7, 2023
    @msyyc
    Copy link
    Member

    msyyc commented Feb 7, 2023

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript Approved-SdkBreakingChange-Python BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    7 participants