Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenAI Preview #22364

Merged
merged 73 commits into from
Feb 3, 2023
Merged

OpenAI Preview #22364

merged 73 commits into from
Feb 3, 2023

Conversation

lmazuel
Copy link
Member

@lmazuel lmazuel commented Jan 30, 2023

No description provided.

tjprescott and others added 30 commits November 1, 2022 14:11
@tjprescott
Initial commit.
fe4d8be
@tjprescott
Commit OpenAI inference cadl files.
72979e5
@glharper
use non-deprecated service decorator
537e069
@jpalvarezl
Fixes to main
872bb29
@jpalvarezl
Reverted changes
bd6312f
@glharper
use latest cadl to sync with vs code properly
06deebe
@jpalvarezl
Merge branch 'feature/cognitiveservices/openai-cadl' of https://githu…
aec3b90 
…b.com/Azure/azure-rest-api-specs into feature/cognitiveservices/openai-cadl
@glharper
cadl compilation works for authoring (but it is correct?)
daa1574
@glharper
Cleaned up routes and model for Inference REST CADL spec
de7ee20
@jpalvarezl
Merge branch 'feature/cognitiveservices/openai-cadl' of https://githu…
c53edb7 
…b.com/Azure/azure-rest-api-specs into feature/cognitiveservices/openai-cadl
@jpalvarezl
Added cadl-output to .gitignore file and removed error response
ed6c019
@jpalvarezl
Implemented polymorphic return for endpoint
28d0a49
@glharper
enable Files_Import as non-standard operation, use standard operation…
93eecd7 
… names
@jpalvarezl
Merge branch 'feature/cognitiveservices/openai-cadl' of https://githu…
6173424 
…b.com/Azure/azure-rest-api-specs into feature/cognitiveservices/openai-cadl
@glharper
Authoring CADL now emits openAPI schema almost identical to current A…
92e5ae0 
…uthoring schema
@glharper
Merge branch 'feature/cognitiveservices/openai-cadl' of https://githu…
463d23a 
…b.com/Azure/azure-rest-api-specs into feature/cognitiveservices/openai-cadl
@jpalvarezl
Empty model used for polymorphic expectation in embedding endpoint
71498b3
@jpalvarezl
Renamed models to match convention
571dd82
@jpalvarezl
Renamed completions related models
7f7e7cc
@jpalvarezl
Adjusted comment for embeddings body types
c8f5e49
@jpalvarezl
Split up models.cadl into completions and embeddings files
a6cacda
@jpalvarezl
Renamed models
0accec7
@jpalvarezl
Refactored model names
d91f220
@jpalvarezl
Removed redundants bits of model names
4919eba
@jpalvarezl
added headers
479f9a1
@jpalvarezl
Added header to correct model
75c140f
@glharper
break up monolithic routes and model cadl files
ba7ded1
@jpalvarezl
Merge branch 'feature/cognitiveservices/openai-cadl' of https://githu…
afeb880 
…b.com/Azure/azure-rest-api-specs into feature/cognitiveservices/openai-cadl
@glharper
add namespace to all models
7c200c3
@jpalvarezl
Removed gitIgnore file and changed files to not have domain related n…
5bc2b16 
…amespaces
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 30, 2023 •
edited
Loading

Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@lmazuel lmazuel assigned lmazuel and johanste and unassigned akning-ms Jan 30, 2023
@openapi-workflow-bot
Copy link

Hi @lmazuel, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

TaskHow to fixPriority
AvocadoFix-AvocadoHigh
Semantic validationFix-SemanticValidation-ErrorHigh
Model validationFix-ModelValidation-ErrorHigh
LintDiffFix-LintDiffhigh
 If you need further help, please feedback via swagger feedback.

@openapi-workflow-bot
Copy link

Hi, @lmazuel, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

@jpalvarezl @lmazuel
Embeddings model and field documentation and fix to models (#22368)
066622c 
* Moved usage to the response object of embeddings and added some basic documentation to models and fields

* Fixed typo

* Update specification/cognitiveservices/OpenAI.Inference/models/embeddings.create.cadl

---------

Co-authored-by: Laurent Mazuel <[email protected]>
@ruowan
Copy link
Member

ruowan commented Jan 31, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tjprescott
Copy link
Member

/azp run unifiedPipeline

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@tjprescott tjprescott added APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. and removed APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. labels Jan 31, 2023
@tjprescott
Copy link
Member

I am messing with the APIStewardship labels for testing. This PR is NOT yet approved by the APIStewardship board.

@lmazuel lmazuel merged commit 270d3cd into main Feb 3, 2023
@lmazuel lmazuel deleted the feature/cognitiveservices/openai-cadl branch February 3, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpalvarezl jpalvarezl jpalvarezl approved these changes

@yangyuan yangyuan Awaiting requested review from yangyuan yangyuan is a code owner

Assignees

@lmazuel lmazuel

@johanste johanste

Labels
Cadl Authored with Cadl CI-FixRequiredOnFailure CI-MissingBaseCommit Cognitive Services DataPlane new-api-version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.