Rename MonitoringAccount to Monitor workspace in tags, operationId and description #22182

divya-jay · 2023-01-12T23:00:00Z

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

…d description

openapi-workflow-bot · 2023-01-12T23:00:04Z

Hi, @divya-jay Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2023-01-12T23:00:05Z

Swagger Validation Report

️❌BreakingChange: 6 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.2)]	new version	base version
monitoringAccounts_API.json	2021-06-03-preview(c5a4313)	2021-06-03-preview(main)

Rule	Message
`❌` 1008 - ModifiedOperationId	The operation id has been changed from 'MonitoringAccounts_ListByResourceGroup' to 'AzureMonitorWorkspaces_ListByResourceGroup'. This will impact generated code. New: Microsoft.Monitor/preview/2021-06-03-preview/monitoringAccounts_API.json#L50:7 Old: Microsoft.Monitor/preview/2021-06-03-preview/monitoringAccounts_API.json#L50:7
`❌` 1008 - ModifiedOperationId	The operation id has been changed from 'MonitoringAccounts_ListBySubscription' to 'AzureMonitorWorkspaces_ListBySubscription'. This will impact generated code. New: Microsoft.Monitor/preview/2021-06-03-preview/monitoringAccounts_API.json#L95:7 Old: Microsoft.Monitor/preview/2021-06-03-preview/monitoringAccounts_API.json#L95:7
`❌` 1008 - ModifiedOperationId	The operation id has been changed from 'MonitoringAccounts_Get' to 'AzureMonitorWorkspaces_Get'. This will impact generated code. New: Microsoft.Monitor/preview/2021-06-03-preview/monitoringAccounts_API.json#L137:7 Old: Microsoft.Monitor/preview/2021-06-03-preview/monitoringAccounts_API.json#L137:7
`❌` 1008 - ModifiedOperationId	The operation id has been changed from 'MonitoringAccounts_Create' to 'AzureMonitorWorkspaces_Create'. This will impact generated code. New: Microsoft.Monitor/preview/2021-06-03-preview/monitoringAccounts_API.json#L180:7 Old: Microsoft.Monitor/preview/2021-06-03-preview/monitoringAccounts_API.json#L180:7
`❌` 1008 - ModifiedOperationId	The operation id has been changed from 'MonitoringAccounts_Update' to 'AzureMonitorWorkspaces_Update'. This will impact generated code. New: Microsoft.Monitor/preview/2021-06-03-preview/monitoringAccounts_API.json#L241:7 Old: Microsoft.Monitor/preview/2021-06-03-preview/monitoringAccounts_API.json#L241:7
`❌` 1008 - ModifiedOperationId	The operation id has been changed from 'MonitoringAccounts_Delete' to 'AzureMonitorWorkspaces_Delete'. This will impact generated code. New: Microsoft.Monitor/preview/2021-06-03-preview/monitoringAccounts_API.json#L295:7 Old: Microsoft.Monitor/preview/2021-06-03-preview/monitoringAccounts_API.json#L295:7

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-preview-2022-08	package-preview-2022-08(c5a4313)	package-preview-2022-08(main)
package-composite-v1	package-composite-v1(c5a4313)	package-composite-v1(main)

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'monitoringAccountName' should be defined with a 'pattern' restriction. Location: Microsoft.Monitor/preview/2021-06-03-preview/monitoringAccounts_API.json#L136
`❌` ResourceNameRestriction	The resource name parameter 'monitoringAccountName' should be defined with a 'pattern' restriction. Location: Microsoft.Monitor/preview/2021-06-03-preview/monitoringAccounts_API.json#L136
⚠️ PreviewVersionOverOneYear	The API version:2021-06-03-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.Monitor/preview/2021-06-03-preview/monitoringAccounts_API.json#L6
⚠️ PreviewVersionOverOneYear	The API version:2021-06-03-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.Monitor/preview/2021-06-03-preview/monitoringAccounts_API.json#L6
⚠️ DeprecatedXmsCodeGenerationSetting	The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation. Location: Microsoft.Monitor/preview/2021-06-03-preview/monitoringAccounts_API.json#L7
⚠️ DeprecatedXmsCodeGenerationSetting	The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation. Location: Microsoft.Monitor/preview/2021-06-03-preview/monitoringAccounts_API.json#L7

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/monitor/resource-manager/readme.md tag: specification/monitor/resource-manager/readme.md#tag-package-preview-2022-08

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]

️️✔️~[Staging] CadlAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-01-12T23:00:06Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-js - @azure/arm-monitor - 8.0.0-beta.3

+	Class MonitorClient no longer has parameter metrics
+	Enum KnownOperator no longer has value Include
+	Enum KnownProvisioningState no longer has value Deploying
+	Interface ActivityLogsListNextOptionalParams no longer has parameter select
+	Interface AzureResource no longer has parameter identity
+	Interface AzureResource no longer has parameter kind
+	Interface PrivateEndpointConnectionListResult no longer has parameter nextLink
+	Interface PrivateLinkResourceListResult no longer has parameter nextLink
+	Interface ResourceAutoGenerated no longer has parameter etag
+	Interface ResourceAutoGenerated no longer has parameter kind
+	Interface ScheduledQueryRulesListByResourceGroupOptionalParams no longer has parameter filter
+	Interface ScheduledQueryRulesListBySubscriptionOptionalParams no longer has parameter filter
+	Interface TenantActivityLogsListNextOptionalParams no longer has parameter filter
+	Interface TenantActivityLogsListNextOptionalParams no longer has parameter select
+	Operation ActivityLogAlerts.update has a new signature
+	Operation ScheduledQueryRules.createOrUpdate has a new signature
+	Operation ScheduledQueryRules.update has a new signature
+	Removed Enum KnownConditionalOperator
+	Removed Enum KnownEnabled
+	Removed Enum KnownMetricTriggerType
+	Removed Enum KnownQueryType
+	Removed operation group Metrics
+	Type of parameter error of interface ErrorContract is changed from ErrorResponse to ErrorResponseDetails
+	Type of parameter error of interface OperationStatus is changed from ErrorResponseCommon to ErrorDetail
+	Type of parameter operator of interface Dimension is changed from Operator to DimensionOperator

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from 2d9846d. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 672 | �[0m         �[96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:760
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 760 | �[0m … rtifacts += �[96mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because it does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 672 | �[0m         �[96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.Monitor [View full logs] [Release SDK Changes]
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 2d9846d. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.3.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.3.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-monitor [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model Condition has a new parameter metric_name
info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter auto_mitigate
info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter check_workspace_alerts_storage_configured
info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter identity
info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter is_workspace_alerts_storage_configured
info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter public_network_access
info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter rule_resolve_configuration
info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter skip_query_validation
info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter system_data
info	[Changelog]   - Model ScheduledQueryRuleResourceCollection has a new parameter next_link
info	[Changelog]   - Model ScheduledQueryRuleResourcePatch has a new parameter auto_mitigate
info	[Changelog]   - Model ScheduledQueryRuleResourcePatch has a new parameter check_workspace_alerts_storage_configured
info	[Changelog]   - Model ScheduledQueryRuleResourcePatch has a new parameter identity
info	[Changelog]   - Model ScheduledQueryRuleResourcePatch has a new parameter is_workspace_alerts_storage_configured
info	[Changelog]   - Model ScheduledQueryRuleResourcePatch has a new parameter public_network_access
info	[Changelog]   - Model ScheduledQueryRuleResourcePatch has a new parameter rule_resolve_configuration
info	[Changelog]   - Model ScheduledQueryRuleResourcePatch has a new parameter skip_query_validation

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 2d9846d. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-monitor-generated [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2d9846d. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/monitor/armmonitor [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `DynamicMetricCriteria.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
info	[Changelog] - Type of `ErrorAdditionalInfo.Info` has been changed from `interface{}` to `any`
info	[Changelog] - Type of `ErrorResponseAdditionalInfo.Info` has been changed from `interface{}` to `any`
info	[Changelog] - Type of `ExtensionDataSource.ExtensionSettings` has been changed from `interface{}` to `any`
info	[Changelog] - Type of `MetricAlertCriteria.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
info	[Changelog] - Type of `MetricAlertMultipleResourceMultipleMetricCriteria.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
info	[Changelog] - Type of `MetricAlertSingleResourceMultipleMetricCriteria.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
info	[Changelog] - Type of `MetricCriteria.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
info	[Changelog] - Type of `MultiMetricCriteria.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
info	[Changelog] - Type of `WebtestLocationAvailabilityCriteria.AdditionalProperties` has been changed from `map[string]interface{}` to `map[string]any`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New type alias `ActionType` with values `ActionTypeInternal`
info	[Changelog] - New type alias `IdentityType` with values `IdentityTypeNone`, `IdentityTypeSystemAssigned`, `IdentityTypeUserAssigned`
info	[Changelog] - New type alias `Origin` with values `OriginSystem`, `OriginUser`, `OriginUserSystem`
info	[Changelog] - New type alias `ProvisioningState` with values `ProvisioningStateCanceled`, `ProvisioningStateCreating`, `ProvisioningStateDeleting`, `ProvisioningStateFailed`, `ProvisioningStateSucceeded`
info	[Changelog] - New type alias `PublicNetworkAccess` with values `PublicNetworkAccessDisabled`, `PublicNetworkAccessEnabled`, `PublicNetworkAccessSecuredByPerimeter`
info	[Changelog] - New function `NewAzureMonitorWorkspacesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*AzureMonitorWorkspacesClient, error)`
info	[Changelog] - New function `*AzureMonitorWorkspacesClient.Create(context.Context, string, string, MonitoringAccountResource, *AzureMonitorWorkspacesClientCreateOptions) (AzureMonitorWorkspacesClientCreateResponse, error)`
info	[Changelog] - New function `*AzureMonitorWorkspacesClient.Delete(context.Context, string, string, *AzureMonitorWorkspacesClientDeleteOptions) (AzureMonitorWorkspacesClientDeleteResponse, error)`
info	[Changelog] - New function `*AzureMonitorWorkspacesClient.Get(context.Context, string, string, *AzureMonitorWorkspacesClientGetOptions) (AzureMonitorWorkspacesClientGetResponse, error)`
info	[Changelog] - New function `*AzureMonitorWorkspacesClient.NewListByResourceGroupPager(string, *AzureMonitorWorkspacesClientListByResourceGroupOptions) *runtime.Pager[AzureMonitorWorkspacesClientListByResourceGroupResponse]`
info	[Changelog] - New function `*AzureMonitorWorkspacesClient.NewListBySubscriptionPager(*AzureMonitorWorkspacesClientListBySubscriptionOptions) *runtime.Pager[AzureMonitorWorkspacesClientListBySubscriptionResponse]`
info	[Changelog] - New function `*AzureMonitorWorkspacesClient.Update(context.Context, string, string, *AzureMonitorWorkspacesClientUpdateOptions) (AzureMonitorWorkspacesClientUpdateResponse, error)`
info	[Changelog] - New function `NewClient(azcore.TokenCredential, *arm.ClientOptions) (*Client, error)`
info	[Changelog] - New function `*Client.NewOperationsListPager(*ClientOperationsListOptions) *runtime.Pager[ClientOperationsListResponse]`
info	[Changelog] - New struct `AzureMonitorWorkspacesClient`
info	[Changelog] - New struct `AzureMonitorWorkspacesClientListByResourceGroupResponse`
info	[Changelog] - New struct `AzureMonitorWorkspacesClientListBySubscriptionResponse`
info	[Changelog] - New struct `Client`
info	[Changelog] - New struct `ClientOperationsListResponse`
info	[Changelog] - New struct `ErrorDetailAutoGenerated`
info	[Changelog] - New struct `ErrorResponseAutoGenerated2`
info	[Changelog] - New struct `Identity`
info	[Changelog] - New struct `IngestionSettings`
info	[Changelog] - New struct `Metrics`
info	[Changelog] - New struct `MonitoringAccount`
info	[Changelog] - New struct `MonitoringAccountDefaultIngestionSettings`
info	[Changelog] - New struct `MonitoringAccountMetrics`
info	[Changelog] - New struct `MonitoringAccountResource`
info	[Changelog] - New struct `MonitoringAccountResourceForUpdate`
info	[Changelog] - New struct `MonitoringAccountResourceListResult`
info	[Changelog] - New struct `MonitoringAccountResourceProperties`
info	[Changelog] - New struct `OperationAutoGenerated`
info	[Changelog] - New struct `OperationDisplayAutoGenerated`
info	[Changelog] - New struct `OperationListResultAutoGenerated`
info	[Changelog] - New struct `ResourceAutoGenerated5`
info	[Changelog] - New struct `RuleResolveConfiguration`
info	[Changelog] - New struct `TrackedResourceAutoGenerated`
info	[Changelog] - New struct `UserIdentityProperties`
info	[Changelog] - New field `PublicNetworkAccess` in struct `ScheduledQueryRuleProperties`
info	[Changelog] - New field `RuleResolveConfiguration` in struct `ScheduledQueryRuleProperties`
info	[Changelog] - New field `Identity` in struct `ScheduledQueryRuleResource`
info	[Changelog] - New field `Identity` in struct `ScheduledQueryRuleResourcePatch`
info	[Changelog]
info	[Changelog] Total 10 breaking change(s), 80 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2d9846d. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-monitor [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-monitor-8.0.0-beta.3.tgz

Only show 120 items here, please refer to log for details.

info	[Changelog]   - Added Interface PrivateEndpointConnection
info	[Changelog]   - Added Interface PrivateLinkResource
info	[Changelog]   - Added Interface PrivateLinkServiceConnectionState
info	[Changelog]   - Added Interface ProxyResourceAutoGenerated
info	[Changelog]   - Added Interface ResourceAutoGenerated2
info	[Changelog]   - Added Interface ResourceAutoGenerated3
info	[Changelog]   - Added Interface ResourceAutoGenerated4
info	[Changelog]   - Added Interface ResourceAutoGenerated5
info	[Changelog]   - Added Interface RuleEmailAction
info	[Changelog]   - Added Interface RuleManagementEventDataSource
info	[Changelog]   - Added Interface RuleMetricDataSource
info	[Changelog]   - Added Interface RuleResolveConfiguration
info	[Changelog]   - Added Interface RuleWebhookAction
info	[Changelog]   - Added Interface ScheduledQueryRuleCriteria
info	[Changelog]   - Added Interface ScheduledQueryRuleResource
info	[Changelog]   - Added Interface ScheduledQueryRuleResourceCollection
info	[Changelog]   - Added Interface ScheduledQueryRuleResourcePatch
info	[Changelog]   - Added Interface ScheduledQueryRulesListByResourceGroupNextOptionalParams
info	[Changelog]   - Added Interface ScheduledQueryRulesListBySubscriptionNextOptionalParams
info	[Changelog]   - Added Interface ScopedResource
info	[Changelog]   - Added Interface StreamDeclaration
info	[Changelog]   - Added Interface ThresholdRuleCondition
info	[Changelog]   - Added Interface TrackedResource
info	[Changelog]   - Added Interface TrackedResourceAutoGenerated
info	[Changelog]   - Added Interface UserIdentityProperties
info	[Changelog]   - Added Interface VMInsightsOnboardingStatus
info	[Changelog]   - Added Interface WebtestLocationAvailabilityCriteria
info	[Changelog]   - Added Type Alias AccessMode
info	[Changelog]   - Added Type Alias ActionGroupsCreateNotificationsAtActionGroupResourceLevelResponse
info	[Changelog]   - Added Type Alias ActionGroupsCreateNotificationsAtResourceGroupLevelResponse
info	[Changelog]   - Added Type Alias ActionGroupsGetTestNotificationsAtActionGroupResourceLevelResponse
info	[Changelog]   - Added Type Alias ActionGroupsGetTestNotificationsAtResourceGroupLevelResponse
info	[Changelog]   - Added Type Alias ActionType
info	[Changelog]   - Added Type Alias ActivityLogAlertsListByResourceGroupNextResponse
info	[Changelog]   - Added Type Alias ActivityLogAlertsListBySubscriptionIdNextResponse
info	[Changelog]   - Added Type Alias AzureMonitorWorkspacesCreateResponse
info	[Changelog]   - Added Type Alias AzureMonitorWorkspacesGetResponse
info	[Changelog]   - Added Type Alias AzureMonitorWorkspacesListByResourceGroupNextResponse
info	[Changelog]   - Added Type Alias AzureMonitorWorkspacesListByResourceGroupResponse
info	[Changelog]   - Added Type Alias AzureMonitorWorkspacesListBySubscriptionNextResponse
info	[Changelog]   - Added Type Alias AzureMonitorWorkspacesListBySubscriptionResponse
info	[Changelog]   - Added Type Alias AzureMonitorWorkspacesUpdateResponse
info	[Changelog]   - Added Type Alias DataCollectionRuleAssociationsListByDataCollectionEndpointNextResponse
info	[Changelog]   - Added Type Alias DataCollectionRuleAssociationsListByDataCollectionEndpointResponse
info	[Changelog]   - Added Type Alias DimensionOperator
info	[Changelog]   - Added Type Alias IdentityType
info	[Changelog]   - Added Type Alias Kind
info	[Changelog]   - Added Type Alias KnownColumnDefinitionType
info	[Changelog]   - Added Type Alias KnownLogFilesDataSourceFormat
info	[Changelog]   - Added Type Alias KnownLogFileTextSettingsRecordStartTimestampFormat
info	[Changelog]   - Added Type Alias MonitorOperationsListNextResponse
info	[Changelog]   - Added Type Alias MonitorOperationsListResponse
info	[Changelog]   - Added Type Alias Origin
info	[Changelog]   - Added Type Alias PredictiveAutoscalePolicyScaleMode
info	[Changelog]   - Added Type Alias PredictiveMetricGetResponse
info	[Changelog]   - Added Type Alias PrivateEndpointConnectionProvisioningState
info	[Changelog]   - Added Type Alias PrivateEndpointServiceConnectionStatus
info	[Changelog]   - Added Type Alias PublicNetworkAccess
info	[Changelog]   - Added Type Alias ScheduledQueryRulesListByResourceGroupNextResponse
info	[Changelog]   - Added Type Alias ScheduledQueryRulesListBySubscriptionNextResponse
info	[Changelog]   - Added Type Alias TimeAggregation
info	[Changelog]   - Interface AutoscaleSettingResourcePatch has a new optional parameter predictiveAutoscalePolicy
info	[Changelog]   - Interface DataCollectionRule has a new optional parameter dataCollectionEndpointId
info	[Changelog]   - Interface DataCollectionRule has a new optional parameter metadata
info	[Changelog]   - Interface DataCollectionRule has a new optional parameter streamDeclarations
info	[Changelog]   - Interface DataCollectionRuleAssociation has a new optional parameter metadata
info	[Changelog]   - Interface DataCollectionRuleAssociationProxyOnlyResource has a new optional parameter metadata
info	[Changelog]   - Interface DataCollectionRuleResource has a new optional parameter dataCollectionEndpointId
info	[Changelog]   - Interface DataCollectionRuleResource has a new optional parameter metadata
info	[Changelog]   - Interface DataCollectionRuleResource has a new optional parameter streamDeclarations
info	[Changelog]   - Interface DataFlow has a new optional parameter outputStream
info	[Changelog]   - Interface DataFlow has a new optional parameter transformKql
info	[Changelog]   - Interface DataSourcesSpec has a new optional parameter iisLogs
info	[Changelog]   - Interface DataSourcesSpec has a new optional parameter logFiles
info	[Changelog]   - Interface LogSettings has a new optional parameter categoryGroup
info	[Changelog]   - Interface Resource has a new optional parameter systemData
info	[Changelog]   - Added Enum KnownAccessMode
info	[Changelog]   - Added Enum KnownActionType
info	[Changelog]   - Added Enum KnownCategoryType
info	[Changelog]   - Added Enum KnownDimensionOperator
info	[Changelog]   - Added Enum KnownKind
info	[Changelog]   - Added Enum KnownKnownColumnDefinitionType
info	[Changelog]   - Added Enum KnownKnownLogFilesDataSourceFormat
info	[Changelog]   - Added Enum KnownKnownLogFileTextSettingsRecordStartTimestampFormat
info	[Changelog]   - Added Enum KnownOrigin
info	[Changelog]   - Added Enum KnownPrivateEndpointConnectionProvisioningState
info	[Changelog]   - Added Enum KnownPrivateEndpointServiceConnectionStatus
info	[Changelog]   - Added Enum KnownPublicNetworkAccess
info	[Changelog]   - Added Enum KnownTimeAggregation
info	[Changelog]   - Enum KnownProvisioningState has a new value Creating
info	[Changelog]   - Enum KnownProvisioningState has a new value Deleting
info	[Changelog]   - Added function getContinuationToken
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Removed operation group Metrics
info	[Changelog]   - Operation ActivityLogAlerts.update has a new signature
info	[Changelog]   - Operation ScheduledQueryRules.createOrUpdate has a new signature
info	[Changelog]   - Operation ScheduledQueryRules.update has a new signature
info	[Changelog]   - Interface ActivityLogsListNextOptionalParams no longer has parameter select
info	[Changelog]   - Interface AzureResource no longer has parameter identity
info	[Changelog]   - Interface AzureResource no longer has parameter kind
info	[Changelog]   - Interface PrivateEndpointConnectionListResult no longer has parameter nextLink
info	[Changelog]   - Interface PrivateLinkResourceListResult no longer has parameter nextLink
info	[Changelog]   - Interface ResourceAutoGenerated no longer has parameter etag
info	[Changelog]   - Interface ResourceAutoGenerated no longer has parameter kind
info	[Changelog]   - Interface ScheduledQueryRulesListByResourceGroupOptionalParams no longer has parameter filter
info	[Changelog]   - Interface ScheduledQueryRulesListBySubscriptionOptionalParams no longer has parameter filter
info	[Changelog]   - Interface TenantActivityLogsListNextOptionalParams no longer has parameter filter
info	[Changelog]   - Interface TenantActivityLogsListNextOptionalParams no longer has parameter select
info	[Changelog]   - Type of parameter operator of interface Dimension is changed from Operator to DimensionOperator
info	[Changelog]   - Type of parameter error of interface ErrorContract is changed from ErrorResponse to ErrorResponseDetails
info	[Changelog]   - Type of parameter error of interface OperationStatus is changed from ErrorResponseCommon to ErrorDetail
info	[Changelog]   - Class MonitorClient no longer has parameter metrics
info	[Changelog]   - Removed Enum KnownConditionalOperator
info	[Changelog]   - Removed Enum KnownEnabled
info	[Changelog]   - Removed Enum KnownMetricTriggerType
info	[Changelog]   - Removed Enum KnownQueryType
info	[Changelog]   - Enum KnownOperator no longer has value Include
info	[Changelog]   - Enum KnownProvisioningState no longer has value Deploying

️❌ azure-resource-manager-schemas failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 2d9846d. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cannot force update branch 'sdkAuto/monitor' as it is the current HEAD of the repository.
Error: cannot force update branch 'sdkAuto/monitor' as it is the current HEAD of the repository.

️✔️monitor [View full logs] [Release Schema Changes]

️✔️monitor [View full logs]

error	Fatal error: cannot force update branch 'sdkAuto/monitor' as it is the current HEAD of the repository.
error	The following packages are still pending:
error		monitor
error		monitor

️❌ azure-powershell failed [Detail]

❌Failed [Logs]Release - Generate from 2d9846d. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

❌Az.monitor [View full logs] [Release SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-01-12T23:00:07Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/monitor/armmonitor	https://apiview.dev/Assemblies/Review/c550c86ce8aa4076b5c5753c7f824431
Java	azure-resourcemanager-monitor-generated	https://apiview.dev/Assemblies/Review/5f64289cd94746b588740906b4fc88c7
JavaScript	@azure/arm-monitor	https://apiview.dev/Assemblies/Review/3a746d58b06747458cc1325d755f0831

openapi-workflow-bot · 2023-01-12T23:09:49Z

Hi @divya-jay, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

openapi-workflow-bot · 2023-01-12T23:09:49Z

Hi @divya-jay, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

raych1 · 2023-01-20T05:51:01Z

SDK is never released, so it's ok to update operationId. And no ARM review is required as no api level change.

Rename MonitoringAccount to Monitor workspace in tags, operationId an…

af865fa

…d description

openapi-assignment-bot bot assigned ArcturusZhang Jan 12, 2023

ghost added the Monitor Monitor, Monitor Ingestion, Monitor Query label Jan 12, 2023

divya-jay changed the title ~~Rename MonitoringAccount to Monitor workspace in tags, operationId an…~~ Rename MonitoringAccount to Monitor workspace in tags, operationId and description Jan 12, 2023

AzureRestAPISpecReview added ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-FixRequiredOnFailure resource-manager labels Jan 12, 2023

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Jan 12, 2023

divyajay added 2 commits January 12, 2023 15:20

Revert renaming of definitions

288ef09

revert updated property name

c5a4313

AzureRestAPISpecReview removed the CI-FixRequiredOnFailure label Jan 13, 2023

raych1 approved these changes Jan 20, 2023

View reviewed changes

raych1 added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 20, 2023

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 20, 2023

raych1 removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 20, 2023

raych1 removed the ARMReview label Jan 20, 2023

raych1 merged commit 2d9846d into main Jan 20, 2023

raych1 deleted the divyaj/renameTags branch January 20, 2023 05:51

openapi-pipeline-app bot added the ARMReview label Jan 20, 2023

azure-sdk mentioned this pull request Jan 20, 2023

[ReleasePR sdk/resourcemanager/monitor/armmonitor] [Monitor.Query] Update Preview Swagger File Azure/azure-sdk-for-go#18964

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Jan 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename MonitoringAccount to Monitor workspace in tags, operationId and description #22182

Rename MonitoringAccount to Monitor workspace in tags, operationId and description #22182

divya-jay commented Jan 12, 2023 •

edited by openapi-workflow-bot bot

Loading

openapi-workflow-bot bot commented Jan 12, 2023

openapi-pipeline-app bot commented Jan 12, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jan 12, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Jan 12, 2023 •

edited

Loading

openapi-workflow-bot bot commented Jan 12, 2023

openapi-workflow-bot bot commented Jan 12, 2023

raych1 commented Jan 20, 2023 •

edited

Loading

Rename MonitoringAccount to Monitor workspace in tags, operationId and description #22182

Rename MonitoringAccount to Monitor workspace in tags, operationId and description #22182

Conversation

divya-jay commented Jan 12, 2023 • edited by openapi-workflow-bot bot Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jan 12, 2023

openapi-pipeline-app bot commented Jan 12, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jan 12, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Jan 12, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Jan 12, 2023

openapi-workflow-bot bot commented Jan 12, 2023

raych1 commented Jan 20, 2023 • edited Loading

divya-jay commented Jan 12, 2023 •

edited by openapi-workflow-bot bot

Loading

openapi-pipeline-app bot commented Jan 12, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jan 12, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jan 12, 2023 •

edited

Loading

raych1 commented Jan 20, 2023 •

edited

Loading