-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VpnGateway Reset with ipConfigurationId #22111
VpnGateway Reset with ipConfigurationId #22111
Conversation
Hi, @Khushboo-Baheti Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.2)] | new version | base version |
---|---|---|
virtualWan.json | 2022-09-01(7a48b2d) | 2022-07-01(main) |
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.0.0) | new version | base version |
---|---|---|
package-2022-09 | package-2022-09(7a48b2d) | package-2022-09(release-Microsoft.Network-2022-09-01) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
GetCollectionResponseSchema |
The response in the GET collection operation 'VirtualNetworkGateways_List' does not match the response definition in the individual GET operation 'VirtualNetworkGateways_Get' . Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L36 |
GetCollectionResponseSchema |
The response in the GET collection operation 'VirtualNetworkGatewayConnections_List' does not match the response definition in the individual GET operation 'VirtualNetworkGatewayConnections_Get' . Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L36 |
GetCollectionResponseSchema |
The response in the GET collection operation 'LocalNetworkGateways_List' does not match the response definition in the individual GET operation 'LocalNetworkGateways_Get' . Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L36 |
GetCollectionResponseSchema |
The response in the GET collection operation 'VirtualNetworkGatewayNatRules_ListByVirtualNetworkGateway' does not match the response definition in the individual GET operation 'VirtualNetworkGatewayNatRules_Get' . Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L36 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualWans/{VirtualWANName}' Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L37 |
ResourceNameRestriction |
The resource name parameter 'VirtualWANName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L37 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L238 |
ResourceNameRestriction |
The resource name parameter 'vpnSiteName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L336 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L537 |
ResourceNameRestriction |
The resource name parameter 'vpnSiteName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L599 |
ResourceNameRestriction |
The resource name parameter 'vpnSiteLinkName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L599 |
ResourceNameRestriction |
The resource name parameter 'vpnSiteName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L653 |
ResourceNameRestriction |
The resource name parameter 'virtualWANName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L739 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L783 |
ResourceNameRestriction |
The resource name parameter 'virtualWANName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L799 |
ResourceNameRestriction |
The resource name parameter 'vpnServerConfigurationName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L846 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L1047 |
ResourceNameRestriction |
The resource name parameter 'vpnServerConfigurationName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L1109 |
ResourceNameRestriction |
The resource name parameter 'configurationPolicyGroupName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L1109 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L1222 |
ResourceNameRestriction |
The resource name parameter 'vpnServerConfigurationName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L1293 |
ResourceNameRestriction |
The resource name parameter 'virtualHubName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L1379 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L1580 |
ResourceNameRestriction |
The resource name parameter 'virtualHubName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L1678 |
ResourceNameRestriction |
The resource name parameter 'routeMapName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L1678 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L1843 |
ResourceNameRestriction |
The resource name parameter 'virtualHubName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L1862 |
ResourceNameRestriction |
The resource name parameter 'virtualHubName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L1912 |
ResourceNameRestriction |
The resource name parameter 'connectionName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L1912 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2022-09-01/virtualWan.json#L2025 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌
~[Staging] SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️❌
ModelValidation: 75 Errors, 0 Warnings failed [Detail]
Only 30 items are listed, please refer to log for more details.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Rule | Message |
---|---|
RestBuild error |
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=340101&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️⚠️
SDK Breaking Change Tracking warning [Detail]
Breaking Changes Tracking
⚠️
azure-sdk-for-js - @azure/arm-network - Approved - 31.0.0+ Interface AdminRuleCollectionsListNextOptionalParams no longer has parameter skipToken + Interface AdminRuleCollectionsListNextOptionalParams no longer has parameter top + Interface AdminRulesListNextOptionalParams no longer has parameter skipToken + Interface AdminRulesListNextOptionalParams no longer has parameter top + Interface ConnectivityConfigurationsListNextOptionalParams no longer has parameter skipToken + Interface ConnectivityConfigurationsListNextOptionalParams no longer has parameter top + Interface DdosProtectionPlan no longer has parameter publicIpAddresses + Interface ManagementGroupNetworkManagerConnectionsListNextOptionalParams no longer has parameter skipToken + Interface ManagementGroupNetworkManagerConnectionsListNextOptionalParams no longer has parameter top + Interface NetworkGroupsListNextOptionalParams no longer has parameter skipToken + Interface NetworkGroupsListNextOptionalParams no longer has parameter top + Interface NetworkInterfacesListVirtualMachineScaleSetIpConfigurationsNextOptionalParams no longer has parameter expand + Interface NetworkManagersListBySubscriptionNextOptionalParams no longer has parameter skipToken + Interface NetworkManagersListBySubscriptionNextOptionalParams no longer has parameter top + Interface NetworkManagersListNextOptionalParams no longer has parameter skipToken + Interface NetworkManagersListNextOptionalParams no longer has parameter top + Interface ScopeConnectionsListNextOptionalParams no longer has parameter skipToken + Interface ScopeConnectionsListNextOptionalParams no longer has parameter top + Interface SecurityAdminConfigurationsListNextOptionalParams no longer has parameter skipToken + Interface SecurityAdminConfigurationsListNextOptionalParams no longer has parameter top + Interface ServiceTagInformationListNextOptionalParams no longer has parameter noAddressPrefixes + Interface ServiceTagInformationListNextOptionalParams no longer has parameter tagName + Interface StaticMembersListNextOptionalParams no longer has parameter skipToken + Interface StaticMembersListNextOptionalParams no longer has parameter top + Interface SubscriptionNetworkManagerConnectionsListNextOptionalParams no longer has parameter skipToken + Interface SubscriptionNetworkManagerConnectionsListNextOptionalParams no longer has parameter top + Interface VirtualNetworksListDdosProtectionStatusNextOptionalParams no longer has parameter skipToken + Interface VirtualNetworksListDdosProtectionStatusNextOptionalParams no longer has parameter top
️️✔️
azure-sdk-for-net succeeded [Detail] [Expand]
️✔️
Succeeded [Logs] Generate from f29f50e5889fb6c2d45eee41b53edbf6bf62fb81. SDK Automation 14.0.0warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-6.0 command autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️
Microsoft.Azure.Management.Network [View full logs] [Preview SDK Changes]
️️✔️
azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️✔️
Succeeded [Logs] Generate from f29f50e5889fb6c2d45eee41b53edbf6bf62fb81. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️
Azure.ResourceManager.Network [View full logs] [Preview SDK Changes]info [Changelog]
️⚠️
azure-sdk-for-python-track2 warning [Detail]
⚠️
Warning [Logs] Generate from f29f50e5889fb6c2d45eee41b53edbf6bf62fb81. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] npm notice cmderr [automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.2.0 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.2.0> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice
️✔️
track2_azure-mgmt-network [View full logs] [Preview SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - Model NspLink has a new parameter remote_perimeter_location info [Changelog] - Model NspLinkReference has a new parameter remote_perimeter_location
️⚠️
azure-sdk-for-java warning [Detail]
⚠️
Warning [Logs] Generate from f29f50e5889fb6c2d45eee41b53edbf6bf62fb81. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️
azure-resourcemanager-network-generated [View full logs] [Preview SDK Changes]
️️✔️
azure-sdk-for-go succeeded [Detail] [Expand]
️✔️
Succeeded [Logs] Generate from f29f50e5889fb6c2d45eee41b53edbf6bf62fb81. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️
sdk/resourcemanager/network/armnetwork [View full logs] [Preview SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - New field `IPConfigurationID` in struct `VPNGatewaysClientBeginResetOptions` info [Changelog] - New field `FlowLogs` in struct `VirtualNetworkPropertiesFormat` info [Changelog] info [Changelog] Total 0 breaking change(s), 2 additive change(s).
️️✔️
azure-sdk-for-js succeeded [Detail] [Expand]
️✔️
Succeeded [Logs] Generate from f29f50e5889fb6c2d45eee41b53edbf6bf62fb81. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️
@azure/arm-network [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Interface DdosProtectionPlan has a new optional parameter publicIPAddresses info [Changelog] - Interface VirtualNetwork has a new optional parameter flowLogs info [Changelog] - Interface VpnGatewaysResetOptionalParams has a new optional parameter ipConfigurationId info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Interface AdminRuleCollectionsListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface AdminRuleCollectionsListNextOptionalParams no longer has parameter top info [Changelog] - Interface AdminRulesListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface AdminRulesListNextOptionalParams no longer has parameter top info [Changelog] - Interface ConnectivityConfigurationsListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface ConnectivityConfigurationsListNextOptionalParams no longer has parameter top info [Changelog] - Interface DdosProtectionPlan no longer has parameter publicIpAddresses info [Changelog] - Interface ManagementGroupNetworkManagerConnectionsListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface ManagementGroupNetworkManagerConnectionsListNextOptionalParams no longer has parameter top info [Changelog] - Interface NetworkGroupsListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface NetworkGroupsListNextOptionalParams no longer has parameter top info [Changelog] - Interface NetworkInterfacesListVirtualMachineScaleSetIpConfigurationsNextOptionalParams no longer has parameter expand info [Changelog] - Interface NetworkManagersListBySubscriptionNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface NetworkManagersListBySubscriptionNextOptionalParams no longer has parameter top info [Changelog] - Interface NetworkManagersListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface NetworkManagersListNextOptionalParams no longer has parameter top info [Changelog] - Interface ScopeConnectionsListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface ScopeConnectionsListNextOptionalParams no longer has parameter top info [Changelog] - Interface SecurityAdminConfigurationsListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface SecurityAdminConfigurationsListNextOptionalParams no longer has parameter top info [Changelog] - Interface ServiceTagInformationListNextOptionalParams no longer has parameter noAddressPrefixes info [Changelog] - Interface ServiceTagInformationListNextOptionalParams no longer has parameter tagName info [Changelog] - Interface StaticMembersListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface StaticMembersListNextOptionalParams no longer has parameter top info [Changelog] - Interface SubscriptionNetworkManagerConnectionsListNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface SubscriptionNetworkManagerConnectionsListNextOptionalParams no longer has parameter top info [Changelog] - Interface VirtualNetworksListDdosProtectionStatusNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface VirtualNetworksListDdosProtectionStatusNextOptionalParams no longer has parameter top
️🔄
azure-resource-manager-schemas inProgress [Detail]
️❌
azure-powershell failed [Detail]
❌
Failed [Logs] Generate from f29f50e5889fb6c2d45eee41b53edbf6bf62fb81. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
❌
Az.network [View full logs] [Preview SDK Changes]
Generated ApiView
|
Hi @Khushboo-Baheti, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Model validation errors are not related to this PR. |
* Adds base for updating Microsoft.Network from version stable/2022-07-01 to version 2022-09-01 * Updates readme * Updates API version in new specs and examples * Added flowlog property in virtual network (#21790) Co-authored-by: Krishna Mishra <[email protected]> * commit1 (#22111) Co-authored-by: Khushboo Baheti <[email protected]> * adding auth status property to circuit (#22024) * Make auth status readonly (#22365) * make auth status read only * fixing model validation * prettier fix * Add support for State flag in Custom Rule (#22457) * Fix LRO header model validation (#22506) * Add new status code for application gateway custom error page (#22151) * Add new status code for application gateway custom error page * Fix prettier * Adding words to Custom-Words list * Fix missing resource id in application gateway list example (#22509) * Resolving merge conflicts with main branch --------- Co-authored-by: Mikhail <[email protected]> Co-authored-by: KRISHNA MISHRA <[email protected]> Co-authored-by: Krishna Mishra <[email protected]> Co-authored-by: Khushboo Baheti <[email protected]> Co-authored-by: Khushboo Baheti <[email protected]> Co-authored-by: utbarn-ms <[email protected]> Co-authored-by: tejasshah7 <[email protected]> Co-authored-by: Prateek Sachan <[email protected]>
* Adds base for updating Microsoft.Network from version stable/2022-07-01 to version 2022-09-01 * Updates readme * Updates API version in new specs and examples * Added flowlog property in virtual network (Azure#21790) Co-authored-by: Krishna Mishra <[email protected]> * commit1 (Azure#22111) Co-authored-by: Khushboo Baheti <[email protected]> * adding auth status property to circuit (Azure#22024) * Make auth status readonly (Azure#22365) * make auth status read only * fixing model validation * prettier fix * Add support for State flag in Custom Rule (Azure#22457) * Fix LRO header model validation (Azure#22506) * Add new status code for application gateway custom error page (Azure#22151) * Add new status code for application gateway custom error page * Fix prettier * Adding words to Custom-Words list * Fix missing resource id in application gateway list example (Azure#22509) * Resolving merge conflicts with main branch --------- Co-authored-by: Mikhail <[email protected]> Co-authored-by: KRISHNA MISHRA <[email protected]> Co-authored-by: Krishna Mishra <[email protected]> Co-authored-by: Khushboo Baheti <[email protected]> Co-authored-by: Khushboo Baheti <[email protected]> Co-authored-by: utbarn-ms <[email protected]> Co-authored-by: tejasshah7 <[email protected]> Co-authored-by: Prateek Sachan <[email protected]>
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.