Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pachaturvedi/elastic new version 2022 09 01 preview #21670

Merged
merged 11 commits into from
Feb 9, 2023
Merged

Pachaturvedi/elastic new version 2022 09 01 preview #21670

merged 11 commits into from
Feb 9, 2023

Conversation

pachaturvedi
Copy link
Contributor

@pachaturvedi pachaturvedi commented Nov 28, 2022 •
edited by utkarshjain1508
Loading

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify : Sync from azure-rest-api-specs-pr
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. December 2022
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. December 2022
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      • To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @pachaturvedi Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 28, 2022
    @openapi-workflow-bot
    Copy link

    Hi, @pachaturvedi your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 28, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 6 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    elastic.json 2022-07-01-preview(593832e) 2022-07-01-preview(main)
    Rule Message
    ❌ 1011 - AddingResponseCode The new version adds a response code '200'.
    New: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1083:11
    ❌ 1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1086:11
    ❌ 1011 - AddingResponseCode The new version adds a response code '200'.
    New: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1150:11
    ❌ 1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1153:11
    ❌ 1012 - RemovedResponseCode The new version removes the response code '201'
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1083:11
    ❌ 1012 - RemovedResponseCode The new version removes the response code '201'
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1144:11
    ️⚠️Breaking Change(Cross-Version): 32 Warnings warning [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    elastic.json 2022-09-01-preview(593832e) 2020-07-01(main)
    elastic.json 2022-09-01-preview(593832e) 2022-07-01-preview(main)

    The following breaking changes are detected by comparison with the latest preview version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '200'.
    New: Microsoft.Elastic/preview/2022-09-01-preview/elastic.json#L1083:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.Elastic/preview/2022-09-01-preview/elastic.json#L1086:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '200'.
    New: Microsoft.Elastic/preview/2022-09-01-preview/elastic.json#L1150:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.Elastic/preview/2022-09-01-preview/elastic.json#L1153:11
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L39:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L78:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L120:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L165:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L211:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L275:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L326:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L375:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L423:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L468:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L521:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L572:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L626:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L672:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L724:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L772:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L817:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L867:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L915:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L966:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1011:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1056:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1111:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1172:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1221:9
    ⚠️ 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1269:9
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2022-07-01-preview package-2022-07-01-preview(593832e) package-2022-07-01-preview(main)
    package-2022-09-01-preview package-2022-09-01-preview(593832e) default(main)

    The following errors/warnings exist before current PR submission:

    Rule Message
    ❌ XmsParameterLocation The parameter 'ApiVersionParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
    Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L2263
    ❌ XmsParameterLocation The parameter 'SubscriptionIdParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
    Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L2281
    ❌ XmsParameterLocation The parameter 'ApiVersionParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
    Location: Microsoft.Elastic/preview/2022-09-01-preview/elastic.json#L2268
    ❌ XmsParameterLocation The parameter 'SubscriptionIdParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
    Location: Microsoft.Elastic/preview/2022-09-01-preview/elastic.json#L2276
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1444
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1658
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1769
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1911
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1915
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1919
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1970
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L2039
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L2212
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Elastic/preview/2022-09-01-preview/elastic.json#L1444
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.Elastic/preview/2022-09-01-preview/elastic.json#L1658
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Elastic/preview/2022-09-01-preview/elastic.json#L1769
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Elastic/preview/2022-09-01-preview/elastic.json#L1911
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Elastic/preview/2022-09-01-preview/elastic.json#L1915
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Elastic/preview/2022-09-01-preview/elastic.json#L1919
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Elastic/preview/2022-09-01-preview/elastic.json#L1970
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Elastic/preview/2022-09-01-preview/elastic.json#L2044
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Elastic/preview/2022-09-01-preview/elastic.json#L2217
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 23 Errors, 0 Warnings failed [Detail]

    Tag package-2022-09-01-preview; Prod region: Deployed

    Test run on region: centralindia; Operation coverage: total: 27, untested: 0, failed: 23, passed: 4

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Rule Message
    ❌ CLIENT_ERROR statusCode: 400,
    errorCode: InvalidResource,
    errorMessage: The resource definition is invalid.
    Source: runtime
    OperationId: Monitors_Create
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornltk4oa' under resource group 'apiTest-gSUnXb-21670' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Monitors_Get
    ❌ CLIENT_ERROR statusCode: 400,
    errorCode: InvalidResource,
    errorMessage: The resource definition is invalid.
    Source: runtime
    OperationId: Monitors_Update
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'monitornltk4oa' not found.
    Source: runtime
    OperationId: TagRules_CreateOrUpdate
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'monitornltk4oa' not found.
    Source: runtime
    OperationId: TagRules_List
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'monitornltk4oa' not found.
    Source: runtime
    OperationId: TagRules_Get
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornltk4oa' under resource group 'apiTest-gSUnXb-21670' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: AssociateTrafficFilter_Associate
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornltk4oa' under resource group 'apiTest-gSUnXb-21670' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: createAndAssociateIPFilter_Create
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornltk4oa' under resource group 'apiTest-gSUnXb-21670' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: createAndAssociatePLFilter_Create
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornltk4oa' under resource group 'apiTest-gSUnXb-21670' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: ExternalUser_CreateOrUpdate
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornltk4oa' under resource group 'apiTest-gSUnXb-21670' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: TrafficFilters_Delete
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornltk4oa' under resource group 'apiTest-gSUnXb-21670' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: DetachAndDeleteTrafficFilter_Delete
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornltk4oa' under resource group 'apiTest-gSUnXb-21670' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: DetachTrafficFilter_Update
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornltk4oa' under resource group 'apiTest-gSUnXb-21670' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: AllTrafficFilters_list
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornltk4oa' under resource group 'apiTest-gSUnXb-21670' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: listAssociatedTrafficFilters_list
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornltk4oa' under resource group 'apiTest-gSUnXb-21670' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: DeploymentInfo_List
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornltk4oa' under resource group 'apiTest-gSUnXb-21670' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: MonitoredResources_List
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornltk4oa' under resource group 'apiTest-gSUnXb-21670' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: UpgradableVersions_Details
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornltk4oa' under resource group 'apiTest-gSUnXb-21670' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: VMHost_List
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornltk4oa' under resource group 'apiTest-gSUnXb-21670' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Monitor_Upgrade
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornltk4oa' under resource group 'apiTest-gSUnXb-21670' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: VMCollection_Update
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornltk4oa' under resource group 'apiTest-gSUnXb-21670' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: VMIngestion_Details
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'monitornltk4oa' not found.
    Source: runtime
    OperationId: TagRules_Delete
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 28, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking



    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 7cfe017. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.4.2
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.4.2>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-elastic [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model DeploymentInfoResponse has a new parameter deployment_url
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 7cfe017. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-elastic [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 7cfe017. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/elastic/armelastic [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New field `DeploymentURL` in struct `DeploymentInfoResponse`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 7cfe017. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️elastic [View full logs]  [Release Schema Changes]
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 7cfe017. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.Elastic [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 28, 2022 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/elastic/armelastic https://apiview.dev/Assemblies/Review/06497b26632f43d3b591bbd1481cb81e
    Java azure-resourcemanager-elastic https://apiview.dev/Assemblies/Review/3ff5d04c87e14d3ea73c957b69e88c57

    This was referenced Nov 28, 2022
    Closed
    Closed
    @pachaturvedi
    Copy link
    Contributor Author

    pachaturvedi commented Nov 28, 2022 •
    edited
    Loading

    @ArcturusZhang
    Regarding the breaking changes, this is a swagger fix from our side because we did not have a 202 response for all x-ms-long-running-operation: true (as mentioned in link )

    Regarding Model validation failures, we've always been returning the status in the previous versions as well. Is this something for which we can get exception?

    @azure-sdk azure-sdk mentioned this pull request Nov 28, 2022
    Closed
    @openapi-workflow-bot
    Copy link

    Hi @pachaturvedi, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi @pachaturvedi, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @openapi-workflow-bot
    Copy link

    Hi, @pachaturvedi, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    This was referenced Nov 28, 2022
    Closed
    Closed
    @pachaturvedi
    Copy link
    Contributor Author

    @ArcturusZhang could you please help review this PR?

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 1, 2023
    @sjanamma sjanamma added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 1, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 1, 2023
    @utkarshjain1508 utkarshjain1508 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 6, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 6, 2023
    @sjanamma
    Copy link

    sjanamma commented Feb 6, 2023

    Please add x-ms-long-running-operation-options for long running operations

    https://github.com/Azure/azure-openapi-validator/blob/main/docs/long-running-operations-options-validator.md
    More details here - https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-long-running-operation

    @sjanamma sjanamma added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 6, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 6, 2023
    @utkarshjain1508 utkarshjain1508 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 7, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 7, 2023
    @zizw123 zizw123 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Feb 7, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 7, 2023
    @pachaturvedi pachaturvedi requested review from sjanamma and zizw123 and removed request for zizw123 and sjanamma February 8, 2023 05:22
    @honghr honghr merged commit 7cfe017 into Azure:main Feb 9, 2023
    This was referenced Feb 9, 2023
    Closed
    Merged
    Closed
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Feb 9, 2023
    [ReleasePR elastic] Pachaturvedi/elastic new version 2022 09 01 previ…
    5728850 
    …ew (#2788)

Create to sync Azure/azure-rest-api-specs#21670
[ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/elastic?expand=1)
    This was referenced Feb 9, 2023
    Closed
    Closed
    aviyerMSFT pushed a commit to aviyerMSFT/azure-rest-api-specs that referenced this pull request Mar 22, 2023
    @pachaturvedi @aviyerMSFT
    Pachaturvedi/elastic new version 2022 09 01 preview (Azure#21670)
    673e34e 
    * base commit

* update elastic.json & examples

* Sync with azure-rest-api-specs-pr for 2022-09-01-preview

* Update 202 response for long-running-operations in 2022-07-01

* Addressed review comments to fix ApiVersionParameter

* Update response status to 200 for TrafficFilterCreate

* Fix Swagger model validation error

* fix prettier check

* Update api version in examples

* Addressed Review comments

* Add Long running operation opeions
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @sjanamma sjanamma sjanamma left review comments

    @rkmanda rkmanda rkmanda left review comments

    @honghr honghr honghr approved these changes

    @zizw123 zizw123 Awaiting requested review from zizw123

    Assignees

    @honghr honghr

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-MissingBaseCommit new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.