recoveryservicessiterecovery: fixing an inconsistency in the segment naming #21667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…naming This being named both `replicatedProtectedItemName` and `replicationProtectedItemName` leads to spurious diff's, as can be seen here: https://github.com/hashicorp/pandora/pull/1876/files#diff-769ff618512efcaf7271a5282d8cac1250e3ad381b060f86f2d6f209cedf8cf4L15
|
Hi, @tombuildsstuff Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.2)] | new version | base version |
|---|---|---|
| service.json | 2022-10-01(340626e) | 2022-10-01(main) |
Only 24 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L2883:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/addDisks' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3151:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/applyRecoveryPoint' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3228:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/failoverCancel' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3305:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/failoverCommit' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3370:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/plannedFailover' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3435:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/recoveryPoints' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3512:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/recoveryPoints/{recoveryPointName}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3576:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/remove' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3644:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/removeDisks' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3715:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/repairReplication' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3792:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/reProtect' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3857:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/resolveHealthErrors' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3934:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/switchProvider' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L4011:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/targetComputeSizes' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L4091:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/testFailover' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L4155:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/testFailoverCleanup' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L4232:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/unplannedFailover' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L4309:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/updateAppliance' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L4386:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/updateMobilityService' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L4463:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L2883:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3151:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3228:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3305:5 |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️🔄LintDiff inProgress [Detail]
️❌Avocado: 20 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/addDisks is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/applyRecoveryPoint is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/failoverCancel is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/failoverCommit is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/plannedFailover is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/recoveryPoints is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/recoveryPoints/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/remove is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/removeDisks is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/repairReplication is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/reProtect is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/resolveHealthErrors is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/targetComputeSizes is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/testFailover is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/testFailoverCleanup is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/unplannedFailover is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/updateMobilityService is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/updateAppliance is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/switchProvider is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 124 Errors, 0 Warnings failed [Detail]
Only 24 items are listed, please refer to log for more details.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
ghost
added
the
customer-reported
Generated ApiView
|
|
Thank you for your contribution tombuildsstuff! We will review the pull request and get back to you soon. |
AzureRestAPISpecReview
added
ARMReview
BreakingChangeReviewRequired
|
Hi @tombuildsstuff, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Hi @tombuildsstuff, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
NewApiVersionRequired reason: |
This was referenced Nov 28, 2022
tombuildsstuff
added a commit
to hashicorp/pandora
that referenced
this pull request
Nov 28, 2022
…ecoveryServices Site Recovery Temporarily works around Azure/azure-rest-api-specs#21667 until that's fixed upstream
|
There are a bunch of breaking changes reported on this PR. Please get a breaking changes approval and ARM can review the changes afterwards. Once you have the approval, please remove the "ARMChangesRequested" label from the PR to make the PR visible to the ARM reviewers. |
rkmanda
added
the
ARMChangesRequested
|
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
There's no breaking changes in this PR, it's renaming a segment to be consistent, which is unfortunately flagged as a breaking change when it isn't - so this is waiting on the Service Team to review it |
favoretti
pushed a commit
to favoretti/pandora
that referenced
this pull request
Feb 3, 2023
…ecoveryServices Site Recovery Temporarily works around Azure/azure-rest-api-specs#21667 until that's fixed upstream
|
Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Still waiting on the service team here? |
konrad-jamrozik
added
the
VersioningReviewRequired
Next Steps to MergeNext steps that must be taken to merge this PR:
|
konrad-jamrozik
removed
NewApiVersionRequired
VersioningReviewRequired
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This being named both
replicatedProtectedItemNameandreplicationProtectedItemNameleads to spurious diff's, as can be seen here:https://github.com/hashicorp/pandora/pull/1876/files#diff-769ff618512efcaf7271a5282d8cac1250e3ad381b060f86f2d6f209cedf8cf4L15