-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swagger definitions for the schemas of the Event Grid events published by Azure Storage and Azure EventHub services. #2147
Conversation
# Conflicts: # specification/eventgrid/resource-manager/Microsoft.EventGrid/2017-06-15-preview/EventGrid.json # specification/eventgrid/resource-manager/readme.md
…enced in the Swagger.
…d by Azure Storage and Azure EventHub services.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review the linter errors: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/316049515
# Conflicts: # specification/eventgrid/data-plane/readme.md
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
@alvadb, regarding the linter error, the error is "Error: No unique 'title' across OpenAPI definitions:", however in this case they are three separate Swagger definitions so the titles being unique is by design. (This is somewhat similar to the model of https://github.com/Azure/azure-rest-api-specs/blob/master/specification/compute/resource-manager/readme.md where multiple swagger definition files are included in the same autorest configuration file in readme.md). |
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
@alvadb, can you please take a look at this PR? Please see my comments above related to the 1 linter error. Thanks! |
I seem to have lost permission to merge. I will look into this and hope to get this merged tomorrow. |
No modification for AutorestCI/azure-sdk-for-python |
No modification for AutorestCI/azure-sdk-for-ruby |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger