Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger definitions for the schemas of the Event Grid events published by Azure Storage and Azure EventHub services. #2147

Merged
merged 24 commits into from
Jan 8, 2018

Conversation

kalyanaj
Copy link
Contributor

@kalyanaj kalyanaj commented Dec 13, 2017

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

# Conflicts:
#	specification/eventgrid/resource-manager/Microsoft.EventGrid/2017-06-15-preview/EventGrid.json
#	specification/eventgrid/resource-manager/readme.md
…d by Azure Storage and Azure EventHub services.
Copy link

@alvadb alvadb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marstr marstr changed the base branch from current to master December 28, 2017 17:55
# Conflicts:
#	specification/eventgrid/data-plane/readme.md
@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/eventgrid/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@kalyanaj
Copy link
Contributor Author

kalyanaj commented Jan 2, 2018

@alvadb, regarding the linter error, the error is "Error: No unique 'title' across OpenAPI definitions:", however in this case they are three separate Swagger definitions so the titles being unique is by design. (This is somewhat similar to the model of https://github.com/Azure/azure-rest-api-specs/blob/master/specification/compute/resource-manager/readme.md where multiple swagger definition files are included in the same autorest configuration file in readme.md).

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/eventgrid/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@kalyanaj
Copy link
Contributor Author

kalyanaj commented Jan 5, 2018

@alvadb, can you please take a look at this PR? Please see my comments above related to the 1 linter error. Thanks!

@alvadb
Copy link

alvadb commented Jan 8, 2018

I seem to have lost permission to merge. I will look into this and hope to get this merged tomorrow.

@alvadb alvadb merged commit ce1b768 into Azure:master Jan 8, 2018
@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-python

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-ruby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants