Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.SqlVirtualMachine to add version preview/2022-08-01-preview #21422

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
f260d7a
Adds base for updating Microsoft.SqlVirtualMachine from version previ…
qianliu-pdx Nov 3, 2022
31aa21d
Updates readme
qianliu-pdx Nov 3, 2022
c48a48d
Updates API version in new specs and examples
qianliu-pdx Nov 3, 2022
39151f9
Adding 2022-08-01-preview version for Sql Virtual Machine swagger
Nov 4, 2022
b4926be
move all api-version to 2022-08-01-preview
Nov 4, 2022
7c1daae
fix the following validation errors:
Nov 4, 2022
71e1fd9
add location for 202 reponse
Nov 4, 2022
4df63c9
fix typo
Nov 4, 2022
d1d6d52
fix LRO_RESPONSE_HEADER validation error
Nov 4, 2022
e099070
fix Swagger PrettierCheck
Nov 4, 2022
2d76d31
fix 1047 - XmsEnumChanged, manually move IdentityTypeWithNone to
Nov 10, 2022
f9431b9
fix DefinitionsPropertiesNamesCamelCase, adding
Nov 10, 2022
41c5e2b
adding azureADAuthenticationSettings in the alphabetical position.
Nov 11, 2022
6144a39
fix PostOperationAsyncResponseValidation and LroLocationHeader errors
Nov 11, 2022
bc919e1
fix typo
Nov 11, 2022
752e75f
missing quote
Nov 11, 2022
34e6fca
adding quote
Nov 11, 2022
48023bb
fix DefinitionsPropertiesNamesCamelCase
Nov 11, 2022
37f3118
remove azureADAuthenticationSettings
Nov 11, 2022
19fb3e0
fix ResourceNameRestriction
Nov 11, 2022
dc25276
use \" to escape "
Nov 11, 2022
741ea38
fix swagger regex syntax difference comparing to C# regex
Nov 11, 2022
55a3c4a
addressing one comment from ARM team to add error response schema for
Nov 17, 2022
28d7430
fix 202 response:
Nov 17, 2022
0ef0501
UnHealthyReplica to UnhealthyReplica
Nov 18, 2022
2812cb3
TroubleShoot to Troubleshoot
Nov 18, 2022
d32ebd9
"UTC format" to "UTC timezone"
Nov 18, 2022
6f498c4
SqlVmTroubleshoot to SqlVmTroubleshooting
Nov 18, 2022
b1b5e24
Successfully started SQL virtual machine troubleshoot to Successfully
Nov 18, 2022
e9722d5
"SQL Iaas Extension" to "SQL IaaS Extension"
Nov 18, 2022
50bef2f
Assessment to "an assessment" and other similiar issues
Nov 18, 2022
2667055
resolve conflict for custom-words.txt
Nov 18, 2022
8aa651d
resolve conflict
Nov 18, 2022
8308eff
adding default for troubleshootingScenario
Nov 19, 2022
b879556
refactor all sqlVirtualMachineName into common definition and reference
Nov 19, 2022
f305a82
add x-ms-long-running-operation-options with azure-async-operation
Nov 19, 2022
39801f0
remove Location header from the Post request
Nov 19, 2022
8f28bca
add back the Location header for the Post method, as the validation
Nov 29, 2022
cc73dcb
add response schema to HA troubleshooting endpoint 200 response.
Nov 30, 2022
3e3331e
add "default" to false for SQL IAAS auto upgrade property
Dec 1, 2022
ff04bd9
renaming:
Dec 1, 2022
d32184a
update the HA troubleshooting example after the renaming in this
Dec 1, 2022
6269746
rewording Assessment as SQL best practices Assessment after consulting
Dec 1, 2022
d787456
revert custom-words.tx file
Dec 2, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
{
"parameters": {
"subscriptionId": "00000000-1111-2222-3333-444444444444",
"resourceGroupName": "testrg",
"sqlVirtualMachineGroupName": "testvmgroup",
"availabilityGroupListenerName": "agl-test",
"api-version": "2022-08-01-preview",
"parameters": {
"properties": {
"availabilityGroupName": "ag-test",
"loadBalancerConfigurations": [
{
"privateIpAddress": {
"ipAddress": "10.1.0.112",
"subnetResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/default"
},
"loadBalancerResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Network/loadBalancers/lb-test",
"probePort": 59983,
"sqlVirtualMachineInstances": [
"/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm2",
"/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm3"
]
}
],
"port": 1433
}
}
},
"responses": {
"200": {
"body": {
"properties": {
"provisioningState": "Updating",
"loadBalancerConfigurations": [
{
"privateIpAddress": {
"ipAddress": "10.1.0.113",
"subnetResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/default"
},
"sqlVirtualMachineInstances": [
"/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm2",
"/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm3"
]
}
],
"port": 1433
},
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/testvmgroup/availabilityGroupListeners/agl-test",
"name": "agl-test",
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/availabilityGroupListeners"
}
},
"201": {
"body": {
"properties": {
"provisioningState": "Provisioning",
"loadBalancerConfigurations": [
{
"privateIpAddress": {
"ipAddress": "10.1.0.112",
"subnetResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/default"
},
"sqlVirtualMachineInstances": [
"/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm2",
"/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm3"
]
}
],
"port": 1433
},
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/testvmgroup/availabilityGroupListeners/agl-test",
"name": "agl-test",
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/availabilityGroupListeners"
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
{
"parameters": {
"subscriptionId": "00000000-1111-2222-3333-444444444444",
"resourceGroupName": "testrg",
"sqlVirtualMachineGroupName": "testvmgroup",
"availabilityGroupListenerName": "agl-test",
"api-version": "2022-08-01-preview",
"parameters": {
"properties": {
"availabilityGroupName": "ag-test",
"multiSubnetIpConfigurations": [
{
"privateIpAddress": {
"ipAddress": "10.0.0.112",
"subnetResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/default"
},
"sqlVirtualMachineInstance": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm2"
},
{
"privateIpAddress": {
"ipAddress": "10.0.1.112",
"subnetResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/alternate"
},
"sqlVirtualMachineInstance": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm1"
}
],
"port": 1433
}
}
},
"responses": {
"200": {
"body": {
"properties": {
"provisioningState": "Updating",
"multiSubnetIpConfigurations": [
{
"privateIpAddress": {
"ipAddress": "10.0.0.112",
"subnetResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/default"
},
"sqlVirtualMachineInstance": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm2"
},
{
"privateIpAddress": {
"ipAddress": "10.0.1.112",
"subnetResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/alternate"
},
"sqlVirtualMachineInstance": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm1"
}
],
"port": 1433
},
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/testvmgroup/availabilityGroupListeners/agl-test",
"name": "agl-test",
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/availabilityGroupListeners"
}
},
"201": {
"body": {
"properties": {
"provisioningState": "Provisioning",
"multiSubnetIpConfigurations": [
{
"privateIpAddress": {
"ipAddress": "10.0.0.112",
"subnetResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/default"
},
"sqlVirtualMachineInstance": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm2"
},
{
"privateIpAddress": {
"ipAddress": "10.0.1.112",
"subnetResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/alternate"
},
"sqlVirtualMachineInstance": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm1"
}
],
"port": 1433
},
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/testvmgroup/availabilityGroupListeners/agl-test",
"name": "agl-test",
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/availabilityGroupListeners"
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,100 @@
{
"parameters": {
"subscriptionId": "00000000-1111-2222-3333-444444444444",
"resourceGroupName": "testrg",
"sqlVirtualMachineName": "testvm",
"api-version": "2022-08-01-preview",
"parameters": {
"location": "northeurope",
"properties": {
"sqlServerLicenseType": "PAYG",
"sqlImageSku": "Enterprise",
"sqlManagement": "Full",
"virtualMachineResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Compute/virtualMachines/testvm",
"serverConfigurationsManagementSettings": {
"sqlConnectivityUpdateSettings": {
"connectivityType": "PRIVATE",
"port": 1433,
"sqlAuthUpdateUserName": "sqllogin",
"sqlAuthUpdatePassword": "<password>"
},
"sqlStorageUpdateSettings": {
"diskCount": 1,
"startingDeviceId": 2,
"diskConfigurationType": "NEW"
},
"sqlWorkloadTypeUpdateSettings": {
"sqlWorkloadType": "OLTP"
},
"additionalFeaturesServerConfigurations": {
"isRServicesEnabled": false
}
},
"keyVaultCredentialSettings": {
"enable": false
},
"autoPatchingSettings": {
"enable": true,
"dayOfWeek": "Sunday",
"maintenanceWindowStartingHour": 2,
"maintenanceWindowDuration": 60
},
"autoBackupSettings": {
"enable": true,
"retentionPeriod": 17,
"enableEncryption": true,
"password": "<Password>",
"backupScheduleType": "Manual",
"backupSystemDbs": true,
"storageAccountUrl": "https://teststorage.blob.core.windows.net/",
"storageContainerName": "testcontainer",
"storageAccessKey": "<primary storage access key>",
"fullBackupFrequency": "Weekly",
"daysOfWeek": [
"Monday",
"Friday"
],
"fullBackupStartTime": 6,
"fullBackupWindowHours": 11,
"logBackupFrequency": 10
}
}
}
},
"responses": {
"200": {
"body": {
"properties": {
"virtualMachineResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Compute/virtualMachines/testvm",
"provisioningState": "Updating",
"sqlServerLicenseType": "PAYG",
"sqlImageSku": "Enterprise",
"leastPrivilegeMode": "NotSet",
"enableAutomaticUpgrade": false,
"sqlManagement": "Full"
},
"location": "northeurope",
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm",
"name": "testvm",
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachines"
}
},
"201": {
"body": {
"properties": {
"virtualMachineResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Compute/virtualMachines/testvm",
"provisioningState": "Provisioning",
"sqlServerLicenseType": "PAYG",
"sqlImageSku": "Unknown",
"leastPrivilegeMode": "NotSet",
"enableAutomaticUpgrade": true,
"sqlManagement": "Full"
},
"location": "northeurope",
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm",
"name": "testvm",
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachines"
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
{
"parameters": {
"subscriptionId": "00000000-1111-2222-3333-444444444444",
"resourceGroupName": "testrg",
"sqlVirtualMachineGroupName": "testvmgroup",
"api-version": "2022-08-01-preview",
"parameters": {
"location": "northeurope",
"tags": {
"mytag": "myval"
},
"properties": {
"sqlImageOffer": "SQL2016-WS2016",
"sqlImageSku": "Enterprise",
"wsfcDomainProfile": {
"domainFqdn": "testdomain.com",
"ouPath": "OU=WSCluster,DC=testdomain,DC=com",
"clusterBootstrapAccount": "testrpadmin",
"clusterOperatorAccount": "[email protected]",
"sqlServiceAccount": "[email protected]",
"storageAccountUrl": "https://storgact.blob.core.windows.net/",
"storageAccountPrimaryKey": "<primary storage access key>",
"clusterSubnetType": "MultiSubnet"
}
}
}
},
"responses": {
"200": {
"body": {
"properties": {
"provisioningState": "UpdatingDomainful",
"sqlImageOffer": "SQL2016-WS2016",
"sqlImageSku": "Enterprise",
"wsfcDomainProfile": {
"domainFqdn": "testdomain.com",
"ouPath": "OU=WSCluster,DC=testdomain,DC=com",
"clusterBootstrapAccount": "testrpadmin",
"clusterOperatorAccount": "[email protected]",
"sqlServiceAccount": "[email protected]",
"storageAccountUrl": "https://storgact.blob.core.windows.net/",
"clusterSubnetType": "MultiSubnet"
}
},
"location": "northeurope",
"tags": {
"mytag": "myval"
},
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/testvmgroup",
"name": "testvmgroup",
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups"
}
},
"201": {
"body": {
"properties": {
"provisioningState": "ProvisioningDomainful",
"sqlImageOffer": "SQL2016-WS2016",
"sqlImageSku": "Enterprise",
"wsfcDomainProfile": {
"domainFqdn": "testdomain.com",
"ouPath": "OU=WSCluster,DC=testdomain,DC=com",
"clusterBootstrapAccount": "testrpadmin",
"clusterOperatorAccount": "[email protected]",
"sqlServiceAccount": "[email protected]",
"storageAccountUrl": "https://storgact.blob.core.windows.net/",
"clusterSubnetType": "MultiSubnet"
}
},
"location": "northeurope",
"tags": {
"mytag": "myval"
},
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/testvmgroup",
"name": "testvmgroup",
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups"
}
}
}
}
Loading