-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Microsoft.BillingBenefits] Adding 2022-11-01 stable version #21340
Merged
msyyc
merged 38 commits into
Azure:main
from
gaoyp830:billingbenefits-Microsoft.BillingBenefits-2022-11-01
Nov 14, 2022
Merged
[Microsoft.BillingBenefits] Adding 2022-11-01 stable version #21340
msyyc
merged 38 commits into
Azure:main
from
gaoyp830:billingbenefits-Microsoft.BillingBenefits-2022-11-01
Nov 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoyp830
requested review from
msyyc,
Wzb123456789,
ArcturusZhang,
jsntcy and
qiaozha
as code owners
October 30, 2022 23:58
Hi, @gaoyp830 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
labels
Oct 30, 2022
Hi, @gaoyp830 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
Swagger Validation Report
|
rkmanda
added
the
ARMChangesRequested
<valid label in PR review process>add this label when require changes after ARM review
label
Nov 11, 2022
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Nov 11, 2022
gaoyp830
removed
the
ARMChangesRequested
<valid label in PR review process>add this label when require changes after ARM review
label
Nov 12, 2022
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Nov 12, 2022
rkmanda
added
the
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
label
Nov 12, 2022
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Nov 12, 2022
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
discussion in teams : |
Swagger Generation Artifacts
|
This was referenced Nov 14, 2022
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Nov 14, 2022
…1-01 stable version (#2662) Create to sync Azure/azure-rest-api-specs#21340 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/billingbenefits?expand=1)
anandanthony
pushed a commit
to anandMicro/azure-rest-api-specs
that referenced
this pull request
Dec 16, 2022
…1340) * New Swagger Spec File * New Swagger Example Spec File * New Readme Config File * New Azure AZ Readme Config File * New Azure CLI Readme Config File * New Go Language Readme Config File * New Python Language Readme Config File * New Typescript Language Readme Config File * New C# Language Readme Config File * base * Savings plan order get/list and savings plan item get * List SavingsPlan API * CalculateMigrationCost * Fixing list api summary property * Update * elevate * Fixing * ReservationOrderAlias * Validate swagger and example * Fix style * update * Remove audit api * Comments * comments and remove migration api * Fixing pipeline * Update elevate api response * Update SavingsPlanOrderElevate.json * update * Update billingbenefits.json * Update patch api * Addressed comments * Update ReservationOrderAliasCreate.json * Update readme.md * Update readme.md * Update readme.md * 200 in order alias put * Update billingbenefits.json * Update readme.md
kayousef-zz
pushed a commit
to kayousef-zz/azure-rest-api-specs
that referenced
this pull request
Dec 21, 2022
…1340) * New Swagger Spec File * New Swagger Example Spec File * New Readme Config File * New Azure AZ Readme Config File * New Azure CLI Readme Config File * New Go Language Readme Config File * New Python Language Readme Config File * New Typescript Language Readme Config File * New C# Language Readme Config File * base * Savings plan order get/list and savings plan item get * List SavingsPlan API * CalculateMigrationCost * Fixing list api summary property * Update * elevate * Fixing * ReservationOrderAlias * Validate swagger and example * Fix style * update * Remove audit api * Comments * comments and remove migration api * Fixing pipeline * Update elevate api response * Update SavingsPlanOrderElevate.json * update * Update billingbenefits.json * Update patch api * Addressed comments * Update ReservationOrderAliasCreate.json * Update readme.md * Update readme.md * Update readme.md * 200 in order alias put * Update billingbenefits.json * Update readme.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMReview
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
CI-MissingBaseCommit
new-api-version
ReadyForApiTest
<valid label in PR review process>add this label when swagger and service APIs are ready for test
resource-manager
SuppressionReviewRequired
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
, API version update for previous endpoints as the second commit, and new API endpoint as the third commit.
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.