Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Microsoft.BillingBenefits] Adding 2022-11-01 stable version #21340

Merged

Conversation

gaoyp830
Copy link
Contributor

@gaoyp830 gaoyp830 commented Oct 30, 2022

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • ] Other, please clarify

, API version update for previous endpoints as the second commit, and new API endpoint as the third commit.

  1. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  2. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  3. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @gaoyp830 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 30, 2022
    @openapi-workflow-bot
    Copy link

    Hi, @gaoyp830 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 30, 2022

    Swagger Validation Report

    ️🔄BreakingChange inProgress [Detail]
    ️🔄Breaking Change(Cross-Version) inProgress [Detail]
    ️🔄CredScan inProgress [Detail]
    ️🔄LintDiff inProgress [Detail]
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️🔄ApiReadinessCheck inProgress [Detail]
    ️⌛~[Staging] ServiceAPIReadinessTest pending [Detail]
    ️🔄ModelValidation inProgress [Detail]
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️🔄PoliCheck inProgress [Detail]
    ️🔄PrettierCheck inProgress [Detail]
    ️🔄SpellCheck inProgress [Detail]
    ️🔄Lint(RPaaS) inProgress [Detail]
    ️⌛CadlValidation pending [Detail]
    ️⌛PR Summary pending [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @rkmanda rkmanda added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Nov 11, 2022
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 11, 2022
    @gaoyp830 gaoyp830 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Nov 12, 2022
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 12, 2022
    @rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 12, 2022
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 12, 2022
    @msyyc
    Copy link
    Member

    msyyc commented Nov 14, 2022

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @msyyc
    Copy link
    Member

    msyyc commented Nov 14, 2022

    discussion in teams : Microsoft.BillingBenefits ARM API Review

    @msyyc msyyc merged commit 33bc423 into Azure:main Nov 14, 2022
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 14, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking



    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 33bc423. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.1.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.1.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-billingbenefits [View full logs]  [Release SDK Changes]
      info	[Changelog]   - Initial Release
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 33bc423. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 33bc423. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/billingbenefits/armbillingbenefits [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
      info	[Changelog]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 33bc423. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-billingbenefits [View full logs]  [Release SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 33bc423. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️billingbenefits [View full logs]  [Release Schema Changes]
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 33bc423. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.BillingBenefitsRp [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Nov 14, 2022
    anandanthony pushed a commit to anandMicro/azure-rest-api-specs that referenced this pull request Dec 16, 2022
    …1340)
    
    * New Swagger Spec File
    
    * New Swagger Example Spec File
    
    * New Readme Config File
    
    * New Azure AZ Readme Config File
    
    * New Azure CLI Readme Config File
    
    * New Go Language Readme Config File
    
    * New Python Language Readme Config File
    
    * New Typescript Language Readme Config File
    
    * New C# Language Readme Config File
    
    * base
    
    * Savings plan order get/list and savings plan item get
    
    * List SavingsPlan API
    
    * CalculateMigrationCost
    
    * Fixing list api summary property
    
    * Update
    
    * elevate
    
    * Fixing
    
    * ReservationOrderAlias
    
    * Validate swagger and example
    
    * Fix style
    
    * update
    
    * Remove audit api
    
    * Comments
    
    * comments and remove migration api
    
    * Fixing pipeline
    
    * Update elevate api response
    
    * Update SavingsPlanOrderElevate.json
    
    * update
    
    * Update billingbenefits.json
    
    * Update patch api
    
    * Addressed comments
    
    * Update ReservationOrderAliasCreate.json
    
    * Update readme.md
    
    * Update readme.md
    
    * Update readme.md
    
    * 200 in order alias put
    
    * Update billingbenefits.json
    
    * Update readme.md
    kayousef-zz pushed a commit to kayousef-zz/azure-rest-api-specs that referenced this pull request Dec 21, 2022
    …1340)
    
    * New Swagger Spec File
    
    * New Swagger Example Spec File
    
    * New Readme Config File
    
    * New Azure AZ Readme Config File
    
    * New Azure CLI Readme Config File
    
    * New Go Language Readme Config File
    
    * New Python Language Readme Config File
    
    * New Typescript Language Readme Config File
    
    * New C# Language Readme Config File
    
    * base
    
    * Savings plan order get/list and savings plan item get
    
    * List SavingsPlan API
    
    * CalculateMigrationCost
    
    * Fixing list api summary property
    
    * Update
    
    * elevate
    
    * Fixing
    
    * ReservationOrderAlias
    
    * Validate swagger and example
    
    * Fix style
    
    * update
    
    * Remove audit api
    
    * Comments
    
    * comments and remove migration api
    
    * Fixing pipeline
    
    * Update elevate api response
    
    * Update SavingsPlanOrderElevate.json
    
    * update
    
    * Update billingbenefits.json
    
    * Update patch api
    
    * Addressed comments
    
    * Update ReservationOrderAliasCreate.json
    
    * Update readme.md
    
    * Update readme.md
    
    * Update readme.md
    
    * 200 in order alias put
    
    * Update billingbenefits.json
    
    * Update readme.md
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-MissingBaseCommit new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager SuppressionReviewRequired
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants