Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix naming consistency of recoveryservicessiterecovery@2022-09-10 #21207

Merged
merged 1 commit into from
Nov 14, 2022
Merged

fix naming consistency of recoveryservicessiterecovery@2022-09-10 #21207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...essiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2022-09-10/service.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4460,7 +4460,7 @@
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicationProtectedItemName}/updateMobilityService": {
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/updateMobilityService": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subscriptions

please get the breaking change approved after which ARM can sign off

Copy link
Contributor

@magodo magodo Oct 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rkmanda From what I know, this is not a breakinge change from API's perspective, could you please double confirm?

Ping @leni-msft

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeffreyRichter could you check if renaming path parameter is breaking change from API's perspective?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is potentially breaking in C# SDKs but is so unlikely that we consider it non-breaking.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rkmanda Any update on this PR? I saw there is another similar PR got merged month ago: #20588.

"post": {
"tags": [
"ReplicationProtectedItems"
Expand Down Expand Up @@ -4502,7 +4502,7 @@
"type": "string"
},
{
"name": "replicationProtectedItemName",
"name": "replicatedProtectedItemName",
"in": "path",
"description": "The name of the protected item on which the agent is to be updated.",
"required": true,
Expand Down