Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataFactory] Add properties to spark job activity #20879

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

wonner
Copy link
Contributor

@wonner wonner commented Sep 27, 2022

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 27, 2022

Swagger Validation Report

️❌BreakingChange: 9 Errors, 0 Warnings failed [Detail]
compared swaggers (via Oad v0.9.7)] new version base version
entityTypes 2018-06-01(3c758a0) 2018-06-01(main)
entityTypes 2020-12-01(3c758a0) 2020-12-01(main)
Rule Message
1026 - TypeChanged The new version has a different type 'object' than the previous one 'string'.
New: stable/2018-06-01/entityTypes/Pipeline.json#L7999:9
Old: stable/2018-06-01/entityTypes/Pipeline.json#L7980:9
1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
New: stable/2018-06-01/entityTypes/Pipeline.json#L7934:11
Old: stable/2018-06-01/entityTypes/Pipeline.json#L7934:11
1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
New: stable/2020-12-01/entityTypes/Pipeline.json#L7504:11
Old: stable/2020-12-01/entityTypes/Pipeline.json#L7504:11
1045 - AddedOptionalProperty The new version has a new optional property 'workspaceResourceId' that was not found in the old version.
New: stable/2018-06-01/entityTypes/LinkedService.json#L6942:7
Old: stable/2018-06-01/entityTypes/LinkedService.json#L6942:7
1045 - AddedOptionalProperty The new version has a new optional property 'pythonCodeReference' that was not found in the old version.
New: stable/2018-06-01/entityTypes/Pipeline.json#L7909:7
Old: stable/2018-06-01/entityTypes/Pipeline.json#L7909:7
1045 - AddedOptionalProperty The new version has a new optional property 'filesV2' that was not found in the old version.
New: stable/2018-06-01/entityTypes/Pipeline.json#L7909:7
Old: stable/2018-06-01/entityTypes/Pipeline.json#L7909:7
1045 - AddedOptionalProperty The new version has a new optional property 'workspaceResourceId' that was not found in the old version.
New: stable/2020-12-01/entityTypes/LinkedService.json#L6687:7
Old: stable/2020-12-01/entityTypes/LinkedService.json#L6687:7
1045 - AddedOptionalProperty The new version has a new optional property 'pythonCodeReference' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L7479:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L7479:7
1045 - AddedOptionalProperty The new version has a new optional property 'filesV2' that was not found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L7479:7
Old: stable/2020-12-01/entityTypes/Pipeline.json#L7479:7
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v1.13.0) new version base version
package-2018-06 package-2018-06(3c758a0) package-2018-06(main)
package-artifacts-2020-12-01 package-artifacts-2020-12-01(3c758a0) package-artifacts-2020-12-01(main)
package-artifacts-composite-v1 package-artifacts-composite-v1(3c758a0) package-artifacts-composite-v1(main)
package-artifacts-composite-v5 package-artifacts-composite-v5(3c758a0) package-artifacts-composite-v5(main)
package-artifacts-composite-v4 package-artifacts-composite-v4(3c758a0) package-artifacts-composite-v4(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L46
R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L46
R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L238
R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L238
R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L5263
R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L5263
R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L6114
R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L6114
R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L6534
R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L6534
R4037 - MissingTypeObject The schema 'ControlActivity' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L197
R4037 - MissingTypeObject The schema 'ControlActivity' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L197
R4037 - MissingTypeObject The schema 'ExecutionActivity' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L207
R4037 - MissingTypeObject The schema 'ExecutionActivity' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L207
R4037 - MissingTypeObject The schema 'CopyActivity' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L1536
R4037 - MissingTypeObject The schema 'CopyActivity' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L1536
R4037 - MissingTypeObject The schema 'CopyActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L1575
R4037 - MissingTypeObject The schema 'CopyActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L1575
R4037 - MissingTypeObject The schema 'HDInsightHiveActivity' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L5193
R4037 - MissingTypeObject The schema 'HDInsightHiveActivity' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L5193
R4037 - MissingTypeObject The schema 'HDInsightHiveActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L5212
R4037 - MissingTypeObject The schema 'HDInsightHiveActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L5212
R4037 - MissingTypeObject The schema 'HDInsightPigActivity' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L5282
R4037 - MissingTypeObject The schema 'HDInsightPigActivity' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L5282
R4037 - MissingTypeObject The schema 'HDInsightPigActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L5301
R4037 - MissingTypeObject The schema 'HDInsightPigActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L5301
R4037 - MissingTypeObject The schema 'HDInsightMapReduceActivity' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L5340
R4037 - MissingTypeObject The schema 'HDInsightMapReduceActivity' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L5340
R4037 - MissingTypeObject The schema 'HDInsightMapReduceActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L5359
R4037 - MissingTypeObject The schema 'HDInsightMapReduceActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: stable/2018-06-01/entityTypes/Pipeline.json#L5359
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
Validation passes for ServiceAPIReadinessTest.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️SDK Track2 Validation: 13 Warnings warning [Detail]
  • The following tags are being changed in this PR
    • "https://github.com/Azure/azure-rest-api-specs/blob/3c758a03be34d5fdc4c75500833344edfd39284d/specification/datafactory/resource-manager/readme.md#tag-package-2018-06">datafactory/resource-manager/readme.md#package-2018-06
    • "https://github.com/Azure/azure-rest-api-specs/blob/3c758a03be34d5fdc4c75500833344edfd39284d/specification/synapse/data-plane/readme.md#tag-package-artifacts-composite-v5">synapse/data-plane/readme.md#package-artifacts-composite-v5
    • "https://github.com/Azure/azure-rest-api-specs/blob/3c758a03be34d5fdc4c75500833344edfd39284d/specification/synapse/data-plane/readme.md#tag-package-artifacts-composite-v4">synapse/data-plane/readme.md#package-artifacts-composite-v4
    • "https://github.com/Azure/azure-rest-api-specs/blob/3c758a03be34d5fdc4c75500833344edfd39284d/specification/synapse/data-plane/readme.md#tag-package-artifacts-composite-v3">synapse/data-plane/readme.md#package-artifacts-composite-v3
    • "https://github.com/Azure/azure-rest-api-specs/blob/3c758a03be34d5fdc4c75500833344edfd39284d/specification/synapse/data-plane/readme.md#tag-package-artifacts-composite-v2">synapse/data-plane/readme.md#package-artifacts-composite-v2
    • "https://github.com/Azure/azure-rest-api-specs/blob/3c758a03be34d5fdc4c75500833344edfd39284d/specification/synapse/data-plane/readme.md#tag-package-artifacts-composite-v1">synapse/data-plane/readme.md#package-artifacts-composite-v1
    • "https://github.com/Azure/azure-rest-api-specs/blob/3c758a03be34d5fdc4c75500833344edfd39284d/specification/synapse/data-plane/readme.md#tag-package-artifacts-2020-12-01">synapse/data-plane/readme.md#package-artifacts-2020-12-01
The following errors/warnings are introduced by current PR:
Rule Message
⚠️ Modeler/MissingType "readme":"datafactory/resource-manager/readme.md",
"tag":"package-2018-06",
"details":"The schema 'SynapseSparkJobActivityTypeProperties-argsItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json#/components/schemas/SynapseSparkJobActivityTypeProperties-argsItem"
⚠️ Modeler/MissingType "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v5",
"details":"The schema 'NotebookCellOutputItem-text' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/synapse/data-plane/Microsoft.Synapse/stable/2020-12-01/entityTypes/Notebook.json#/components/schemas/NotebookCellOutputItem-text"
⚠️ Modeler/MissingType "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v5",
"details":"The schema 'SynapseSparkJobActivityTypeProperties-argsItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/synapse/data-plane/Microsoft.Synapse/stable/2020-12-01/entityTypes/Pipeline.json#/components/schemas/SynapseSparkJobActivityTypeProperties-argsItem"
⚠️ Modeler/MissingType "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v4",
"details":"The schema 'NotebookCellOutputItem-text' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/synapse/data-plane/Microsoft.Synapse/stable/2020-12-01/entityTypes/Notebook.json#/components/schemas/NotebookCellOutputItem-text"
⚠️ Modeler/MissingType "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v4",
"details":"The schema 'SynapseSparkJobActivityTypeProperties-argsItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/synapse/data-plane/Microsoft.Synapse/stable/2020-12-01/entityTypes/Pipeline.json#/components/schemas/SynapseSparkJobActivityTypeProperties-argsItem"
⚠️ Modeler/MissingType "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v3",
"details":"The schema 'NotebookCellOutputItem-text' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/synapse/data-plane/Microsoft.Synapse/stable/2020-12-01/entityTypes/Notebook.json#/components/schemas/NotebookCellOutputItem-text"
⚠️ Modeler/MissingType "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v3",
"details":"The schema 'SynapseSparkJobActivityTypeProperties-argsItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/synapse/data-plane/Microsoft.Synapse/stable/2020-12-01/entityTypes/Pipeline.json#/components/schemas/SynapseSparkJobActivityTypeProperties-argsItem"
⚠️ Modeler/MissingType "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v2",
"details":"The schema 'NotebookCellOutputItem-text' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/synapse/data-plane/Microsoft.Synapse/stable/2020-12-01/entityTypes/Notebook.json#/components/schemas/NotebookCellOutputItem-text"
⚠️ Modeler/MissingType "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v2",
"details":"The schema 'SynapseSparkJobActivityTypeProperties-argsItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/synapse/data-plane/Microsoft.Synapse/stable/2020-12-01/entityTypes/Pipeline.json#/components/schemas/SynapseSparkJobActivityTypeProperties-argsItem"
⚠️ Modeler/MissingType "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v1",
"details":"The schema 'NotebookCellOutputItem-text' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/synapse/data-plane/Microsoft.Synapse/stable/2020-12-01/entityTypes/Notebook.json#/components/schemas/NotebookCellOutputItem-text"
⚠️ Modeler/MissingType "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v1",
"details":"The schema 'SynapseSparkJobActivityTypeProperties-argsItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/synapse/data-plane/Microsoft.Synapse/stable/2020-12-01/entityTypes/Pipeline.json#/components/schemas/SynapseSparkJobActivityTypeProperties-argsItem"
⚠️ Modeler/MissingType "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-2020-12-01",
"details":"The schema 'NotebookCellOutputItem-text' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/synapse/data-plane/Microsoft.Synapse/stable/2020-12-01/entityTypes/Notebook.json#/components/schemas/NotebookCellOutputItem-text"
⚠️ Modeler/MissingType "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-2020-12-01",
"details":"The schema 'SynapseSparkJobActivityTypeProperties-argsItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/synapse/data-plane/Microsoft.Synapse/stable/2020-12-01/entityTypes/Pipeline.json#/components/schemas/SynapseSparkJobActivityTypeProperties-argsItem"


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"datafactory/resource-manager/readme.md",
"tag":"package-2018-06",
"details":"Schema 'DataFlowSource' has a property 'dataset' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSource"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"datafactory/resource-manager/readme.md",
"tag":"package-2018-06",
"details":"Schema 'DataFlowSource' has a property 'linkedService' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSource"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"datafactory/resource-manager/readme.md",
"tag":"package-2018-06",
"details":"Schema 'DataFlowSource' has a property 'flowlet' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSource"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"datafactory/resource-manager/readme.md",
"tag":"package-2018-06",
"details":"Schema 'DataFlowSink' has a property 'dataset' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSink"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"datafactory/resource-manager/readme.md",
"tag":"package-2018-06",
"details":"Schema 'DataFlowSink' has a property 'linkedService' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSink"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"datafactory/resource-manager/readme.md",
"tag":"package-2018-06",
"details":"Schema 'DataFlowSink' has a property 'flowlet' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSink"
⚠️ UnkownSecurityScheme "readme":"datafactory/resource-manager/readme.md",
"tag":"package-2018-06",
"details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
AzureKey,
Anonymous"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v5",
"details":"Schema 'DataFlowSource' has a property 'dataset' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSource"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v5",
"details":"Schema 'DataFlowSource' has a property 'linkedService' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSource"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v5",
"details":"Schema 'DataFlowSource' has a property 'flowlet' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSource"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v5",
"details":"Schema 'DataFlowSink' has a property 'dataset' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSink"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v5",
"details":"Schema 'DataFlowSink' has a property 'linkedService' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSink"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v5",
"details":"Schema 'DataFlowSink' has a property 'flowlet' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSink"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v4",
"details":"Schema 'DataFlowSource' has a property 'dataset' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSource"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v4",
"details":"Schema 'DataFlowSource' has a property 'linkedService' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSource"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v4",
"details":"Schema 'DataFlowSource' has a property 'flowlet' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSource"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v4",
"details":"Schema 'DataFlowSink' has a property 'dataset' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSink"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v4",
"details":"Schema 'DataFlowSink' has a property 'linkedService' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSink"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v4",
"details":"Schema 'DataFlowSink' has a property 'flowlet' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSink"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v3",
"details":"Schema 'DataFlowSource' has a property 'dataset' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSource"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v3",
"details":"Schema 'DataFlowSource' has a property 'linkedService' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSource"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v3",
"details":"Schema 'DataFlowSource' has a property 'flowlet' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSource"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v3",
"details":"Schema 'DataFlowSink' has a property 'dataset' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSink"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v3",
"details":"Schema 'DataFlowSink' has a property 'linkedService' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSink"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v3",
"details":"Schema 'DataFlowSink' has a property 'flowlet' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSink"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v2",
"details":"Schema 'DataFlowSource' has a property 'dataset' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSource"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v2",
"details":"Schema 'DataFlowSource' has a property 'linkedService' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSource"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v2",
"details":"Schema 'DataFlowSource' has a property 'flowlet' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSource"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v2",
"details":"Schema 'DataFlowSink' has a property 'dataset' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSink"
⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-composite-v2",
"details":"Schema 'DataFlowSink' has a property 'linkedService' that is already declared the parent schema 'Transformation' but isn't significantly different. The property has been removed from DataFlowSink"
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link

Hi @wonner, this service has enabled Service API Toolset. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth. @Frey-Wang , please review this pull request if it's intentional or reject it if it's not expected. Normally, all the specification or example changes should start with PR created in ADO.

  • You can refer to Service API Toolset Introduction for details.
  • Please contact service focal @Frey-Wang contacts or Service API Toolset Support Channel if need further help.
  • @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 27, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/datafactory/armdatafactory - 2.0.0
    +	Struct `CloudErrorBody` has been removed
    +	Struct `CloudError` has been removed
    +	Type of `AmazonRdsForSQLServerSource.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`
    +	Type of `AzureSQLSink.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`
    +	Type of `AzureSQLSource.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`
    +	Type of `SQLMISink.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`
    +	Type of `SQLMISource.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`
    +	Type of `SQLServerSink.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`
    +	Type of `SQLServerSource.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`
    +	Type of `SQLSink.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`
    +	Type of `SQLSource.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`
    +	Type of `SynapseSparkJobReference.ReferenceName` has been changed from `*string` to `interface{}`


    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs]Release - Generate from c71a66d. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
      warn		specification/synapse/data-plane/readme.md skipped due to azure-sdk-for-net-track2 not found in swagger-to-sdk
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:515
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 515 | �[0m         �[96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mFailed to generate sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:599
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 599 | �[0m … rtifacts += �[96mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mCannot find path
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because it does not exist.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:515
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 515 | �[0m         �[96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mFailed to generate sdk artifact
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • Azure.ResourceManager.DataFactory [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from c71a66d. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      warn		specification/synapse/data-plane/readme.md skipped due to azure-sdk-for-python-track2 not found in swagger-to-sdk
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.15.0 -> 8.19.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.19.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-datafactory [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model AzureSynapseArtifactsLinkedService has a new parameter workspace_resource_id
      info	[Changelog]   - Model SynapseSparkJobDefinitionActivity has a new parameter files_v2
      info	[Changelog]   - Model SynapseSparkJobDefinitionActivity has a new parameter python_code_reference
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c71a66d. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      warn		specification/synapse/data-plane/readme.md skipped due to azure-sdk-for-go not found in swagger-to-sdk
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/datafactory/armdatafactory [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `AzureSQLSource.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`
      info	[Changelog] - Type of `SQLServerSource.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`
      info	[Changelog] - Type of `AzureSQLSink.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`
      info	[Changelog] - Type of `AmazonRdsForSQLServerSource.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`
      info	[Changelog] - Type of `SQLServerSink.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`
      info	[Changelog] - Type of `SQLSink.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`
      info	[Changelog] - Type of `SynapseSparkJobReference.ReferenceName` has been changed from `*string` to `interface{}`
      info	[Changelog] - Type of `SQLSource.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`
      info	[Changelog] - Type of `SQLMISink.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`
      info	[Changelog] - Type of `SQLMISource.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`
      info	[Changelog] - Struct `CloudError` has been removed
      info	[Changelog] - Struct `CloudErrorBody` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New field `FilesV2` in struct `SynapseSparkJobActivityTypeProperties`
      info	[Changelog] - New field `PythonCodeReference` in struct `SynapseSparkJobActivityTypeProperties`
      info	[Changelog] - New field `WorkspaceResourceID` in struct `AzureSynapseArtifactsLinkedServiceTypeProperties`
      info	[Changelog]
      info	[Changelog] Total 14 breaking change(s), 2 additive change(s).
    ️❌ azure-sdk-for-js failed [Detail]
    • Failed [Logs]Release - Generate from c71a66d. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-datafactory [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Interface AzureSynapseArtifactsLinkedService has a new optional parameter workspaceResourceId
      info	[Changelog]   - Interface SynapseSparkJobDefinitionActivity has a new optional parameter filesV2
      info	[Changelog]   - Interface SynapseSparkJobDefinitionActivity has a new optional parameter pythonCodeReference
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from c71a66d. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️datafactory [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from c71a66d. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      warn		specification/synapse/data-plane/readme.md skipped due to azure-powershell not found in swagger-to-sdk
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.datafactory [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 27, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/datafactory/armdatafactory https://apiview.dev/Assemblies/Review/6b00dc1dcf26466d8468bad15758b843
    Java azure-resourcemanager-datafactory https://apiview.dev/Assemblies/Review/3f9e93cd4e0c428fb96d36f7dffdc3b1
    JavaScript @azure/arm-datafactory https://apiview.dev/Assemblies/Review/e0903766230346898f4ddde95058b612
    Python track2_azure-mgmt-datafactory Create ApiView timeout. Package is too large and we cannot create ApiView for it.

    @openapi-workflow-bot openapi-workflow-bot bot added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 27, 2022
    @openapi-workflow-bot
    Copy link

    Hi, @wonner Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NewApiVersionRequired labels Oct 11, 2022
    @openapi-workflow-bot
    Copy link

    Hi @wonner, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Oct 11, 2022
    @lmazuel lmazuel merged commit c71a66d into Azure:main Oct 12, 2022
    anandanthony pushed a commit to anandMicro/azure-rest-api-specs that referenced this pull request Dec 16, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go Data Factory data-plane DoNotMerge <valid label in PR review process> use to hold merge after approval NewApiVersionRequired ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager ShiftLeftViolation Synapses
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants