-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
currentworkloadProfileStates - GET #20550
currentworkloadProfileStates - GET #20550
Conversation
Hi, @tdaroly Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger pipeline can not start as the pull request has merge conflicts. |
1 similar comment
Swagger pipeline can not start as the pull request has merge conflicts. |
Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
Make sure all the checks run successfully |
...ation/app/resource-manager/Microsoft.App/preview/2022-06-01-preview/ManagedEnvironments.json
Outdated
Show resolved
Hide resolved
...ation/app/resource-manager/Microsoft.App/preview/2022-06-01-preview/ManagedEnvironments.json
Outdated
Show resolved
Hide resolved
Swagger Validation Report
|
compared swaggers (via Oad v0.10.0)] | new version | base version |
---|---|---|
ManagedEnvironments.json | 2022-06-01-preview(a79a45b) | 2022-06-01-preview(main) |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 3 Warnings warning [Detail]
compared tags (via openapi-validator v1.13.0) | new version | base version |
---|---|---|
package-preview-2022-06 | package-preview-2022-06(a79a45b) | package-preview-2022-06(main) |
[must fix]The following errors/warnings are introduced by current PR:
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2022-06-01-preview/ManagedEnvironments.json#L1084 |
||
The resource 'workloadProfileStates' does not have get operation, please add it. Location: Microsoft.App/preview/2022-06-01-preview/ManagedEnvironments.json#L1075 |
||
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List environments by subscription Location: Microsoft.App/preview/2022-06-01-preview/ManagedEnvironments.json#L737 |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: internal Location: Microsoft.App/preview/2022-06-01-preview/ManagedEnvironments.json#L789 |
|
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get environments by name Location: Microsoft.App/preview/2022-06-01-preview/ManagedEnvironments.json#L141 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️❌
~[Staging] ServiceAPIReadinessTest: 162 Errors, 0 Warnings failed [Detail]
Tag package-preview-2022-06; Prod region: Deployed
Test run on region: northcentralus; Operation coverage: total: 79, untested: 3, failed: 63, passed: 13
Service API Readiness Test failed. Check pipeline artifact for detail report.
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/connectedEnvironments/connectedeo7gg8e' under resource group 'apiTest-cmOxGq-20550' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/managedEnvironments/environmen8xaw22' under resource group 'apiTest-cmOxGq-20550' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: undefined, errorMessage: undefined" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
OBJECT_ADDITIONAL_PROPERTIES |
"Additional properties not allowed: code" |
OBJECT_ADDITIONAL_PROPERTIES |
"Additional properties not allowed: message" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/containerApps/containeraft3d26' under resource group 'apiTest-cmOxGq-20550' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/containerApps/containeraft3d26' under resource group 'apiTest-cmOxGq-20550' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/containerApps/containeraft3d26' under resource group 'apiTest-cmOxGq-20550' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/containerApps/containeraft3d26' under resource group 'apiTest-cmOxGq-20550' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/containerApps/containeraft3d26' under resource group 'apiTest-cmOxGq-20550' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 409, errorCode: undefined, errorMessage: undefined" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 409" |
INVALID_FORMAT |
"Object didn't pass validation for format byte: PFX-or-PEM-blob" |
INVALID_FORMAT |
"Object didn't pass validation for format byte: private key password" |
OBJECT_ADDITIONAL_PROPERTIES |
"Additional properties not allowed: code" |
OBJECT_ADDITIONAL_PROPERTIES |
"Additional properties not allowed: message" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/managedEnvironments/environmen8xaw22' under resource group 'apiTest-cmOxGq-20550' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/managedEnvironments/environmen8xaw22' under resource group 'apiTest-cmOxGq-20550' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/managedEnvironments/environmen8xaw22' under resource group 'apiTest-cmOxGq-20550' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
️❌
~[Staging] TrafficValidation: 0 Errors, 0 Warnings failed [Detail]
️❌
ModelValidation: 2 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
RESPONSE_STATUS_CODE_NOT_IN_SPEC |
Response statusCode 404 for operation ManagedEnvironments_GetAuthToken is provided in exampleResponseValue, however it is not present in the swagger spec. Url: Microsoft.App/preview/2022-06-01-preview/ManagedEnvironments.json#L673:22 ExampleUrl: preview/2022-06-01-preview/examples/ManagedEnvironments_GetAuthToken.json#L8:16 |
RESPONSE_STATUS_CODE_NOT_IN_SPEC |
Response statusCode 404 for operation ManagedEnvironments_GetAuthToken is provided in exampleResponseValue, however it is not present in the swagger spec. Url: Microsoft.App/preview/2022-06-01-preview/ManagedEnvironments.json#L673:22 ExampleUrl: preview/2022-06-01-preview/examples/ManagedEnvironments_GetAuthToken.json#L8:16 |
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️
SDK Track2 Validation: 0 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/a79a45b4cae6ba848f5df61ee2547bcf1111a259/specification/app/resource-manager/readme.md#tag-package-preview-2022-06">app/resource-manager/readme.md#package-preview-2022-06
Rule | Message |
---|---|
"readme":"app/resource-manager/readme.md", "tag":"package-preview-2022-06", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
Hi @tdaroly, Your PR has some issues. Please fix the CI sequentially by following the order of
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@tdaroly - This PR doesn't currently show as needing ARM review, but it's probably because the submission form wasn't filled out. Please do so: you PR cannot be routed and reviewed correctly without that information. If your PR does need ARM review, be sure to study the materials linked in the form and attest to that fact by checking the box. This is required for ARM review. |
Hi, @tdaroly your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
Yes, I reviewed and signed off that PR. @tdaroly, can you bring those changes to this PR after they merge? |
NewApiVersionRequired reason: |
Please use the instructions in this comment to facilitate ARM review: #20550 (comment). |
@tdaroly - This comment is still unaddressed: #20550 (comment). IIUC, the intent was to apply that feedback in a separate PR, get signoff and merge there and then merge those changes to this PR. If that other PR is ready for review, please provide a link here. |
Hi @tdaroly, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
@tdaroly - Approving from ARM. Please in future stop using force push for swagger PRs. Swagger review is already difficult. Wiping out the commit history makes the review job nearly impossible. |
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.