Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users/prjayasw/agrifoodrp #20363

Merged
merged 30 commits into from
Nov 14, 2022
Merged

Users/prjayasw/agrifoodrp #20363

merged 30 commits into from
Nov 14, 2022

Conversation

JatinKhatri03
Copy link
Contributor

@JatinKhatri03 JatinKhatri03 commented Aug 24, 2022

My changes are on top of already approved PR #20243
The commit that needs to be reviewed is cc504a0, fc9c850 and 4243437.

Description:

We are updating Extension apis as mentioned below -

Extension installation api will be Create or Update api now. This api will take ExtensionVersion and ApiProperties as inputand it will enable users to update some new configs that we have introduced, through the same api. If no ExtensionVersion is provided, then we are only going to update the config.

Extension Update api will be removed in the next api-version.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @JatinKhatri03 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    Swagger pipeline can not start as the pull request has merge conflicts.

    @openapi-pipeline-app
    Copy link

    Swagger pipeline can not start as the pull request has merge conflicts.

    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

    @honghr
    Copy link
    Contributor

    honghr commented Oct 28, 2022

    Hi @JatinKhatri03 , Do you need this PR? Please resolve swagger breaking change If you need. You also can close this pr if you don't need.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 9, 2022
    @ArcturusZhang ArcturusZhang added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Nov 14, 2022
    @openapi-workflow-bot
    Copy link

    Hi @JatinKhatri03, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval.

    anandanthony pushed a commit to anandMicro/azure-rest-api-specs that referenced this pull request Dec 16, 2022
    * Adds base for updating Microsoft.AgFoodPlatform from version preview/2020-05-12-preview to version 2021-09-01-preview
    
    * Adds base for updating Microsoft.AgFoodPlatform from version preview/2020-05-12-preview to version 2021-09-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Private endpoint changes
    
    * updated examples
    
    * updated db update example
    
    * build fixes
    
    * changed common-types version
    
    * pr comments
    
    * minor update
    
    * Removed 202 response code from Put call
    
    * update examples
    
    * prettier fix
    
    * enum example fix
    
    * Incremental change of sensor feature
    
    * Adding support for operationResults api for farmbeats resource.
    
    * Making cosmetic changes to fix checks
    
    * Update readme.python.md
    
    pin the title for python SDK
    
    * Fixing one change
    
    * Rsolving comments
    
    * Updating Extension Create api and removing extension update api
    
    * Removing ApiProperties from required list and adding Extension_CreateOrUpdate.json
    
    * Adding examples/Extensions_Delete.json and removing examples/Extensions_Update.json. Also, adding few small changes to Extension apis
    
    * Fixing a small typo
    
    * Fixing failing checks
    
    * Fixing example for extension create or update
    
    * Fixing prettier error
    
    Co-authored-by: Prabhav Gupta <[email protected]>
    Co-authored-by: Prabhav Gupta <[email protected]>
    Co-authored-by: Priyanka Jayaswal <[email protected]>
    Co-authored-by: Yuchao Yan <[email protected]>
    kayousef-zz pushed a commit to kayousef-zz/azure-rest-api-specs that referenced this pull request Dec 21, 2022
    * Adds base for updating Microsoft.AgFoodPlatform from version preview/2020-05-12-preview to version 2021-09-01-preview
    
    * Adds base for updating Microsoft.AgFoodPlatform from version preview/2020-05-12-preview to version 2021-09-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Private endpoint changes
    
    * updated examples
    
    * updated db update example
    
    * build fixes
    
    * changed common-types version
    
    * pr comments
    
    * minor update
    
    * Removed 202 response code from Put call
    
    * update examples
    
    * prettier fix
    
    * enum example fix
    
    * Incremental change of sensor feature
    
    * Adding support for operationResults api for farmbeats resource.
    
    * Making cosmetic changes to fix checks
    
    * Update readme.python.md
    
    pin the title for python SDK
    
    * Fixing one change
    
    * Rsolving comments
    
    * Updating Extension Create api and removing extension update api
    
    * Removing ApiProperties from required list and adding Extension_CreateOrUpdate.json
    
    * Adding examples/Extensions_Delete.json and removing examples/Extensions_Update.json. Also, adding few small changes to Extension apis
    
    * Fixing a small typo
    
    * Fixing failing checks
    
    * Fixing example for extension create or update
    
    * Fixing prettier error
    
    Co-authored-by: Prabhav Gupta <[email protected]>
    Co-authored-by: Prabhav Gupta <[email protected]>
    Co-authored-by: Priyanka Jayaswal <[email protected]>
    Co-authored-by: Yuchao Yan <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript CI-FixRequiredOnFailure NewApiVersionRequired resource-manager SuppressionReviewRequired
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.