-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Users/prjayasw/agrifoodrp #20363
Users/prjayasw/agrifoodrp #20363
Conversation
…2020-05-12-preview to version 2021-09-01-preview
…2020-05-12-preview to version 2021-09-01-preview
pin the title for python SDK
…kajayaswal1/azure-rest-api-specs into users/prjayasw/agrifoodrp
Hi, @JatinKhatri03 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger pipeline can not start as the pull request has merge conflicts. |
Swagger pipeline can not start as the pull request has merge conflicts. |
Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
Hi @JatinKhatri03 , Do you need this PR? Please resolve swagger breaking change If you need. You also can close this pr if you don't need. |
Hi @JatinKhatri03, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval. |
* Adds base for updating Microsoft.AgFoodPlatform from version preview/2020-05-12-preview to version 2021-09-01-preview * Adds base for updating Microsoft.AgFoodPlatform from version preview/2020-05-12-preview to version 2021-09-01-preview * Updates readme * Updates API version in new specs and examples * Private endpoint changes * updated examples * updated db update example * build fixes * changed common-types version * pr comments * minor update * Removed 202 response code from Put call * update examples * prettier fix * enum example fix * Incremental change of sensor feature * Adding support for operationResults api for farmbeats resource. * Making cosmetic changes to fix checks * Update readme.python.md pin the title for python SDK * Fixing one change * Rsolving comments * Updating Extension Create api and removing extension update api * Removing ApiProperties from required list and adding Extension_CreateOrUpdate.json * Adding examples/Extensions_Delete.json and removing examples/Extensions_Update.json. Also, adding few small changes to Extension apis * Fixing a small typo * Fixing failing checks * Fixing example for extension create or update * Fixing prettier error Co-authored-by: Prabhav Gupta <[email protected]> Co-authored-by: Prabhav Gupta <[email protected]> Co-authored-by: Priyanka Jayaswal <[email protected]> Co-authored-by: Yuchao Yan <[email protected]>
* Adds base for updating Microsoft.AgFoodPlatform from version preview/2020-05-12-preview to version 2021-09-01-preview * Adds base for updating Microsoft.AgFoodPlatform from version preview/2020-05-12-preview to version 2021-09-01-preview * Updates readme * Updates API version in new specs and examples * Private endpoint changes * updated examples * updated db update example * build fixes * changed common-types version * pr comments * minor update * Removed 202 response code from Put call * update examples * prettier fix * enum example fix * Incremental change of sensor feature * Adding support for operationResults api for farmbeats resource. * Making cosmetic changes to fix checks * Update readme.python.md pin the title for python SDK * Fixing one change * Rsolving comments * Updating Extension Create api and removing extension update api * Removing ApiProperties from required list and adding Extension_CreateOrUpdate.json * Adding examples/Extensions_Delete.json and removing examples/Extensions_Update.json. Also, adding few small changes to Extension apis * Fixing a small typo * Fixing failing checks * Fixing example for extension create or update * Fixing prettier error Co-authored-by: Prabhav Gupta <[email protected]> Co-authored-by: Prabhav Gupta <[email protected]> Co-authored-by: Priyanka Jayaswal <[email protected]> Co-authored-by: Yuchao Yan <[email protected]>
My changes are on top of already approved PR #20243
The commit that needs to be reviewed is cc504a0, fc9c850 and 4243437.
Description:
We are updating Extension apis as mentioned below -
Extension installation api will be Create or Update api now. This api will take ExtensionVersion and ApiProperties as inputand it will enable users to update some new configs that we have introduced, through the same api. If no ExtensionVersion is provided, then we are only going to update the config.
Extension Update api will be removed in the next api-version.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.