-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add News Search API Swagger Spec #2026
Conversation
* Add News Search API Swagger Spec * Add NewsArticle into Spec * Add miss comma before x-ms-examples
@fearthecowboy FYI, data plane |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look at the job failures:
linter: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/303479989
model: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/303479990
``` yaml $(tag) == 'release_1_0' | ||
input-file: v1.0/NewsSearch.json | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a section in the readme.md
that looks like this:
## Suppressions
Suppressing errors due to API design:
``` yaml
directive:
- suppress: R3016
reason: _type is a polymorphic discriminator that can't be changed.
```
…#2) Suppress _type error, fix 'OBJECT_ADDITIONAL_PROPERTIES' error, add required parameters
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
Update description and Remove some internal properties
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
"allOf": [ | ||
{ | ||
"$ref": "#/definitions/SearchResultsAnswer" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be readonly?
"allOf": [ | ||
{ | ||
"$ref": "#/definitions/SearchResultsAnswer" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add descriptions to the individual properties.
"allOf": [ | ||
{ | ||
"$ref": "#/definitions/SearchResultsAnswer" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing description.
"allOf": [ | ||
{ | ||
"$ref": "#/definitions/SearchResultsAnswer" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add readonly.
No modification for AutorestCI/azure-sdk-for-ruby |
No modification for AutorestCI/azure-sdk-for-python |
Add News Search API Swagger Spec
Add NewsArticle into Spec
Add miss comma before x-ms-examples
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger