Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitor] Update readme.md #20064

Merged
merged 2 commits into from
Aug 2, 2022
Merged

[Monitor] Update readme.md #20064

merged 2 commits into from
Aug 2, 2022

Conversation

BigCat20196
Copy link
Contributor

@BigCat20196 BigCat20196 commented Aug 2, 2022

@openapi-workflow-bot
Copy link

Hi, @BigCat20196 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 2, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⌛CredScan pending [Detail]
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2018-09-01-python-only package-2018-09-01-python-only(8be5e3c) default(main)
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/monitor/resource-manager/readme.md
    tag: specification/monitor/resource-manager/readme.md#tag-package-composite-v1
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️⌛PoliCheck pending [Detail]
    ️⚠️SDK Track2 Validation: 1 Warnings warning [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/8be5e3c65e03b673dca5f44299c7599fa795a4a7/specification/monitor/resource-manager/readme.md#tag-package-2018-09-01-python-only">monitor/resource-manager/readme.md#package-2018-09-01-python-only
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ UnkownSecurityScheme "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2018-09-01-python-only",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 2, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - armmonitor - 0.8.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-monitor - 4.0.0
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 0a4e1e9. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.Monitor [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 0a4e1e9. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  global `--global`, `--local` are deprecated. Use `--location=global` instead.
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.11.0 -> 8.15.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.15.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-monitor [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 0a4e1e9. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armmonitor [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `*DataCollectionRuleAssociationsClient.Create` parameter(s) have been changed from `(context.Context, string, string, *DataCollectionRuleAssociationsClientCreateOptions)` to `(context.Context, string, string, DataCollectionRuleAssociationProxyOnlyResource, *DataCollectionRuleAssociationsClientCreateOptions)`
      info	[Changelog] - Function `*DataCollectionEndpointsClient.Update` parameter(s) have been changed from `(context.Context, string, string, *DataCollectionEndpointsClientUpdateOptions)` to `(context.Context, string, string, ResourceForUpdate, *DataCollectionEndpointsClientUpdateOptions)`
      info	[Changelog] - Function `*DataCollectionRulesClient.Create` parameter(s) have been changed from `(context.Context, string, string, *DataCollectionRulesClientCreateOptions)` to `(context.Context, string, string, DataCollectionRuleResource, *DataCollectionRulesClientCreateOptions)`
      info	[Changelog] - Function `*DataCollectionRulesClient.Update` parameter(s) have been changed from `(context.Context, string, string, *DataCollectionRulesClientUpdateOptions)` to `(context.Context, string, string, ResourceForUpdate, *DataCollectionRulesClientUpdateOptions)`
      info	[Changelog] - Function `*DataCollectionEndpointsClient.Create` parameter(s) have been changed from `(context.Context, string, string, *DataCollectionEndpointsClientCreateOptions)` to `(context.Context, string, string, DataCollectionEndpointResource, *DataCollectionEndpointsClientCreateOptions)`
      info	[Changelog] - Type of `PrivateEndpointConnectionProperties.PrivateLinkServiceConnectionState` has been changed from `*PrivateLinkServiceConnectionStateProperty` to `*PrivateLinkServiceConnectionState`
      info	[Changelog] - Type of `PrivateEndpointConnectionProperties.PrivateEndpoint` has been changed from `*PrivateEndpointProperty` to `*PrivateEndpoint`
      info	[Changelog] - Type of `PrivateEndpointConnectionProperties.ProvisioningState` has been changed from `*string` to `*PrivateEndpointConnectionProvisioningState`
      info	[Changelog] - Type of `OperationStatus.Error` has been changed from `*ErrorResponseCommon` to `*ErrorDetail`
      info	[Changelog] - Function `*PrivateLinkResourcesClient.NewListByPrivateLinkScopePager` has been removed
      info	[Changelog] - Function `*DiagnosticSettingsCategoryClient.List` has been removed
      info	[Changelog] - Function `*PrivateEndpointConnectionsClient.NewListByPrivateLinkScopePager` has been removed
      info	[Changelog] - Function `*DiagnosticSettingsClient.List` has been removed
      info	[Changelog] - Struct `ErrorResponseCommon` has been removed
      info	[Changelog] - Struct `PrivateEndpointProperty` has been removed
      info	[Changelog] - Struct `PrivateLinkScopesResource` has been removed
      info	[Changelog] - Struct `PrivateLinkServiceConnectionStateProperty` has been removed
      info	[Changelog] - Struct `ProxyOnlyResource` has been removed
      info	[Changelog] - Field `NextLink` of struct `PrivateEndpointConnectionListResult` has been removed
      info	[Changelog] - Field `Body` of struct `DataCollectionEndpointsClientCreateOptions` has been removed
      info	[Changelog] - Field `Identity` of struct `ActionGroupResource` has been removed
      info	[Changelog] - Field `Kind` of struct `ActionGroupResource` has been removed
      info	[Changelog] - Field `Body` of struct `DataCollectionRulesClientCreateOptions` has been removed
      info	[Changelog] - Field `Body` of struct `DataCollectionEndpointsClientUpdateOptions` has been removed
      info	[Changelog] - Field `Identity` of struct `AzureResource` has been removed
      info	[Changelog] - Field `Kind` of struct `AzureResource` has been removed
      info	[Changelog] - Field `Body` of struct `DataCollectionRulesClientUpdateOptions` has been removed
      info	[Changelog] - Field `Body` of struct `DataCollectionRuleAssociationsClientCreateOptions` has been removed
      info	[Changelog] - Field `NextLink` of struct `PrivateLinkResourceListResult` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `AccessModePrivateOnly`
      info	[Changelog] - New const `PrivateEndpointConnectionProvisioningStateSucceeded`
      info	[Changelog] - New const `AccessModeOpen`
      info	[Changelog] - New const `PrivateEndpointConnectionProvisioningStateDeleting`
      info	[Changelog] - New const `PredictiveAutoscalePolicyScaleModeDisabled`
      info	[Changelog] - New const `PrivateEndpointConnectionProvisioningStateFailed`
      info	[Changelog] - New const `PrivateEndpointServiceConnectionStatusPending`
      info	[Changelog] - New const `PrivateEndpointConnectionProvisioningStateCreating`
      info	[Changelog] - New const `PredictiveAutoscalePolicyScaleModeForecastOnly`
      info	[Changelog] - New const `PrivateEndpointServiceConnectionStatusApproved`
      info	[Changelog] - New const `PredictiveAutoscalePolicyScaleModeEnabled`
      info	[Changelog] - New const `PrivateEndpointServiceConnectionStatusRejected`
      info	[Changelog] - New function `*DiagnosticSettingsCategoryClient.NewListPager(string, *DiagnosticSettingsCategoryClientListOptions) *runtime.Pager[DiagnosticSettingsCategoryClientListResponse]`
      info	[Changelog] - New function `PossibleAccessModeValues() []AccessMode`
      info	[Changelog] - New function `PossiblePrivateEndpointConnectionProvisioningStateValues() []PrivateEndpointConnectionProvisioningState`
      info	[Changelog] - New function `NewPredictiveMetricClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PredictiveMetricClient, error)`
      info	[Changelog] - New function `*PrivateLinkResourcesClient.ListByPrivateLinkScope(context.Context, string, string, *PrivateLinkResourcesClientListByPrivateLinkScopeOptions) (PrivateLinkResourcesClientListByPrivateLinkScopeResponse, error)`
      info	[Changelog] - New function `PossiblePrivateEndpointServiceConnectionStatusValues() []PrivateEndpointServiceConnectionStatus`
      info	[Changelog] - New function `*PredictiveMetricClient.Get(context.Context, string, string, string, string, string, string, string, *PredictiveMetricClientGetOptions) (PredictiveMetricClientGetResponse, error)`
      info	[Changelog] - New function `*DiagnosticSettingsClient.NewListPager(string, *DiagnosticSettingsClientListOptions) *runtime.Pager[DiagnosticSettingsClientListResponse]`
      info	[Changelog] - New function `PossiblePredictiveAutoscalePolicyScaleModeValues() []PredictiveAutoscalePolicyScaleMode`
      info	[Changelog] - New function `*PrivateEndpointConnectionsClient.ListByPrivateLinkScope(context.Context, string, string, *PrivateEndpointConnectionsClientListByPrivateLinkScopeOptions) (PrivateEndpointConnectionsClientListByPrivateLinkScopeResponse, error)`
      info	[Changelog] - New struct `AccessModeSettings`
      info	[Changelog] - New struct `AccessModeSettingsExclusion`
      info	[Changelog] - New struct `AutoscaleErrorResponse`
      info	[Changelog] - New struct `AutoscaleErrorResponseError`
      info	[Changelog] - New struct `DefaultErrorResponse`
      info	[Changelog] - New struct `PredictiveAutoscalePolicy`
      info	[Changelog] - New struct `PredictiveMetricClient`
      info	[Changelog] - New struct `PredictiveMetricClientGetOptions`
      info	[Changelog] - New struct `PredictiveMetricClientGetResponse`
      info	[Changelog] - New struct `PredictiveResponse`
      info	[Changelog] - New struct `PredictiveValue`
      info	[Changelog] - New struct `PrivateEndpoint`
      info	[Changelog] - New struct `PrivateLinkServiceConnectionState`
      info	[Changelog] - New struct `ProxyResourceAutoGenerated`
      info	[Changelog] - New struct `ResourceAutoGenerated`
      info	[Changelog] - New struct `ResourceAutoGenerated2`
      info	[Changelog] - New struct `ResourceAutoGenerated3`
      info	[Changelog] - New struct `ResourceAutoGenerated4`
      info	[Changelog] - New struct `TrackedResource`
      info	[Changelog] - New anonymous field `TestNotificationDetailsResponse` in struct `ActionGroupsClientCreateNotificationsAtResourceGroupLevelResponse`
      info	[Changelog] - New field `MarketplacePartnerID` in struct `DiagnosticSettings`
      info	[Changelog] - New field `SystemData` in struct `DiagnosticSettingsCategoryResource`
      info	[Changelog] - New anonymous field `TestNotificationDetailsResponse` in struct `ActionGroupsClientPostTestNotificationsResponse`
      info	[Changelog] - New field `CategoryGroup` in struct `LogSettings`
      info	[Changelog] - New field `PredictiveAutoscalePolicy` in struct `AutoscaleSetting`
      info	[Changelog] - New field `SystemData` in struct `DiagnosticSettingsResource`
      info	[Changelog] - New anonymous field `TestNotificationDetailsResponse` in struct `ActionGroupsClientCreateNotificationsAtActionGroupResourceLevelResponse`
      info	[Changelog] - New field `SystemData` in struct `ScopedResource`
      info	[Changelog] - New field `SystemData` in struct `Resource`
      info	[Changelog] - New field `SystemData` in struct `AzureMonitorPrivateLinkScope`
      info	[Changelog] - New field `AccessModeSettings` in struct `AzureMonitorPrivateLinkScopeProperties`
      info	[Changelog] - New field `RequiredZoneNames` in struct `PrivateLinkResourceProperties`
      info	[Changelog] - New field `SystemData` in struct `AutoscaleSettingResource`
      info	[Changelog] - New field `CategoryGroups` in struct `DiagnosticSettingsCategory`
      info	[Changelog]
      info	[Changelog] Total 30 breaking change(s), 75 additive change(s).
    ️❌ azure-sdk-for-js failed [Detail]
    • Failed [Logs]Release - Generate from 0a4e1e9. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
      cmderr	[automation_generate.sh] ERROR: The command failed with exit code 1
      cmderr	[automation_generate.sh] [ERROR] Error:
      cmderr	[automation_generate.sh] [ERROR] An error occurred while run build for readme file: "specification/monitor/resource-manager/readme.md":
      cmderr	[automation_generate.sh] [ERROR] Err: Error: Command failed: rush update
      cmderr	[automation_generate.sh] [ERROR] Stderr: "null"
      cmderr	[automation_generate.sh] [ERROR] Stdout: "null"
      cmderr	[automation_generate.sh] [ERROR] ErrorStack: "Error: Command failed: rush update
      cmderr	[automation_generate.sh] [ERROR]     at checkExecSyncError (child_process.js:790:11)
      cmderr	[automation_generate.sh] [ERROR]     at Object.execSync (child_process.js:863:15)
      cmderr	[automation_generate.sh] [ERROR]     at Object.<anonymous> (/opt/hostedtoolcache/node/14.20.0/x64/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/hlc/generateMgmt.js:74:33)
      cmderr	[automation_generate.sh] [ERROR]     at Generator.next (<anonymous>)
      cmderr	[automation_generate.sh] [ERROR]     at fulfilled (/opt/hostedtoolcache/node/14.20.0/x64/lib/node_modules/@azure-tools/js-sdk-release-tools/node_modules/tslib/tslib.js:112:62)"
      the given reference name 'refs/heads/sdkAuto/' is not valid
      Error: the given reference name 'refs/heads/sdkAuto/' is not valid
    • error	Fatal error: the given reference name 'refs/heads/sdkAuto/' is not valid
      error	The following packages are still pending:
      error
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 0a4e1e9. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️monitor [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 0a4e1e9. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.monitor [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 2, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Python track2_azure-mgmt-monitor Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and re-trigger the CI. If issue still exists, please ask PR assignee for help
    Java azure-resourcemanager-monitor-generated Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and re-trigger the CI. If issue still exists, please ask PR assignee for help
    .Net Azure.ResourceManager.Monitor Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and re-trigger the CI. If issue still exists, please ask PR assignee for help

    @ghost ghost added the Monitor Monitor, Monitor Ingestion, Monitor Query label Aug 2, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    CI-BreakingChange-Go Monitor Monitor, Monitor Ingestion, Monitor Query resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants