Add idleShutdownSetting to Compute Instances #19748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @teochaban Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.6)] | new version | base version |
|---|---|---|
| machineLearningServices.json | 2022-06-01(224c53e) | 2022-05-01(main) |
| machineLearningServices.json | 2022-06-01(224c53e) | 2022-02-01(main) |
The following breaking changes are detected by comparison with the latest preview version:
️⚠️LintDiff: 1 Warnings warning [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-preview-2022-06 | package-preview-2022-06(224c53e) | package-preview-2022-06(dev-machinelearningservices-Microsoft.MachineLearningServices-2022-06-01-preview) |
The following errors/warnings are introduced by current PR:
| Rule | Message |
|---|---|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L1278 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Collection object 'AmlComputeNodesInformation' returned by list operation 'Compute_ListNodes' with 'x-ms-pageable' extension, has no property named 'value'. Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L1031 |
| Since operation 'QuotasUpdate' response has model definition 'array', it should be of the form 'list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L567 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L3193 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L3294 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L3389 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L3602 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L3780 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L3801 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L3869 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L3912 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L3932 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L3947 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L4217 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L5521 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L5701 |
|
| Based on the response model schema, operation 'VirtualMachineSizes_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L519 |
|
| Based on the response model schema, operation 'PrivateLinkResources_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L1510 |
|
| Based on the response model schema, operation 'Workspaces_ListOutboundNetworkDependenciesEndpoints' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L1872 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L713 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L759 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L812 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L893 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L947 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L1009 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L1101 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L1147 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L1191 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L1235 |
|
| OperationId should contain the verb: 'updatequotas' in:'Quotas_Update'. Consider updating the operationId Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L567 |
|
| The child tracked resource, 'computes' with immediate parent 'Workspace', must have a list by immediate parent operation. Location: Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json#L3155 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/224c53e9da685165c6946f3f575175829c21b617/specification/machinelearningservices/resource-manager/readme.md#tag-package-preview-2022-06">machinelearningservices/resource-manager/readme.md#package-preview-2022-06
| Rule | Message |
|---|---|
| "readme":"machinelearningservices/resource-manager/readme.md", "tag":"package-preview-2022-06", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
This was referenced Jul 12, 2022
SubaMoorthy
reviewed
Jul 12, 2022
...er/Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json
Outdated
Show resolved
Hide resolved
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @teochaban your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
SubaMoorthy
approved these changes
Jul 13, 2022
chrjia
approved these changes
Jul 13, 2022
|
@teochaban - Please study the guidelines described in the submission form and attest to that by checking the box: [ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board. |
mentat9
added
the
ARMChangesRequested
|
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
mentat9
reviewed
Jul 14, 2022
...er/Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json
Show resolved
Hide resolved
mentat9
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
mentat9
added
ARMChangesRequested
mentat9
reviewed
Jul 14, 2022
...er/Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json
Show resolved
Hide resolved
|
Hi @teochaban, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
teochaban
commented
Jul 14, 2022
...er/Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json
Show resolved
Hide resolved
openapi-pipeline-app
bot
added
CI-BreakingChange-JavaScript
and removed
CI-BreakingChange-JavaScript
labels
mentat9
reviewed
Jul 15, 2022
...er/Microsoft.MachineLearningServices/preview/2022-06-01-preview/machineLearningServices.json
Show resolved
Hide resolved
teochaban
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
mentat9
added
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
teochaban
added
WaitForARMFeedback
mentat9
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
shouryaj
approved these changes
Jul 15, 2022
sogansky
approved these changes
Jul 16, 2022
teochaban
merged commit b11e89f
into
Azure:dev-machinelearningservices-Microsoft.MachineLearningServices-2022-06-01-preview
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.