Add description to Key Vault certs 7.3 key_usage #19642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlowell
requested review from
scgbear and
MushMal
and removed request for
a team
|
Hi, @chlowell Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.6)] | new version | base version |
|---|---|---|
| certificates.json | 7.3(0acfc5b) | 7.3(main) |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-7.3 | package-7.3(0acfc5b) | package-7.3(main) |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| The operation 'CreateCertificate' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.KeyVault/stable/7.3/certificates.json#L458 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]
- The following tags are being changed in this PR
|:speech_balloon: |"readme":"keyvault/data-plane/readme.md",
"tag":"package-7.3",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0 -> 1.11.0)"|
|:speech_balloon: |"readme":"keyvault/data-plane/readme.md",
"tag":"package-7.3",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0->1.11.0)"|
|:speech_balloon: |"readme":"keyvault/data-plane/readme.md",
"tag":"package-7.3",
"details":"> Installing AutoRest extension '@autorest/modelerfour' (4.21.4 -> 4.21.4)"|
|:speech_balloon: |"readme":"keyvault/data-plane/readme.md",
"tag":"package-7.3",
"details":"> Installed AutoRest extension '@autorest/modelerfour' (4.21.4->4.21.4)"|
|:speech_balloon: |"readme":"keyvault/data-plane/readme.md",
"tag":"package-7.3",
"details":"Autorest completed in 14.13s. 0 files generated."|
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.0.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.1.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.2.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.3.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.4.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.5.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.6.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.7.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.8.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.9.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.10.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.11.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.12.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.13.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.14.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.15.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.16.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.17.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.18.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.19.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.20.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.21.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.22.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.23.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.24.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.25.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.26.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.27.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.28.suppress which is deprecated and will be removed in the future." |
|
| "readme":"keyvault/data-plane/readme.md", "tag":"package-7.3", "details":"Using directive.29.suppress which is deprecated and will be removed in the future." |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
heaths
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No API change, just adding a line of documentation.