ARM ID Annotations for Redis #19596

matthchr · 2022-06-24T21:51:21Z

Uses the new arm-id format to describe fields which are references to other ARM resources.

This was split off from #18318

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-06-24T21:51:24Z

Hi, @matthchr Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2022-06-24T21:51:25Z

Swagger Validation Report

️❌BreakingChange: 8 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.9.6)]	new version	base version
redis.json	2020-12-01(bcfca39)	2020-12-01(main)
redis.json	2021-06-01(bcfca39)	2021-06-01(main)

Rule	Message
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Cache/stable/2020-12-01/redis.json#L1965:9 Old: Microsoft.Cache/stable/2020-12-01/redis.json#L1965:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Cache/stable/2020-12-01/redis.json#L1965:9 Old: Microsoft.Cache/stable/2020-12-01/redis.json#L1965:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Cache/stable/2020-12-01/redis.json#L2560:9 Old: Microsoft.Cache/stable/2020-12-01/redis.json#L2549:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Cache/stable/2020-12-01/redis.json#L2560:9 Old: Microsoft.Cache/stable/2020-12-01/redis.json#L2549:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Cache/stable/2021-06-01/redis.json#L2020:9 Old: Microsoft.Cache/stable/2021-06-01/redis.json#L2020:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Cache/stable/2021-06-01/redis.json#L2020:9 Old: Microsoft.Cache/stable/2021-06-01/redis.json#L2020:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Cache/stable/2021-06-01/redis.json#L2630:9 Old: Microsoft.Cache/stable/2021-06-01/redis.json#L2619:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Cache/stable/2021-06-01/redis.json#L2630:9 Old: Microsoft.Cache/stable/2021-06-01/redis.json#L2619:9

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v1.13.0)	new version	base version
package-2021-06	package-2021-06(bcfca39)	package-2021-06(main)
package-2020-12	package-2020-12(bcfca39)	package-2020-12(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R3021 - PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/CheckNameAvailability' Location: Microsoft.Cache/stable/2020-12-01/redis.json#L73
`❌` R3021 - PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/CheckNameAvailability' Location: Microsoft.Cache/stable/2021-06-01/redis.json#L73
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2347
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2417
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.Cache/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L37
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.Cache/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L37
`❌` R4037 - MissingTypeObject	The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1789
`❌` R4037 - MissingTypeObject	The schema 'RedisCommonProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1829
`❌` R4037 - MissingTypeObject	The schema 'RedisCreateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1959
`❌` R4037 - MissingTypeObject	The schema 'RedisUpdateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2002
`❌` R4037 - MissingTypeObject	The schema 'RedisProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2017
`❌` R4037 - MissingTypeObject	The schema 'RedisCreateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2097
`❌` R4037 - MissingTypeObject	The schema 'RedisUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2133
`❌` R4037 - MissingTypeObject	The schema 'RedisAccessKeys' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2150
`❌` R4037 - MissingTypeObject	The schema 'RedisFirewallRule' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2165
`❌` R4037 - MissingTypeObject	The schema 'RedisFirewallRuleProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2191
`❌` R4037 - MissingTypeObject	The schema 'RedisFirewallRuleListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2208
`❌` R4037 - MissingTypeObject	The schema 'RedisResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2225
`❌` R4037 - MissingTypeObject	The schema 'RedisInstanceDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2250
`❌` R4037 - MissingTypeObject	The schema 'RedisListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2288
`❌` R4037 - MissingTypeObject	The schema 'RedisRegenerateKeyParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2305
`❌` R4037 - MissingTypeObject	The schema 'RedisRebootParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2325
`❌` R4037 - MissingTypeObject	The schema 'ExportRDBParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2355
`❌` R4037 - MissingTypeObject	The schema 'ImportRDBParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2376
`❌` R4037 - MissingTypeObject	The schema 'ScheduleEntry' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2395
`❌` R4037 - MissingTypeObject	The schema 'ScheduleEntries' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2434
`❌` R4037 - MissingTypeObject	The schema 'RedisPatchSchedule' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2450
`❌` R4037 - MissingTypeObject	The schema 'RedisPatchScheduleListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2473
`❌` R4037 - MissingTypeObject	The schema 'RedisForceRebootResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2490
`❌` R4037 - MissingTypeObject	The schema 'RedisLinkedServer' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2500

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]

The following tags are being changed in this PR

"https://github.com/Azure/azure-rest-api-specs/blob/bcfca397d778ea96b4fb4bf52602d1c8d2b00c27/specification/redis/resource-manager/readme.md#tag-package-2021-06">redis/resource-manager/readme.md#package-2021-06
"https://github.com/Azure/azure-rest-api-specs/blob/bcfca397d778ea96b4fb4bf52602d1c8d2b00c27/specification/redis/resource-manager/readme.md#tag-package-2020-12">redis/resource-manager/readme.md#package-2020-12

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` PreCheck/DuplicateSchema	"readme":"redis/resource-manager/readme.md", "tag":"package-2021-06", "details":"Duplicate Schema named 'ErrorDetail' (1 differences):\n - properties.details.$ref: "#/components/schemas/schemas:247" => "#/components/schemas/schemas:453"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌`	"readme":"redis/resource-manager/readme.md", "tag":"package-2021-06", "details":"Error: 1 errors occured -- cannot continue."
⚠️ UnkownSecurityScheme	"readme":"redis/resource-manager/readme.md", "tag":"package-2020-12", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous"

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-06-24T21:51:25Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-go - armredis - 1.1.0
❌azure-sdk-for-python-track2 - track2_azure-mgmt-redis - 13.1.0

-	Removed operation LinkedServerOperations.delete
-	Removed operation RedisOperations.update

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from 9d4fb5a. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/redis/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 9d4fb5a. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]  config global `--global`, `--local` are deprecated. Use `--location=global` instead.

️✔️track2_azure-mgmt-redis [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation LinkedServerOperations.begin_delete
info	[Changelog]   - Added operation RedisOperations.begin_update
info	[Changelog]   - Added operation group AsyncOperationStatusOperations
info	[Changelog]   - Model ExportRDBParameters has a new parameter preferred_data_archive_auth_method
info	[Changelog]   - Model ImportRDBParameters has a new parameter preferred_data_archive_auth_method
info	[Changelog]   - Model RedisCommonPropertiesRedisConfiguration has a new parameter aof_backup_enabled
info	[Changelog]   - Model RedisCommonPropertiesRedisConfiguration has a new parameter authnotrequired
info	[Changelog]   - Model RedisCommonPropertiesRedisConfiguration has a new parameter zonal_configuration
info	[Changelog]   - Model RedisPatchSchedule has a new parameter location
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Removed operation LinkedServerOperations.delete
info	[Changelog]   - Removed operation RedisOperations.update

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 9d4fb5a. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-redis-generated [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 9d4fb5a. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armredis [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*Client.Update` has been removed
info	[Changelog] - Function `*LinkedServerClient.Delete` has been removed
info	[Changelog] - Struct `ClientUpdateOptions` has been removed
info	[Changelog] - Struct `LinkedServerClientDeleteOptions` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New function `*Client.BeginUpdate(context.Context, string, string, UpdateParameters, *ClientBeginUpdateOptions) (*runtime.Poller[ClientUpdateResponse], error)`
info	[Changelog] - New function `*LinkedServerClient.BeginDelete(context.Context, string, string, string, *LinkedServerClientBeginDeleteOptions) (*runtime.Poller[LinkedServerClientDeleteResponse], error)`
info	[Changelog] - New struct `ClientBeginUpdateOptions`
info	[Changelog] - New struct `LinkedServerClientBeginDeleteOptions`
info	[Changelog] - New field `Authnotrequired` in struct `CommonPropertiesRedisConfiguration`
info	[Changelog] - New field `AofBackupEnabled` in struct `CommonPropertiesRedisConfiguration`
info	[Changelog] - New field `PreferredDataArchiveAuthMethod` in struct `ImportRDBParameters`
info	[Changelog] - New field `PreferredDataArchiveAuthMethod` in struct `ExportRDBParameters`
info	[Changelog]
info	[Changelog] Total 6 breaking change(s), 9 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 9d4fb5a. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-rediscache [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-rediscache-7.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation LinkedServer.beginDelete
info	[Changelog]   - Added operation LinkedServer.beginDeleteAndWait
info	[Changelog]   - Added operation Redis.beginUpdate
info	[Changelog]   - Added operation Redis.beginUpdateAndWait
info	[Changelog]   - Added Interface OperationStatus
info	[Changelog]   - Added Interface PrivateEndpointConnection
info	[Changelog]   - Added Interface PrivateLinkResource
info	[Changelog]   - Added Interface ProxyResource
info	[Changelog]   - Added Interface RedisCreateProperties
info	[Changelog]   - Added Interface RedisFirewallRule
info	[Changelog]   - Added Interface RedisFirewallRuleCreateParameters
info	[Changelog]   - Added Interface RedisLinkedServerProperties
info	[Changelog]   - Added Interface RedisLinkedServerWithProperties
info	[Changelog]   - Added Interface RedisPatchSchedule
info	[Changelog]   - Added Interface RedisProperties
info	[Changelog]   - Added Interface RedisResource
info	[Changelog]   - Added Interface RedisUpdateProperties
info	[Changelog]   - Added Interface TrackedResource
info	[Changelog]   - Interface ExportRDBParameters has a new optional parameter preferredDataArchiveAuthMethod
info	[Changelog]   - Interface ImportRDBParameters has a new optional parameter preferredDataArchiveAuthMethod
info	[Changelog]   - Interface LinkedServerDeleteOptionalParams has a new optional parameter resumeFrom
info	[Changelog]   - Interface LinkedServerDeleteOptionalParams has a new optional parameter updateIntervalInMs
info	[Changelog]   - Interface RedisCommonPropertiesRedisConfiguration has a new optional parameter aofBackupEnabled
info	[Changelog]   - Interface RedisCommonPropertiesRedisConfiguration has a new optional parameter authnotrequired
info	[Changelog]   - Interface RedisUpdateOptionalParams has a new optional parameter resumeFrom
info	[Changelog]   - Interface RedisUpdateOptionalParams has a new optional parameter updateIntervalInMs
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Removed operation LinkedServer.delete
info	[Changelog]   - Removed operation Redis.update

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 9d4fb5a. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️redis [View full logs] [Release Schema Changes]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 9d4fb5a. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.Redis [View full logs] [Release SDK Changes]
- Az.Redis.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-06-24T21:56:00Z

Hi @matthchr, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

openapi-workflow-bot · 2022-06-24T21:56:34Z

Hi @matthchr, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

TimLovellSmith · 2022-06-27T17:04:56Z

@mattchr Looks like I expect.

matthchr · 2022-07-22T21:09:05Z

.NET SDK for reference. This PR is a superset of ARM IDs used by the .NET SDK. That should be OK because the Redis .NET SDK isn't GA yet.

Create to sync Azure/azure-rest-api-specs#19596 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/redis?expand=1)

matthchr requested a review from TimLovellSmith as a code owner June 24, 2022 21:51

openapi-assignment-bot bot assigned leni-msft Jun 24, 2022

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Jun 24, 2022

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Jun 24, 2022

TimLovellSmith approved these changes Jun 27, 2022

View reviewed changes

ARM ID Annotations for Redis

bcfca39

matthchr force-pushed the feature/redis-arm-ids branch from b2e876c to bcfca39 Compare July 22, 2022 21:09

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Jul 22, 2022

ArcturusZhang approved these changes Aug 5, 2022

View reviewed changes

ArcturusZhang added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 5, 2022

ArcturusZhang merged commit 9d4fb5a into Azure:main Aug 5, 2022

This was referenced Aug 5, 2022

[ReleasePR redis] ARM ID Annotations for Redis Azure/azure-resource-manager-schemas#2518

Merged

[ReleasePR armredis] Migrate to net track2 for some resource-manager readmes batch 2 Azure/azure-sdk-for-go#18514

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Aug 5, 2022

azure-sdk mentioned this pull request Aug 5, 2022

[ReleasePR track2_azure-mgmt-redis] Use format: arm-id in Redis and RedisEnterprise where appropriate Azure/azure-sdk-for-python#25045

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Aug 5, 2022

azure-sdk mentioned this pull request Aug 5, 2022

[ReleasePR azure-resourcemanager-redis-generated] Use format: arm-id in Redis and RedisEnterprise where appropriate Azure/azure-sdk-for-java#29743

Closed

azure-sdk mentioned this pull request Aug 5, 2022

[ReleasePR @azure/arm-rediscache] Use format: arm-id in Redis and RedisEnterprise where appropriate Azure/azure-sdk-for-js#22416

Closed

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Aug 5, 2022

azure-sdk mentioned this pull request Aug 5, 2022

[ReleasePR Az.Redis] [Go] redis add directive Azure/azure-powershell#18533

Closed

matthchr deleted the feature/redis-arm-ids branch September 27, 2022 18:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ARM ID Annotations for Redis #19596

ARM ID Annotations for Redis #19596

matthchr commented Jun 24, 2022

openapi-workflow-bot bot commented Jun 24, 2022

openapi-pipeline-app bot commented Jun 24, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jun 24, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Jun 24, 2022

openapi-workflow-bot bot commented Jun 24, 2022

TimLovellSmith commented Jun 27, 2022

matthchr commented Jul 22, 2022

ARM ID Annotations for Redis #19596

ARM ID Annotations for Redis #19596

Conversation

matthchr commented Jun 24, 2022

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jun 24, 2022

openapi-pipeline-app bot commented Jun 24, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jun 24, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Jun 24, 2022

openapi-workflow-bot bot commented Jun 24, 2022

TimLovellSmith commented Jun 27, 2022

matthchr commented Jul 22, 2022

openapi-pipeline-app bot commented Jun 24, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jun 24, 2022 •

edited

Loading