Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding x-ms-enum type extension for enums #19383

Merged
merged 38 commits into from
Jul 14, 2022

Conversation

Gargimitra12300
Copy link
Contributor

@Gargimitra12300 Gargimitra12300 commented Jun 8, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  • Feature is already deployed. Fixing swagger validation errors.
  1. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  • Swagger is already published, fixing validation errors.
  1. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@Gargimitra12300 Gargimitra12300 requested a review from naveedaz as a code owner June 8, 2022 22:50
@openapi-workflow-bot
Copy link

Hi, @Gargimitra12300 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    1 similar comment
    @openapi-workflow-bot
    Copy link

    Hi, @Gargimitra12300 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 8, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.9.6)] new version base version
    AppServiceCertificateOrders.json 2015-08-01(1cb9364) 2015-08-01(main)
    AppServiceCertificateOrders.json 2018-02-01(1cb9364) 2018-02-01(main)
    AppServiceCertificateOrders.json 2019-08-01(1cb9364) 2019-08-01(main)
    AppServiceCertificateOrders.json 2020-06-01(1cb9364) 2020-06-01(main)
    AppServiceCertificateOrders.json 2020-09-01(1cb9364) 2020-09-01(main)
    AppServiceCertificateOrders.json 2020-10-01(1cb9364) 2020-10-01(main)
    AppServiceCertificateOrders.json 2020-12-01(1cb9364) 2020-12-01(main)
    AppServiceCertificateOrders.json 2021-01-01(1cb9364) 2021-01-01(main)
    AppServiceCertificateOrders.json 2021-01-15(1cb9364) 2021-01-15(main)
    AppServiceCertificateOrders.json 2021-02-01(1cb9364) 2021-02-01(main)
    AppServiceCertificateOrders.json 2021-03-01(1cb9364) 2021-03-01(main)
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2018-12 package-2018-12(1cb9364) package-2018-12(main)
    package-2018-11 package-2018-11(1cb9364) package-2018-11(main)
    package-2018-02-only package-2018-02-only(1cb9364) package-2018-02-only(main)
    package-2016-09 package-2016-09(1cb9364) package-2016-09(main)
    package-2020-10 package-2020-10(1cb9364) package-2020-10(main)
    package-2020-09 package-2020-09(1cb9364) package-2020-09(main)
    package-2020-06 package-2020-06(1cb9364) package-2020-06(main)
    package-2019-08 package-2019-08(1cb9364) package-2019-08(main)
    package-2020-12 package-2020-12(1cb9364) package-2020-12(main)
    package-2021-02 package-2021-02(1cb9364) package-2021-02(main)
    package-2021-01-15 package-2021-01-15(1cb9364) package-2021-01-15(main)
    package-2021-01 package-2021-01(1cb9364) package-2021-01(main)
    package-2021-03 package-2021-03(1cb9364) package-2021-03(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
    Location: Microsoft.CertificateRegistration/stable/2015-08-01/AppServiceCertificateOrders.json#L17
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
    Location: Microsoft.CertificateRegistration/stable/2018-02-01/AppServiceCertificateOrders.json#L17
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
    Location: Microsoft.CertificateRegistration/stable/2018-02-01/AppServiceCertificateOrders.json#L17
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
    Location: Microsoft.CertificateRegistration/stable/2018-02-01/AppServiceCertificateOrders.json#L17
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
    Location: Microsoft.CertificateRegistration/stable/2019-08-01/AppServiceCertificateOrders.json#L17
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
    Location: Microsoft.CertificateRegistration/stable/2020-06-01/AppServiceCertificateOrders.json#L17
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
    Location: Microsoft.CertificateRegistration/stable/2020-09-01/AppServiceCertificateOrders.json#L17
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
    Location: Microsoft.CertificateRegistration/stable/2020-10-01/AppServiceCertificateOrders.json#L17
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
    Location: Microsoft.CertificateRegistration/stable/2020-12-01/AppServiceCertificateOrders.json#L17
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
    Location: Microsoft.CertificateRegistration/stable/2021-01-01/AppServiceCertificateOrders.json#L17
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.CertificateRegistration/stable/2015-08-01/AppServiceCertificateOrders.json#L34
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.CertificateRegistration/stable/2015-08-01/AppServiceCertificateOrders.json#L72
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.CertificateRegistration/stable/2015-08-01/AppServiceCertificateOrders.json#L98
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.CertificateRegistration/stable/2015-08-01/AppServiceCertificateOrders.json#L137
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.CertificateRegistration/stable/2015-08-01/AppServiceCertificateOrders.json#L180
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.CertificateRegistration/stable/2015-08-01/AppServiceCertificateOrders.json#L221
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.CertificateRegistration/stable/2015-08-01/AppServiceCertificateOrders.json#L264
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.CertificateRegistration/stable/2015-08-01/AppServiceCertificateOrders.json#L306
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.CertificateRegistration/stable/2015-08-01/AppServiceCertificateOrders.json#L352
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.CertificateRegistration/stable/2015-08-01/AppServiceCertificateOrders.json#L402
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.CertificateRegistration/stable/2015-08-01/AppServiceCertificateOrders.json#L450
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.CertificateRegistration/stable/2015-08-01/AppServiceCertificateOrders.json#L500
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.CertificateRegistration/stable/2015-08-01/AppServiceCertificateOrders.json#L551
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.CertificateRegistration/stable/2015-08-01/AppServiceCertificateOrders.json#L593
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.CertificateRegistration/stable/2015-08-01/AppServiceCertificateOrders.json#L626
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.CertificateRegistration/stable/2015-08-01/AppServiceCertificateOrders.json#L668
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.CertificateRegistration/stable/2015-08-01/AppServiceCertificateOrders.json#L710
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.CertificateRegistration/stable/2015-08-01/AppServiceCertificateOrders.json#L746
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.CertificateRegistration/stable/2015-08-01/AppServiceCertificateOrders.json#L779
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.CertificateRegistration/stable/2015-08-01/AppServiceCertificateOrders.json#L818
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/1cb936439861e5ff104cee0b9bafe07b9f7ae83b/specification/web/resource-manager/readme.md#tag-package-2021-03">web/resource-manager/readme.md#package-2021-03
      • "https://github.com/Azure/azure-rest-api-specs/blob/1cb936439861e5ff104cee0b9bafe07b9f7ae83b/specification/web/resource-manager/readme.md#tag-package-2021-02">web/resource-manager/readme.md#package-2021-02
      • "https://github.com/Azure/azure-rest-api-specs/blob/1cb936439861e5ff104cee0b9bafe07b9f7ae83b/specification/web/resource-manager/readme.md#tag-package-2021-01-15">web/resource-manager/readme.md#package-2021-01-15
      • "https://github.com/Azure/azure-rest-api-specs/blob/1cb936439861e5ff104cee0b9bafe07b9f7ae83b/specification/web/resource-manager/readme.md#tag-package-2021-01">web/resource-manager/readme.md#package-2021-01
      • "https://github.com/Azure/azure-rest-api-specs/blob/1cb936439861e5ff104cee0b9bafe07b9f7ae83b/specification/web/resource-manager/readme.md#tag-package-2020-12">web/resource-manager/readme.md#package-2020-12
      • "https://github.com/Azure/azure-rest-api-specs/blob/1cb936439861e5ff104cee0b9bafe07b9f7ae83b/specification/web/resource-manager/readme.md#tag-package-2020-10">web/resource-manager/readme.md#package-2020-10
      • "https://github.com/Azure/azure-rest-api-specs/blob/1cb936439861e5ff104cee0b9bafe07b9f7ae83b/specification/web/resource-manager/readme.md#tag-package-2020-09">web/resource-manager/readme.md#package-2020-09
      • "https://github.com/Azure/azure-rest-api-specs/blob/1cb936439861e5ff104cee0b9bafe07b9f7ae83b/specification/web/resource-manager/readme.md#tag-package-2020-06">web/resource-manager/readme.md#package-2020-06
      • "https://github.com/Azure/azure-rest-api-specs/blob/1cb936439861e5ff104cee0b9bafe07b9f7ae83b/specification/web/resource-manager/readme.md#tag-package-2019-08">web/resource-manager/readme.md#package-2019-08
      • "https://github.com/Azure/azure-rest-api-specs/blob/1cb936439861e5ff104cee0b9bafe07b9f7ae83b/specification/web/resource-manager/readme.md#tag-package-2018-12">web/resource-manager/readme.md#package-2018-12
      • "https://github.com/Azure/azure-rest-api-specs/blob/1cb936439861e5ff104cee0b9bafe07b9f7ae83b/specification/web/resource-manager/readme.md#tag-package-2018-11">web/resource-manager/readme.md#package-2018-11
      • "https://github.com/Azure/azure-rest-api-specs/blob/1cb936439861e5ff104cee0b9bafe07b9f7ae83b/specification/web/resource-manager/readme.md#tag-package-2018-02">web/resource-manager/readme.md#package-2018-02
      • "https://github.com/Azure/azure-rest-api-specs/blob/1cb936439861e5ff104cee0b9bafe07b9f7ae83b/specification/web/resource-manager/readme.md#tag-package-2018-02-only">web/resource-manager/readme.md#package-2018-02-only
      • "https://github.com/Azure/azure-rest-api-specs/blob/1cb936439861e5ff104cee0b9bafe07b9f7ae83b/specification/web/resource-manager/readme.md#tag-package-2016-09">web/resource-manager/readme.md#package-2016-09
      • "https://github.com/Azure/azure-rest-api-specs/blob/1cb936439861e5ff104cee0b9bafe07b9f7ae83b/specification/web/resource-manager/readme.md#tag-package-2015-08-only">web/resource-manager/readme.md#package-2015-08-only
      • "https://github.com/Azure/azure-rest-api-specs/blob/1cb936439861e5ff104cee0b9bafe07b9f7ae83b/specification/web/resource-manager/readme.md#tag-package-2015-08-certificate-registration">web/resource-manager/readme.md#package-2015-08-certificate-registration
    The following errors/warnings exist before current PR submission:
    Rule Message
    ⚠️ UnkownSecurityScheme "readme":"web/resource-manager/readme.md",
    "tag":"package-2021-03",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"web/resource-manager/readme.md",
    "tag":"package-2021-02",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"web/resource-manager/readme.md",
    "tag":"package-2021-01-15",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"web/resource-manager/readme.md",
    "tag":"package-2021-01",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"web/resource-manager/readme.md",
    "tag":"package-2020-12",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"web/resource-manager/readme.md",
    "tag":"package-2020-10",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"web/resource-manager/readme.md",
    "tag":"package-2020-09",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"web/resource-manager/readme.md",
    "tag":"package-2020-06",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"web/resource-manager/readme.md",
    "tag":"package-2019-08",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"web/resource-manager/readme.md",
    "tag":"package-2018-12",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"web/resource-manager/readme.md",
    "tag":"package-2018-11",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"web/resource-manager/readme.md",
    "tag":"package-2018-02",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"web/resource-manager/readme.md",
    "tag":"package-2018-02-only",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"web/resource-manager/readme.md",
    "tag":"package-2016-09",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"web/resource-manager/readme.md",
    "tag":"package-2015-08-only",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"web/resource-manager/readme.md",
    "tag":"package-2015-08-certificate-registration",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 8, 2022

    Swagger Generation Artifacts

    ️❌ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    RestBuild error "logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=304778&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b",
    "detail":"npm ERR! code E401"
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go-track2 - armappservice - 2.0.0
    +	Const `AppServiceCertificateOrderPatchResourcePropertiesAppServiceCertificateNotRenewableReasonsItemExpirationNotInRenewalTimeRange` has been removed
    +	Const `AppServiceCertificateOrderPatchResourcePropertiesAppServiceCertificateNotRenewableReasonsItemRegistrationStatusNotSupportedForRenewal` has been removed
    +	Const `AppServiceCertificateOrderPatchResourcePropertiesAppServiceCertificateNotRenewableReasonsItemSubscriptionNotActive` has been removed
    +	Const `AppServiceCertificateOrderPropertiesAppServiceCertificateNotRenewableReasonsItemExpirationNotInRenewalTimeRange` has been removed
    +	Const `AppServiceCertificateOrderPropertiesAppServiceCertificateNotRenewableReasonsItemRegistrationStatusNotSupportedForRenewal` has been removed
    +	Const `AppServiceCertificateOrderPropertiesAppServiceCertificateNotRenewableReasonsItemSubscriptionNotActive` has been removed
    +	Const `Enum15LinuxFunctions` has been removed
    +	Const `Enum15WindowsFunctions` has been removed
    +	Const `Enum19All` has been removed
    +	Const `Enum19Linux` has been removed
    +	Const `Enum19Windows` has been removed
    +	Const `Enum20All` has been removed
    +	Const `Enum20LinuxFunctions` has been removed
    +	Const `Enum20Linux` has been removed
    +	Const `Enum20WindowsFunctions` has been removed
    +	Const `Enum20Windows` has been removed
    +	Function `PossibleAppServiceCertificateOrderPatchResourcePropertiesAppServiceCertificateNotRenewableReasonsItemValues` has been removed
    +	Function `PossibleAppServiceCertificateOrderPropertiesAppServiceCertificateNotRenewableReasonsItemValues` has been removed
    +	Function `PossibleEnum19Values` has been removed
    +	Function `PossibleEnum20Values` has been removed
    +	Type of `CertificateOrderPatchResourceProperties.AppServiceCertificateNotRenewableReasons` has been changed from `[]*AppServiceCertificateOrderPatchResourcePropertiesAppServiceCertificateNotRenewableReasonsItem` to `[]*ResourceNotRenewableReason`
    +	Type of `CertificateOrderProperties.AppServiceCertificateNotRenewableReasons` has been changed from `[]*AppServiceCertificateOrderPropertiesAppServiceCertificateNotRenewableReasonsItem` to `[]*ResourceNotRenewableReason`
    +	Type of `ProviderClientGetAvailableStacksOnPremOptions.OSTypeSelected` has been changed from `*Enum20` to `*Enum18`
    +	Type of `ProviderClientGetAvailableStacksOptions.OSTypeSelected` has been changed from `*Enum15` to `*Enum13`
    +	Type of `ProviderClientGetFunctionAppStacksForLocationOptions.StackOsType` has been changed from `*Enum17` to `*Enum15`
    +	Type of `ProviderClientGetFunctionAppStacksOptions.StackOsType` has been changed from `*Enum16` to `*Enum14`
    +	Type of `ProviderClientGetWebAppStacksForLocationOptions.StackOsType` has been changed from `*Enum18` to `*Enum16`
    +	Type of `ProviderClientGetWebAppStacksOptions.StackOsType` has been changed from `*Enum19` to `*Enum17`
    azure-sdk-for-js - @azure/arm-appservice - 14.0.0
    azure-sdk-for-go - web/mgmt/2021-03-01/web - Approved - v65.0.0
    +	Type of `AppServiceCertificateOrderPatchResourceProperties.AppServiceCertificateNotRenewableReasons` has been changed from `*[]string` to `*[]ResourceNotRenewableReason`
    +	Type of `AppServiceCertificateOrderProperties.AppServiceCertificateNotRenewableReasons` has been changed from `*[]string` to `*[]ResourceNotRenewableReason`
    azure-sdk-for-go - web/mgmt/2021-02-01/web - Approved - v65.0.0
    +	Type of `AppServiceCertificateOrderPatchResourceProperties.AppServiceCertificateNotRenewableReasons` has been changed from `*[]string` to `*[]ResourceNotRenewableReason`
    +	Type of `AppServiceCertificateOrderProperties.AppServiceCertificateNotRenewableReasons` has been changed from `*[]string` to `*[]ResourceNotRenewableReason`
    azure-sdk-for-go - web/mgmt/2021-01-15/web - Approved - v65.0.0
    +	Type of `AppServiceCertificateOrderPatchResourceProperties.AppServiceCertificateNotRenewableReasons` has been changed from `*[]string` to `*[]ResourceNotRenewableReason`
    +	Type of `AppServiceCertificateOrderProperties.AppServiceCertificateNotRenewableReasons` has been changed from `*[]string` to `*[]ResourceNotRenewableReason`
    azure-sdk-for-go - web/mgmt/2020-12-01/web - Approved - v65.0.0
    +	Type of `AppServiceCertificateOrderPatchResourceProperties.AppServiceCertificateNotRenewableReasons` has been changed from `*[]string` to `*[]ResourceNotRenewableReason`
    +	Type of `AppServiceCertificateOrderProperties.AppServiceCertificateNotRenewableReasons` has been changed from `*[]string` to `*[]ResourceNotRenewableReason`
    azure-sdk-for-go - web/mgmt/2020-09-01/web - Approved - v65.0.0
    +	Type of `AppServiceCertificateOrderPatchResourceProperties.AppServiceCertificateNotRenewableReasons` has been changed from `*[]string` to `*[]ResourceNotRenewableReason`
    +	Type of `AppServiceCertificateOrderProperties.AppServiceCertificateNotRenewableReasons` has been changed from `*[]string` to `*[]ResourceNotRenewableReason`
    azure-sdk-for-go - web/mgmt/2020-06-01/web - Approved - v65.0.0
    +	Type of `AppServiceCertificateOrderPatchResourceProperties.AppServiceCertificateNotRenewableReasons` has been changed from `*[]string` to `*[]ResourceNotRenewableReason`
    +	Type of `AppServiceCertificateOrderProperties.AppServiceCertificateNotRenewableReasons` has been changed from `*[]string` to `*[]ResourceNotRenewableReason`
    azure-sdk-for-go - web/mgmt/2019-08-01/web - Approved - v65.0.0
    +	Type of `AppServiceCertificateOrderPatchResourceProperties.AppServiceCertificateNotRenewableReasons` has been changed from `*[]string` to `*[]ResourceNotRenewableReason`
    +	Type of `AppServiceCertificateOrderProperties.AppServiceCertificateNotRenewableReasons` has been changed from `*[]string` to `*[]ResourceNotRenewableReason`
    azure-sdk-for-go - web/mgmt/2018-02-01/web - Approved - v65.0.0
    +	Type of `AppServiceCertificateOrderPatchResourceProperties.AppServiceCertificateNotRenewableReasons` has been changed from `*[]string` to `*[]ResourceNotRenewableReason`
    +	Type of `AppServiceCertificateOrderProperties.AppServiceCertificateNotRenewableReasons` has been changed from `*[]string` to `*[]ResourceNotRenewableReason`
    azure-sdk-for-go - web/mgmt/2016-09-01/web - Approved - v65.0.0
    +	Type of `AppServiceCertificateOrderPatchResourceProperties.AppServiceCertificateNotRenewableReasons` has been changed from `*[]string` to `*[]ResourceNotRenewableReason`
    +	Type of `AppServiceCertificateOrderProperties.AppServiceCertificateNotRenewableReasons` has been changed from `*[]string` to `*[]ResourceNotRenewableReason`
    ️✔️azure-sdk-for-go - preview/web/mgmt/2015-08-01-preview/web - Approved - v65.0.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-web - 7.0.0
    ️✔️azure-sdk-for-go - armappservice - Approved - 2.0.1
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a5a62b7. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
    • ️✔️track2_azure-mgmt-web [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added model Enum3
      info	[Changelog]   - Added model ProviderOsTypeSelected
      info	[Changelog]   - Added model ProviderStackOsType
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from a5a62b7. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armappservice [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a5a62b7. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh] npm WARN deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh] deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh] deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh] WARN deprecated @azure/[email protected]: This version has been deprecated, please upgrade to the version tagged as latest
      cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-appservice [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Type Alias DiagnosticAnalysis
      info	[Changelog]   - Added Type Alias DiagnosticCategory
      info	[Changelog]   - Added Type Alias DiagnosticDetectorResponse
      info	[Changelog]   - Added Type Alias Domain
      info	[Changelog]   - Added Type Alias DomainOwnershipIdentifier
      info	[Changelog]   - Added Type Alias DomainPatchResource
      info	[Changelog]   - Added Type Alias ExpressionRoot
      info	[Changelog]   - Added Type Alias FunctionAppStack
      info	[Changelog]   - Added Type Alias FunctionEnvelope
      info	[Changelog]   - Added Type Alias GeoRegion
      info	[Changelog]   - Added Type Alias HostNameBinding
      info	[Changelog]   - Added Type Alias HybridConnection
      info	[Changelog]   - Added Type Alias HybridConnectionKey
      info	[Changelog]   - Added Type Alias HybridConnectionLimits
      info	[Changelog]   - Added Type Alias Identifier
      info	[Changelog]   - Added Type Alias KubeEnvironment
      info	[Changelog]   - Added Type Alias KubeEnvironmentPatchResource
      info	[Changelog]   - Added Type Alias MigrateMySqlRequest
      info	[Changelog]   - Added Type Alias MigrateMySqlStatus
      info	[Changelog]   - Added Type Alias MSDeploy
      info	[Changelog]   - Added Type Alias MSDeployLog
      info	[Changelog]   - Added Type Alias MSDeployStatus
      info	[Changelog]   - Added Type Alias NetworkFeatures
      info	[Changelog]   - Added Type Alias OperationResult
      info	[Changelog]   - Added Type Alias PremierAddOn
      info	[Changelog]   - Added Type Alias PremierAddOnOffer
      info	[Changelog]   - Added Type Alias PremierAddOnPatchResource
      info	[Changelog]   - Added Type Alias PrivateAccess
      info	[Changelog]   - Added Type Alias PrivateLinkConnectionApprovalRequestResource
      info	[Changelog]   - Added Type Alias ProcessInfo
      info	[Changelog]   - Added Type Alias ProcessModuleInfo
      info	[Changelog]   - Added Type Alias ProcessThreadInfo
      info	[Changelog]   - Added Type Alias ProviderOsTypeSelected
      info	[Changelog]   - Added Type Alias ProviderStackOsType
      info	[Changelog]   - Added Type Alias PublicCertificate
      info	[Changelog]   - Added Type Alias PushSettings
      info	[Changelog]   - Added Type Alias Recommendation
      info	[Changelog]   - Added Type Alias RecommendationRule
      info	[Changelog]   - Added Type Alias ReissueCertificateOrderRequest
      info	[Changelog]   - Added Type Alias RelayServiceConnectionEntity
      info	[Changelog]   - Added Type Alias RemotePrivateEndpointConnection
      info	[Changelog]   - Added Type Alias RemotePrivateEndpointConnectionARMResource
      info	[Changelog]   - Added Type Alias RenewCertificateOrderRequest
      info	[Changelog]   - Added Type Alias RequestHistory
      info	[Changelog]   - Added Type Alias ResourceHealthMetadata
      info	[Changelog]   - Added Type Alias ResourceMetricDefinition
      info	[Changelog]   - Added Type Alias RestoreRequest
      info	[Changelog]   - Added Type Alias Revision
      info	[Changelog]   - Added Type Alias RunActionCorrelation
      info	[Changelog]   - Added Type Alias Site
      info	[Changelog]   - Added Type Alias SiteAuthSettings
      info	[Changelog]   - Added Type Alias SiteAuthSettingsV2
      info	[Changelog]   - Added Type Alias SiteConfigResource
      info	[Changelog]   - Added Type Alias SiteConfigurationSnapshotInfo
      info	[Changelog]   - Added Type Alias SiteExtensionInfo
      info	[Changelog]   - Added Type Alias SiteLogsConfig
      info	[Changelog]   - Added Type Alias SitePatchResource
      info	[Changelog]   - Added Type Alias SitePhpErrorLogFlag
      info	[Changelog]   - Added Type Alias SiteSourceControl
      info	[Changelog]   - Added Type Alias SlotConfigNamesResource
      info	[Changelog]   - Added Type Alias SlotDifference
      info	[Changelog]   - Added Type Alias Snapshot
      info	[Changelog]   - Added Type Alias SnapshotRestoreRequest
      info	[Changelog]   - Added Type Alias SourceControl
      info	[Changelog]   - Added Type Alias StaticSiteARMResource
      info	[Changelog]   - Added Type Alias StaticSiteBuildARMResource
      info	[Changelog]   - Added Type Alias StaticSiteCustomDomainOverviewARMResource
      info	[Changelog]   - Added Type Alias StaticSiteCustomDomainRequestPropertiesARMResource
      info	[Changelog]   - Added Type Alias StaticSiteFunctionOverviewARMResource
      info	[Changelog]   - Added Type Alias StaticSiteLinkedBackendARMResource
      info	[Changelog]   - Added Type Alias StaticSitePatchResource
      info	[Changelog]   - Added Type Alias StaticSiteResetPropertiesARMResource
      info	[Changelog]   - Added Type Alias StaticSitesWorkflowPreview
      info	[Changelog]   - Added Type Alias StaticSitesWorkflowPreviewRequest
      info	[Changelog]   - Added Type Alias StaticSiteUserARMResource
      info	[Changelog]   - Added Type Alias StaticSiteUserInvitationRequestResource
      info	[Changelog]   - Added Type Alias StaticSiteUserInvitationResponseResource
      info	[Changelog]   - Added Type Alias StaticSiteUserProvidedFunctionApp
      info	[Changelog]   - Added Type Alias StaticSiteUserProvidedFunctionAppARMResource
      info	[Changelog]   - Added Type Alias StaticSiteZipDeploymentARMResource
      info	[Changelog]   - Added Type Alias StorageMigrationOptions
      info	[Changelog]   - Added Type Alias StorageMigrationResponse
      info	[Changelog]   - Added Type Alias StringDictionary
      info	[Changelog]   - Added Type Alias StringList
      info	[Changelog]   - Added Type Alias SwiftVirtualNetwork
      info	[Changelog]   - Added Type Alias TopLevelDomain
      info	[Changelog]   - Added Type Alias TriggeredJobHistory
      info	[Changelog]   - Added Type Alias TriggeredWebJob
      info	[Changelog]   - Added Type Alias Usage
      info	[Changelog]   - Added Type Alias User
      info	[Changelog]   - Added Type Alias VnetGateway
      info	[Changelog]   - Added Type Alias VnetInfoResource
      info	[Changelog]   - Added Type Alias VnetParameters
      info	[Changelog]   - Added Type Alias VnetRoute
      info	[Changelog]   - Added Type Alias VnetValidationFailureDetails
      info	[Changelog]   - Added Type Alias VnetValidationTestFailure
      info	[Changelog]   - Added Type Alias WebAppStack
      info	[Changelog]   - Added Type Alias WebJob
      info	[Changelog]   - Added Type Alias WebSiteInstanceStatus
      info	[Changelog]   - Added Type Alias WorkerPoolResource
      info	[Changelog]   - Added Type Alias Workflow
      info	[Changelog]   - Added Type Alias WorkflowOutputParameter
      info	[Changelog]   - Added Type Alias WorkflowRun
      info	[Changelog]   - Added Type Alias WorkflowRunAction
      info	[Changelog]   - Added Type Alias WorkflowRunActionRepetitionDefinition
      info	[Changelog]   - Added Type Alias WorkflowRunActionRepetitionProperties
      info	[Changelog]   - Added Type Alias WorkflowTrigger
      info	[Changelog]   - Added Type Alias WorkflowTriggerHistory
      info	[Changelog]   - Added Type Alias WorkflowVersion
      info	[Changelog]   - Added Enum KnownProviderOsTypeSelected
      info	[Changelog]   - Added Enum KnownProviderStackOsType
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed Enum KnownEnum14
      info	[Changelog]   - Removed Enum KnownEnum15
      info	[Changelog]   - Removed Enum KnownEnum16
      info	[Changelog]   - Removed Enum KnownEnum17
      info	[Changelog]   - Removed Enum KnownEnum18
      info	[Changelog]   - Removed Enum KnownEnum19
    ️🔄 azure-resource-manager-schemas inProgress [Detail]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from a5a62b7. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @Gargimitra12300, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    1 similar comment
    @openapi-workflow-bot
    Copy link

    Hi @Gargimitra12300, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @tadelesh tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Jul 12, 2022
    @tadelesh
    Copy link
    Member

    Approved for Go.

    @weidongxu-microsoft
    Copy link
    Member

    "Swagger SDK Breaking Change Tracking" would requires SDK owners to sign-off (I've added owners in comment above).

    @weidongxu-microsoft
    Copy link
    Member

    I will wait one more day for @qiliao123 @msyyc if they have issue with the change.

    @msyyc
    Copy link
    Member

    msyyc commented Jul 13, 2022

    Python approved for the PR

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants