Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swagger update for 2022-06-01-preview version for recoveryservices-backup #19182

Merged
merged 8 commits into from
Jun 9, 2022
Merged

Swagger update for 2022-06-01-preview version for recoveryservices-backup #19182

merged 8 commits into from
Jun 9, 2022

Conversation

pratimaupadhyay02
Copy link
Contributor

@pratimaupadhyay02 pratimaupadhyay02 commented May 23, 2022 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @pratimaupadhyay02 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 23, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 28 items are listed, please refer to log for more details.

    Rule Message
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig'
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L21
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupPreValidateProtection'
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L164
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupStatus'
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L209
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupValidateFeatures'
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L254
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/backupProtectionIntent/{intentObjectName}'
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L299
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupProtectionIntents'
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L460
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupUsageSummaries'
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L517
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L194
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L239
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L284
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L337
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L397
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L448
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L498
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L555
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L589
    ❌ R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L448
    ❌ R4015 - NestedResourcesMustHaveListOperation The nested resource 'PrivateEndpointConnectionResource' does not have list operation, please add it.
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L4670
    ❌ R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.RecoveryServices/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L577
    ❌ R4036 - ImplementPrivateEndpointAPIs The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateLinkResources is missing.
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L20
    ❌ R4036 - ImplementPrivateEndpointAPIs The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections is missing.
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L20
    ❌ R4037 - MissingTypeObject The schema 'BackupResourceEncryptionConfigResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L4619
    ❌ R4037 - MissingTypeObject The schema 'PrivateEndpointConnectionResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L4670
    ❌ R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L4712
    ❌ R4037 - MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L4723
    ❌ R4037 - MissingTypeObject The schema 'NewErrorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L4764
    ❌ R4037 - MissingTypeObject The schema 'BackupResourceConfigResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L6682
    ❌ R4037 - MissingTypeObject The schema 'JobResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L7586
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️❌Cross-Version Breaking Changes: 50 Errors, 63 Warnings failed [Detail]
    The following breaking changes are detected by comparison with the latest stable version:

    Only 28 items are listed, please refer to log for more details.

    Rule Message
    ❌ 1010 - AddingRequiredParameter The required parameter 'parameters' was added in the new version.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L4390:11
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L8313:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L8243:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L8333:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L8262:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L8313:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L8243:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L8333:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L8262:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5399:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L5388:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5404:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L5392:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5429:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L5416:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5465:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L5451:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5471:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L5456:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L8313:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L8243:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L8333:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L8262:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5399:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L5388:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5404:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L5392:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5429:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L5416:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5465:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L5451:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5471:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L5456:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L8313:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L8243:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L8333:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L8262:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5399:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L5388:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5404:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L5392:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5429:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L5416:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5465:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L5451:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5471:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L5456:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L8313:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L8243:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L8333:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L8262:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L8313:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L8243:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L8333:9
    Old: Microsoft.RecoveryServices/stable/2022-03-01/bms.json#L8262:9


    The following breaking changes are detected by comparison with latest preview version:

    Only 28 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1010 - AddingRequiredParameter The required parameter 'parameters' was added in the new version.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L4390:11
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L784:13
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L641:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L12623:11
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L11578:11
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L4345:13
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L4001:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L4403:13
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L4050:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L12597:5
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L11553:5
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L8313:9
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L7528:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L8333:9
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L7547:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L8313:9
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L7528:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L8333:9
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L7547:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5399:9
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L4931:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5404:9
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L4935:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5429:9
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L4959:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5465:9
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L4991:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5471:9
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L4996:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L8313:9
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L7528:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L8333:9
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L7547:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5399:9
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L4931:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5404:9
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L4935:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5429:9
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L4959:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5465:9
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L4991:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5471:9
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L4996:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L8313:9
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L7528:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L8333:9
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L7547:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5399:9
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L4931:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5404:9
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L4935:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5429:9
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L4959:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.RecoveryServices/preview/2022-06-01-preview/bms.json#L5465:9
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L4991:9
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 23, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️SDK Breaking Change Tracking warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-java warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-js warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-resource-manager-schemas warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-powershell failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @pratimaupadhyay02, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    This was referenced May 23, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    @azure-sdk azure-sdk mentioned this pull request May 23, 2022
    Draft
    @azure-sdk azure-sdk mentioned this pull request May 24, 2022
    Draft
    @openapi-workflow-bot
    Copy link

    Hi, @pratimaupadhyay02 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @openapi-workflow-bot openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 25, 2022
    @mentat9
    Copy link
    Member

    mentat9 commented May 31, 2022

    @pratimaupadhyay02 - Please fully fill out the submission form, including reviewing the guidelines. This is required for proper automation and routing of your PR.

    @mentat9 mentat9 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 31, 2022
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 31, 2022
    @pratimaupadhyay02
    Copy link
    Contributor Author

    @pratimaupadhyay02 - Please fully fill out the submission form, including reviewing the guidelines. This is required for proper automation and routing of your PR.

    Hi @mentat9 I have updated the submission form with the required details. Thanks. Can you please review the PR?

    @mentat9 mentat9 added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Jun 1, 2022
    @openapi-workflow-bot openapi-workflow-bot bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 1, 2022
    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    1 similar comment
    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @leniatgh leniatgh merged commit 58e507f into Azure:recoveryservices-backup-jun2022 Jun 9, 2022
    @pratimaupadhyay02 pratimaupadhyay02 mentioned this pull request Jun 13, 2022
    Merged
    25 tasks
    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jun 14, 2022
    tadelesh pushed a commit that referenced this pull request Jun 22, 2022
    @pratimaupadhyay02
    Swagger update for 2022-06-01-preview version for recoveryservices-ba…
    1a95386 
    …ckup (#19182) (#19425)

* Adding base version 2022-03-01

* Adding changes for new version

* Updating readme and custom words

* Fixing typo

* Adding saphanaDBInstance to protected items

* Fixing lintdiff issues

* Adding back tiering policy changes

* Fixing swagger correctness issues
    @raych1 raych1 mentioned this pull request Oct 3, 2022
    Merged
    11 tasks
    @mikekistler mikekistler mentioned this pull request Dec 1, 2022
    Merged
    11 tasks
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers
    No reviews
    Assignees

    @leniatgh leniatgh

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go-V2 CI-BreakingChange-JavaScript CI-FixRequiredOnFailure
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @pratimaupadhyay02 @mentat9 @JeffreyRichter @leniatgh