Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed CopyCompletionError enum name to not conflict with the CopyCompletionError object in GET response #19160

Merged
merged 1 commit into from
May 20, 2022
Merged

Changed CopyCompletionError enum name to not conflict with the CopyCompletionError object in GET response #19160

merged 1 commit into from
May 20, 2022

Conversation

kkaran27
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @kkaran27 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label May 20, 2022
    @ghost
    Copy link

    ghost commented May 20, 2022

    Thank you for your contribution kkaran27! We will review the pull request and get back to you soon.

    @ghost ghost added the Compute label May 20, 2022
    @kkaran27 kkaran27 mentioned this pull request May 20, 2022
    Merged
    25 tasks
    @haagha haagha merged commit ef3caf6 into Azure:diskrp-2022-03-02 May 20, 2022
    ArcturusZhang pushed a commit that referenced this pull request May 30, 2022
    @haagha @grizzlytheodore
    @anshulsolanki21 @parkhyukjun89 @akashpargat @jerryc3 @kkaran27
    [Compute] Disk 2022-03-02 (#19116)
    fa094e0 
    * new version folder

* new version folder

* sync with diskRP 2021-12-01 changes

* Update creationData description  (#18050)

* Update diskRPCommon.json

* Update diskRPCommon.json

* adding SecurityProfile in DiskRestorePointProperties (#18826)

* add cross-tenant feature (#18718)

* add cross-tenant feature

* fix filename typo

* prettier

* Swagger changes for PremiumV2 in DiskRP (#18786)

* Swagger changes for PremiumV2 in DiskRP

* Added new property copyCompletionError

* Updated description for new property copyCompletionError

* Added the type as object for CopyCompletionError

* Addressed comment to update the description for CopySourceNotFound

Co-authored-by: akashpargat <[email protected]>

* Add new Azure Compute Gallery image ids to ImageDiskReference for PutDisk Support in 2022-03-02 Api Version (#18868)

* new sig ids for put disk 2022-03-02

* fix errors and add example path

* extra space

* remove required id

* prettify common

Co-authored-by: Jerry Chan <[email protected]>

* Feature/cplat 2022 03 02 (#18945)

* add cross-tenant feature

* fix filename typo

* prettier

* add federatedClientId to diskEncryptionSetUpdateProperties

* New ApI Version

* Readme changes

* adding SecurityProfile in DiskRestorePointProperties (#18826)

* add cross-tenant feature (#18718)

* add cross-tenant feature

* fix filename typo

* prettier

* Swagger changes for PremiumV2 in DiskRP (#18786)

* Swagger changes for PremiumV2 in DiskRP

* Added new property copyCompletionError

* Updated description for new property copyCompletionError

* Added the type as object for CopyCompletionError

* Addressed comment to update the description for CopySourceNotFound

Co-authored-by: akashpargat <[email protected]>

* Add new Azure Compute Gallery image ids to ImageDiskReference for PutDisk Support in 2022-03-02 Api Version (#18868)

* new sig ids for put disk 2022-03-02

* fix errors and add example path

* extra space

* remove required id

* prettify common

Co-authored-by: Jerry Chan <[email protected]>

* Feature/cplat 2022 03 02 (#18945)

* add cross-tenant feature

* fix filename typo

* prettier

* add federatedClientId to diskEncryptionSetUpdateProperties

* GET snapshot-Changed CopyCompletionError enum name (#19160)

Co-authored-by: Karan Manish Thakkar <[email protected]>

* move UserAssignedIdentities to common.json to fix duplicate definition

* update readme with gallery 2022-01-03

* sync with past updates

* update with description for object

* fix readme

* GET snapshot-Changed CopyCompletionError enum name (#19227)

Co-authored-by: Karan Manish Thakkar <[email protected]>

* fixing readme.md

* fix vmss userAssignedIdentities duplicate definition

Co-authored-by: Theodore Chang <[email protected]>
Co-authored-by: anshulsolanki21 <[email protected]>
Co-authored-by: parkhyukjun89 <[email protected]>
Co-authored-by: Akash Pargat <[email protected]>
Co-authored-by: akashpargat <[email protected]>
Co-authored-by: jerryc3 <[email protected]>
Co-authored-by: Jerry Chan <[email protected]>
Co-authored-by: Karan Manish Thakkar <[email protected]>
Co-authored-by: Karan Manish Thakkar <[email protected]>
Co-authored-by: Theodore Chang <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Sandido Sandido Awaiting requested review from Sandido Sandido is a code owner

    @dkulkarni-ms dkulkarni-ms Awaiting requested review from dkulkarni-ms dkulkarni-ms is a code owner

    @haagha haagha Awaiting requested review from haagha haagha is a code owner

    @madewithsmiles madewithsmiles Awaiting requested review from madewithsmiles

    @MS-syh2qs MS-syh2qs Awaiting requested review from MS-syh2qs MS-syh2qs is a code owner

    @grizzlytheodore grizzlytheodore Awaiting requested review from grizzlytheodore grizzlytheodore is a code owner

    @hyonholee hyonholee Awaiting requested review from hyonholee hyonholee is a code owner

    Assignees
    No one assigned
    Labels
    Compute customer-reported Issues that are reported by GitHub users external to the Azure organization.
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @kkaran27 @haagha