Adding new Tracked Resource Type for Microsoft.Migrate RP with new Ap… #19045

sumukha100 · 2022-05-12T08:44:57Z

…i Version

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
June 2022
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
June 2022
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…i Version

openapi-workflow-bot · 2022-05-12T08:45:00Z

Hi, @sumukha100 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-workflow-bot · 2022-05-12T08:45:02Z

Hi, @sumukha100 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

openapi-pipeline-app · 2022-05-12T08:45:02Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

compared swaggers (via Oad v0.10.4)]	new version	base version
hubmigrate.json	2020-05-01(cb56d1c)	2020-05-01(main)
migrate.json	2020-07-07(cb56d1c)	2020-07-07(main)

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️❌LintDiff: 217 Errors, 236 Warnings failed [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-migrate-2018-02	package-migrate-2018-02(cb56d1c)	default(main)
package-migrate-2019-10	package-migrate-2019-10(cb56d1c)	default(main)
package-migrate-2020-01	package-migrate-2020-01(cb56d1c)	default(main)
package-hubmigrate-2020-05	package-hubmigrate-2020-05(cb56d1c)	default(main)
package-migrate-2020-07	package-migrate-2020-07(cb56d1c)	default(main)
package-migrateengine-2022-05	package-migrateengine-2022-05(cb56d1c)	default(main)

[must fix]The following errors/warnings are introduced by current PR:

Only 30 items are listed, please refer to log for more details.

Rule	Message	Related RPC [For API reviewers]
`❌` XmsParameterLocation	The parameter 'subscriptionId' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.Migrate/stable/2020-05-01/hubmigrate.json#L18
`❌` ResourceNameRestriction	The resource name parameter 'migrateProjectName' should be defined with a 'pattern' restriction. Location: Microsoft.Migrate/stable/2020-05-01/hubmigrate.json#L61	RPC-Uri-V1-05
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property name. Location: Microsoft.Migrate/stable/2020-05-01/hubmigrate.json#L226	RPC-Patch-V1-02
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property type. Location: Microsoft.Migrate/stable/2020-05-01/hubmigrate.json#L226	RPC-Patch-V1-02
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property location. Location: Microsoft.Migrate/stable/2020-05-01/hubmigrate.json#L226	RPC-Patch-V1-02
`❌` ResourceNameRestriction	The resource name parameter 'migrateProjectName' should be defined with a 'pattern' restriction. Location: Microsoft.Migrate/stable/2020-05-01/hubmigrate.json#L265	RPC-Uri-V1-05
`❌` ResourceNameRestriction	The resource name parameter 'migrateProjectName' should be defined with a 'pattern' restriction. Location: Microsoft.Migrate/stable/2020-05-01/hubmigrate.json#L320	RPC-Uri-V1-05
`❌` ResourceNameRestriction	The resource name parameter 'peConnectionName' should be defined with a 'pattern' restriction. Location: Microsoft.Migrate/stable/2020-05-01/hubmigrate.json#L320	RPC-Uri-V1-05
`❌` ResourceNameRestriction	The resource name parameter 'migrateProjectName' should be defined with a 'pattern' restriction. Location: Microsoft.Migrate/stable/2020-05-01/hubmigrate.json#L490	RPC-Uri-V1-05
`❌` ResourceNameRestriction	The resource name parameter 'privateLinkResourceName' should be defined with a 'pattern' restriction. Location: Microsoft.Migrate/stable/2020-05-01/hubmigrate.json#L490	RPC-Uri-V1-05
`❌` ResourceNameRestriction	The resource name parameter 'migrateProjectName' should be defined with a 'pattern' restriction. Location: Microsoft.Migrate/stable/2020-05-01/hubmigrate.json#L545	RPC-Uri-V1-05
`❌` SubscriptionsAndResourceGroupCasing	The path segment resourcegroups should be resourceGroups. Location: Microsoft.Migrate/stable/2020-05-01/hubmigrate.json#L640
`❌` ApiVersionParameterRequired	Operation should include an 'api-version' parameter. Location: Microsoft.Migrate/stable/2020-05-01/hubmigrate.json#L691	RPC-Uri-V1-08
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Migrate/stable/2020-05-01/hubmigrate.json#L751
`❌` XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Migrate/stable/2020-05-01/hubmigrate.json#L876
`❌` ProvisioningStateValidation	ProvisioningState must have terminal states: Succeeded, Failed and Canceled. Location: Microsoft.Migrate/stable/2020-05-01/hubmigrate.json#L935	RPC-Async-V1-03
`❌` XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Migrate/stable/2020-05-01/hubmigrate.json#L935
`❌` XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Migrate/stable/2020-05-01/hubmigrate.json#L1066
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Migrate/stable/2020-05-01/hubmigrate.json#L1116
`❌` PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/clusters/{clusterName}' Location: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L44
`❌` PutGetPatchResponseSchema	/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/clusters/{clusterName} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response. Location: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L44	RPC-Put-V1-12
`❌` ResourceNameRestriction	The resource name parameter 'siteName' should be defined with a 'pattern' restriction. Location: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L44	RPC-Uri-V1-05
`❌` ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L44	RPC-Uri-V1-05
`❌` CreateOperationAsyncResponseValidation	Only 201 is the supported response code for PUT async response. Location: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L164	RPC-Async-V1-01
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L166	RPC-Async-V1-07
`❌` PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/clusters' Location: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L188
`❌` ResourceNameRestriction	The resource name parameter 'siteName' should be defined with a 'pattern' restriction. Location: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L188	RPC-Uri-V1-05
`❌` PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/hosts/{hostName}' Location: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L256
`❌` PutGetPatchResponseSchema	/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/hosts/{hostName} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response. Location: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L256	RPC-Put-V1-12
`❌` ResourceNameRestriction	The resource name parameter 'siteName' should be defined with a 'pattern' restriction. Location: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L256	RPC-Uri-V1-05

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` XmsParameterLocation	The parameter 'subscriptionId' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L17
`❌` ProvisioningStateValidation	ProvisioningState must have terminal states: Succeeded, Failed and Canceled. Location: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L5845
`❌` XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L5845
`❌` XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L5876
`❌` MissingTypeObject	The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L6424
`❌` MissingTypeObject	The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L6433
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L5831
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L5931

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]

Validation passes for ServiceAPIReadinessTest.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-05-12T08:45:03Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-js - @azure/arm-migrate - 3.0.0-beta.1

+	Deleted Class AzureMigrateV2
+	Enum KnownProvisioningState no longer has value Accepted
+	Enum KnownProvisioningState no longer has value Moving
+	Removed Enum KnownAssessmentSizingCriterion
+	Removed Enum KnownAssessmentStage
+	Removed Enum KnownAssessmentStatus
+	Removed Enum KnownAzureDiskSize
+	Removed Enum KnownAzureDiskSuitabilityDetail
+	Removed Enum KnownAzureDiskSuitabilityExplanation
+	Removed Enum KnownAzureDiskType
+	Removed Enum KnownAzureHybridUseBenefit
+	Removed Enum KnownAzureLocation
+	Removed Enum KnownAzureNetworkAdapterSuitabilityDetail
+	Removed Enum KnownAzureNetworkAdapterSuitabilityExplanation
+	Removed Enum KnownAzureOfferCode
+	Removed Enum KnownAzurePricingTier
+	Removed Enum KnownAzureStorageRedundancy
+	Removed Enum KnownAzureVmFamily
+	Removed Enum KnownAzureVmSize
+	Removed Enum KnownAzureVmSuitabilityDetail
+	Removed Enum KnownAzureVmSuitabilityExplanation
+	Removed Enum KnownCloudSuitability
+	Removed Enum KnownCurrency
+	Removed Enum KnownGroupStatus
+	Removed Enum KnownGroupUpdateOperation
+	Removed Enum KnownMachineBootType
+	Removed Enum KnownPercentile
+	Removed Enum KnownPrivateEndpointConnectionPropertiesProvisioningState
+	Removed Enum KnownPrivateLinkServiceConnectionStateStatus
+	Removed Enum KnownProjectStatus
+	Removed Enum KnownReservedInstance
+	Removed Enum KnownTimeRange
+	Removed operation group AssessedMachines
+	Removed operation group Assessments
+	Removed operation group Groups
+	Removed operation group HyperVCollectors
+	Removed operation group ImportCollectors
+	Removed operation group Machines
+	Removed operation group Operations
+	Removed operation group PrivateEndpointConnectionOperations
+	Removed operation group PrivateLinkResourceOperations
+	Removed operation group Projects
+	Removed operation group ServerCollectors
+	Removed operation group VMwareCollectors

❌azure-sdk-for-go - sdk/resourcemanager/migrate/armmigrate - Approved - 2.0.0

+	Struct `CloudErrorBody` has been removed
+	Struct `CloudError` has been removed

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from 1de0b53. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 672 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 672 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to packe sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:760
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 760 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 672 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.Migrate [View full logs] [Release SDK Changes]
```
info	[Changelog]
```

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 1de0b53. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/migrate/armmigrate [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Struct `CloudError` has been removed
info	[Changelog] - Struct `CloudErrorBody` has been removed
info	[Changelog]
info	[Changelog] Total 4 breaking change(s), 0 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 1de0b53. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
cmderr	[automation_generate.sh] [ERROR] Cannot generate changelog because the codes of local and npm may be the same.

️✔️@azure/arm-migrate [View full logs] [Release SDK Changes]

azure-arm-migrate-2.0.4.tgz

info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.

️❌ azure-resource-manager-schemas failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 1de0b53. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cannot force update branch 'sdkAuto/migrate' as it is the current HEAD of the repository.
Error: cannot force update branch 'sdkAuto/migrate' as it is the current HEAD of the repository.

️✔️migrate [View full logs] [Release Schema Changes]

️✔️migrate [View full logs]

error	Fatal error: cannot force update branch 'sdkAuto/migrate' as it is the current HEAD of the repository.
error	The following packages are still pending:
error		migrate
error		migrate

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 1de0b53. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.MigrateV2 [View full logs] [Release SDK Changes]
- Az.MigrateV2.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-05-12T08:47:21Z

Hi @sumukha100, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

qiaozha · 2022-05-16T07:31:32Z

@sumukha100 Can you fix those CI failures ? Thanks

qiaozha · 2022-05-16T07:32:38Z

Also, there's a WaitForARMFeedback label, let's wait for their feedback.

vineetkumar-ms · 2022-05-17T13:44:29Z

Adding an overview of the resource model:
MigrateDataCenters: Top level tracked resource which provides customer with different offerings for migrating their data center workloads to Azure.

MigrateAgents: An agent resource, which is installed on the customer premises to perform the migration journey actions. The agent bootstrapping is done by the customer as part of onboarding process in Azure Migrate, which requires setting up an appliance in customer environment.

WorkloadInstances: Resource representing a particular workload instance customer wants to migrate. As part of PUT action, we initiate the replication process of the workload instance. The replication process is triggered as a job on a selected migrate agent configured by the customer.

WorkloadDeployments: Post replicating a workload instance, a customer can select a target platform to deploy the instance and create a workload deployment resource. Supported post actions:
○ BuildContainerImage: Triggers an action to build container image for the workload instance
○ Migrate: Triggers deployment of the workload instance to the specified target platform
○ TestMigrate: Triggers sandbox deployment of the workload instance to the specified target platform
○ TestMigrateCleanup: Cleans up the sandbox deployment created for the workload instance

DeployedResources: A read only resource capturing details of azure resources created in migrating a workload deployment.

Jobs: A read only resource capturing details of long running operation triggered within the MigrateDataCenter resource.

More details are captured in the below one-note:https://microsoft.sharepoint.com/teams/AppModernizationTeam/_layouts/OneNote.aspx?id=%2Fteams%2FAppModernizationTeam%2FShared%20Documents%2FGeneral%2FApp%20Modernization%20Notebook&wd=target%28Engineering.one%7C8B30D576-5B31-4B28-990F-C442032BCF45%2FService%20Architecture%7C2707389B-2FA5-4F3C-A31E-E83E0C6DDD95%2F%29
onenote:https://microsoft.sharepoint.com/teams/AppModernizationTeam/Shared%20Documents/General/App%20Modernization%20Notebook/Engineering.one#Service%20Architecture&section-id={8B30D576-5B31-4B28-990F-C442032BCF45}&page-id={2707389B-2FA5-4F3C-A31E-E83E0C6DDD95}&end

jorgecotillo · 2022-05-18T00:57:59Z

          "$ref": "#/definitions/MigrateDataCenterModel"

Is this valid? What is the difference between calling PUT on this resource with updated values and calling PATCH with updated values? Generally, PATCH is used to update a small subset of properties (common values to update: tags)

In reply to: 1129458473

Refers to: specification/migrate/resource-manager/Microsoft.Migrate/preview/2022-05-01-preview/migrateEngine.json:684 in 8fe9e43. [](commit_id = 8fe9e43, deletion_comment = False)

jorgecotillo · 2022-05-18T00:59:23Z

  "put": {

Make sure to adhere to our RPC: https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/async-api-reference.md#creatingupdating-using-put

For example the recommended response code on an initial PUT is 201 you are returning 201 & 202

Refers to: specification/migrate/resource-manager/Microsoft.Migrate/preview/2022-05-01-preview/migrateEngine.json:586 in 8fe9e43. [](commit_id = 8fe9e43, deletion_comment = False)

shreyasmalims · 2023-02-01T10:58:15Z

Please address the review comments provided by @jorgecotillo
@sjanamma
I believe all of his comments were resolved by @sumukha100 and we did get an ARM Sign off with those resolutions.
This is his last comment on the PR: #19045
Please let me know if I'm missing any comment here.

…ation

shishir-msft · 2023-02-07T10:07:39Z

...ion/migrate/resource-manager/Microsoft.Migrate/preview/2022-05-01-preview/migrateEngine.json

@@ -2775,45 +2755,6 @@
        }
      }
    },
-    "AuthenticationProperties": {


Reviewed, should be removed.

shishir-msft · 2023-02-07T10:07:59Z

...ion/migrate/resource-manager/Microsoft.Migrate/preview/2022-05-01-preview/migrateEngine.json

@@ -4383,15 +4296,6 @@
        }
      }
    },
-    "SecureString": {


Reviewed, can be removed.

fengzhou-msft · 2023-02-07T14:12:14Z

azure-sdk-for-net-track2 failure is caused by a known pipeline issue, please ignore it.

qiaozha · 2023-02-08T06:30:32Z

/azp run

azure-pipelines · 2023-02-08T06:30:43Z

Azure Pipelines successfully started running 1 pipeline(s).

…grate RP with new Ap… (#2785) Create to sync Azure/azure-rest-api-specs#19045 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/migrate?expand=1)

Azure#19045) * Adding new Tracked Resource Type for Microsoft.Migrate RP with new Api Version * Adding tag in readme and IISAKS to custom words * Restructuring example files * Renaming files * Fixing Avocado error * Rectifying swagger model validation * Addressing code style and validation issues * Implementing review comment * fixing prettier check * Deleting patch operations for proxy resources * Modifying readme.md to accomodate new resourcetype * Resolving errors * Resolving errors * Chankging tracked resource name from migrateDataCenter to modernizeProject * Reverting addition of id fiels in migrate and hubmigrate.json * . * Delete non-existing x-ms-examples from swagger * Auto-generate examples * run prettier changes * . * prettier * fix: Deleting and modifying examples * fix: Generated new examples to remove some errors * fix: Added x-ms-long-running-operation-options * refactor: Ran prettier fix * fix: Spell check error * fix: Removed 2 unnecessary filenames from inputfiles section under 'package-2022-05' tag. * feat: Latest Swagger updated. New examples generated. * fix: Resolving LintDiff Errors * fix: Ran prettier fix * fix: fixing model validation errors * fix: model validation error fix * fix: Removed patch operation and updated camelCase * fix: updated 'name' and restore readme.md * fix: removed tag: package-2022-05 and reverted the default tag to 2019-10 * fix: OperationsAPIImplementation * fix: OperationsAPI Implementaiton shifted to migrateEngine file * fix: ran prettier fix on 2 new example files * fix: updated package-2019 with package-migrate-2019 * refactor: Changed random guid to reopen the PR * fix: Updated the swagger till date 19Jan * fix: added 'fareast' in custom-words * fix: Recreated examples * fix: ran prettier command * fix: camelCase at 3 places * fix: Re generated examples * fix: Removed the Loglink from ContainerImageProperties * fix: Regenerated examples * Added GMSA Configuration State * fix: Added two DeployedResourcesProperties: isCleanUpDone, isTestMigration * fix: Removed spellcheck * fix: Added Produces in operations * fix: schema error * fix: Removed unnecessary configurations --------- Co-authored-by: Shishir Gupta <[email protected]> Co-authored-by: Shreyas Mali <[email protected]> Co-authored-by: shishir-msft <[email protected]> Co-authored-by: shreyasmalims <[email protected]>

Adding new Tracked Resource Type for Microsoft.Migrate RP with new Ap…

d3333bb

…i Version

openapi-assignment-bot bot assigned qiaozha May 12, 2022

openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 12, 2022

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label May 12, 2022

Adding tag in readme and IISAKS to custom words

e01bf46

sumukha100 added 2 commits May 13, 2022 13:48

Restructuring example files

6d7efea

Renaming files

b0cc74a

azure-sdk mentioned this pull request May 15, 2022

[AutoPR migrate] Adding new Tracked Resource Type for Microsoft.Migrate RP with new Ap… azure-sdk/azure-resource-manager-schemas#338

Closed

sumukha100 added 2 commits May 15, 2022 23:44

Fixing Avocado error

30f4e2a

Rectifying swagger model validation

1df8ecb

sumukha100 modified the milestone: -v May 15, 2022

Addressing code style and validation issues

8fe9e43

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label May 16, 2022

AzureRestAPISpecReview added the CI-FixRequiredOnFailure label Feb 1, 2023

shishir-msft removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 2, 2023

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 2, 2023

sjanamma added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Feb 2, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 2, 2023

fix: Added two DeployedResourcesProperties: isCleanUpDone, isTestMigr…

72136dd

…ation

qiaozha removed the CI-BreakingChange-JavaScript label Feb 7, 2023

fix: Removed spellcheck

f0431cb

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Feb 7, 2023

shreyasmalims added 3 commits February 7, 2023 12:25

fix: Added Produces in operations

2f9019c

fix: schema error

5610aa8

fix: Removed unnecessary configurations

cb56d1c

shishir-msft reviewed Feb 7, 2023

View reviewed changes

qiaozha approved these changes Feb 8, 2023

View reviewed changes

qiaozha merged commit 1de0b53 into Azure:main Feb 8, 2023

shishir-msft deleted the azureMigrateEngine/newTrackedResourceType branch February 9, 2023 04:40

shishir-msft restored the azureMigrateEngine/newTrackedResourceType branch February 9, 2023 04:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding new Tracked Resource Type for Microsoft.Migrate RP with new Ap… #19045

Adding new Tracked Resource Type for Microsoft.Migrate RP with new Ap… #19045

sumukha100 commented May 12, 2022

openapi-workflow-bot bot commented May 12, 2022

openapi-workflow-bot bot commented May 12, 2022

openapi-pipeline-app bot commented May 12, 2022 •

edited

Loading

openapi-pipeline-app bot commented May 12, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented May 12, 2022

qiaozha commented May 16, 2022

qiaozha commented May 16, 2022

vineetkumar-ms commented May 17, 2022 •

edited

Loading

jorgecotillo commented May 18, 2022 •

edited by sjanamma

Loading

jorgecotillo commented May 18, 2022

shreyasmalims commented Feb 1, 2023

shishir-msft Feb 7, 2023

shishir-msft Feb 7, 2023

fengzhou-msft commented Feb 7, 2023

qiaozha commented Feb 8, 2023

azure-pipelines bot commented Feb 8, 2023

Adding new Tracked Resource Type for Microsoft.Migrate RP with new Ap… #19045

Adding new Tracked Resource Type for Microsoft.Migrate RP with new Ap… #19045

Conversation

sumukha100 commented May 12, 2022

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented May 12, 2022

openapi-workflow-bot bot commented May 12, 2022

openapi-pipeline-app bot commented May 12, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented May 12, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented May 12, 2022

qiaozha commented May 16, 2022

qiaozha commented May 16, 2022

vineetkumar-ms commented May 17, 2022 • edited Loading

jorgecotillo commented May 18, 2022 • edited by sjanamma Loading

jorgecotillo commented May 18, 2022

shreyasmalims commented Feb 1, 2023

shishir-msft Feb 7, 2023

Choose a reason for hiding this comment

shishir-msft Feb 7, 2023

Choose a reason for hiding this comment

fengzhou-msft commented Feb 7, 2023

qiaozha commented Feb 8, 2023

azure-pipelines bot commented Feb 8, 2023

openapi-pipeline-app bot commented May 12, 2022 •

edited

Loading

openapi-pipeline-app bot commented May 12, 2022 •

edited

Loading

vineetkumar-ms commented May 17, 2022 •

edited

Loading

jorgecotillo commented May 18, 2022 •

edited by sjanamma

Loading