Review request for Microsoft.ContainerService to add version 2022-04-01 #18991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/2022-03-01 to version 2022-04-01
Signed-off-by: Ji An Liu <[email protected]>
* GA mc alias minor version in 0401 * unify info to be consistent with ap alias minor version * update the title of kuberneteVersion * add title for currentKubernetesVersion * make currentKubernetesVersion language consistency with AP currentOrchestratorVersion
* GA agent pool alisa minor version * Unify description with MC * Add read-only field * Rematch description with MC
|
Hi, @FumingZhang Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @FumingZhang your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
Swagger Validation Report
|
Swagger Generation Artifacts
|
|
Hi @FumingZhang, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced May 10, 2022
FumingZhang
requested review from
msyyc,
BigCat20196,
ArcturusZhang,
palma21 and
matthchr
as code owners
|
Dear review board, I would like to clarify the failures in the CI checks. For short, all the errors are not relevant to the changes in this PR and have happened in our previous PRs like 03-01 and 04-02-preview. For SDK azure-powershell, it happened in our previous PR 04-02-preview. This used to be optional and is enabled recently. Confirmed with owner @dolauli, this would not work for some modules and could be ignored. For SDK azure-sdk-for-go, this also happened in our previous PR 04-02-preview and is caused by another PR #18789. Confirmed with Golang SDK owner @ArcturusZhang, might need to revert the problematic PR. For SDK azure-sdk-for-net, it happened in our previous PR 03-01. I suppose this should be a known issue. According to the error log, the reason for the error is the permission problem when the pipeline is executed, which has nothing to do with this PR. For Swagger Avocado, it happened in our previous PR 03-01. I've listed the detailed explanation for each error in comment. These errors started appearing after this update of Avocado. Would really appreciate if some mechanism could be provided to disable the alarms, cc owner @ruowan. |
rkmanda
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
honghr
approved these changes
May 12, 2022
This was referenced May 12, 2022
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
May 16, 2022
…01 (Azure#18991) * Adds base for updating Microsoft.ContainerService from version stable/2022-03-01 to version 2022-04-01 * Updates readme * Updates API version in new specs and examples * update readme (Azure#18715) * add storage profile into managedcluster (Azure#18818) Signed-off-by: Ji An Liu <[email protected]> * GA mc alias minor version in 0401 (Azure#18821) * GA mc alias minor version in 0401 * unify info to be consistent with ap alias minor version * update the title of kuberneteVersion * add title for currentKubernetesVersion * make currentKubernetesVersion language consistency with AP currentOrchestratorVersion * GA agent pool alisa minor version (Azure#18814) * GA agent pool alisa minor version * Unify description with MC * Add read-only field * Rematch description with MC Co-authored-by: Xia ZHU <[email protected]> Co-authored-by: Ji'an Liu <[email protected]> Co-authored-by: Jianping Zeng <[email protected]> Co-authored-by: Thalia Wang <[email protected]>
25 tasks
FumingZhang
deleted the
fuming/dev-containerservice-Microsoft.ContainerService-2022-04-01
branch
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Already deployed to all global regions by 2022-05-01 and sov clouds by 2022-05-10.
2022-05-11.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.