Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Publish private branch 'rolyon-permissions-extension-test-v1' #18942

Merged
merged 14 commits into from
Jun 1, 2022
Merged

[Hub Generated] Publish private branch 'rolyon-permissions-extension-test-v1' #18942

merged 14 commits into from
Jun 1, 2022

Conversation

rolyon
Copy link
Contributor

@rolyon rolyon commented May 6, 2022

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

rolyon and others added 14 commits May 27, 2021 15:16
@rolyon
Permissions for elevate access
2f60e75
@rolyon
Merge branch 'master' of https://github.com/Azure/azure-rest-api-spec…
d799751 
…s-pr into rolyon-permissions-extension-test-v1
@rolyon
Merge branch 'master' of https://github.com/Azure/azure-rest-api-spec…
fbd748d 
…s-pr into rolyon-permissions-extension-test-v1
@rolyon
Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs-pr…
71f917f 
… into rolyon-permissions-extension-test-v1
@rolyon
Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs-pr…
faa2482 
… into rolyon-permissions-extension-test-v1
@rolyon
Repositioned permissions section
9d444b5
@rolyon
Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs-pr…
40e56a4 
… into rolyon-permissions-extension-test-v1
@rolyon
Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs-pr…
a78ee01 
… into rolyon-permissions-extension-test-v1
@rolyon
Extension name change
11f4153
@rolyon
Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs-pr…
532f784 
… into rolyon-permissions-extension-test-v1
@rolyon
Deleted extra spaces
ce3f07f
@rolyon
Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs-pr…
8b47b27 
… into rolyon-permissions-extension-test-v1
@rolyon
Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs-pr…
ff6dc46 
… into rolyon-permissions-extension-test-v1
@rolyon
Changed rolesWithThesePermissions to an array
b731ed8
@rolyon
Copy link
Contributor Author

rolyon commented May 6, 2022

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/3927

@rolyon rolyon requested a review from stankovski as a code owner May 6, 2022 17:42
@openapi-workflow-bot
Copy link

Hi, @rolyon Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 6, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 6, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go-track2 - armauthorization - 0.5.1
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-authorization - 2.0.0
    ️❌ azure-sdk-for-net failed [Detail]
    • ❌Failed [Logs]Release - Generate from 688cfd3. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/authorization/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 688cfd3. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation AccessReviewInstancesOperations.create
info	[Changelog]   - Added operation group AccessReviewInstanceContactedReviewersOperations
info	[Changelog]   - Added operation group TenantLevelAccessReviewInstanceContactedReviewersOperations
info	[Changelog]   - Model AccessReviewDefaultSettings has a new parameter recommendation_look_back_duration
info	[Changelog]   - Model AccessReviewInstance has a new parameter backup_reviewers
info	[Changelog]   - Model AccessReviewInstance has a new parameter reviewers
info	[Changelog]   - Model AccessReviewInstance has a new parameter reviewers_type
info	[Changelog]   - Model AccessReviewScheduleDefinition has a new parameter expand_nested_memberships
info	[Changelog]   - Model AccessReviewScheduleDefinition has a new parameter recommendation_look_back_duration
info	[Changelog]   - Model AccessReviewScheduleDefinitionProperties has a new parameter expand_nested_memberships
info	[Changelog]   - Model AccessReviewScheduleDefinitionProperties has a new parameter recommendation_look_back_duration
info	[Changelog]   - Model AccessReviewScheduleSettings has a new parameter recommendation_look_back_duration
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 688cfd3. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
    • ️✔️azure-resourcemanager-authorization-generated [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 688cfd3. SDK Automation 14.0.0 
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️authorization/mgmt/2020-10-01/authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️authorization/mgmt/2015-07-01/authorization [View full logs] 
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - Function `ProviderOperationsMetadataClient.GetPreparer` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.ListComplete` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.List` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.Get` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.ListPreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New function `ErrorDetail.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `ErrorAdditionalInfo.MarshalJSON() ([]byte, error)`
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 8 additive change(s).
    • ️✔️preview/authorization/mgmt/2020-10-01-preview/authorization [View full logs]  
      info	[Changelog] This is a new package
info	[Changelog]
    • ️✔️preview/authorization/mgmt/2020-04-01-preview/authorization [View full logs] 
      Only show 15 items here, please refer to log for details.
      info	[Changelog]
info	[Changelog] - Const `Everyone` has been removed
info	[Changelog] - Const `Application` has been removed
info	[Changelog] - Const `MSI` has been removed
info	[Changelog] - Const `Unknown` has been removed
info	[Changelog] - Const `DirectoryObjectOrGroup` has been removed
info	[Changelog] - Const `DirectoryRoleTemplate` has been removed
info	[Changelog] - Function `Principal.MarshalJSON` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New field `Email` in struct `Principal`
info	[Changelog] - New field `DisplayName` in struct `Principal`
info	[Changelog]
info	[Changelog] Total 7 breaking change(s), 1 additive change(s).
    • ️✔️preview/authorization/mgmt/2018-09-01-preview/authorization [View full logs] 
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - Const `Everyone` has been removed
info	[Changelog] - Const `DirectoryObjectOrGroup` has been removed
info	[Changelog] - Function `Principal.MarshalJSON` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New function `ErrorAdditionalInfo.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `ErrorDetail.MarshalJSON() ([]byte, error)`
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog] - New field `DisplayName` in struct `Principal`
info	[Changelog] - New field `Email` in struct `Principal`
info	[Changelog]
info	[Changelog] Total 7 breaking change(s), 9 additive change(s).
    • ️✔️preview/authorization/mgmt/2018-07-01-preview/authorization [View full logs]  
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `Principal.MarshalJSON` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New function `ErrorAdditionalInfo.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `ErrorDetail.MarshalJSON() ([]byte, error)`
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog] - New field `Email` in struct `Principal`
info	[Changelog] - New field `DisplayName` in struct `Principal`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 9 additive change(s).
    • ️✔️preview/authorization/mgmt/2018-01-01-preview/authorization [View full logs]  
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New function `ErrorAdditionalInfo.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `ErrorDetail.MarshalJSON() ([]byte, error)`
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 8 additive change(s).
    • ️✔️preview/authorization/mgmt/2017-10-01-preview/authorization [View full logs] 
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - Function `ProviderOperationsMetadataClient.Get` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.ListComplete` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.ListPreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.List` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.GetPreparer` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New function `ErrorDetail.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `ErrorAdditionalInfo.MarshalJSON() ([]byte, error)`
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 8 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 688cfd3. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armauthorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 688cfd3. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] npm WARN deprecated @azure/[email protected]: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 688cfd3. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
    • ️✔️authorization [View full logs] 
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 688cfd3. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.Authorization [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    This was referenced May 6, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    @akning-ms akning-ms assigned akning-ms and unassigned ruowan May 9, 2022
    @rolyon
    Copy link
    Contributor Author

    rolyon commented May 19, 2022

    Hi @stankovski
    When you have time, can you review this pull request?
    This is to support a permissions section that will appear in the docs. Let me know if you have any questions.
    https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-azure-rbac-permissions-required
    thanks

    @akning-ms akning-ms merged commit 688cfd3 into main Jun 1, 2022
    This was referenced Jun 1, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @akning-ms akning-ms akning-ms approved these changes

    @stankovski stankovski Awaiting requested review from stankovski stankovski is a code owner

    Assignees

    @akning-ms akning-ms

    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @rolyon @akning-ms @ruowan