Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use azure-sdk-for-net-track2 for validation #18756

Conversation

heaths
Copy link
Member

@heaths heaths commented Apr 20, 2022

No description provided.

@heaths heaths requested a review from yangyuan as a code owner April 20, 2022 20:11
@openapi-workflow-bot
Copy link

Hi, @heaths Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 20, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 20, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs] Generate from a4d30aeb9617fa6db396452fa8f094c43a9991a3. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
      command	pwsh ./eng/scripts/Automation-Sdk-Generate.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      warn	No file changes detected after generation
      error	Fatal error: packageFolderFromFileSearch not configured and could not be found in legacy config
      packageFolderFromFileSearch not configured and could not be found in legacy config
      Error: packageFolderFromFileSearch not configured and could not be found in legacy config
          at workflowDetectChangedPackages (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:422:23)
          at workflowHandleReadmeMd (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:168:11)
          at async Object.exports.workflowMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9)
          at async Object.exports.sdkAutoMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:152:13)
          at async /mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18
    Posted by Swagger Pipeline | How to fix these errors?

    Copy link
    Member

    @tjprescott tjprescott left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Is it expected/intended that this PR is failing azure-sdk-for-net-track2?

    @heaths
    Copy link
    Member Author

    heaths commented Apr 20, 2022

    No. I've got an email out on this and just CC'd you.

    @heaths
    Copy link
    Member Author

    heaths commented Apr 20, 2022

    And since you responded first, I'm going to reassign the other two changes (all in different branches) to you. Congrats. 🙂

    @heaths
    Copy link
    Member Author

    heaths commented Apr 22, 2022

    @lmazuel the second attempt after @ShivangiReja's changes seems to have worked, but I'm not sure why it didn't update the checks: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1519441&view=logs&j=f5934c1f-9ec9-5119-b2dd-43d5040d4468

    Could you help merge this?

    @tjprescott tjprescott merged commit 8fc6ae7 into release-cognitiveservices-Language-2022-05-01-GA Apr 25, 2022
    nourhaanfarid pushed a commit to nourhaanfarid/azure-rest-api-specs that referenced this pull request May 23, 2022
    lmazuel pushed a commit that referenced this pull request May 23, 2022
    * Cognitive Services Language GA API 2022-05-01 Swagger (#18402)
    
    * adding Swagger for GA API
    
    * remove extractive summerization changes
    
    * run  .\Copy-AzSpecifications.ps1  -SourceBranch dev-cognitiveservices-Language-2022-03-01-preview
    
    * removing extractive summerization from results
    
    * removing analyze conversation APIs auto generated from March APIs
    
    * single classification with array of class as multi classification
    
    * update readme
    
    * update the read me
    
    * update read.me
    
    * code review
    # Conflicts:
    #	specification/cognitiveservices/data-plane/Language/readme.md
    
    * Use azure-sdk-for-net-track2 for validation (#18756)
    
    * Add Language authoring 2022-05-01 APIs (#18694)
    
    * Add Language authoring 2022-05-01 APIs
    
    * Some build fixes
    
    * Add polymerphism for CLU exported project
    
    * Rename the api-version property in the import body
    
    * Retrigger CI
    
    * Update the hostTemplate and the operation Ids
    
    * Use the common error objects
    
    * Remove redundant definitions
    
    * Update the stringIndexType
    
    * Revert "Update the stringIndexType"
    
    This reverts commit 455762d.
    
    * Fix import/export object in CT
    
    * Rename actual to predicted
    
    * Add the APIs examples
    
    * Fix the examples validations
    
    * Fix prettier
    
    * Fix autorest issues
    
    * Fix nextLink examples regression
    
    * Retrigger CI
    
    * Renaming the swagger files
    
    * Apply PR feedback - part 1
    
    * Add the documentation for the schemas
    
    * Fix spelling errors
    
    * Update the descriptions for the analyzetext-authoring
    
    * Rename project-file-version to projectFileVersion
    
    * Add CLU 2022-05-01 GA version (#18759)
    
    * Add CLU 2022-05-01 GA version
    
    * Remove role
    
    * Update modality to inputModality
    
    * Do not update property name to inputModality, only the enum name.
    
    * Resolve comments
    
    * Rename CustomConversation
    
    Co-authored-by: Chong Tang <[email protected]>
    
    * Update Language authoring and runtime APIs to follow the same convention (2022-05-01) (#18836)
    
    * Update authoring and runtime APIs to follow the same convention
    
    * Update the examples
    
    * Remove other references to "named" in "named entity recognition"
    
    * Remove more 'named' from the swagger
    
    * Adding the missing 'required' attribute present in preview APIs and not in the GA version (#18946)
    
    * Adding the missing 'required' attribute present in preview APIs and not in the GA version
    
    * Updates
    
    * Add api-version parameter to cancel job endpoint (#18985)
    
    * Use PascalCase for enum values (#18840)
    
    * rename LUIS to Luis
    
    * use camel case for enum values
    
    * Revert "use camel case for enum values"
    
    This reverts commit 8db93fb.
    
    Co-authored-by: Chong Tang <[email protected]>
    
    * Copy QuestionAnswering definitions to common.json and refer them in analyzeconversations.json (#19030)
    
    Co-authored-by: Chong Tang <[email protected]>
    
    Co-authored-by: Heath Stewart <[email protected]>
    Co-authored-by: Mohamed Abbas <[email protected]>
    Co-authored-by: Chong Tang <[email protected]>
    Co-authored-by: Chong Tang <[email protected]>
    Co-authored-by: Bidisha Chakraborty <[email protected]>
    heaths added a commit that referenced this pull request May 24, 2022
    * Cognitive Services Language GA API 2022-05-01 Swagger (#18402)
    
    * adding Swagger for GA API
    
    * remove extractive summerization changes
    
    * run  .\Copy-AzSpecifications.ps1  -SourceBranch dev-cognitiveservices-Language-2022-03-01-preview
    
    * removing extractive summerization from results
    
    * removing analyze conversation APIs auto generated from March APIs
    
    * single classification with array of class as multi classification
    
    * update readme
    
    * update the read me
    
    * update read.me
    
    * code review
    
    * Use azure-sdk-for-net-track2 for validation (#18756)
    
    * Add Language authoring 2022-05-01 APIs (#18694)
    
    * Add Language authoring 2022-05-01 APIs
    
    * Some build fixes
    
    * Add polymerphism for CLU exported project
    
    * Rename the api-version property in the import body
    
    * Retrigger CI
    
    * Update the hostTemplate and the operation Ids
    
    * Use the common error objects
    
    * Remove redundant definitions
    
    * Update the stringIndexType
    
    * Revert "Update the stringIndexType"
    
    This reverts commit 455762d.
    
    * Fix import/export object in CT
    
    * Rename actual to predicted
    
    * Add the APIs examples
    
    * Fix the examples validations
    
    * Fix prettier
    
    * Fix autorest issues
    
    * Fix nextLink examples regression
    
    * Retrigger CI
    
    * Renaming the swagger files
    
    * Apply PR feedback - part 1
    
    * Add the documentation for the schemas
    
    * Fix spelling errors
    
    * Update the descriptions for the analyzetext-authoring
    
    * Rename project-file-version to projectFileVersion
    
    * Add CLU 2022-05-01 GA version (#18759)
    
    * Add CLU 2022-05-01 GA version
    
    * Remove role
    
    * Update modality to inputModality
    
    * Do not update property name to inputModality, only the enum name.
    
    * Resolve comments
    
    * Rename CustomConversation
    
    Co-authored-by: Chong Tang <[email protected]>
    
    * Update Language authoring and runtime APIs to follow the same convention (2022-05-01) (#18836)
    
    * Update authoring and runtime APIs to follow the same convention
    
    * Update the examples
    
    * Remove other references to "named" in "named entity recognition"
    
    * Remove more 'named' from the swagger
    
    * Adding the missing 'required' attribute present in preview APIs and not in the GA version (#18946)
    
    * Adding the missing 'required' attribute present in preview APIs and not in the GA version
    
    * Updates
    
    * Add api-version parameter to cancel job endpoint (#18985)
    
    * Use PascalCase for enum values (#18840)
    
    * rename LUIS to Luis
    
    * use camel case for enum values
    
    * Revert "use camel case for enum values"
    
    This reverts commit 8db93fb.
    
    Co-authored-by: Chong Tang <[email protected]>
    
    * Copy QuestionAnswering definitions to common.json and refer them in analyzeconversations.json (#19030)
    
    Co-authored-by: Chong Tang <[email protected]>
    
    Co-authored-by: Heath Stewart <[email protected]>
    Co-authored-by: Mohamed Abbas <[email protected]>
    Co-authored-by: Chong Tang <[email protected]>
    Co-authored-by: Chong Tang <[email protected]>
    Co-authored-by: Bidisha Chakraborty <[email protected]>
    lmazuel pushed a commit that referenced this pull request May 24, 2022
    * Cognitive Services Language GA API 2022-05-01 Swagger (#18402)
    
    * adding Swagger for GA API
    
    * remove extractive summerization changes
    
    * run  .\Copy-AzSpecifications.ps1  -SourceBranch dev-cognitiveservices-Language-2022-03-01-preview
    
    * removing extractive summerization from results
    
    * removing analyze conversation APIs auto generated from March APIs
    
    * single classification with array of class as multi classification
    
    * update readme
    
    * update the read me
    
    * update read.me
    
    * code review
    
    * Use azure-sdk-for-net-track2 for validation (#18756)
    
    * Add Language authoring 2022-05-01 APIs (#18694)
    
    * Add Language authoring 2022-05-01 APIs
    
    * Some build fixes
    
    * Add polymerphism for CLU exported project
    
    * Rename the api-version property in the import body
    
    * Retrigger CI
    
    * Update the hostTemplate and the operation Ids
    
    * Use the common error objects
    
    * Remove redundant definitions
    
    * Update the stringIndexType
    
    * Revert "Update the stringIndexType"
    
    This reverts commit 455762d.
    
    * Fix import/export object in CT
    
    * Rename actual to predicted
    
    * Add the APIs examples
    
    * Fix the examples validations
    
    * Fix prettier
    
    * Fix autorest issues
    
    * Fix nextLink examples regression
    
    * Retrigger CI
    
    * Renaming the swagger files
    
    * Apply PR feedback - part 1
    
    * Add the documentation for the schemas
    
    * Fix spelling errors
    
    * Update the descriptions for the analyzetext-authoring
    
    * Rename project-file-version to projectFileVersion
    
    * Add CLU 2022-05-01 GA version (#18759)
    
    * Add CLU 2022-05-01 GA version
    
    * Remove role
    
    * Update modality to inputModality
    
    * Do not update property name to inputModality, only the enum name.
    
    * Resolve comments
    
    * Rename CustomConversation
    
    Co-authored-by: Chong Tang <[email protected]>
    
    * Update Language authoring and runtime APIs to follow the same convention (2022-05-01) (#18836)
    
    * Update authoring and runtime APIs to follow the same convention
    
    * Update the examples
    
    * Remove other references to "named" in "named entity recognition"
    
    * Remove more 'named' from the swagger
    
    * Adding the missing 'required' attribute present in preview APIs and not in the GA version (#18946)
    
    * Adding the missing 'required' attribute present in preview APIs and not in the GA version
    
    * Updates
    
    * Add api-version parameter to cancel job endpoint (#18985)
    
    * Use PascalCase for enum values (#18840)
    
    * rename LUIS to Luis
    
    * use camel case for enum values
    
    * Revert "use camel case for enum values"
    
    This reverts commit 8db93fb.
    
    Co-authored-by: Chong Tang <[email protected]>
    
    * Copy QuestionAnswering definitions to common.json and refer them in analyzeconversations.json (#19030)
    
    Co-authored-by: Chong Tang <[email protected]>
    
    Co-authored-by: Heath Stewart <[email protected]>
    Co-authored-by: Mohamed Abbas <[email protected]>
    Co-authored-by: Chong Tang <[email protected]>
    Co-authored-by: Chong Tang <[email protected]>
    Co-authored-by: Bidisha Chakraborty <[email protected]>
    
    Co-authored-by: Nourhan <[email protected]>
    Co-authored-by: Mohamed Abbas <[email protected]>
    Co-authored-by: Chong Tang <[email protected]>
    Co-authored-by: Chong Tang <[email protected]>
    Co-authored-by: Bidisha Chakraborty <[email protected]>
    gargankit-microsoft pushed a commit that referenced this pull request May 26, 2022
    * Cognitive Services Language GA API 2022-05-01 Swagger (#18402)
    
    * adding Swagger for GA API
    
    * remove extractive summerization changes
    
    * run  .\Copy-AzSpecifications.ps1  -SourceBranch dev-cognitiveservices-Language-2022-03-01-preview
    
    * removing extractive summerization from results
    
    * removing analyze conversation APIs auto generated from March APIs
    
    * single classification with array of class as multi classification
    
    * update readme
    
    * update the read me
    
    * update read.me
    
    * code review
    
    * Use azure-sdk-for-net-track2 for validation (#18756)
    
    * Add Language authoring 2022-05-01 APIs (#18694)
    
    * Add Language authoring 2022-05-01 APIs
    
    * Some build fixes
    
    * Add polymerphism for CLU exported project
    
    * Rename the api-version property in the import body
    
    * Retrigger CI
    
    * Update the hostTemplate and the operation Ids
    
    * Use the common error objects
    
    * Remove redundant definitions
    
    * Update the stringIndexType
    
    * Revert "Update the stringIndexType"
    
    This reverts commit 455762d.
    
    * Fix import/export object in CT
    
    * Rename actual to predicted
    
    * Add the APIs examples
    
    * Fix the examples validations
    
    * Fix prettier
    
    * Fix autorest issues
    
    * Fix nextLink examples regression
    
    * Retrigger CI
    
    * Renaming the swagger files
    
    * Apply PR feedback - part 1
    
    * Add the documentation for the schemas
    
    * Fix spelling errors
    
    * Update the descriptions for the analyzetext-authoring
    
    * Rename project-file-version to projectFileVersion
    
    * Add CLU 2022-05-01 GA version (#18759)
    
    * Add CLU 2022-05-01 GA version
    
    * Remove role
    
    * Update modality to inputModality
    
    * Do not update property name to inputModality, only the enum name.
    
    * Resolve comments
    
    * Rename CustomConversation
    
    Co-authored-by: Chong Tang <[email protected]>
    
    * Update Language authoring and runtime APIs to follow the same convention (2022-05-01) (#18836)
    
    * Update authoring and runtime APIs to follow the same convention
    
    * Update the examples
    
    * Remove other references to "named" in "named entity recognition"
    
    * Remove more 'named' from the swagger
    
    * Adding the missing 'required' attribute present in preview APIs and not in the GA version (#18946)
    
    * Adding the missing 'required' attribute present in preview APIs and not in the GA version
    
    * Updates
    
    * Add api-version parameter to cancel job endpoint (#18985)
    
    * Use PascalCase for enum values (#18840)
    
    * rename LUIS to Luis
    
    * use camel case for enum values
    
    * Revert "use camel case for enum values"
    
    This reverts commit 8db93fb.
    
    Co-authored-by: Chong Tang <[email protected]>
    
    * Copy QuestionAnswering definitions to common.json and refer them in analyzeconversations.json (#19030)
    
    Co-authored-by: Chong Tang <[email protected]>
    
    Co-authored-by: Heath Stewart <[email protected]>
    Co-authored-by: Mohamed Abbas <[email protected]>
    Co-authored-by: Chong Tang <[email protected]>
    Co-authored-by: Chong Tang <[email protected]>
    Co-authored-by: Bidisha Chakraborty <[email protected]>
    
    Co-authored-by: Nourhan <[email protected]>
    Co-authored-by: Mohamed Abbas <[email protected]>
    Co-authored-by: Chong Tang <[email protected]>
    Co-authored-by: Chong Tang <[email protected]>
    Co-authored-by: Bidisha Chakraborty <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants